Re: Re[2]: Any interest in JDK-8264999 (stroke miter edge case in Marlin)

2022-05-29 Thread Laurent Bourgès
One more general comment on this bug: what is expected when lineTo() does not change last point after all other possible operations ? - lineTo, lineto (this bug) - quadTo, lineto - cubicTo, lineto - moveto, lineto: point (ok) - close, lineto(star: equiv to close, move start, lineto start: point sta

Re: RFR: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small" [v4]

2022-05-29 Thread Jeremy
> This resolves an occasional unit test failure in Path2D.UnitTest. > > The previous Path2D#getBounds2D(PathIterator) implementation assumed that > after a SEG_CLOSE the next segment would always be a SEG_MOVETO to start a > new clearly defined segment. But the Path2D.UnitTest created random pat

RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines

2022-05-29 Thread Jeremy
Previously when you drew a line that moved exactly (+0, +0) with a miter stroke the Stroker class acted like a horizontal miter was appropriate. Now we abort instead, so no miter is applied. The new unit test tests the original steps plus several variations. I'm a little nervous about this chan

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines

2022-05-29 Thread Jeremy
On Mon, 30 May 2022 01:15:01 GMT, Jeremy wrote: > Previously when you drew a line that moved exactly (+0, +0) with a miter > stroke the Stroker class acted like a horizontal miter was appropriate. Now > we abort instead, so no miter is applied. > > The new unit test tests the original steps pl

Re: RFR: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen [v4]

2022-05-29 Thread Dmitry Kulikov
> Hello, > Please review this fix for JDK-8282863. > > The failing > `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test > basically checks that full-screen window remains full-screen when a display > mode change occurs. It has been introduced in JDK-8211999, which also

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-29 Thread Tejesh R
> _Header_ object not initialized/set when paint() method of > `WindowTableHeaderUI` class is executed. The paint() event is executed > through explicit call of `JTable.updateUI()` in the regression test. In order > to set the _header_ to the _called_ JTable, it is set in the > `getTableCellRen

Re: RFR: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen [v4]

2022-05-29 Thread Dmitry Kulikov
On Mon, 30 May 2022 05:55:38 GMT, Dmitry Kulikov wrote: >> Hello, >> Please review this fix for JDK-8282863. >> >> The failing >> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test >> basically checks that full-screen window remains full-screen when a display >> mode

Integrated: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"

2022-05-29 Thread Jeremy
On Sun, 22 May 2022 09:08:03 GMT, Jeremy wrote: > This resolves an occasional unit test failure in Path2D.UnitTest. > > The previous Path2D#getBounds2D(PathIterator) implementation assumed that > after a SEG_CLOSE the next segment would always be a SEG_MOVETO to start a > new clearly defined s