On Thu, 3 Mar 2022 17:11:39 GMT, lawrence.andrews wrote:
>> This testcase covers both old and new api ( api added in jdk17
>> getAccessibleAction(), getAccessibleActionCount() ,
>> getAccessibleActionDescription )
>>
>> @shurymury
>> @savoptik
>
> lawrence.andrews has updated the pull reques
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Thu, 3 Mar 2022 22:51:48 GMT, DamonGuy wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to re
On Thu, 3 Mar 2022 22:51:48 GMT, DamonGuy wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to re
On Fri, 4 Mar 2022 01:55:45 GMT, Manukumar V S wrote:
>> Create a regression test for
>> [JDK-4518432](https://bugs.openjdk.java.net/browse/JDK-4518432).
>>
>> Issue: Copying from JTree and then changing the data in the component that
>> was copied from, can cause pastes to use
>>
On Thu, 24 Feb 2022 11:46:58 GMT, Manukumar V S wrote:
> Create a regression test for
> [JDK-4518432](https://bugs.openjdk.java.net/browse/JDK-4518432).
>
> Issue: Copying from JTree and then changing the data in the component that
> was copied from, can cause pastes to use
>the n
Please review this small patch that fixes a potential memory leak that
exception return fails to release allocated `cacheDirs`
Test:
- [x] jdk_desktop on Linux x86_64
-
Commit messages:
- 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
Changes: https:
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
Looks good.
-
Marked as reviewed by stuefe (Revie
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi
I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
Now: what is the next step?
This is a cleanup PR
Hi
I have reviewed the code for removing double semicolons at the end of lines
all the best
matteo
-
Commit messages:
- Removed double semicolon at the end of lines
Changes: https://git.openjdk.java.net/jdk/pull/7268/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=726
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> Hi
>
> I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
> Now: what is the next step?
>
> T
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by la
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi Lance
I can make a second commit updating the copyright year
Tell me if this is necessary
ciao
matteo
-
PR:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client mo
On Thu, 3 Mar 2022 18:07:25 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add bold version
>
> make/data/fontconfig/windows.fontconfig.properties line 184:
>
>> 182: dialoginput.bold.japanes
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> We usually request that these be be broken up by area to attract the
> appropriate reviewers and avoid eye-strain. The c
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Fri, 4 Mar 2022 18:16:22 GMT, Phil Race wrote:
> allfonts.korean=Malgun Gothic will provide it as a fall back so I don't see
> the need.
OK, that's what I needed. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/7643
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by prr (Reviewer).
Looks like there's only one client source code file touched
Most of the client changes a
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing swing classes javadoc to use @throws
This is touching a lot of files but I can't see it interfering with clean
backports as we are very unlik
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Thu, 3 Mar 2022 12:26:19 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing java/awt classes javadoc to use @throws
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/76
On Tue, 1 Feb 2022 16:11:52 GMT, DamonGuy wrote:
> Html does not fit in JButton at certain sizes because default Insets cause
> html to be displayed off-center.
>
> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
> clipping if html does not fit, similar to regular
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
I've increased the number of reviewers because as well as the c
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new S
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR: https:/
On Tue, 1 Mar 2022 23:33:40 GMT, DamonGuy wrote:
> There is no new bug submitted yet for other LAFs that I know of. I tested
> other LAFs and the issue does persist, so I can submit the bug for them if
> necessary. The other LAFs I tested were Metal, Nimbus, and Motif.
Please, submit a new bug
On Thu, 3 Mar 2022 12:26:19 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing java/awt classes javadoc to use @throws
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7675
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Sat, 26 Feb 2022 16:24:07 GMT, Ichiroh Takiguchi
wrote:
> On AIX ko_KR locale, I could see following exception after JTable.print() was
> called
>
> java.nio.charset.UnsupportedCharsetException: sun.font.X11KSC5601
> at java.base/java.nio.charset.Charset.forName(Charset.java:527)
>
On Mon, 28 Feb 2022 14:54:19 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/o
On Mon, 28 Feb 2022 07:24:27 GMT, Prasanta Sadhukhan
wrote:
>> If invalid ie 0 or > getColumnCount() index is passed to
>> DefaultTableColumnModel.getColumn() then it returns AIOBE in current
>> implementation which should be documented in the spec. Fixed the spec to
>> mention the exception.
On Mon, 21 Feb 2022 04:59:34 GMT, Prasanta Sadhukhan
wrote:
> [SynthPainter](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthPainter.java#L1759)
> and
> [SynthPainterImpl](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/cla
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
I would have just inlined JNU_CHECK_EXCEPTION and added the cle
On Fri, 4 Mar 2022 00:49:39 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - adjusted pixels to check f
On Fri, 4 Mar 2022 21:30:53 GMT, David Holmes wrote:
> I would have just inlined JNU_CHECK_EXCEPTION and added the cleanup code
> directly. The additional macro wasn't really necessary and would not really
> be usable for any kind of general cleanup actions beyond a one-liner.
>
> But it is ok
On Thu, 16 Dec 2021 18:33:37 GMT, Jeremy wrote:
>> This removes code that relied on consulting the Bezier control points to
>> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
>> to convert the Bezier control points into the x & y parametric equations. At
>> their m
On Thu, 10 Feb 2022 09:49:41 GMT, Tejesh R wrote:
> Issue in painting last row of JTable due to decrement in `MaxRow `during
> computation. Differences in `MaxRow `computation between `TablePrintable` and
> `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added
> to valida
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics, repaintPeerTarget should not be
On Fri, 4 Mar 2022 21:31:55 GMT, Phil Race wrote:
> Can you explain (walk through) why the old code was wrong and the new code is
> correct ? There's a lot of things that aren't obvious to me. The old code
> would use the same coords and just toggle which parts were in
> highlight/shadow Now y
On Fri, 4 Mar 2022 09:10:02 GMT, Artem Semenov wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> run the on windows and mac
>
> Looks good to me. I agree
@savoptik , can you approve this PR so that this PR is el
On Fri, 4 Mar 2022 21:54:57 GMT, Zhengyu Gu wrote:
> The macros are used to hide the different syntax of c and c++ to avoid
> polluting code here, it seems to be a common pattern in client code.
That's to allow for general use by C or C++ source files. But you are only
needing this in a C sour
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice, good work matteo
Should I change the JBS issue title to match the PR title, or is it preferred
for the PR title to chang
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This PR changes a comment in javax/swing/RepaintManager.java. This commented
out code should be removed altogether in another P
49 matches
Mail list logo
