RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes"

2022-01-31 Thread Alexander Zuev
Focus painting for combo box and radio button with custom icon should honour the corresponding property. - Commit messages: - 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" Changes: https://git.openjdk.java.net/jdk/

Withdrawn: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes"

2022-01-31 Thread Alexander Zuev
On Mon, 31 Jan 2022 09:11:40 GMT, Alexander Zuev wrote: > Focus painting for combo box and radio button with custom icon should honour > the corresponding property. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/7284

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-01-31 Thread Alexander Zuev
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. Focus painting for combo box and radio button with cus

RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-01-31 Thread Alexander Zuev
Make border painting for the check boxes and radio buttons with custom icons take into account the property that enables or disables the focus painting. Add that case to the test. - Commit messages: - 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is sti

Integrated: 8278908: [macOS] Unexpected text normalization on pasting from clipboard

2022-01-31 Thread Dmitry Batrak
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote: > The fix just removes the explicit normalization of text obtained from system > clipboard in JDK code, as I've found no > good justification for such a normalization, at least for the latest macOS > version. > The same fix was performed in

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-01-31 Thread Victor Dyakov
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. @azvegint @aivanov-jdk please review - P

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v3]

2022-01-31 Thread Harshitha Onkar
On Mon, 31 Jan 2022 07:24:08 GMT, Prasanta Sadhukhan wrote: >> @prsadhuk I have changed the test case to explicitly set the table and >> header background to white. Mach5 tests are passing on all platforms >> including linux now. Can you please let me know in case you are seeing any >> issues

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v4]

2022-01-31 Thread Harshitha Onkar
On Mon, 31 Jan 2022 07:24:08 GMT, Prasanta Sadhukhan wrote: >> @prsadhuk I have changed the test case to explicitly set the table and >> header background to white. Mach5 tests are passing on all platforms >> including linux now. Can you please let me know in case you are seeing any >> issues

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v4]

2022-01-31 Thread Harshitha Onkar
> A new test case was added to test the fix as there was no corresponding test > case present for this issue previously. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: tagged test case as mac only - Changes: - all

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v4]

2022-01-31 Thread Sergey Bylokhov
On Mon, 31 Jan 2022 19:44:51 GMT, Harshitha Onkar wrote: >> A new test case was added to test the fix as there was no corresponding test >> case present for this issue previously. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn [v2]

2022-01-31 Thread Sergey Bylokhov
On Thu, 27 Jan 2022 04:30:14 GMT, Toshio Nakamura wrote: >> JInternalFrame's bottom area is not properly drawn with Aqua LAF. >> This problem remained for long time, but we recognized it recently. >> >> According to the bug report, it depends on MacOS's version. I don't have old >> ones (10.10

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-01-31 Thread Sergey Bylokhov
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. Looks fine, BTW we can improve this test by checking a

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-01-31 Thread Sergey Bylokhov
On Fri, 28 Jan 2022 21:03:48 GMT, lawrence.andrews wrote: > 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interac

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v4]

2022-01-31 Thread Prasanta Sadhukhan
On Mon, 31 Jan 2022 07:24:08 GMT, Prasanta Sadhukhan wrote: >> @prsadhuk I have changed the test case to explicitly set the table and >> header background to white. Mach5 tests are passing on all platforms >> including linux now. Can you please let me know in case you are seeing any >> issues

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn [v2]

2022-01-31 Thread Toshio Nakamura
On Thu, 27 Jan 2022 00:36:54 GMT, Phil Race wrote: >> Toshio Nakamura has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Applied review comments > > Looks so much better. @prrace @mrserb Thank you for the review. Could you sponsor this pat

RFR: 8280948: [TESTBUG] Colocate tonga test bug4659800.java to a regression test

2022-01-31 Thread Manukumar V S
Colocate the tonga based test Swing_JButton/Automated/bug4659800/bug4659800.java to a regression based automated test. This test checks whether typing key generates ActionEvent on focused Button or not, in all Look And Feels in all platforms. This test is run 10 times per platform(mac,linux,win

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-01-31 Thread Manukumar V S
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul

Re: RFR: 8280948: [TESTBUG] Colocate tonga test bug4659800.java to a regression test

2022-01-31 Thread Manukumar V S
On Tue, 1 Feb 2022 06:40:17 GMT, Manukumar V S wrote: > Colocate the tonga based test > Swing_JButton/Automated/bug4659800/bug4659800.java to a regression based > automated test. > This test checks whether typing key generates ActionEvent on focused > Button or not, in all Look And Feels in a

May I close JDK-8067629 and JDK-8252901?

2022-01-31 Thread Mitsuru Kariya
Hi, Both JDK-8067629 and JDK-8252901 claim that it's a bug that a bean property of type Boolean cannot have a getter prefix "is". JDK-8067629: PropertyDescriptor.getReadMethod() returns null for Boolean property JDK-8252901: Introspector.getBeanInfo ignore properties of boxed Boolean type