Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-06 Thread via cfe-commits
2018-08-03 13:48, Vlad Tsyrklevich wrote: This change is causing ASan failures on the sanitizer bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/21898/steps/check-clang%20asan/logs/stdio [9] I've reverted it in r338904. On Fri, Aug 3, 2018 at 8:51 AM Scott Linder via

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-06 Thread via cfe-commits
/sanitizer-x86_64-linux-fast/builds/21898/steps/check-clang%20asan/logs/stdio [1] [9] I've reverted it in r338904. On Fri, Aug 3, 2018 at 8:51 AM Scott Linder via cfe-commits wrote: Author: scott.linder Date: Fri Aug 3 08:50:52 2018 New Revision: 338899 URL: http://llvm.org/viewvc/llvm-pr

RE: r339185 - Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

2018-08-07 Thread via cfe-commits
> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Douglas Yung via cfe-commits > Sent: Tuesday, August 07, 2018 5:23 PM > To: cfe-commits@lists.llvm.org > Subject: r339185 - Make test more robust by not checking hard

RE: r339307 - [CMake] Use normalized Windows target triples

2018-08-09 Thread via cfe-commits
m: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Petr Hosek via cfe-commits > Sent: Wednesday, August 08, 2018 10:16 PM > To: cfe-commits@lists.llvm.org > Subject: r339307 - [CMake] Use normalized Windows target triples > > Author: phosek > Date: Wed

RE: r333311 - [DebugInfo] Don't bother with MD5 checksums of preprocessed files.

2018-05-25 Thread via cfe-commits
town... I'll have to revisit this later. --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Paul Robinson via cfe-commits > Sent: Friday, May 25, 2018 4:59 PM > To: cfe-commits@lists.llvm.org > Subject: r1

r341309 - [OpenCL] Traverse vector types for ocl extensions support

2018-09-03 Thread via cfe-commits
Author: AlexeySotkin Date: Mon Sep 3 04:43:22 2018 New Revision: 341309 URL: http://llvm.org/viewvc/llvm-project?rev=341309&view=rev Log: [OpenCL] Traverse vector types for ocl extensions support Summary: Given the following kernel: __kernel void foo() { double d; double4 dd; } and cl_khr_f

r341314 - [Index] Update tests allowing double4 type to be "invalid"

2018-09-03 Thread via cfe-commits
Author: AlexeySotkin Date: Mon Sep 3 05:43:26 2018 New Revision: 341314 URL: http://llvm.org/viewvc/llvm-project?rev=341314&view=rev Log: [Index] Update tests allowing double4 type to be "invalid" Fixes test failure after r341309 Modified: cfe/trunk/test/Index/opencl-types.cl Modified: cfe

Re: r338299 - [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

2018-07-30 Thread via cfe-commits
Sorry for the delay, this should be fixed in r338321. Scott On 2018-07-30 17:19, Benjamin Kramer wrote: On Mon, Jul 30, 2018 at 10:37 PM Scott Linder via cfe-commits wrote: Author: scott.linder Date: Mon Jul 30 13:31:11 2018 New Revision: 338299 URL: http://llvm.org/viewvc/llvm-project?rev

Re: r338321 - Fix use of uninitialized variable in r338299

2018-07-31 Thread via cfe-commits
for OpenCL here? Seems a little odd. -eric On Mon, Jul 30, 2018 at 3:56 PM Scott Linder via cfe-commits wrote: Author: scott.linder Date: Mon Jul 30 15:52:07 2018 New Revision: 338321 URL: http://llvm.org/viewvc/llvm-project?rev=338321&view=rev [1] Log: Fix use of uninitialized variable in r33

r338427 - [OpenCL] Check for invalid kernel arguments in array types

2018-07-31 Thread via cfe-commits
Author: AlexeySotkin Date: Tue Jul 31 12:47:19 2018 New Revision: 338427 URL: http://llvm.org/viewvc/llvm-project?rev=338427&view=rev Log: [OpenCL] Check for invalid kernel arguments in array types Summary: OpenCL specification forbids use of several types as kernel arguments. This patch improves

r338432 - [OpenCL] Forbid size dependent types used as kernel arguments

2018-07-31 Thread via cfe-commits
Author: AlexeySotkin Date: Tue Jul 31 13:26:43 2018 New Revision: 338432 URL: http://llvm.org/viewvc/llvm-project?rev=338432&view=rev Log: [OpenCL] Forbid size dependent types used as kernel arguments Summary: Size_t, intptr_t, uintptr_t and ptrdiff_t cannot be used as kernel arguments, according

Re: r338321 - Fix use of uninitialized variable in r338299

2018-07-31 Thread via cfe-commits
Offset += FieldSize` that was moved only applies to the non-OpenCL "__descriptor" field. Scott On 2018-07-30 19:22, Eric Christopher wrote: Is 0 right for FieldOffset for OpenCL here? Seems a little odd. -eric On Mon, Jul 30, 2018 at 3:56 PM Scott Linder via cfe-commits wrote: Autho

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-03 Thread via cfe-commits
://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/21898/steps/check-clang%20asan/logs/stdio [9] I've reverted it in r338904. On Fri, Aug 3, 2018 at 8:51 AM Scott Linder via cfe-commits wrote: Author: scott.linder Date: Fri Aug 3 08:50:52 2018 New Revision: 338899 URL:

RE: r325175 - [Debug] Annotate compiler generated range-for loop variables.

2018-02-15 Thread via cfe-commits
From: Galina Kistanova [mailto:gkistan...@gmail.com] > Sent: Thursday, February 15, 2018 9:33 AM > To: Davis, Matthew > Cc: cfe-commits > Subject: Re: r325175 - [Debug] Annotate compiler generated range-for loop > variables. > > Hello Matt, > > This commit broke tests on one of our builders: >

RE: r325291 - [Coroutines] Use allocator overload when available

2018-02-16 Thread via cfe-commits
: requires 4 arguments, but 1 was provided 8 errors generated. Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Brian Gesiak via cfe-commits > Sent: Thursday, February 15, 2018 12:37 > To:

RE: r325691 - [clang-format] New API guessLanguage()

2018-02-21 Thread via cfe-commits
t; From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Ben > Hamilton via cfe-commits > Sent: Wednesday, February 21, 2018 7:55 > To: cfe-commits@lists.llvm.org > Subject: r325691 - [clang-format] New API guessLanguage() > > Author: benhamilton > Date: We

r325771 - [OpenCL] Add '-cl-uniform-work-group-size' compile option

2018-02-22 Thread via cfe-commits
Author: AlexeySotkin Date: Thu Feb 22 03:54:14 2018 New Revision: 325771 URL: http://llvm.org/viewvc/llvm-project?rev=325771&view=rev Log: [OpenCL] Add '-cl-uniform-work-group-size' compile option Summary: OpenCL 2.0 specification defines '-cl-uniform-work-group-size' option, which requires that

RE: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

2018-02-23 Thread via cfe-commits
cfe-commits-boun...@lists.llvm.org] On Behalf Of > Yvan Roux via cfe-commits > Sent: Friday, February 23, 2018 5:34 AM > To: Davide Italiano > Cc: cfe-commits > Subject: Re: r325850 - [Darwin] Add a test to check clang produces > accelerator tables. > > Hi Davide, > >

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

2017-06-23 Thread via cfe-commits
Good point, it makes sense to hand users a warning when they explicitly enable -fsanitize=object-size at -O0. I've added in the diagnostic. PTAL. disable-object-size-check-O0.diff Description: Binary data vedantOn Jun 23, 2017, at 1:05 PM, Justin Bogner wrote:+++ test/Driv

r326566 - Add possibility to specify output stream for CompilerInstance

2018-03-02 Thread via cfe-commits
Author: AlexeySotkin Date: Fri Mar 2 04:11:40 2018 New Revision: 326566 URL: http://llvm.org/viewvc/llvm-project?rev=326566&view=rev Log: Add possibility to specify output stream for CompilerInstance Patch by: krisb Reviewers: teemperor Reviewed By: teemperor Subscribers: klimek, mgorny, cfe-

RE: [PATCH] D44218: Correct the alignment for the PS4 target

2018-03-07 Thread via cfe-commits
Thanks! I’ll commit this. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, March 7, 2018 12:33 PM To: reviews+d44218+public+fd8ca19cc9985...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; craig.top...@gmail.com; erich.ke...@intel.com; filcab+llvm.phabrica...@gmail.com; Voss,

RE: [clang-tools-extra] r327295 - Reland "[clang-doc] Setup clang-doc frontend framework"

2018-03-12 Thread via cfe-commits
Julie Hockett via cfe-commits Sent: Monday, March 12, 2018 10:05 AM To: cfe-commits@lists.llvm.org Subject: [clang-tools-extra] r327295 - Reland "[clang-doc] Setup clang-doc frontend framework" Author: juliehockett Date: Mon Mar 12 10:05:14 2018 New Revision: 327295 URL: http://llvm.

RE: r327322 - [Tooling] Clear the PreambleSrcLocCache when preamble is discarded during reparsing

2018-03-12 Thread via cfe-commits
.src\tools\clang\test\Index\reparsed-live-issue.cpp" # command stderr: 'CINDEXTEST_EDITING=1': command not found error: command failed with exit status: 127 -- It seems perhaps you forgot to prefix the test line with "env"? Douglas Yung > -Ori

RE: [clang-tools-extra] r327833 - [clang-tidy] New check bugprone-unused-return-value

2018-03-19 Thread via cfe-commits
This should be fixed by r327911. Douglas Yung From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Galina Kistanova via cfe-commits Sent: Monday, March 19, 2018 13:13 To: Alexander Kornienko Cc: cfe-commits Subject: Re: [clang-tools-extra] r327833 - [clang-tidy] New check

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-11 Thread via cfe-commits
ei-ps4-windows10pro-fast\llvm.obj\bin\FileCheck.EXE" "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Driver\crash-report-modules.m" # command stderr: FileCheck error: '-' is empty. FileCheck command line: C:\ps4-buildsla

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-11 Thread via cfe-commits
s-boun...@lists.llvm.org] On Behalf > Of via cfe-commits > Sent: Monday, June 11, 2018 18:37 > To: r...@google.com > Cc: cfe-commits@lists.llvm.org > Subject: RE: r334418 - Enable crash recovery tests on Windows, globs > work in the lit internal shell now > > Hi Reid, &g

RE: r335159 - Fixed test in prior build where FileCheck tried to match against

2018-06-20 Thread via cfe-commits
(Using the right commits list this time...) See inline (same as previous). > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Leonard Chan via cfe-commits > Sent: Wednesday, June 20, 2018 3:34 PM > To: cfe-commits@lists.llv

Fix bug 26547

2018-10-11 Thread via cfe-commits
This is a patch to fix bug 26547 (https://bugs.llvm.org/show_bug.cgi?id=26547) This is my first patch, so please give feedback! This should be correct though, and I've tested it on both Windows x86 (where it does nothing), and Linux x86 (where it correctly returns alignof(double) = 4, __alignof(do

RE: r344337 - Remove top-level using declaration from header files, as these aliases leak.

2018-10-12 Thread via cfe-commits
.org] On Behalf Of Sam McCall via cfe-commits Sent: Friday, October 12, 2018 5:22 AM To: cfe-commits@lists.llvm.org Subject: r344337 - Remove top-level using declaration from header files, as these aliases leak. Author: sammccall Date: Fri Oct 12 05:21:29 2018 New Revision: 344337 URL: http://ll

RE: [clang-tools-extra] r344513 - [clangd] Minimal implementation of automatic static index (not enabled).

2018-10-15 Thread via cfe-commits
program finished with exit code 1 elapsedTime=1446.10 Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam McCall via cfe-commits > Sent: Monday, October 15, 2018 6:34 > To: cfe-commit

RE: r345676 - [Win64] Handle passing i128 by value

2018-10-31 Thread via cfe-commits
Also, don't we usually put ABI changes under an ABI compatibility check? This would be making Clang incompatible with itself. --paulr From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Richard Trieu via cfe-commits Sent: Tuesday, October 30, 2018 10:16 PM To:

r346838 - [OpenCL] Fix invalid address space generation for clk_event_t

2018-11-14 Thread via cfe-commits
Author: AlexeySotkin Date: Wed Nov 14 01:40:05 2018 New Revision: 346838 URL: http://llvm.org/viewvc/llvm-project?rev=346838&view=rev Log: [OpenCL] Fix invalid address space generation for clk_event_t Summary: Addrspace(32) was generated when putting 0 in clk_event_t * event_ret parameter for enq

RE: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

2019-03-13 Thread via cfe-commits
l and not NonTrivial? (At the very least it seems that the names could be improved.) Thanks, --paulr From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Aaron Smith via cfe-commits Sent: Monday, March 04, 2019 6:22 PM To: David Blaikie; Reid Kleckner; Adrian Prantl;

RE: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

2019-03-13 Thread via cfe-commits
d be improved.) Thanks, --paulr From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Aaron Smith via cfe-commits Sent: Monday, March 04, 2019 6:22 PM To: David Blaikie; Reid Kleckner; Adrian Prantl; Jonas Devlieghere Cc: cfe-commits@lists.llvm.org Subject: Re: r354843 - [CGDebugInfo]

RE: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

2019-03-20 Thread via cfe-commits
ible intended match here File "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/test/../test/../clang-tidy/tool/clang-tidy-diff.py", line 38, in ^ -- Can you please take a look? Douglas Yung -Ori

RE: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

2019-03-20 Thread via cfe-commits
-commits On Behalf Of Galina Kistanova via cfe-commits Sent: Wednesday, March 20, 2019 14:03 To: Zinovy Nis Cc: cfe-commits Subject: Re: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux. Hello Zinovy, This commit broke test on the next builder: http://lab.llvm.org:8011

RE: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-24 Thread via cfe-commits
tected member declared in class 'llvm::Error' C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include\llvm/Support/Error.h(176): note: see declaration of 'llvm::Error::Error' C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\i

RE: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-25 Thread via cfe-commits
e.cpp(155): > note: while trying to match the argument list '(FilterType, > llvm::raw_fd_ostream)' > C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\pp-trace\PPTrace.cpp(155): > error C2248: 'llvm::Error::Error'

RE: [clang-tools-extra] r358103 - clangd: fix the build with XPC

2019-04-10 Thread via cfe-commits
Original Message- From: cfe-commits On Behalf Of Saleem Abdulrasool via cfe-commits Sent: Wednesday, April 10, 2019 9:49 To: cfe-commits@lists.llvm.org Subject: [clang-tools-extra] r358103 - clangd: fix the build with XPC Author: compnerd Date: Wed Apr 10 09:48:52 2019 New Revisio

RE: r358104 - Don't emit an unreachable return block.

2019-04-10 Thread via cfe-commits
x27;s just a case of updating the test. Could you please take a look? Thanks, Wolfgang Pieb -Original Message- From: cfe-commits On Behalf Of John McCall via cfe-commits Sent: Wednesday, April 10, 2019 10:03 AM To: cfe-commits@lists.llvm.org Subject: r358104 - Don't emit an u

RE: r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

2019-04-12 Thread via cfe-commits
f the commit message is enough to let people track down the original report, although even there we usually abbreviate it to 'PR' (so PR41413 in this example). Thanks! --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf

RE: r358355 - [c++20] Enable driver and frontend support for building and using

2019-04-15 Thread via cfe-commits
- From: cfe-commits On Behalf Of Richard Smith via cfe-commits Sent: Sunday, April 14, 2019 4:12 To: cfe-commits@lists.llvm.org Subject: r358355 - [c++20] Enable driver and frontend support for building and using Author: rsmith Date: Sun Apr 14 04:11:37 2019 New Revision: 358355 URL: http

RE: r358355 - [c++20] Enable driver and frontend support for building and using

2019-04-15 Thread via cfe-commits
its Subject: Re: r358355 - [c++20] Enable driver and frontend support for building and using On Mon, 15 Apr 2019 at 18:14, via cfe-commits wrote: > > Hi Richard, > > The driver test you added (modules.cpp) seems to fail if the compiler > configuration uses an external assemb

RE: r358355 - [c++20] Enable driver and frontend support for building and using

2019-04-15 Thread via cfe-commits
Smith Sent: Monday, April 15, 2019 19:12 To: Yung, Douglas Cc: cfe-commits Subject: Re: r358355 - [c++20] Enable driver and frontend support for building and using On Mon, 15 Apr 2019, 19:08 via cfe-commits, mailto:cfe-commits@lists.llvm.org>> wrote: Hi Richard, That helps a little bi

Re: r359814 - [Sema] Emit warning for visibility attribute on internal-linkage declaration

2019-05-02 Thread via cfe-commits
ct __attribute__((visibility("hidden"))) {} A;   ^    A In addition to the error, note that the warning is wrong, because the linkage was computed too early (before it was known). On Thu, 2 May 2019 at 12:01, Scott Linder via cfe-commits wrote: > > Author: scott.linder >

r360018 - Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

2019-05-06 Thread via cfe-commits
Author: luoyuanke Date: Mon May 6 01:25:11 2019 New Revision: 360018 URL: http://llvm.org/viewvc/llvm-project?rev=360018&view=rev Log: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake Summary: 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOA

RE: r342501 - Fix logic around determining use of frame pointer with -pg.

2018-09-18 Thread via cfe-commits

RE: r342668 - Add testcases for r342667.

2018-09-20 Thread via cfe-commits
th exit status: 1 Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Eric Christopher via cfe-commits > Sent: Thursday, September 20, 2018 10:23 > To: cfe-commits@lists.llvm.org > Subject: r342668 - Add testcase

RE: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread via cfe-commits
e) Code complete: 1 results from Sema, 0 from Index, 0 matched, 1 returned. Can you please take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Eric Liu via cfe-commits > Sent: Tuesday,

RE: [clang-tools-extra] r343780 - [clangd] expose MergedIndex class

2018-10-04 Thread via cfe-commits
: warning: control reaches end of non-void function [-Wreturn-type] } ^ Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam McCall via cfe-commits > Sent: Thursday, October 04, 2018 7:20 > To: cfe-commits

RE: [clang-tools-extra] r343778 - [clangd] clangd-indexer gathers refs and stores them in index files.

2018-10-05 Thread via cfe-commits
000 0x), RtlUserThreadStart() + 0x1D bytes(s) Could you take a look into this? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam McCall via cfe-commits > Sent: Thursday, October 04, 2018 7:10 > To

RE: r353569 - [Sema] Make string literal init an rvalue.

2019-02-08 Thread via cfe-commits
27;['clang-tidy', '/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/bugprone-string-constructor.cpp.tmp.cpp', '-fix', '--checks=-*,bugprone-string-constructor', '--'

RE: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread via cfe-commits
I thin the Best Fix is probably to make FileCheck diag if a line starts with (after a few whitelisted comment chars like // and #) a check-prefix but then isn't followed by : (maybe after -NOT, -SAME, -LABEL etc). FileCheck doesn't explicitly pass over leading comment characters, it just patter

RE: r353370 - Generalised the SMT state constraints

2019-02-11 Thread via cfe-commits
=ON -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 -DLLVM_TOOL_COMPILER_RT_BUILD:BOOL=OFF -DLLVM_BUILD_TESTS:BOOL=ON -DLLVM_BUILD_EXAMPLES:BOOL=ON -DCLANG_BUILD_EXAMPLES:BOOL=ON -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_LIT_ARGS="-v -j8" C:\src\upstream\llvm_clean Douglas Yung -Original Message----- From: cfe

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

2019-02-20 Thread via cfe-commits
e': a scoped enumeration cannot be redeclared as an unscoped enumeration [C:\src\upstream\354517-win32-Release\tools\clang\tools\extra\clang-tidy\utils\clangTidyUtils.vcxproj] Douglas Yung -Original Message- From: cfe-commits On Behalf Of Jonas Toth via cfe-commits Sent: Wednesday, F

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

2019-02-20 Thread via cfe-commits
Hi Jonas, I've committed what I think should be a fix for the build issue in r354545. Douglas Yung -Original Message- From: cfe-commits On Behalf Of via cfe-commits Sent: Wednesday, February 20, 2019 16:57 To: jonas.t...@gmail.com Cc: cfe-commits@lists.llvm.org Subject: RE: [

RE: r362856 - DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates

2019-06-17 Thread via cfe-commits
e-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > David Blaikie via cfe-commits > Sent: Friday, June 07, 2019 8:01 PM > To: cfe-commits@lists.llvm.org > Subject: r362856 - DebugInfo: Add support for 'nodebug' attribute on > typedefs and alias templates >

RE: r363204 - [clang-scan-deps] initial outline of the tool that runs preprocessor to find

2019-06-17 Thread via cfe-commits
ing the "-c" to "-S" still shows the test passing when I run it locally, so if the "-c" is not really needed, can it be changed to "-S" to work correctly where the integrated assembler is not the default option? Douglas Yung -Original Message- F

RE: r363548 - Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver flags

2019-06-17 Thread via cfe-commits
me/dyung/src/upstream/363548-linux/bin/../lib" "-L/lib" "-L/usr/lib" "/tmp/clang_f_opts-f2e231.o" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s

RE: r363855 - [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread via cfe-commits
__cdecl clang::ast_matchers::dynamic::`anonymous namespace'::RegistryMaps::RegistryMaps(void)" (??0RegistryMaps@?A0x914e59e4@dynamic@ast_matchers@clang@@QEAA@XZ) bin\clang-query.exe : fatal error LNK1120: 1 unresolved externals Douglas Yung -Original Message- From: cfe-commits

RE: [clang-tools-extra] r365937 - [clang-doc] Add html links to references

2019-07-12 Thread via cfe-commits
est case ran. (1 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] HTMLGeneratorTest.emitRecordHTML 1 FAILED TEST Can you please take a look? Douglas Yung -Original Message- From: cfe-commits On Behalf Of Julie Hockett via cfe-commits Sent: Friday

RE: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

2019-06-21 Thread via cfe-commits
^ error: command failed with exit status: 1 Douglas Yung -Original Message- From: cfe-commits On Behalf Of Serge Guelton via cfe-commits Sent: Thursday, June 20, 2019 13:26 To: cfe-commits@lists.llvm.org Subject: [cl

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
Hi Rainer, I tried your patch and it still has problems. First, the "%s" was being replaced with the actual path by LIT, so I replaced that with "%%s" which then created the response file correctly, but now the response file contains this: /IC:\src\git\dev\llvm\tools\clang\test\Driver\Inputs\\c

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
Hi Rainer, I figured it out. Because you are using printf, you no longer need the '\\c'. If I use the following RUN line, the test passes on both Windows/linux (I don't have solaris to test unfortunately): // RUN: printf '%%s\n' '/I%S\Inputs\cl-response-file\ /DFOO=2' > %t.rsp I can submit thi

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
I see Reid has reverted your original fix so instead of directly submitting, I have put the patch up for review first at https://reviews.llvm.org/D63678. Douglas Yung -Original Message- From: Rainer Orth Sent: Friday, June 21, 2019 14:46 To: Yung, Douglas Cc: cfe-commits@lists.llvm.or

RE: [clang-tools-extra] r365123 - [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread via cfe-commits
- From: cfe-commits On Behalf Of Kadir Cetinkaya via cfe-commits Sent: Thursday, July 4, 2019 2:52 To: cfe-commits@lists.llvm.org Subject: [clang-tools-extra] r365123 - [clangd] Make HadErrors part of background index's internal state Author: kadircet Date: Thu Jul 4 02:52:12 201

RE: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

2019-05-14 Thread via cfe-commits
ot;UNSUPPORTED: foo" and "REQUIRES: !foo"? (I see some of the fixes you've made go one way, some the other way) On Fri, May 10, 2019 at 11:30 AM Paul Robinson via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: probinson Date: Fri May 10 11:32:53 2019 Ne

RE: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

2019-05-14 Thread via cfe-commits
t; > > > > > > > What's the practical difference between "UNSUPPORTED: foo" and > "REQUIRES: !foo"? (I see some of the fixes you've made go one way, some > the other way) > > > > > > > > On Fri, May 10, 2019 at 11:30 AM P

RE: r360833 - [Clang][PP] Add the __FILE_NAME__ builtin macro.

2019-05-15 Thread via cfe-commits
\\build\\llvm.src\\tools\\clang\\test\\Preprocessor\\file_name_macro.c" ^ error: command failed with exit status: 1 Douglas Yung -Original Message- From: cfe-commits On Behalf Of Kristina Brooks via

RE: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread via cfe-commits
I'm not sure that is problem. Our internal linux build bot also hit the same problem and it has a 64-bit CPU. Douglas Yung -Original Message- From: cfe-commits On Behalf Of Chris Bieneman via cfe-commits Sent: Thursday, May 16, 2019 22:45 To: Chris Bieneman Cc: Richard Smith

RE: r361278 - [clang][Darwin] Refactor header search path logic into the driver

2019-05-21 Thread via cfe-commits
lang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Driver/Inputs/basic_darwin_toolchain", the value of TOOLCHAIN as expected by FileCheck is "C:ps4-buildslave2llvm-clang-lld-x86_64-scei-ps4-windows10pro-fastllvm\\.srctoolsclangtestDriver/Inputs/bas

RE: r361562 - Use clang_cc1 instead of clang in CodeGen test.

2019-05-24 Thread via cfe-commits
est() local_unnamed_addr #0 { ^ :11:5: note: possible intended match here %A = alloca [1000 x double], align 16 ^ -- Can you take a look into fixing the test or running it only when the x86 backend is present? Douglas Yung -Original Message- From: cfe-commit

RE: [clang-tools-extra] r349038 - [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

2018-12-13 Thread via cfe-commits
I have reverted this commit in r349121. Ivan, please do not leave in commits that cause failures as they make the bots red which can mask other failures. Douglas Yung From: cfe-commits On Behalf Of Galina Kistanova via cfe-commits Sent: Thursday, December 13, 2018 17:41 To: ivan.donchevs

RE: r349053 - [CodeComplete] Fill preferred type on binary expressions

2018-12-14 Thread via cfe-commits
Hi, I think this test is still broken on Windows when you are building a cross compiler as we at Sony do. I have put the details in PR40033. Can somebody take a look? Douglas Yung From: cfe-commits On Behalf Of Reid Kleckner via cfe-commits Sent: Thursday, December 13, 2018 13:51 To: Ilya

RE: r349281 - [analyzer][MallocChecker][NFC] Document and reorganize some functions

2018-12-16 Thread via cfe-commits
-notes.cpp Clang :: Analysis/NewDelete-intersections.mm Clang :: Analysis/free.c Clang :: Analysis/inner-pointer.cpp Clang :: Analysis/malloc.c Clang :: Analysis/malloc.mm Can you please take a look? Douglas Yung -Original Message- From: cfe-commits On Behalf Of Kristof Umann via cfe

Re: r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

2019-09-25 Thread via cfe-commits
Thank you, sorry for the trouble. vedant > On Sep 25, 2019, at 3:36 PM, Evgenii Stepanov > wrote: > > FYI I've fixed a memory leak in the new test in r372925. > > On Wed, Sep 25, 2019 at 10:58 AM Vedant Kumar via cfe-commits > wrote: >> >> Author: ved

RE: r330244 - [MinGW] Look for a cross sysroot relative to the clang binary

2018-04-18 Thread via cfe-commits
:: Driver/pic.c Clang :: Driver/windows-pic.cpp Clang :: Index/index-attrs.c Clang :: Index/index-attrs.cpp Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Martin Storsjo via cfe-commits > Sent: Wednesd

r330404 - [OpenCL] Add 'denorms-are-zero' function attribute

2018-04-20 Thread via cfe-commits
Author: AlexeySotkin Date: Fri Apr 20 01:08:04 2018 New Revision: 330404 URL: http://llvm.org/viewvc/llvm-project?rev=330404&view=rev Log: [OpenCL] Add 'denorms-are-zero' function attribute Summary: Generate attribute 'denorms-are-zero'='true' if '-cl-denorms-are-zero' compile option was specifie

If I want to disable certain attributes, such as "swiftcall", is there any way to do it now?

2018-04-27 Thread ???? via cfe-commits
As the title says,thanks.___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

?????? If I want to disable certain attributes, such as "swiftcall", isthere any way to do it now?

2018-05-02 Thread ???? via cfe-commits
"TargetNotSupportedAttr?? && //add SuperName.empty()) SuperName = R->getName(); If I use this method, is it correct? -- -- ??: "Aaron Ballman"; : 2018??4??29??(??) 3:07 ??: ""<772847.

?????? If I want to disable certain attributes, such as "swiftcall",isthere any way to do it now?

2018-05-02 Thread ???? via cfe-commits
ty()) > > SuperName = R->getName(); > > > If I use this method, is it correct? It seems like it would work, yes. ~Aaron > > > > > -- -- > ??: "Aaron Ballman"; > : 2018??4??29??(??) 3

?????? If I want to disable certain attributes, such as"swiftcall",isthere any way to do it now?

2018-05-03 Thread ???? via cfe-commits
ttr" && >> >> R->getName() != "TargetNotSupportedAttr?? && //add >> >> SuperName.empty()) >> >> SuperName = R->getName(); >> >> >> If I use this method, is it co

OpenCL Header: Guard all half float usage based on cl_khr_fp16 extension

2018-05-05 Thread via cfe-commits
Hi,   this patch guards all missed half float functions based on the availabiltiy of the OpenCL extension cl_khr_fp16.   Best regards,   JerryIndex: lib/Headers/opencl-c.h === --- lib/Headers/opencl-c.h (revision 331598) +++ lib/Head

?????? If I want to disable certain attributes, such as"swiftcall",isthere any way to do it now?

2018-05-06 Thread ???? via cfe-commits
gt; need to generate the attribute class, so add the following code in >> EmitClangAttrClass >> >> if (R->getName() != "TargetSpecificAttr" && >> >> R->getName() != "TargetNotSupportedAttr?? && //add >> >> Su

?????? If I want to disable certain attributes, such as"swiftcall",isthereany way to do it now?

2018-05-07 Thread ???? via cfe-commits
d >>> >>> TestStr = !Test.empty() ? Test + " ? " + " 0 :" + >>> llvm::itostr(Version) : "0"; // add >>> >>> } else if (Attr->isSubClassOf("TargetSpecificAttr")) >>> >>> 4.And for classes that inher

RE: r335740 - [analyzer] Allow registering custom statically-linked analyzer checkers

2018-06-27 Thread via cfe-commits
ment unique_ptr(const unique_ptr&) = delete; ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/unique_ptr.h:176:2: note: candidate template ignored: could not match 'auto_ptr' against 'unique_ptr' unique_ptr(auto_ptr<

RE: [clang-tools-extra] r336177 - [clangd] Incorporate transitive #includes into code complete proximity scoring.

2018-07-03 Thread via cfe-commits
-scei-ps4-windows10pro-fast/builds/18166 These failures are also occurring on our internal bots. Could you take a look at this? Thanks, Matthew -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Sam McCall via cfe-commits Sent: Tuesday, July 3

[clang] 1ae8e8d - Don't add -fsplit-lto-unit for thin LTO builds with PS4 and Darwin toolchains

2019-10-24 Thread via cfe-commits
Author: evgeny Date: 2019-10-24T14:10:03+03:00 New Revision: 1ae8e8d25fd87048d3d8d7429308e52b236c79a1 URL: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1 DIFF: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1.diff LOG: D

[clang] ec66603 - [clang-format] Remove the dependency on frontend

2019-10-24 Thread via cfe-commits
Author: paulhoad Date: 2019-10-24T19:03:57+01:00 New Revision: ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b URL: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b DIFF: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b.diff LOG:

[clang] 8fa5e98 - [clang-format] Remove duplciate code from Invalid BOM detection

2019-10-24 Thread via cfe-commits
Author: paulhoad Date: 2019-10-24T20:24:44+01:00 New Revision: 8fa5e98fd191d02fc7e0e220d74af267b9140e6a URL: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a DIFF: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a.diff LOG:

[clang] 23b7836 - [clang-format] update documentation

2019-10-24 Thread via cfe-commits
Author: paulhoad Date: 2019-10-24T21:10:13+01:00 New Revision: 23b78364150cd946a8b111e87defdf179eecbc8f URL: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f DIFF: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f.diff LOG:

[clang] 6df7ef0 - [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

2019-10-25 Thread via cfe-commits
Author: paulhoad Date: 2019-10-25T14:46:19+01:00 New Revision: 6df7ef0d8baac34259e2c93043d843f27812c534 URL: https://github.com/llvm/llvm-project/commit/6df7ef0d8baac34259e2c93043d843f27812c534 DIFF: https://github.com/llvm/llvm-project/commit/6df7ef0d8baac34259e2c93043d843f27812c534.diff LOG:

[clang] 5d35b7d - [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

2019-10-28 Thread via cfe-commits
Author: vhscampos Date: 2019-10-28T10:59:18Z New Revision: 5d35b7d9e1a34b45c19609f754050e4263bee4ce URL: https://github.com/llvm/llvm-project/commit/5d35b7d9e1a34b45c19609f754050e4263bee4ce DIFF: https://github.com/llvm/llvm-project/commit/5d35b7d9e1a34b45c19609f754050e4263bee4ce.diff LOG: [AR

[clang] f6e11a3 - [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

2019-10-28 Thread via cfe-commits
Author: vhscampos Date: 2019-10-28T11:06:58Z New Revision: f6e11a36c49c065cd71e9c54e4fba917da5bbf2e URL: https://github.com/llvm/llvm-project/commit/f6e11a36c49c065cd71e9c54e4fba917da5bbf2e DIFF: https://github.com/llvm/llvm-project/commit/f6e11a36c49c065cd71e9c54e4fba917da5bbf2e.diff LOG: [AR

[clang] e71c537 - [clang-format] Fix line lengths w/ comments in align

2020-05-19 Thread via cfe-commits
Author: mydeveloperday Date: 2020-05-20T07:22:01+01:00 New Revision: e71c537a487cacaa00265e1acb765235943d5172 URL: https://github.com/llvm/llvm-project/commit/e71c537a487cacaa00265e1acb765235943d5172 DIFF: https://github.com/llvm/llvm-project/commit/e71c537a487cacaa00265e1acb765235943d5172.diff

[clang] b99bf0e - [clang-format][PR45816] Add AlignConsecutiveBitFields

2020-05-19 Thread via cfe-commits
Author: mydeveloperday Date: 2020-05-20T07:42:58+01:00 New Revision: b99bf0e08be4faa4527709541dfdc29240e0c75c URL: https://github.com/llvm/llvm-project/commit/b99bf0e08be4faa4527709541dfdc29240e0c75c DIFF: https://github.com/llvm/llvm-project/commit/b99bf0e08be4faa4527709541dfdc29240e0c75c.diff

[clang] cc918e9 - [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

2020-05-19 Thread via cfe-commits
Author: mydeveloperday Date: 2020-05-20T07:44:36+01:00 New Revision: cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140 URL: https://github.com/llvm/llvm-project/commit/cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140 DIFF: https://github.com/llvm/llvm-project/commit/cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140.diff

[clang] 807ab2c - [clang-format] [PR42164] Add Option to Break before While

2020-05-19 Thread via cfe-commits
Author: mydeveloperday Date: 2020-05-20T07:48:45+01:00 New Revision: 807ab2cd0db398c420ca5b8a7fc260aaea5051a1 URL: https://github.com/llvm/llvm-project/commit/807ab2cd0db398c420ca5b8a7fc260aaea5051a1 DIFF: https://github.com/llvm/llvm-project/commit/807ab2cd0db398c420ca5b8a7fc260aaea5051a1.diff

[clang] 166ebef - [clang-format] Set of unit test to begin to validate that we don't change defaults

2020-05-20 Thread via cfe-commits
Author: mydeveloperday Date: 2020-05-20T21:11:10+01:00 New Revision: 166ebefd27ac71e3f911f3d7ba0e168464d372af URL: https://github.com/llvm/llvm-project/commit/166ebefd27ac71e3f911f3d7ba0e168464d372af DIFF: https://github.com/llvm/llvm-project/commit/166ebefd27ac71e3f911f3d7ba0e168464d372af.diff

  1   2   3   4   5   6   7   8   9   10   >