@@ -179,12 +183,14 @@ void IncludeCleanerCheck::check(const
MatchFinder::MatchResult &Result) {
if (getCurrentMainFile().endswith(PHeader))
continue;
}
-
-if (llvm::none_of(
-IgnoreHeadersRegex,
-[Resolved = (*I.Resolved).getFileEn
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/68185
From 91ce80c89689518c20f18efd172628a51aebb769 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 4 Oct 2023 09:38:28 +0200
Subject: [PATCH 1/3] [clang-tidy][IncludeCleaner] Fix analysis supression in
pre
kadircet wrote:
> Overall looks fine, but please update release notes for this (update current
> entry or even merge them together instead of adding new one). And make sure
> that there is a commit description for this change when committing, instead
> of just having only a title.
done.
http
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/68325
Otherwise we create collisions, e.g. a struct named Foo inside an anonymous
namespace will get the same USR no matter what the surrounding decl-context is.
From 5603c6ee481332f82c8ec1589e3e1610c570526d Mon Sep
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/68329
None
From 5603c6ee481332f82c8ec1589e3e1610c570526d Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 5 Oct 2023 16:55:17 +0200
Subject: [PATCH 1/2] [clang][USR] Encode full decl-context also for anon
n
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/68185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/69427
Fixes https://github.com/llvm/llvm-project/issues/69369.
From e19bf2e40b79b5f65de91d566e675b560620517e Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 18 Oct 2023 09:34:21 +0200
Subject: [PATCH] [cla
@@ -219,6 +219,9 @@ TidyProvider
disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) {
"-bugprone-use-after-move",
// Alias for bugprone-use-after-move.
"-hicpp-invalid-access-moved",
+ // Check uses dataflow analysis, which might hang/crash unexpectedl
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/69427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/68325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/68329
From 80fa52f6efa36e04bf87c525013513d4429788ae Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 5 Oct 2023 18:05:11 +0200
Subject: [PATCH] [clang][Index] Improve USR generation for using-decls
Make sure
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/65499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/65952:
None
From a53f4dbec3a6a0944e67d09bce1b9af2d107e418 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Mon, 11 Sep 2023 14:00:58 +0200
Subject: [PATCH] [include-cleaner] Fix handling of enums in presence of
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/65952:
From 010de76adf9264970e5c5dd6d6cc30205210df89 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Mon, 11 Sep 2023 14:00:58 +0200
Subject: [PATCH] [include-cleaner] Fix handling of enums in presence of
qualif
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/65952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/65266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/65444:
None
From 0b33a1277beb1ec518cb000923d02d78365bfd82 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 5 Sep 2023 19:19:47 +0200
Subject: [PATCH] [clangd][unittests] Limit paralelism for clangd unittests
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/65444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
@HighCommander4 @AaronBallman FYI
https://github.com/llvm/llvm-project/pull/65444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/65431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/65431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -199,6 +200,9 @@ void IncludeCleanerCheck::check(const
MatchFinder::MatchResult &Result) {
tooling::HeaderIncludes HeaderIncludes(getCurrentMainFile(), Code,
FileStyle->IncludeStyle);
+ // `tooling::HeaderIncludes::insert` will n
@@ -224,7 +224,8 @@ Changes in existing checks
- Improved :doc:`misc-include-cleaner
` check by adding option
- `DeduplicateFindings` to output one finding per symbol occurrence.
+ `DeduplicateFindings` to output one finding per symbol occurrence
+ and avoid fixes insert
@@ -209,14 +213,17 @@ void IncludeCleanerCheck::check(const
MatchFinder::MatchResult &Result) {
// main file.
if (auto Replacement =
HeaderIncludes.insert(llvm::StringRef{Spelling}.trim("\"<>"),
- Angled, tooling::IncludeDir
https://github.com/kadircet labeled
https://github.com/llvm/llvm-project/pull/65431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/65444:
From 627082183a34c5b497db1c0eb775b8c3d0bbf06b Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 5 Sep 2023 19:19:47 +0200
Subject: [PATCH] [clangd][unittests] Limit paralelism for clangd unittests
We s
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/65499:
None
From c1f9b400497b78a5283d75da6f7ee0c14320e541 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 6 Sep 2023 18:42:21 +0200
Subject: [PATCH] [include-cleaner] Always keep non-self-contained files
-
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet review_requested
https://github.com/llvm/llvm-project/pull/65499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thanks Kito! not sure if you've noticed D138287, but if landing a solution
is going to take a long while here, i'd like to move forward with that
approach to make sure this doesn't stay in a broken state. so it'd be great
if you can give some updates/estimates about fixing this soon.
On Mon, Nov 2
To illustrate another workflow:
I also got format-on-save turned on, but filter the irrelevant changes
before committing by doing `git add -p` instead of adding all modifications.
On Sat, Mar 28, 2020 at 9:17 PM Nathan Ridge via Phabricator <
revi...@reviews.llvm.org> wrote:
> nridge marked an in
done. sorry for forgetting about this so soon.
On Thu, Oct 31, 2019 at 12:58 PM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:
> thakis added inline comments.
>
>
>
> Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388
>// results in arbitrary fa
I was actually watching for buildbots(sent out
6b8ff5e43b405d255259196b6a53a3b5671aa5c7 for fixing some breakages for
example) but somehow this breakage mail didn't arrive. buildbots were in
bad shape on friday it might've skipped because of that :/
Thanks for fixing this.
On Sat, Dec 14, 2019 at
sent out 0f959c87cc7867beb67bfab2d5e3cf90708b2f98
On Mon, Dec 16, 2019 at 9:08 AM Yvan Roux wrote:
> Hi, it is still broken on AArch64 bots, logs are available here:
>
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21251/steps/ninja%20check%201/logs/stdio
>
> Thanks,
> Yv
> I joined the group; what do I do to get tests run for this?
you need to upload a diff to trigger the bots
> > Hope someone can verify the build on Windows.
> Do you think I should go on IRC and ask?
Not much help before committing, but for post-commit there is
http://45.33.8.238/.
Doesn't con
figured out the issue, preparing a fix
On Wed, Apr 12, 2023 at 7:46 PM Douglas Yung via Phabricator <
revi...@reviews.llvm.org> wrote:
> dyung added a comment.
>
> @kadircet, your change is causing 3 test failures on Windows bots, can you
> take a look and revert if you need time to investigate?
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/76466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -538,11 +564,222 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
https://github.com/kadircet approved this pull request.
thanks, lgtm!
https://github.com/llvm/llvm-project/pull/76466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -538,11 +564,222 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
@@ -696,7 +982,7 @@ renameOutsideFile(const NamedDecl &RenameDecl,
llvm::StringRef MainFilePath,
FilePath);
}
auto RenameEdit =
-buildRenameEdit(FilePath, AffectedFileCode, *RenameRanges, NewName);
+buildRenameEdit(FilePath, AffectedF
@@ -538,11 +564,222 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
@@ -538,11 +564,222 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
@@ -490,6 +491,13 @@ bool eligibleForExtraction(const SelectionTree::Node *N) {
BO->getRHS() == OuterImplicit.ASTNode.get())
return false;
}
+ if (const auto *Decl = Parent->ASTNode.get()) {
+if (!Decl->isInitCapture() &&
kadircet wrote:
t
@@ -490,6 +491,13 @@ bool eligibleForExtraction(const SelectionTree::Node *N) {
BO->getRHS() == OuterImplicit.ASTNode.get())
return false;
}
+ if (const auto *Decl = Parent->ASTNode.get()) {
+if (!Decl->isInitCapture() &&
kadircet wrote:
s
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/69477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/82265
None
From 05e1d91361b4ce4226d21b00a312eb7642057c8f Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Mon, 19 Feb 2024 17:42:34 +0100
Subject: [PATCH] [clang] Preserve found-decl when constructing VarTemplate
@@ -490,6 +491,13 @@ bool eligibleForExtraction(const SelectionTree::Node *N) {
BO->getRHS() == OuterImplicit.ASTNode.get())
return false;
}
+ if (const auto *Decl = Parent->ASTNode.get()) {
+if (!Decl->isInitCapture() &&
kadircet wrote:
>
https://github.com/kadircet approved this pull request.
thanks, lgtm!
https://github.com/llvm/llvm-project/pull/69477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
cc @hokein
https://github.com/llvm/llvm-project/pull/82265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -143,8 +143,16 @@ std::string printDefinition(const Decl *D, PrintingPolicy
PP,
// Initializers might be huge and result in lots of memory allocations in
// some catostrophic cases. Such long lists are not useful in hover cards
// anyway.
- if (200 <
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/82265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/82612
Update include-cleaner tests. Now that we have proper found-decls set up
for VarTemplates, in case of instationtations we point to primary
templates and not specializations. To be changed in a follow-up patch.
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/82615
None
From 1ae249119856ae2d8c1d2d4a3c3e311fa3d66dd0 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 22 Feb 2024 13:22:11 +0100
Subject: [PATCH 1/2] Reland "[clang] Preserve found-decl when constructing
@@ -811,8 +811,14 @@ renameWithinFile(ParsedAST &AST, const NamedDecl
&RenameDecl,
continue;
Locs.push_back(RenameLoc);
}
- if (const auto *MD = dyn_cast(&RenameDecl))
-return renameObjCMethodWithinFile(AST, MD, NewName, std::move(Locs));
+ if (const auto *MD
https://github.com/kadircet requested changes to this pull request.
mentioned this offline already but putting in here as well for my sanity.
the patch is missing the actual changes to the logic, it only has test changes.
https://github.com/llvm/llvm-project/pull/82237
_
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/82625
None
From 11dee86b09f99da7ce3d6dd0d3f8fcb7a3b53b43 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 22 Feb 2024 15:46:20 +0100
Subject: [PATCH] [include-cleaner] Dont apply name-match for non-owning
h
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/82396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -811,8 +811,17 @@ renameWithinFile(ParsedAST &AST, const NamedDecl
&RenameDecl,
continue;
Locs.push_back(RenameLoc);
}
- if (const auto *MD = dyn_cast(&RenameDecl))
-return renameObjCMethodWithinFile(AST, MD, NewName, std::move(Locs));
+ if (const auto *MD
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/82396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/82612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/82615
From 32c8199fb9ffb9180b666e0837aa73aa6151cebc Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 22 Feb 2024 13:52:42 +0100
Subject: [PATCH] [include-cleaner] Use FoundDecl only for using-shadow-decls
--
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/82615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
Hi @ChuanqiXu9, I was on vacation and just returned, i'll provide next round of
feedback quite soon.
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
kadircet wrote:
I am not sure if it's best to push a new command line flag to all other tools
that use clang-format as a library.
Have you considered any other alternatives that can self-contain this in
clang-format? e.g can we just treat paths as relative to current
`.clang-format` file ?
h
kadircet wrote:
there still seems to be a regression when the operator is `-`, filed
https://github.com/llvm/llvm-project/issues/107568
https://github.com/llvm/llvm-project/pull/102261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -861,7 +861,7 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
// or
// cal(
// new SomethingElseee());
- !IsSimpleFunction(Current)) {
+ Current.isNot(
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/107506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
i've also found 3 more cases that point back to same patch in
https://github.com/llvm/llvm-project/issues/107574, in case you want to address
all of them with this change
https://github.com/llvm/llvm-project/pull/107506
___
cfe-commit
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/102615
We were using tryGetRealPathName in certain places, which resolves
symlinks (sometimes). This was resulting in discrepancies in behavior,
depending on how a file was first reached.
This path migrates all usages
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/102615
From 48b7a2c9ebbb5d8ea6be53ef034d2e67558ef97c Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Fri, 9 Aug 2024 14:40:44 +0200
Subject: [PATCH] [include-cleaner] Unify symlink handling
We were using tryGetR
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/102615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/104033
None
From 180279545dd2e6f2b6581376a21fd862d4786197 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 14 Aug 2024 16:50:22 +0200
Subject: [PATCH] [include-cleaner] Add handling for new/delete expression
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/104033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/88381
Building ASTs with compile flags that are incompatible to the ones used
for the Preamble are not really supported by clang and can trigger
crashes.
In an ideal world, we should be re-using not only TargetOpts, b
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/82625
From d5e35aac5bc4103b668766aa10d42bc4dc2c9087 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 22 Feb 2024 15:46:20 +0100
Subject: [PATCH] [include-cleaner] Dont apply name-match for non-owning
headers
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/82625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1354,6 +1354,8 @@ maybeFindIncludeReferences(ParsedAST &AST, Position Pos,
ReferencesResult::Reference Result;
const auto *Token = AST.getTokens().spelledTokenAt(Loc);
+if (!Token)
kadircet wrote:
it's a little bit hard to see what
@@ -387,8 +387,8 @@ const syntax::Token
*TokenBuffer::spelledTokenAt(SourceLocation Loc) const {
assert(Loc.isFileID());
const auto *Tok = llvm::partition_point(
spelledTokens(SourceMgr->getFileID(Loc)),
- [&](const syntax::Token &Tok) { return Tok.location() <
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -387,8 +387,8 @@ const syntax::Token
*TokenBuffer::spelledTokenAt(SourceLocation Loc) const {
assert(Loc.isFileID());
const auto *Tok = llvm::partition_point(
spelledTokens(SourceMgr->getFileID(Loc)),
- [&](const syntax::Token &Tok) { return Tok.location() <
@@ -1354,6 +1354,8 @@ maybeFindIncludeReferences(ParsedAST &AST, Position Pos,
ReferencesResult::Reference Result;
const auto *Token = AST.getTokens().spelledTokenAt(Loc);
+if (!Token)
kadircet wrote:
thanks! can you also rename `spell
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -447,7 +447,7 @@ class HighlightingsBuilder {
if (!RLoc.isValid())
return;
-const auto *RTok = TB.spelledTokenAt(RLoc);
+const auto *RTok = TB.spelledTokenContaining(RLoc);
kadircet wrote:
so looks like this call site was actually expecti
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/94528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
so after this patch, clang seems to be crashing on:
```cpp
template struct map {};
template class foo {};
template class MapType, typename Value>
Value bar(MapType map);
template class MapType, typename Value>
Value bar(MapType> map);
void aux() {
map> input;
bar(input)
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/92743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks, this definitely LG. it's something we've just forgot :(
https://github.com/llvm/llvm-project/pull/94920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/95114
Addresses https://github.com/llvm/llvm-project/issues/81215.
From b15c33b685f80dfe7b0f4865a574276bf1c15b40 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 11 Jun 2024 15:36:15 +0200
Subject: [PATCH]
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/95121
Normalize header-to-be-spelled using WorkingDir, similar to search paths
themselves.
Addresses https://github.com/llvm/llvm-project/issues/81215.
From 22422586ef650bf98f83d5f58a47e59be29d02b8 Mon Sep 17 00:00:
@@ -0,0 +1,364 @@
+//===--- PrerequisiteModulesTests.cpp ---*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
kadircet wrote:
can you revert all of these changes?
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 851 matches
Mail list logo
