[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

dodohand added a comment. IMO you have just introduced a bug, not fixed one. A lambda expression in an if statement condition clause is exactly the kind of thing that this checker was designed to flag. The BARR group coding guideline, with which this is intended to comply in spirit, makes no exc

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @alexfh , @aaron.ballman, Could one of you have a look at this? I'd like to get it moving toward resolution and don't know who else ought to do a review... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 _

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442338. dodohand added a comment. Addressing comments from @gribozavr2 identifying comments needing update/removal/improvement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files: clang-tools-extra/

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand marked 4 inline comments as done. dodohand added a comment. Addressed comments from gribozavr2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @gribozavr2, I don't have commit access... I'll address the merge issue ASAP though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list cfe-com

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442340. dodohand added a comment. Updated to merge successfully into latest version of main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files: clang-tools-extra/clang-tidy/bugprone/Assignment

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442358. dodohand added a comment. somehow, clang-format needed to be re-run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. @gribozavr2 , have I successfully addressed the points you brought up? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand created this revision. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. dodohand requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. new clang-tidy checker for assignments with the condition cla

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-assignment-in-if-clause.rst:9 +Finds these assignments even within multiple sets of parentheses which is often appropriate to structure multi-part condition statements. +Finds these assign

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AssignmentInIfClauseCheck.cpp:39 + diag(MatchedDecl->getBeginLoc(), + "Assignment detected within if statement. Fix to equality check if this " + "was accidental. Consider moving out of if

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 434610. dodohand added a comment. renamed from misc-assignment-in-if-clause to bugprone-assignment-in-if-condition per review input Adjusted documentation per review input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews