https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/71086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74589
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74596
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74597
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74599
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74604
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/5] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74606
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/5] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74618
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/74619
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/5] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/74589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/71086
None
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++
(#677
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70505
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/5] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/71086
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/5] Revert "[clang] Support fixed point types in C++
(#67750)"
zahiraam wrote:
> Just follow allow with the reassociate pragma.
What does that mean?
https://github.com/llvm/llvm-project/pull/68267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
LGTM.
https://github.com/llvm/llvm-project/pull/68267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam approved this pull request.
https://github.com/llvm/llvm-project/pull/68267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/76854
None
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++
(#677
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/76854
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/76856
None
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++
(#677
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/76856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/76854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/76859
None
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++
(#677
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/76859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/68820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/67592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/76862
and generate a warning.
>From 55ee9ac2d36c1485573aa5e291e5867e8f1d5099 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 3 Jan 2024 12:41:44 -0800
Subject: [PATCH] Check for comparisons to INF and NaN when
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/76862
>From 55ee9ac2d36c1485573aa5e291e5867e8f1d5099 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 3 Jan 2024 12:41:44 -0800
Subject: [PATCH 1/2] Check for comparisons to INF and NaN when in ffast-math
mode
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/76862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/76873
None
>From 7dbaf037b6b2196cee7c0c837e0a89ce3c2556ed Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 3 Jan 2024 14:37:17 -0800
Subject: [PATCH] [CLANG] Add warning when comparing to INF or NAN in fast mat
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam reopened
https://github.com/llvm/llvm-project/pull/67592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/76873
>From 7dbaf037b6b2196cee7c0c837e0a89ce3c2556ed Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 3 Jan 2024 14:37:17 -0800
Subject: [PATCH 1/2] [CLANG] Add warning when comparing to INF or NAN in fast
math
@@ -2267,6 +2273,16 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl,
unsigned BuiltinID,
case Builtin::BI__builtin_signbit:
case Builtin::BI__builtin_signbitf:
case Builtin::BI__builtin_signbitl:
+FPO = TheCall->getFPFeaturesInEffect(getLangOpts());
---
@@ -13846,6 +13880,37 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
@@ -13846,6 +13880,37 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
@@ -13044,9 +13044,12 @@ static QualType checkArithmeticOrEnumeralCompare(Sema
&S, ExprResult &LHS,
if (Type->isAnyComplexType() && BinaryOperator::isRelationalOp(Opc))
return S.InvalidOperands(Loc, LHS, RHS);
- // Check for comparisons of floating point operands using
zahiraam wrote:
> Expanding the scope a bit, it would also be useful to have warnings for
> constant NaN or Inf values passed as arguments or used in binary operations.
Added that.
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits maili
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6771,6 +6771,9 @@ def warn_pointer_sub_null_ptr : Warning<
def warn_floatingpoint_eq : Warning<
"comparing floating point with == or != is unsafe">,
InGroup>, DefaultIgnore;
+def warn_fast_floatingpoint_eq : Warning<
+ "explicit comparison with %0 when the program is a
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6771,6 +6771,9 @@ def warn_pointer_sub_null_ptr : Warning<
def warn_floatingpoint_eq : Warning<
"comparing floating point with == or != is unsafe">,
InGroup>, DefaultIgnore;
+def warn_fast_floatingpoint_eq : Warning<
+ "explicit comparison with %0 when the program is a
Author: Zahira Ammarguellat
Date: 2022-04-05T04:58:19-07:00
New Revision: 4d165ad7d9b3395a59c287ef60542b4de3a4d95a
URL:
https://github.com/llvm/llvm-project/commit/4d165ad7d9b3395a59c287ef60542b4de3a4d95a
DIFF:
https://github.com/llvm/llvm-project/commit/4d165ad7d9b3395a59c287ef60542b4de3a4d95a
Author: Zahira Ammarguellat
Date: 2022-03-10T13:19:53-08:00
New Revision: 15ef06f453c6f9513b476e80dd9567d01fc662e8
URL:
https://github.com/llvm/llvm-project/commit/15ef06f453c6f9513b476e80dd9567d01fc662e8
DIFF:
https://github.com/llvm/llvm-project/commit/15ef06f453c6f9513b476e80dd9567d01fc662e8
Author: Zahira Ammarguellat
Date: 2022-03-17T11:48:03-07:00
New Revision: bbf0d1932a3c1be970ed8a580e51edf571b80fd5
URL:
https://github.com/llvm/llvm-project/commit/bbf0d1932a3c1be970ed8a580e51edf571b80fd5
DIFF:
https://github.com/llvm/llvm-project/commit/bbf0d1932a3c1be970ed8a580e51edf571b80fd5
Author: Zahira Ammarguellat
Date: 2022-03-23T04:54:00-07:00
New Revision: b0bc93da926a943cdc2d8b04f8dcbe23a774520c
URL:
https://github.com/llvm/llvm-project/commit/b0bc93da926a943cdc2d8b04f8dcbe23a774520c
DIFF:
https://github.com/llvm/llvm-project/commit/b0bc93da926a943cdc2d8b04f8dcbe23a774520c
Author: Zahira Ammarguellat
Date: 2022-02-15T13:59:27-08:00
New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335
URL:
https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335
DIFF:
https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335
Author: Zahira Ammarguellat
Date: 2022-02-17T08:59:21-08:00
New Revision: 32b73bc6ab8234b670c34d5ef999300e072cc706
URL:
https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706
DIFF:
https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706
Author: Zahira Ammarguellat
Date: 2022-02-17T10:59:54-08:00
New Revision: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4
URL:
https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4
DIFF:
https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/6] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/7] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/8] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
---
@@ -1046,30 +1046,35 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range : Joined<["-"],
@@ -794,8 +834,10 @@ ComplexPairTy ComplexExprEmitter::EmitBinMul(const
BinOpInfo &Op) {
ResR = Builder.CreateFSub(AC, BD, "mul_r");
ResI = Builder.CreateFAdd(AD, BC, "mul_i");
- if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Limited ||
- Op.
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2824,26 +2816,89 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
switch (optID) {
default:
break;
-case options::OPT_fcx_limited_range: {
- EmitComplexRangeDiag(D, Range,
LangOptions::ComplexRangeKind::CX_Limited);
-
@@ -986,13 +1028,17 @@ ComplexPairTy ComplexExprEmitter::EmitBinDiv(const
BinOpInfo &Op) {
llvm::Value *OrigLHSi = LHSi;
if (!LHSi)
LHSi = llvm::Constant::getNullValue(RHSi->getType());
-if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Fortran)
+Qua
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo &Op);
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo &Op);
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
@@ -2824,26 +2816,89 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
switch (optID) {
default:
break;
-case options::OPT_fcx_limited_range: {
- EmitComplexRangeDiag(D, Range,
LangOptions::ComplexRangeKind::CX_Limited);
-
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo &Op);
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
@@ -855,7 +868,17 @@ void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) {
Out << Proto << " -> ";
Proto.clear();
}
- AFT->getReturnType().print(Out, Policy, Proto);
+ if (!Policy.SuppressTagKeyword && Policy.SuppressScope &&
+ !Policy.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/9] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
---
zahiraam wrote:
I have uploaded your patch and compared the attributes generated from your
patch and the little test case from
https://github.com/llvm/llvm-project/issues/62098. The attributes generated
are different. Therefore, the expected optimizations from this patch are going
to be diff
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 01/10] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
-
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 01/10] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
-
zahiraam wrote:
Thank you all for the reviews.
https://github.com/llvm/llvm-project/pull/84014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/84014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/86339
None
>From ab7d280abf053b67b716e0723e2e70876e639810 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 22 Mar 2024 13:55:44 -0700
Subject: [PATCH] Fix printing of templated records.
---
clang/lib/A
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/86339
>From ab7d280abf053b67b716e0723e2e70876e639810 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 22 Mar 2024 13:55:44 -0700
Subject: [PATCH 1/2] Fix printing of templated records.
---
clang/lib/AST
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2303,11 +2303,6 @@ printTo(raw_ostream &OS, ArrayRef Args, const
PrintingPolicy &Policy,
} else {
if (!FirstArg)
OS << Comma;
- if (!Policy.SuppressTagKeyword &&
- Argument.getKind() == TemplateArgument::Type &&
- isa(Argument.getAs
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@AaronBallman Thanks!
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/86661
None
>From 5ef0aca43c2eefbb9967b98c70a58a29a9407e97 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 26 Mar 2024 06:53:31 -0700
Subject: [PATCH] Fix failure in buildbot, builds/25788.
---
clang/l
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
I have a PR ready for it.
https://github.com/llvm/llvm-project/pull/86690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> I'm getting errors like:
>
> ```
> llvm-project/clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error:
> expression result unused [-Werror,-Wunused-value]
> [](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; };
> ```
>
> This file being a clang test, I am wonde
zahiraam wrote:
Creating a PR with
`[](PrintingPolicy [[maybe_unused]] & Policy) {
Policy.SuppressTagKeyword = true;
};`
on those tests.
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
zahiraam wrote:
oh! I think I know what the issue is. I have a fix for it. PR following up.
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
1 - 100 of 711 matches
Mail list logo
