[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: I am OK with fixing this particular guarantee with a test. However, I am not familiar with libc++ testset organization and I need to be guided. Could you, please, provide me with some clues to start wtih? https://github.com/llvm/llvm-project/pull/80443

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: @ldionne, do you find @arichardson reasoning good enough to proceed with merging this PR? https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: @ldionne, gentle ping https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

https://github.com/georgthegreat created https://github.com/llvm/llvm-project/pull/80443 We store libunwind code inside monorepo and would like to reduce the overall amount of `-I` flags. >From 3e8bbe318ebbd498a7457afee2192c47650b6dad Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Fri,

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: We have pretty large codebase and we use custom command-graph based build system (consider bazel as a well-known example of such buld system). The system uses module as a basic unit, modules might depend one each other, dependencies might affect dependant modules (but not

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: I understand the _this will definitely break in the future without proper testing_, but libunwind does not experience frequent changes, so this might be a working soluiton even without explicit testing. https://github.com/llvm/llvm-project/pull/80443 __

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

georgthegreat wrote: @ldionne, gentle ping https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

https://github.com/georgthegreat closed https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

georgthegreat wrote: I applied @ldionne suggestions, I am fine with his approach. https://github.com/llvm/llvm-project/pull/125412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

georgthegreat wrote: @MaskRay, we build libunwind using our own build system with the clang default set of warnings enabled. There is already a couple of `[[maybe_unused]]` attributes in this library, so I do not bring anything new: ``` (dflt) thegeorg@jakku:~/contrib/llvm/libunwind@main$ rg u

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

https://github.com/georgthegreat created https://github.com/llvm/llvm-project/pull/125412 None >From f3f30cca500f839a2e6647ea9acf0cea45a4e178 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Sun, 2 Feb 2025 14:35:53 +0100 Subject: [PATCH] Silence -Wunused-parameter warnings in Unwind-wasm

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

https://github.com/georgthegreat updated https://github.com/llvm/llvm-project/pull/125412 >From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Sun, 2 Feb 2025 14:35:53 +0100 Subject: [PATCH] Silence -Wunused-parameter warnings in Unwind-wasm.c --

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

https://github.com/georgthegreat updated https://github.com/llvm/llvm-project/pull/125412 >From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Sun, 2 Feb 2025 14:35:53 +0100 Subject: [PATCH 1/3] Silence -Wunused-parameter warnings in Unwind-wasm.c

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

https://github.com/georgthegreat updated https://github.com/llvm/llvm-project/pull/125412 >From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Sun, 2 Feb 2025 14:35:53 +0100 Subject: [PATCH 1/3] Silence -Wunused-parameter warnings in Unwind-wasm.c

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

georgthegreat wrote: @ldionne, may we proceed with merging this? https://github.com/llvm/llvm-project/pull/125412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

georgthegreat wrote: I think this is how my clang-format-16 auto-formatted it. I have applied the formatting from the check, it is green now. https://github.com/llvm/llvm-project/pull/125412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https