[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + rogfer01

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b62f19f27d4: [Driver][RISCV] Add missing rv64 test case (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; Nit: V-spec prefers to call instructions without masking operands "unmasked instru

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; eopXD wrote: > Nit: V-spec prefers to call instructions without masking operands "u

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD updated this revision to Diff 411014. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD added a comment. Friendly ping @VincentWu ;) Any comments to the latest response? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added a comment. ping again, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400098. eopXD marked 8 inline comments as done. eopXD added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187 +def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen", "ExtZvl::Zvl64b", + "'Zvl' (Minimum Vector Length) 64", + [FeatureStdExtZvl32b

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400111. eopXD added a comment. Rebase to latest main. Resolve test case conflicts due to Zvamo removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/l

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400238. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/ris

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26bb1b1dab8b: [RISCV] Add the zvl extension according to the v1.0 spec (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked 7 inline comments as done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked an inline comment as not done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__ris

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added a comment. We can land non-macro related code for zve first and continue on proceeding patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 ___

[PATCH] D112408: [RISCV][MC] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v_max_eew_fp", Twine(MaxEewFp));

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 393174. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Suppor

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 393181. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clan

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 393185. eopXD added a comment. Rebase now since the preceeding patches are accepted. This patch is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Fil

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe308b8e0c71b: [RISCV] Fix arch string parsing for multi-character extensions (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4bf1b449dc0: [RISCV] Unify depedency check and extension implication parsing logics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782 +if (IsZvlExt) { + ExtName.consume_back("b"); + unsigned ZvlLen; craig.topper wrote: > craig.topper wrote: > > I think we should check the return value from consume_back

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394119. eopXD marked 8 inline comments as done. eopXD added a comment. Rebase and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Ba

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134 "maximum!"); + assert(RVVVectorBitsMin >= ZvlLen && + "Minimum V extension vector length should be at least the length " eopXD wrote: > eopXD wrote: > > craig

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394454. eopXD marked 3 inline comments as done. eopXD added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/B

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:230 +// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s +// CHECK-V-MINVLEN: __riscv_v_min_vlen 128 frasercrmck wrote: > Are we able to test non-default values of `__riscv

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394471. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/ris

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394739. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/B

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added a comment. Ping, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 396505. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:741-751 +{{"zvl1024b"}, {ImpliedExtsZvl1024b}}, +{{"zvl128b"}, {ImpliedExtsZvl128b}}, +{{"zvl16384b"}, {ImpliedExtsZvl16384b}}, +{{"zvl2048b"}, {ImpliedExtsZvl2048b}}, +{{"zvl256b"}, {I

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD created this revision. eopXD added reviewers: kito.cheng, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0-rc1 spec

eopXD updated this revision to Diff 381737. eopXD added a comment. Herald added subscribers: cfe-commits, achieveartificialintelligence, jdoerfert. Herald added a project: clang. Address comments and add macro in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 381738. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test case fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381742. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381744. eopXD added a comment. Minor update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RIS

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381745. eopXD added a comment. Remove debug code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGe

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 381747. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381866. eopXD added a comment. Update clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/Code

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381873. eopXD edited the summary of this revision. eopXD added a comment. Since parsing logic is unified, code of RISCVAsmParser can be reduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://r

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:268 +// omitted from the version string. E.g., rv32i2p0, rv32i2, rv32i2p1. +static Error getExtensionVersion(StringRef MArch, StringRef Ext, StringRef In, + unsigned &Major,

<    1   2