https://github.com/JOE1994 approved this pull request.
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JOE1994 wrote:
https://buildkite.com/llvm-project/github-pull-requests/builds/12872#018ba3cf-2050-4af1-b46a-55b5482323fc
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/JOE1994 requested changes to this pull request.
Please update existing uses in `polly`, and rebase onto latest `main`.
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
Author: Youngsuk Kim
Date: 2023-11-06T10:19:48-06:00
New Revision: 34ee69b4ce66280ccc65acc1799a5863de2f2aa6
URL:
https://github.com/llvm/llvm-project/commit/34ee69b4ce66280ccc65acc1799a5863de2f2aa6
DIFF:
https://github.com/llvm/llvm-project/commit/34ee69b4ce66280ccc65acc1799a5863de2f2aa6.diff
Author: Youngsuk Kim
Date: 2023-11-06T19:41:32-06:00
New Revision: 0936a718492d248a726b8e8d4529e4aa194bc8e9
URL:
https://github.com/llvm/llvm-project/commit/0936a718492d248a726b8e8d4529e4aa194bc8e9
DIFF:
https://github.com/llvm/llvm-project/commit/0936a718492d248a726b8e8d4529e4aa194bc8e9.diff
https://github.com/JOE1994 approved this pull request.
Thank you
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2023-11-07T11:21:35-06:00
New Revision: 45ca24edc0b9f2541efb0ae3c668ee7af82e22f4
URL:
https://github.com/llvm/llvm-project/commit/45ca24edc0b9f2541efb0ae3c668ee7af82e22f4
DIFF:
https://github.com/llvm/llvm-project/commit/45ca24edc0b9f2541efb0ae3c668ee7af82e22f4.diff
@@ -1123,9 +1123,7 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (!CurFnInfo->getReturnInfo().getIndirectByVal()) {
ReturnValuePointer =
CreateDefaultAlignTempAlloca(Int8PtrTy, "result.ptr");
- Builder.CreateStore(Builder.Cre
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH 1/4] [clang] Replace uses of
CreatePointerBitCastOrAddrSpaceCast (N
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/68277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/72072
Remove bitcast added back in dcd74716f9d18 .
>From b9db2565d3d2d251bde7cd84b704861d5b41bd14 Mon Sep 17 00:00:00 2001
From: JOE1994
Date: Sun, 12 Nov 2023 20:04:44 -0500
Subject: [PATCH] [clang][CGExprScalar] Rem
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/72072
>From b9db2565d3d2d251bde7cd84b704861d5b41bd14 Mon Sep 17 00:00:00 2001
From: JOE1994
Date: Sun, 12 Nov 2023 20:04:44 -0500
Subject: [PATCH 1/2] [clang][CGExprScalar] Remove no-op ptr-to-ptr bitcast
(NFC)
Remov
@@ -2227,14 +2227,6 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
llvm::Value *V = CE->changesVolatileQualification()
? EmitLoadOfLValue(CE)
: Visit(const_cast(E));
-if (V) {
- // CK_NoOp can model a po
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/72072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2023-11-18T04:17:46-06:00
New Revision: b4db24e33008660d11d703c19d8affaf5f9a843e
URL:
https://github.com/llvm/llvm-project/commit/b4db24e33008660d11d703c19d8affaf5f9a843e
DIFF:
https://github.com/llvm/llvm-project/commit/b4db24e33008660d11d703c19d8affaf5f9a843e.diff
Author: Youngsuk Kim
Date: 2023-11-18T14:06:45-06:00
New Revision: a540808de254b18b304aa0915638a0900b36d9fa
URL:
https://github.com/llvm/llvm-project/commit/a540808de254b18b304aa0915638a0900b36d9fa
DIFF:
https://github.com/llvm/llvm-project/commit/a540808de254b18b304aa0915638a0900b36d9fa.diff
Author: Youngsuk Kim
Date: 2023-11-18T17:03:48-06:00
New Revision: b08960f1e96d64874486354c16b4116c5f8f
URL:
https://github.com/llvm/llvm-project/commit/b08960f1e96d64874486354c16b4116c5f8f
DIFF:
https://github.com/llvm/llvm-project/commit/b08960f1e96d64874486354c16b4116c5f8f.diff
Author: Youngsuk Kim
Date: 2023-11-18T17:46:08-06:00
New Revision: 695662b00c993dc33f7196c6d156c967a0aad6af
URL:
https://github.com/llvm/llvm-project/commit/695662b00c993dc33f7196c6d156c967a0aad6af
DIFF:
https://github.com/llvm/llvm-project/commit/695662b00c993dc33f7196c6d156c967a0aad6af.diff
Author: Youngsuk Kim
Date: 2023-11-20T16:21:21-06:00
New Revision: ed73121ffeb636e75162f116bfeca56e7ec310de
URL:
https://github.com/llvm/llvm-project/commit/ed73121ffeb636e75162f116bfeca56e7ec310de
DIFF:
https://github.com/llvm/llvm-project/commit/ed73121ffeb636e75162f116bfeca56e7ec310de.diff
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/73020
Opaque ptr cleanup effort
>From 30cff5f1f27e047247ae126bb4b2d1c6103f7022 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 21 Nov 2023 11:16:23 -0600
Subject: [PATCH] [clang][CodeGen] Remove ptr-to-ptr bitc
Author: Youngsuk Kim
Date: 2023-10-27T14:59:42-05:00
New Revision: 5c159222627e2201bee73c401be3b76f995b2336
URL:
https://github.com/llvm/llvm-project/commit/5c159222627e2201bee73c401be3b76f995b2336
DIFF:
https://github.com/llvm/llvm-project/commit/5c159222627e2201bee73c401be3b76f995b2336.diff
Author: Youngsuk Kim
Date: 2023-10-30T16:51:55-05:00
New Revision: c1183399a8205f83a418f20889776589b3b98d53
URL:
https://github.com/llvm/llvm-project/commit/c1183399a8205f83a418f20889776589b3b98d53
DIFF:
https://github.com/llvm/llvm-project/commit/c1183399a8205f83a418f20889776589b3b98d53.diff
Author: Youngsuk Kim
Date: 2023-11-01T09:06:15-05:00
New Revision: bc44e6e7c64ae7abd885fc31a62e37f649e307be
URL:
https://github.com/llvm/llvm-project/commit/bc44e6e7c64ae7abd885fc31a62e37f649e307be
DIFF:
https://github.com/llvm/llvm-project/commit/bc44e6e7c64ae7abd885fc31a62e37f649e307be.diff
Author: Youngsuk Kim
Date: 2023-11-01T15:01:55-05:00
New Revision: 09f1aaca0bdc260c29043188aa2f63bcbe07f02f
URL:
https://github.com/llvm/llvm-project/commit/09f1aaca0bdc260c29043188aa2f63bcbe07f02f
DIFF:
https://github.com/llvm/llvm-project/commit/09f1aaca0bdc260c29043188aa2f63bcbe07f02f.diff
JOE1994 wrote:
I have a similar concern with @arsenm about making the default address space 0.
Can't we just use the already existing `PointerType::getUnqual()`, instead of
introducing the default address space 0?
https://github.com/llvm/llvm-project/pull/71029
_
Author: Youngsuk Kim
Date: 2023-11-02T12:43:26-05:00
New Revision: 5532d67a360e99f6b60d311d64e94a5a32d5d141
URL:
https://github.com/llvm/llvm-project/commit/5532d67a360e99f6b60d311d64e94a5a32d5d141
DIFF:
https://github.com/llvm/llvm-project/commit/5532d67a360e99f6b60d311d64e94a5a32d5d141.diff
Author: Youngsuk Kim
Date: 2023-11-02T17:50:46-05:00
New Revision: 14f2025671f82192d38e1db9bc185790e1221cd3
URL:
https://github.com/llvm/llvm-project/commit/14f2025671f82192d38e1db9bc185790e1221cd3
DIFF:
https://github.com/llvm/llvm-project/commit/14f2025671f82192d38e1db9bc185790e1221cd3.diff
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1514,7 +1514,7 @@ static void CreateGCRelocates(ArrayRef
LiveVariables,
auto getGCRelocateDecl = [&](Type *Ty) {
assert(isHandledGCPointerType(Ty, GC));
auto AS = Ty->getScalarType()->getPointerAddressSpace();
-Type *NewTy = Type::getInt8PtrTy(M->getContext()
Author: Youngsuk Kim
Date: 2023-11-03T17:05:44-05:00
New Revision: fc55068c0969fa83d894d46e14d4fdec05a30b2c
URL:
https://github.com/llvm/llvm-project/commit/fc55068c0969fa83d894d46e14d4fdec05a30b2c
DIFF:
https://github.com/llvm/llvm-project/commit/fc55068c0969fa83d894d46e14d4fdec05a30b2c.diff
Author: Youngsuk Kim
Date: 2023-11-04T19:17:21-05:00
New Revision: 9e90027d618687f3d744e21ad3eda5735a167503
URL:
https://github.com/llvm/llvm-project/commit/9e90027d618687f3d744e21ad3eda5735a167503
DIFF:
https://github.com/llvm/llvm-project/commit/9e90027d618687f3d744e21ad3eda5735a167503.diff
Author: Youngsuk Kim
Date: 2023-11-04T19:59:39-05:00
New Revision: 730d313041f73760aacc3fa3b12b5b5b0c92a12c
URL:
https://github.com/llvm/llvm-project/commit/730d313041f73760aacc3fa3b12b5b5b0c92a12c
DIFF:
https://github.com/llvm/llvm-project/commit/730d313041f73760aacc3fa3b12b5b5b0c92a12c.diff
Author: Youngsuk Kim
Date: 2023-11-05T10:17:45-06:00
New Revision: b26b1cee2e6b0b730fda87dbd4a236810d424129
URL:
https://github.com/llvm/llvm-project/commit/b26b1cee2e6b0b730fda87dbd4a236810d424129
DIFF:
https://github.com/llvm/llvm-project/commit/b26b1cee2e6b0b730fda87dbd4a236810d424129.diff
JOE1994 wrote:
This revision seems related to the following buildbot failure:
* https://lab.llvm.org/buildbot/#/builders/268/builds/1747
(+ builds 1748 & 1749)
Would you mind taking a look? Thank you 👍
https://github.com/llvm/llvm-project/pull/69949
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/75668
Unify 3 `Pointertype *` members which all refer to the same llvm type.
Opaque pointer clean-up effort.
>From 2f07997d202a8e845e866d0dedbfbcded0bf9518 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Fri, 15 De
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/75668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2023-11-23T09:17:01-06:00
New Revision: d8c40800edc5995c5ff765c4e2940ea001589fa0
URL:
https://github.com/llvm/llvm-project/commit/d8c40800edc5995c5ff765c4e2940ea001589fa0
DIFF:
https://github.com/llvm/llvm-project/commit/d8c40800edc5995c5ff765c4e2940ea001589fa0.diff
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/73020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JOE1994 wrote:
FYI, the following `clang` tests seem to fail after revision
[fe5c360](https://github.com/llvm/llvm-project/commit/fe5c360a9aae61db37886c0c795c409b5129905f)
```
Failed Tests (2):
Clang :: CodeGen/aapcs-align.cpp
Clang :: CodeGen/aapcs64-align.cpp
```
https://github.com/llvm/l
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/73374
Multiple calls to `PointerType::getUnqual(C)`, and calls to
`Type::getPointerTo(AddrSpace=0)` on them all result in the same type.
Clean them up to re-use the same `PtrTy` variable within function
`createRegist
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/73374
>From cd36ba2c52f14051cbe82efc6390a036f75d2b46 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Thu, 23 Nov 2023 10:54:07 -0600
Subject: [PATCH 1/2] [clang-linker-wrapper] Re-use type returned from
'PointerType
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/73374
>From cd36ba2c52f14051cbe82efc6390a036f75d2b46 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Thu, 23 Nov 2023 10:54:07 -0600
Subject: [PATCH 1/3] [clang-linker-wrapper] Re-use type returned from
'PointerType
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/73374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2023-11-25T11:28:18-06:00
New Revision: bc6b632723f8a025c7daa78c82f7d2ad1962a4e9
URL:
https://github.com/llvm/llvm-project/commit/bc6b632723f8a025c7daa78c82f7d2ad1962a4e9
DIFF:
https://github.com/llvm/llvm-project/commit/bc6b632723f8a025c7daa78c82f7d2ad1962a4e9.diff
Author: Youngsuk Kim
Date: 2023-11-29T14:59:27-06:00
New Revision: 328fd363daabb464670613dece6c75cf99d03410
URL:
https://github.com/llvm/llvm-project/commit/328fd363daabb464670613dece6c75cf99d03410
DIFF:
https://github.com/llvm/llvm-project/commit/328fd363daabb464670613dece6c75cf99d03410.diff
Author: Youngsuk Kim
Date: 2023-11-30T14:00:31-06:00
New Revision: ff485a0e77a55847cb50768b01c04fe45a6879ea
URL:
https://github.com/llvm/llvm-project/commit/ff485a0e77a55847cb50768b01c04fe45a6879ea
DIFF:
https://github.com/llvm/llvm-project/commit/ff485a0e77a55847cb50768b01c04fe45a6879ea.diff
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/74179
Remove ptr-to-ptr bitcast which was added back in
939352b6ec31db4e8defe07856868438fbc5340d . With opaque pointers, the bitcast is
now redundant.
Opaque ptr cleanup effort.
>From 56eb182b28277cc6160e6916d98a02b
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/74179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/74279
Merge consecutive AddrSpaceCasts into a single AddrSpaceCast.
>From 4e86272d980b26bf1240df94cbc894e7ded0d018 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Sun, 3 Dec 2023 23:52:33 -0600
Subject: [PATCH] [cla
JOE1994 wrote:
I've been using `git clang-format` without the `--bin` flag using the following
setting
1. `PATH=$PATH:~/llvm-project/build/bin:~/llvm-project/clang/tools/clang-format`
2. Run `git clang-format HEAD~1` at `~/llvm-project` directory
After this revision, I get the following error:
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/74279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/87348
Fixes #41447
>From 90834d7250d18c9389c84966279365638dce80a9 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 2 Apr 2024 08:17:36 -0500
Subject: [PATCH] [Clang][Sema] Warn unused cxx var declared in condit
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/83741
Emit a warning if pointer/reference to compound literal is returned from a
function.
In C, compound literals in block scope are lvalues that have automatic storage
duration. In C++, compound literals in block s
JOE1994 wrote:
> Isn't this warning a duplicate of what is already here?
The diganostic warning is not emitted when `clang` is run without the
`-analyze` flag.
https://github.com/llvm/llvm-project/pull/83741
___
cfe-commits mailing list
cfe-commits@l
JOE1994 wrote:
> @JOE1994 Thoughts on this?
I'm not an ideal reviewer for this as I'm unfamiliar with ObjC side of Clang,
but I'll come back to leave a review and to help merge this if this doesn't get
merged by the end of the day :)
https://github.com/llvm/llvm-project/pull/81335
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/83741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/81335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/81335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2023-10-25T10:36:52-05:00
New Revision: 8e00d59dce23f841586260092bddde8a4a26d75f
URL:
https://github.com/llvm/llvm-project/commit/8e00d59dce23f841586260092bddde8a4a26d75f
DIFF:
https://github.com/llvm/llvm-project/commit/8e00d59dce23f841586260092bddde8a4a26d75f.diff
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/68277
With opaque pointers, CreatePointerBitCastOrAddrSpaceCast is same as
CreateAddrSpaceCast. Replace or remove uses of
CreatePointerBitCastOrAddrSpaceCast.
Opaque pointer cleanup effort.
>From 1299c48eb032aa7543f
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
-if (Val->getType() != Wrapper->getReturnType())
- Val = Builder
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast
(NFC)
JOE1994 wrote:
Applied git clang-format.
https://github.com/llvm/llvm-project/pull/68277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JOE1994 wrote:
No new regressions with `ninja check-clang`
https://github.com/llvm/llvm-project/pull/68277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2138,6 +2138,8 @@ class IRBuilderBase {
return Insert(CastInst::CreatePointerCast(V, DestTy), Name);
}
+ // With opaque pointers enabled, this is same as CreateAddressSpaceCast.
JOE1994 wrote:
> If the types (= address spaces) are the same,
> Crea
@@ -2138,6 +2138,8 @@ class IRBuilderBase {
return Insert(CastInst::CreatePointerCast(V, DestTy), Name);
}
+ // With opaque pointers enabled, this is same as CreateAddressSpaceCast.
JOE1994 wrote:
```suggestion
// With opaque pointers enabled, this c
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
-if (Val->getType() != Wrapper->getReturnType())
- Val = Builder
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH 1/2] [clang] Replace uses of
CreatePointerBitCastOrAddrSpaceCast (N
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH 1/3] [clang] Replace uses of
CreatePointerBitCastOrAddrSpaceCast (N
Author: Youngsuk Kim
Date: 2024-06-30T10:02:49-05:00
New Revision: ac84ada9a169a72ad136ef05c2c194f594f24a37
URL:
https://github.com/llvm/llvm-project/commit/ac84ada9a169a72ad136ef05c2c194f594f24a37
DIFF:
https://github.com/llvm/llvm-project/commit/ac84ada9a169a72ad136ef05c2c194f594f24a37.diff
Author: Youngsuk Kim
Date: 2024-07-02T19:52:09-05:00
New Revision: 0856064ea219d029e7d2c4f68bb88196fe647f6b
URL:
https://github.com/llvm/llvm-project/commit/0856064ea219d029e7d2c4f68bb88196fe647f6b
DIFF:
https://github.com/llvm/llvm-project/commit/0856064ea219d029e7d2c4f68bb88196fe647f6b.diff
Author: Youngsuk Kim
Date: 2024-07-04T21:59:19-05:00
New Revision: 9e211744b82a72e08c137f75b1c671713e2891af
URL:
https://github.com/llvm/llvm-project/commit/9e211744b82a72e08c137f75b1c671713e2891af
DIFF:
https://github.com/llvm/llvm-project/commit/9e211744b82a72e08c137f75b1c671713e2891af.diff
Author: Youngsuk Kim
Date: 2024-07-05T06:42:43-05:00
New Revision: ccc0b66d6971b64175b4e99c6d5baaa2830c4208
URL:
https://github.com/llvm/llvm-project/commit/ccc0b66d6971b64175b4e99c6d5baaa2830c4208
DIFF:
https://github.com/llvm/llvm-project/commit/ccc0b66d6971b64175b4e99c6d5baaa2830c4208.diff
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const
CountAttributedType *T) {
Expr *CountExpr = importChecked(Err, T->getCountExpr());
SmallVector CoupledDecls;
- for (auto TI : T->dependent_decls()) {
+ for (const TypeCoupledDeclRefInfo &TI : T->depen
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/87348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2024-04-04T20:49:45-05:00
New Revision: 66190af7350df7edb03f7ebb8ac11065bb07e22c
URL:
https://github.com/llvm/llvm-project/commit/66190af7350df7edb03f7ebb8ac11065bb07e22c
DIFF:
https://github.com/llvm/llvm-project/commit/66190af7350df7edb03f7ebb8ac11065bb07e22c.diff
JOE1994 wrote:
Why did you close this PR so soon after creating it?
https://github.com/llvm/llvm-project/pull/94883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/93394
>From 00c93043fca8f8a1f20634ea1b281c60926bd571 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Sat, 25 May 2024 20:42:43 -0500
Subject: [PATCH 1/5] [clang][Sema] Don't emit 'declared here' note for builtin
fun
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/93394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 approved this pull request.
https://github.com/llvm/llvm-project/pull/93878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/93878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 approved this pull request.
https://github.com/llvm/llvm-project/pull/91874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 requested changes to this pull request.
The 3 updated items seem to be iterators and not pointers.
I think [the coding standard
item](https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto)
doesn't apply here.
https://github.com/llvm/llvm-pro
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/99417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2024-07-16T10:06:08-05:00
New Revision: 1cd6359f39ab7fa55f00086c322bc183adb583bc
URL:
https://github.com/llvm/llvm-project/commit/1cd6359f39ab7fa55f00086c322bc183adb583bc
DIFF:
https://github.com/llvm/llvm-project/commit/1cd6359f39ab7fa55f00086c322bc183adb583bc.diff
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const
CountAttributedType *T) {
Expr *CountExpr = importChecked(Err, T->getCountExpr());
SmallVector CoupledDecls;
- for (auto TI : T->dependent_decls()) {
+ for (const TypeCoupledDeclRefInfo &TI : T->depen
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/97902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/99417
Method 'backupStr' extracts common code of manually allocating memory with
ASTContext to hold a copy of a string's contents.
>From a2c89a383b340c1da61c6c32790f4cd03976c3a0 Mon Sep 17 00:00:00 2001
From: Youngsuk
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/99417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/90625
First round of Sema checks were run at initial parsing step. Creating a new
BinaryOperator instance (with the re-built LHS or RHS) will trigger another
round of Sema checks, which can lead to duplicate diagnosti
JOE1994 wrote:
`clang-format` issues an error for the comments from a previous commit wrote by
a different author.
I'd like to disregard the clang-format errror, so to keep the diff of this
commit minimial.
https://github.com/llvm/llvm-project/pull/90625
___
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/98699
Fix locations where dangling StringRefs are created.
* `ConstraintSatisfaction::SubstitutionDiagnostic`: typedef of
`std::pair`
* `concepts::Requirement::SubstitutionDiagnostic`: struct whose 1st and 3rd
data
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/98699
>From 07648c7efab15786c36dbcd265015d945b627725 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Fri, 12 Jul 2024 17:40:59 -0500
Subject: [PATCH 1/2] [clang] Prevent dangling StringRefs
Fix locations where dangl
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/90625
>From 3b2f810ff3798ef073a8d1a10ca6fbafdbdb4641 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 30 Apr 2024 11:18:15 -0500
Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible
First ro
JOE1994 wrote:
Buildkite passed on Linux x64 but failed on Windows x64 .
Test log doesn't show any test failures except for `XFAIL` runs, so I'm not
sure what's causing the failure.
Will rebase onto latest `main` to try the build again.
https://github.com/llvm/llvm-project/pull/90625
___
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/90625
>From 0a1598d0e00cbbfd0320ea72491500957ddb6b52 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 30 Apr 2024 11:18:15 -0500
Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible
First ro
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/90625
>From 0a1598d0e00cbbfd0320ea72491500957ddb6b52 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 30 Apr 2024 11:18:15 -0500
Subject: [PATCH 1/2] [clang][Sema] Re-use existing BinaryOperator if possible
Firs
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/90625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Youngsuk Kim
Date: 2024-05-03T05:18:27-05:00
New Revision: 1efc1918502bd8c9cf2431af38d754878eac071a
URL:
https://github.com/llvm/llvm-project/commit/1efc1918502bd8c9cf2431af38d754878eac071a
DIFF:
https://github.com/llvm/llvm-project/commit/1efc1918502bd8c9cf2431af38d754878eac071a.diff
Author: Youngsuk Kim
Date: 2024-05-03T05:45:17-05:00
New Revision: 2933ef2da9103122a52066a1c680046d1bdacaed
URL:
https://github.com/llvm/llvm-project/commit/2933ef2da9103122a52066a1c680046d1bdacaed
DIFF:
https://github.com/llvm/llvm-project/commit/2933ef2da9103122a52066a1c680046d1bdacaed.diff
1 - 100 of 165 matches
Mail list logo
