[PATCH] D153724: [clang] Fix a crash on invalid destructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76d72a715038: [clang] Fix a crash on invalid destructor (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D147909: [clang] Implement CWG 2397

zyounan created this revision. Herald added a project: All. zyounan added a comment. zyounan added reviewers: aaron.ballman, erichkeane, rsmith. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note GCC had implemented such feature

[PATCH] D147909: [clang] Implement CWG 2397

zyounan updated this revision to Diff 512656. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909 Files: clang/docs/Releas

[PATCH] D147909: [clang] Implement CWG 2397

zyounan added a comment. Thank you for the suggestion and I've updated my patch. :) Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/cwg2397.cpp:11 +} + +void g() { aaron.ballman wrote: > I think it'd be good to also show a constexpr test, like: > ```

[PATCH] D147909: [clang] Implement CWG 2397

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9826433f31c: [clang] Implement CWG 2397 (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 513979. zyounan added a comment. zyounan updated this revision to Diff 514019. zyounan updated this revision to Diff 514028. zyounan added reviewers: nridg

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch alleviates ht

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Before F27754400: before.png After F27754403: after.png (Sorry for posting screenshots directly and bringing any inconvenience for email users.) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } `PrintCanonicalTypes` turns on printing default template arguments,

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. In D143319#4115186 , @kadircet wrote: > thanks a lot for the patch! > > we're migrating IWYU related functionality in clangd to make use of > include-cleaner library nowadays. so can you actually move the IWYU > no_include pragm

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496875. zyounan added a comment. Revise symbols from N4100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/unittests/CanonicalInclud

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Sorry for the late update, I'm rebasing my branch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 ___ cfe-commits mailing list cfe

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496934. zyounan added a comment. Rebase to main && Move tests to clang/Tooling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/Tooling/Inclusions/S

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > can you strip clang-format pragmas to be similar to other

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496963. zyounan marked 4 inline comments as done. zyounan added a comment. Revise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/Tooling/Inclusion

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:1 +// These symbols are exported from N4100[fs.filesystem.synopsis], the final +// draft for experimental filesystem. Note that not all of these symbols were kadirce

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > zyounan wrote: > > kadircet wrote: > > > can you strip cl

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Thank you for your detailed explanation and sorry again for my dumb mistake before. :) Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, )

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) zyounan wrote: > kadircet wrote: > > zyounan wrote: > > > kadircet wrote: >

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496971. zyounan added a comment. Apply clang-format to StandardLibrary.cpp to fix pipeline failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/

[PATCH] D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4021ed3d79d: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: kadircet, nridge. zyounan added a comment. zyounan retitled this revision from "[clangd] Hide extra inlay hints for macro as argument" to "[clangd] Hide inlay hints wh

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 499417. zyounan added a comment. Move parsing logic to Record.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520555. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you for the opinions. I've updated and please take a look. Comment at: clang-tools-extra/clangd/Hover.cpp:705 + + // If macro expands to one single token, rule out punctuator or digraph. + // E.g., for the case `array L_BRACKET 42 R_BRACKET;` wh

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520638. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D148457: [clangd] Support macro evaluation on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG7385cc389aba: [clangd] Support macro evaluation on hover (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.ll

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Sorry for chiming in. Left a few nit comments and I hope you don't mind. :) Comment at: clang-tools-extra/clangd/InlayHints.cpp:772 + Label = printName(AST, D); +} else { + // We handle type and namespace decls together. Q

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Thank you for the update. A few questions: - Can you add a test with macro expansion? Would we get two inlay hints right after the spelling location? e.g., #define Decl_Record \ struct Widget { \ [very long definition that reach `EndDefinitionCommentMinLine

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 517865. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittes

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Sorry for responding late and thank you for the good catch! I've updated the code and please feel free to leave comments. :) Comment at: clang-tools-extra/clangd/Hover.cpp:728 } + SelectionTree::createEach( + AST.getASTContext(), AST.getTokens(

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Oops, an inline comment disappears accidentally. > #define PLUS_TWO + 2 > int x = 40 PLUS_TW^O; // huh, the value of "+ 2" is "42"? The reason is we're getting a `SelectionNode` with a wider range. Here is the layout of the tree: txt Built selection tree Tr

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Haha. My bad for misunderstanding. > I think rather if the common ancestor isn't completely selected, evaluation > shouldn't happen. I don't think it is a feasible approach to simply opt out of partial selection. Please consider this snippet: #define SizeOf sizeof

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518144. zyounan added a comment. Refactor tests. Obtain type from VarDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518277. zyounan added a comment. Do not evaluate on partial selection with children. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you very much for the ideas. > (generalization) allow partial selection as long as it's of a single node - > the common ancestor is partially selected and no children are This strategy looks reasonable to me and it passes my test cases. I've updated my patch agai

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3901 +case 1: + EXPECT_TRUE(HI->Type); + EXPECT_FALSE(HI->Value); Oops, this should be FALSE I think. Repository: rG LLVM Github

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518280. zyounan added a comment. Exclude the macro expands to single punctulator token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/cla

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } nridge wrote: > zyounan wrote: > > `PrintCanonicalTypes` turns on p

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. (This pa

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan updated this revision to Diff 530201. zyounan marked 7 inline comments as done. zyounan added a comment. Address many comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files: clang-tools-

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Thank you very much for the insightful review! Regarding to your suggestion, > We have an existing heuristic here, should we move the logic into > maybeDesugar() so it's all in one place? once we merge these two functions, the overloaded `addTypeHint` without a Printin

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530850. zyounan marked an inline comment as done. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files: clang-tools-extra/cla

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530851. zyounan added a comment. Oops. Remove extra debugging statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files: clang-tools-extra/clangd/InlayHints.c

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d68f2ef411e: [clangd] Desugar template parameter aliases in type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan updated this revision to Diff 530867. zyounan added a comment. Rebase onto D151785 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152520/new/ https://reviews.llvm.org/D152520 Files: clang-tools-extra/cl

[PATCH] D152520: [clangd] Unify printing policy for type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cdb906f1e40: [clangd] Unify printing policy for type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan added a comment. In D151785#4417973 , @kstoimenov wrote: > Looks like this might have broken a couple of sanitizer builds. Here is one > of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you > please revert or fix? > Than

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

zyounan created this revision. Herald added a project: All. zyounan added reviewers: aaron.ballman, lh123. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. `desugarForDiagnostic` only sets ShouldAKA to true if desugaring happens, ot

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e08374abb2c: [clang][NFC] Add a notice to desugarForDiagnostic (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new/ https://rev

<    1   2