[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG27e2ff964fc3: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace… (authored by yaron.keren). H

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren added reviewers: Orlando, probinson, tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Three tests fail when building and testing LLVM from the Visual C++ environment since

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren added a comment. looking into Linux failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366515. yaron.keren added a comment. Support both Windows llvm-lit.py and Linux llvm-lit command name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: cla

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108218 Files: clang/test/utils/update_cc_test_checks/lit.local.cfg Index: c

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren abandoned this revision. yaron.keren added a comment. opened by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108218/new/ https://reviews.llvm.org/D108218 ___ cfe-commits mailing list

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366941. yaron.keren added a comment. Switched to Linux repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: clang/test/utils/update_cc_test_checks/lit.lo

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa0f9cc9ab2: Use installed llvm-lit.py instead of lit.py PR-51072 (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ http

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; Result is unused now. Comment

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; vsapsai wrote: > yaron.keren wrote: > > Result is

[PATCH] D27810: Normalize all filenames before searching FileManager caches

yaron.keren added inline comments. Comment at: lib/Basic/FileManager.cpp:218 +#ifdef LLVM_ON_WIN32 + SmallString<128> NormalizedPath(Filename.str()); + llvm::sys::path::native(NormalizedPath); I'd use a larger SmallString<256>, with large projects 128 bytes are

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

yaron.keren added a comment. While at it, llvm.org/pr30994 Repository: rL LLVM https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31187: Fix removal of out-of-line definitions.

yaron.keren added a comment. Could use dumpDeclContext() to test? https://reviews.llvm.org/D31187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren created this revision. Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp. Repository: rL LLVM ht

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

yaron.keren added inline comments. Comment at: cmake/modules/HandleLLVMOptions.cmake:562 add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG) +else() + append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) note this is an else to if (LLVM_ENABLE_WARNINGS

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren added a comment. Thanks, I'll make a test. Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren updated this revision to Diff 94961. yaron.keren added a comment. Added attribute test. https://reviews.llvm.org/D31540 Files: tools/clang/include/clang/AST/DeclBase.h tools/clang/lib/AST/Decl.cpp tools/clang/lib/AST/DeclBase.cpp tools/clang/test/SemaTemplate/friend-template

[PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added reviewers: mati865, rnk. yaron.keren added a comment. Adding Mateusz and Reid. Repository: rL LLVM https://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren reopened this revision. yaron.keren added a comment. reverted in r300497 Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

yaron.keren added a comment. In https://reviews.llvm.org/D28399#642458, @v.g.vassilev wrote: > @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function > declarations. My current patch focuses on friend class templates. Perhaps we > should open another review item for a fix

[PATCH] D28620: Guard __gnuc_va_list typedef

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM, matches the code in libstdc++ stdarg,h. You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef. https://reviews.llvm.or

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. This code is actually used with Windows as well as Linux (with the exception of line 218), see the comment blocks above for detailed include dirs from all platforms from which it was derived. Please make sure include dirs between gcc and clang match after the patch

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. Hiding these two include dirs removes many headers. Most has clang equivalents but not all of them. For example quadmath.h is only there, and without the include path programs using it will fail to compile. The reason mingw limits.h isn't used in your example is tha

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. The gcc include dirs in mingw contains headers not available esewhere and thus can't be removed. Notable examples, omp.h - OpenMP functions openacc.h - OpenACC functions quadmath.h - QUADMATH functions https://reviews.llvm.org/D29464 __

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. What about omp.h and openacc.h ? many programs are using OpenMP. You raised real issues which should certainly be solved with clang mingw support. Removing the gcc dirs from include path will break any program that currently uses or depends in any way on any header

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. These directories are "mostly" equivalent, with some headers existing is mings gcc dir but missing in clang resource dir and thus will break compilation. For example, the most popular (37089 download this week) https://sourceforge.net/projects/mingw-w64 distribuion f

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. If something is broken now we don't break it even more. __float128 remain be fixed to be compatible, not only some poor developer would have to fix the missing headers bug one day, he will have to re-fix limits.h the right way and undo this "fix". There is a problems

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. OK. https://reviews.llvm.org/D29464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

yaron.keren added inline comments. Comment at: lib/AST/ASTContext.cpp:8258 return RHS; -return isa(LHS) ? getReadPipeType(ResultType) - : getWritePipeType(ResultType); +const PipeType *PT = LHS->getAs(); +return PT->isReadOnly()

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM after fixing the inline comment Comment at: lib/Serialization/ASTReader.cpp:5804 QualType ElementType = readType(*Loc.F, Record, Idx); -return Context

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. Please move the =new out of the PP.AddPragmaHandler calls. While at it, this code still (as the original) leaks the PragmaHandlers. These should be deleted after RemovePragmaHandler or instead, simply use std::unique_ptr. https://reviews.llvm.org/D32486

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. Raphael , do you have commit access? should I commit this? https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. OK https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren created this revision. yaron.keren added a reviewer: tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109000 Files: clang/test/utils/update

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren marked an inline comment as done. yaron.keren added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.l

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren added a comment. Addressing comment in https://reviews.llvm.org/D108085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000 ___ cfe-commits mailing list

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG10d78a06baa2: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.