[clang] 381fcaa - [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

Author: Volodymyr Sapsai Date: 2022-07-21T17:42:04-07:00 New Revision: 381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2 URL: https://github.com/llvm/llvm-project/commit/381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2 DIFF: https://github.com/llvm/llvm-project/commit/381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2.di

[clang] 1e4478b - Move "clang/Basic/TokenKinds.h" into a separate top-level module.

Author: Volodymyr Sapsai Date: 2022-07-22T16:26:27-07:00 New Revision: 1e4478bbea727dbbffb1023eedfc24eae7185782 URL: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782 DIFF: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782.di

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

vsapsai wrote: To clarify a little bit > [...] The "already included" state is global across all modules (which is > necessary so that non-modular headers don't get compiled into multiple > translation units and cause redeclaration errors). The necessity isn't actually true. The same definitio

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

https://github.com/vsapsai edited https://github.com/llvm/llvm-project/pull/84127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

@@ -2498,9 +2498,12 @@ void ModuleMapParser::parseHeaderDecl(MMToken::TokenKind LeadingToken, } bool NeedsFramework = false; - // Don't add the top level headers to the builtin modules if the builtin headers - // belong to the system modules. - if (!Map.LangOpts.Built

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

https://github.com/vsapsai commented: Still kinda confused. Have a few questions trying to improve my understanding. https://github.com/llvm/llvm-project/pull/84127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

@@ -7,6 +7,11 @@ *===---=== */ -#ifndef offsetof +/* + * When -fbuiltin-headers-in-system-modules is set this is a non-modular header + * and needs to behave as if it was textual. + */ +#if !defined(offsetof

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

@@ -7,6 +7,11 @@ *===---=== */ -#ifndef offsetof +/* + * When -fbuiltin-headers-in-system-modules is set this is a non-modular header + * and needs to behave as if it was textual. + */ +#if !defined(offsetof

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

vsapsai wrote: > Sometimes it does confuse clang, at least I saw problems with a `typedef > enum` when I made an include-once header `textual`. Ok, I see. I would just consider it a bug, not a design decision. > That's correct. `#import` is an external source - often it comes from the > users

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

vsapsai wrote: I'm not excited by the complexity we are moving toward with the builtin headers. But I don't have any alternatives. Given the situation we are in, I think the change is ok. But I'd like someone else to look at it as it is tricky to reason about it. No blockers from me but want

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -2006,6 +2021,11 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, if (auto MaybeModule = MM.getCachedModuleLoad(*Path[0].first)) { // Use the cached result, which may be nullptr. Module = *MaybeModule; +// Config macros are already checked before build

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -1,3 +1,39 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -std=c99 -fmodules -fimplicit-module-maps -x objective-c -fmodules-cache-path=%t -DWANT_FOO=1 -emit-module -fmodule-name=config %t/module.modulemap +// RUN: %clang_cc1 -std=c99 -fmodules -fimplicit

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

https://github.com/vsapsai edited https://github.com/llvm/llvm-project/pull/83641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

https://github.com/vsapsai approved this pull request. https://github.com/llvm/llvm-project/pull/83641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -2006,6 +2021,11 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, if (auto MaybeModule = MM.getCachedModuleLoad(*Path[0].first)) { // Use the cached result, which may be nullptr. Module = *MaybeModule; +// Config macros are already checked before build

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

vsapsai wrote: So far the testing shows there are no regressions. https://github.com/llvm/llvm-project/pull/76119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

https://github.com/vsapsai edited https://github.com/llvm/llvm-project/pull/76119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

https://github.com/vsapsai approved this pull request. Overall, the change works fine and it is pretty small. Have a few minor suggestion for the test but nothing blocking. https://github.com/llvm/llvm-project/pull/76119 ___ cfe-commits mailing list c

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

@@ -1458,7 +1458,7 @@ bool HeaderSearch::ShouldEnterIncludeFile(Preprocessor &PP, } else { // Otherwise, if this is a #include of a file that was previously #import'd // or if this is the second #include of a #pragma once file, ignore it. vsapsai wro

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

@@ -1458,7 +1458,7 @@ bool HeaderSearch::ShouldEnterIncludeFile(Preprocessor &PP, } else { // Otherwise, if this is a #include of a file that was previously #import'd // or if this is the second #include of a #pragma once file, ignore it. -if ((FileInfo.isPragmaO

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

@@ -0,0 +1,20 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t +// +// RUN: %clang_cc1 -std=c++20 %t/foo.cpp -I%t -fsyntax-only -verify + +//--- i.h +#ifndef FOO_H vsapsai wrote: The mismatch between i.h and FOO_H is slightly annoying but don'

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

@@ -0,0 +1,20 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t +// +// RUN: %clang_cc1 -std=c++20 %t/foo.cpp -I%t -fsyntax-only -verify vsapsai wrote: You don't really need `-I%t`, the test works without it. But don't have a strong opinion.

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

@@ -0,0 +1,20 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t +// +// RUN: %clang_cc1 -std=c++20 %t/foo.cpp -I%t -fsyntax-only -verify + +//--- i.h +#ifndef FOO_H +#pragma once +struct S{}; +#endif + +//--- foo.cpp vsapsai wrote: Personally I

[clang] [Modules] [HeaderSearch] Don't reenter headers if it is pragma once (PR #76119)

vsapsai wrote: Started some of the tests. Expect to have results by the end of this week or early next week. https://github.com/llvm/llvm-project/pull/76119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

r370130 - [ObjC] Fix type checking for qualified id block parameters.

Author: vsapsai Date: Tue Aug 27 17:25:06 2019 New Revision: 370130 URL: http://llvm.org/viewvc/llvm-project?rev=370130&view=rev Log: [ObjC] Fix type checking for qualified id block parameters. When checking if block types are compatible, we are checking for compatibility their return types and p

r370274 - [Modules] Fix rebuilding an updated module for each of its consumers.

Author: vsapsai Date: Wed Aug 28 16:31:32 2019 New Revision: 370274 URL: http://llvm.org/viewvc/llvm-project?rev=370274&view=rev Log: [Modules] Fix rebuilding an updated module for each of its consumers. Marking a module for a rebuild when its signature differs from the expected one causes redund

r370400 - Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.

Author: vsapsai Date: Thu Aug 29 12:51:25 2019 New Revision: 370400 URL: http://llvm.org/viewvc/llvm-project?rev=370400&view=rev Log: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC. Modified: cfe/trunk/include/clang/Basic/FileManager.h cfe/trunk/lib/Basic/FileMana

r311474 - Test commit access.

Author: vsapsai Date: Tue Aug 22 10:39:25 2017 New Revision: 311474 URL: http://llvm.org/viewvc/llvm-project?rev=311474&view=rev Log: Test commit access. Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h URL: http://llvm.

r311480 - [Parser] Correct initalizer typos before lambda capture type is deduced.

Author: vsapsai Date: Tue Aug 22 10:55:19 2017 New Revision: 311480 URL: http://llvm.org/viewvc/llvm-project?rev=311480&view=rev Log: [Parser] Correct initalizer typos before lambda capture type is deduced. This is the same assertion as in https://reviews.llvm.org/D25206 that is triggered when Re

[clang] c4bacc3 - [Modules] Add stats to measure performance of building and loading modules.

Author: Volodymyr Sapsai Date: 2020-09-24T12:23:47-07:00 New Revision: c4bacc3c9b333bb7032fb96f41d6f5b851623132 URL: https://github.com/llvm/llvm-project/commit/c4bacc3c9b333bb7032fb96f41d6f5b851623132 DIFF: https://github.com/llvm/llvm-project/commit/c4bacc3c9b333bb7032fb96f41d6f5b851623132.di

[clang] 9eba6b2 - Revert "[Modules] Add stats to measure performance of building and loading modules."

Author: Volodymyr Sapsai Date: 2020-09-24T12:36:06-07:00 New Revision: 9eba6b20a0579d3441e1b0f3cb3942f86d32679f URL: https://github.com/llvm/llvm-project/commit/9eba6b20a0579d3441e1b0f3cb3942f86d32679f DIFF: https://github.com/llvm/llvm-project/commit/9eba6b20a0579d3441e1b0f3cb3942f86d32679f.di

[clang] 7ac737e - [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

Author: Volodymyr Sapsai Date: 2020-08-20T17:41:28-07:00 New Revision: 7ac737e56bee721fb3535006140362c6e08726bb URL: https://github.com/llvm/llvm-project/commit/7ac737e56bee721fb3535006140362c6e08726bb DIFF: https://github.com/llvm/llvm-project/commit/7ac737e56bee721fb3535006140362c6e08726bb.di

[clang] 8839e27 - [Modules] Improve error message when cannot find parent module for submodule definition.

Author: Volodymyr Sapsai Date: 2020-08-25T16:31:27-07:00 New Revision: 8839e278ffcadc62b333423de07756488cae980f URL: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f DIFF: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f.di

[clang] 4000c9e - Reland "[Modules] Add stats to measure performance of building and loading modules."

Author: Volodymyr Sapsai Date: 2020-10-19T15:44:11-07:00 New Revision: 4000c9ee18ecebe3ff0f197af8c1fb434ad986e5 URL: https://github.com/llvm/llvm-project/commit/4000c9ee18ecebe3ff0f197af8c1fb434ad986e5 DIFF: https://github.com/llvm/llvm-project/commit/4000c9ee18ecebe3ff0f197af8c1fb434ad986e5.di

[clang] 34ccc3e - [hmaptool] Fix `NameError: global name 'num_buckets' is not defined` in `action_dump`.

Author: Volodymyr Sapsai Date: 2020-10-19T16:27:13-07:00 New Revision: 34ccc3e13bccde6f5cf993c744efe4bcb1fd439a URL: https://github.com/llvm/llvm-project/commit/34ccc3e13bccde6f5cf993c744efe4bcb1fd439a DIFF: https://github.com/llvm/llvm-project/commit/34ccc3e13bccde6f5cf993c744efe4bcb1fd439a.di

[clang] a28678e - Revert "Reland "[Modules] Add stats to measure performance of building and loading modules.""

Author: Volodymyr Sapsai Date: 2020-10-19T18:27:30-07:00 New Revision: a28678e20a112f8851fda2550e415924420bdcd5 URL: https://github.com/llvm/llvm-project/commit/a28678e20a112f8851fda2550e415924420bdcd5 DIFF: https://github.com/llvm/llvm-project/commit/a28678e20a112f8851fda2550e415924420bdcd5.di

[clang] 722c514 - [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

Author: Volodymyr Sapsai Date: 2021-06-17T17:29:12-07:00 New Revision: 722c51473c7a3bfe13d929734615a3b46d44c09a URL: https://github.com/llvm/llvm-project/commit/722c51473c7a3bfe13d929734615a3b46d44c09a DIFF: https://github.com/llvm/llvm-project/commit/722c51473c7a3bfe13d929734615a3b46d44c09a.di

[clang] 3220855 - [Modules] Do not remove failed modules after the control block phase

Author: Ben Barham Date: 2021-08-17T16:46:51-07:00 New Revision: 32208555af26c48f3df845a10b049c8eb74e2eb3 URL: https://github.com/llvm/llvm-project/commit/32208555af26c48f3df845a10b049c8eb74e2eb3 DIFF: https://github.com/llvm/llvm-project/commit/32208555af26c48f3df845a10b049c8eb74e2eb3.diff LO

[clang] 0a35cc4 - [clang][objc] Speed up populating the global method pool from modules.

Author: Volodymyr Sapsai Date: 2021-11-03T17:11:14-07:00 New Revision: 0a35cc40b881a35c6a7a748f5fdefac4cafc33ce URL: https://github.com/llvm/llvm-project/commit/0a35cc40b881a35c6a7a748f5fdefac4cafc33ce DIFF: https://github.com/llvm/llvm-project/commit/0a35cc40b881a35c6a7a748f5fdefac4cafc33ce.di

[clang] 7ad693a - [modules] Update visibility for merged ObjCProtocolDecl definitions.

Author: Volodymyr Sapsai Date: 2021-11-08T13:54:00-08:00 New Revision: 7ad693a322c1b6765f5d06559c2bd73cc3938aaf URL: https://github.com/llvm/llvm-project/commit/7ad693a322c1b6765f5d06559c2bd73cc3938aaf DIFF: https://github.com/llvm/llvm-project/commit/7ad693a322c1b6765f5d06559c2bd73cc3938aaf.di

[clang] e12f6c2 - [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

Author: Volodymyr Sapsai Date: 2022-09-20T17:55:37-07:00 New Revision: e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de URL: https://github.com/llvm/llvm-project/commit/e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de DIFF: https://github.com/llvm/llvm-project/commit/e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de.di

[clang] a6ebd30 - [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

Author: Volodymyr Sapsai Date: 2022-10-12T11:10:08-07:00 New Revision: a6ebd3083dbf8aadae58f6f2a2f1071976649d56 URL: https://github.com/llvm/llvm-project/commit/a6ebd3083dbf8aadae58f6f2a2f1071976649d56 DIFF: https://github.com/llvm/llvm-project/commit/a6ebd3083dbf8aadae58f6f2a2f1071976649d56.di

[clang] 1783253 - [Attributes] Improve writing `ExprArgument` value.

Author: Volodymyr Sapsai Date: 2022-10-14T11:20:57-07:00 New Revision: 1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 URL: https://github.com/llvm/llvm-project/commit/1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 DIFF: https://github.com/llvm/llvm-project/commit/1783253c41f1b0ac378ab7fa4b6fe5547369c6b0.di

[clang] 9c79eab - [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-10-17T16:29:52-07:00 New Revision: 9c79eab7fdd5e2bc413e9c4510f759716cd09184 URL: https://github.com/llvm/llvm-project/commit/9c79eab7fdd5e2bc413e9c4510f759716cd09184 DIFF: https://github.com/llvm/llvm-project/commit/9c79eab7fdd5e2bc413e9c4510f759716cd09184.di

[clang] 37fdca2 - [ODRHash] Rename `isDeclToBeProcessed` to `isSubDeclToBeProcessed`. NFC intended.

Author: Volodymyr Sapsai Date: 2022-10-17T18:24:44-07:00 New Revision: 37fdca21f7f61dee5426f55b0ee7bf601d95afcd URL: https://github.com/llvm/llvm-project/commit/37fdca21f7f61dee5426f55b0ee7bf601d95afcd DIFF: https://github.com/llvm/llvm-project/commit/37fdca21f7f61dee5426f55b0ee7bf601d95afcd.di

[clang] 2662009 - [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-10-17T18:48:24-07:00 New Revision: 2662009c87f470ec5bc13c237cd62c57b28e4032 URL: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032 DIFF: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032.di

[clang] dcb71b5 - [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-11-17T17:22:03-08:00 New Revision: dcb71b5e1d1311c41f409c8dab26e04b084875be URL: https://github.com/llvm/llvm-project/commit/dcb71b5e1d1311c41f409c8dab26e04b084875be DIFF: https://github.com/llvm/llvm-project/commit/dcb71b5e1d1311c41f409c8dab26e04b084875be.di

[clang] a65d530 - [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

Author: Volodymyr Sapsai Date: 2022-11-17T18:31:32-08:00 New Revision: a65d5309d5b73527efcbdec49a3ba9bba0fd873d URL: https://github.com/llvm/llvm-project/commit/a65d5309d5b73527efcbdec49a3ba9bba0fd873d DIFF: https://github.com/llvm/llvm-project/commit/a65d5309d5b73527efcbdec49a3ba9bba0fd873d.di

[clang] 574a77a - [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

Author: Volodymyr Sapsai Date: 2023-01-17T15:33:36-06:00 New Revision: 574a77ae85451adc5e2dd9e73652c62bf18eed8d URL: https://github.com/llvm/llvm-project/commit/574a77ae85451adc5e2dd9e73652c62bf18eed8d DIFF: https://github.com/llvm/llvm-project/commit/574a77ae85451adc5e2dd9e73652c62bf18eed8d.di

[clang] 304d730 - [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

Author: Volodymyr Sapsai Date: 2023-01-18T16:15:53-06:00 New Revision: 304d7307aee15b6eb88d198ae94b595f4e09f485 URL: https://github.com/llvm/llvm-project/commit/304d7307aee15b6eb88d198ae94b595f4e09f485 DIFF: https://github.com/llvm/llvm-project/commit/304d7307aee15b6eb88d198ae94b595f4e09f485.di

[clang] 160bc16 - [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2023-01-19T15:57:48-06:00 New Revision: 160bc160b9b114069a8cb9b4cc887aa86e5ca7c4 URL: https://github.com/llvm/llvm-project/commit/160bc160b9b114069a8cb9b4cc887aa86e5ca7c4 DIFF: https://github.com/llvm/llvm-project/commit/160bc160b9b114069a8cb9b4cc887aa86e5ca7c4.di

[clang] f33b5b1 - [ODRHash] Detect mismatches in anonymous `RecordDecl`.

Author: Volodymyr Sapsai Date: 2023-01-19T15:58:31-06:00 New Revision: f33b5b1bf703ee5ff73126fefe2a9bcbd54db457 URL: https://github.com/llvm/llvm-project/commit/f33b5b1bf703ee5ff73126fefe2a9bcbd54db457 DIFF: https://github.com/llvm/llvm-project/commit/f33b5b1bf703ee5ff73126fefe2a9bcbd54db457.di

[clang] 6ba4afb - [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2023-01-20T10:18:18-06:00 New Revision: 6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0 URL: https://github.com/llvm/llvm-project/commit/6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0 DIFF: https://github.com/llvm/llvm-project/commit/6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0.di

[clang] ed7a46a - [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

Author: Volodymyr Sapsai Date: 2023-01-20T10:18:18-06:00 New Revision: ed7a46a8de77087447936965044e2faf734102e5 URL: https://github.com/llvm/llvm-project/commit/ed7a46a8de77087447936965044e2faf734102e5 DIFF: https://github.com/llvm/llvm-project/commit/ed7a46a8de77087447936965044e2faf734102e5.di

[clang] f3defc2 - [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

Author: Volodymyr Sapsai Date: 2022-05-30T10:07:03-07:00 New Revision: f3defc23488eb29c69d2a33c0c5b652c874fb0f3 URL: https://github.com/llvm/llvm-project/commit/f3defc23488eb29c69d2a33c0c5b652c874fb0f3 DIFF: https://github.com/llvm/llvm-project/commit/f3defc23488eb29c69d2a33c0c5b652c874fb0f3.di

[clang] 97dfaf4 - [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

Author: Volodymyr Sapsai Date: 2023-08-10T10:47:51-07:00 New Revision: 97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d URL: https://github.com/llvm/llvm-project/commit/97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d DIFF: https://github.com/llvm/llvm-project/commit/97dfaf4cd27814bdf9aa9d2eafc21fdb4f76c56d.di

[clang] 91b10f6 - Revert "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-10T11:27:08-07:00 New Revision: 91b10f69740ec91ca80ec45323d9807c39252334 URL: https://github.com/llvm/llvm-project/commit/91b10f69740ec91ca80ec45323d9807c39252334 DIFF: https://github.com/llvm/llvm-project/commit/91b10f69740ec91ca80ec45323d9807c39252334.di

[clang] b070be8 - Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-10T14:52:49-07:00 New Revision: b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b URL: https://github.com/llvm/llvm-project/commit/b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b DIFF: https://github.com/llvm/llvm-project/commit/b070be82bb8fb4414a8a6eb4fbfc77921d89fa4b.di

[clang] fe9c332 - Revert "Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.""

Author: Volodymyr Sapsai Date: 2023-08-10T15:14:26-07:00 New Revision: fe9c332408603e50ab846c1ad8aeb705df2950b1 URL: https://github.com/llvm/llvm-project/commit/fe9c332408603e50ab846c1ad8aeb705df2950b1 DIFF: https://github.com/llvm/llvm-project/commit/fe9c332408603e50ab846c1ad8aeb705df2950b1.di

[clang] 52c62d4 - Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-16T18:27:17-07:00 New Revision: 52c62d46a0c8ebf6023233cabc5beb4ee2687c78 URL: https://github.com/llvm/llvm-project/commit/52c62d46a0c8ebf6023233cabc5beb4ee2687c78 DIFF: https://github.com/llvm/llvm-project/commit/52c62d46a0c8ebf6023233cabc5beb4ee2687c78.di

[clang] 32056aa - [docs] Fix doxygen markers for grouping methods. NFC.

Author: Volodymyr Sapsai Date: 2023-08-03T11:16:42-07:00 New Revision: 32056aa3443786822963e6e469d98deb7b857d79 URL: https://github.com/llvm/llvm-project/commit/32056aa3443786822963e6e469d98deb7b857d79 DIFF: https://github.com/llvm/llvm-project/commit/32056aa3443786822963e6e469d98deb7b857d79.di

[clang] 18530e5 - [ODRHash] Stop hashing `ObjCMethodDecl::isOverriding` as it doesn't capture inherent method quality.

Author: Volodymyr Sapsai Date: 2023-07-05T18:04:32-07:00 New Revision: 18530e5d0770098bc33ff6f02a7b63ea887692a6 URL: https://github.com/llvm/llvm-project/commit/18530e5d0770098bc33ff6f02a7b63ea887692a6 DIFF: https://github.com/llvm/llvm-project/commit/18530e5d0770098bc33ff6f02a7b63ea887692a6.di

[clang] f7e0aae - [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

Author: Volodymyr Sapsai Date: 2023-07-05T18:04:50-07:00 New Revision: f7e0aae7284b7ad0cf3cc277c5ef8731f564443d URL: https://github.com/llvm/llvm-project/commit/f7e0aae7284b7ad0cf3cc277c5ef8731f564443d DIFF: https://github.com/llvm/llvm-project/commit/f7e0aae7284b7ad0cf3cc277c5ef8731f564443d.di

[clang] d1e8df8 - [clang] Fix a typo "mdoule" in comments. NFC.

Author: Volodymyr Sapsai Date: 2023-07-06T17:19:26-07:00 New Revision: d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f URL: https://github.com/llvm/llvm-project/commit/d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f DIFF: https://github.com/llvm/llvm-project/commit/d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f.di

[clang] 0314ba3 - [modules] Fix marking `ObjCMethodDecl::isOverriding` when there are no overrides.

Author: Volodymyr Sapsai Date: 2022-11-24T14:26:02-08:00 New Revision: 0314ba3acbabd8dc6d39b6d49798d22b6dc33802 URL: https://github.com/llvm/llvm-project/commit/0314ba3acbabd8dc6d39b6d49798d22b6dc33802 DIFF: https://github.com/llvm/llvm-project/commit/0314ba3acbabd8dc6d39b6d49798d22b6dc33802.di

[clang] eac90d1 - [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

Author: Volodymyr Sapsai Date: 2022-11-28T13:48:29-08:00 New Revision: eac90d1236cfd2935fac5cbe5634f09e2cd0981a URL: https://github.com/llvm/llvm-project/commit/eac90d1236cfd2935fac5cbe5634f09e2cd0981a DIFF: https://github.com/llvm/llvm-project/commit/eac90d1236cfd2935fac5cbe5634f09e2cd0981a.di

[clang] b4b5469 - [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

Author: Volodymyr Sapsai Date: 2022-12-02T11:59:22-08:00 New Revision: b4b54697b7aacda1fabef36d4e74d5ee45641618 URL: https://github.com/llvm/llvm-project/commit/b4b54697b7aacda1fabef36d4e74d5ee45641618 DIFF: https://github.com/llvm/llvm-project/commit/b4b54697b7aacda1fabef36d4e74d5ee45641618.di

[clang] 642c663 - Reland "[clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas."

Author: Volodymyr Sapsai Date: 2022-12-02T14:30:41-08:00 New Revision: 642c6638a3d78359552f5cf71d24a80a9bd9801f URL: https://github.com/llvm/llvm-project/commit/642c6638a3d78359552f5cf71d24a80a9bd9801f DIFF: https://github.com/llvm/llvm-project/commit/642c6638a3d78359552f5cf71d24a80a9bd9801f.di

[clang] a6c8698 - clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

Author: Volodymyr Sapsai Date: 2020-02-21T13:56:50-08:00 New Revision: a6c8698924d2b31a2f096e0f4c06a7015ecccb5e URL: https://github.com/llvm/llvm-project/commit/a6c8698924d2b31a2f096e0f4c06a7015ecccb5e DIFF: https://github.com/llvm/llvm-project/commit/a6c8698924d2b31a2f096e0f4c06a7015ecccb5e.di

[clang] 4069dd1 - [modules] Allow frameworks to have only a private module without a public one.

Author: Volodymyr Sapsai Date: 2020-02-28T15:40:24-08:00 New Revision: 4069dd14124e9a84b46f48153d4fbc4da811a45e URL: https://github.com/llvm/llvm-project/commit/4069dd14124e9a84b46f48153d4fbc4da811a45e DIFF: https://github.com/llvm/llvm-project/commit/4069dd14124e9a84b46f48153d4fbc4da811a45e.di

[clang] 39573da - Revert "[analyzer] Add test directory for scan-build."

Author: Volodymyr Sapsai Date: 2019-11-05T14:03:36-08:00 New Revision: 39573daa76f23b93bda1437157cf78fb3d1003e2 URL: https://github.com/llvm/llvm-project/commit/39573daa76f23b93bda1437157cf78fb3d1003e2 DIFF: https://github.com/llvm/llvm-project/commit/39573daa76f23b93bda1437157cf78fb3d1003e2.di

[clang] 83f4c3a - [modules] Do not cache invalid state for modules that we attempted to load.

Author: Volodymyr Sapsai Date: 2020-01-16T17:12:41-08:00 New Revision: 83f4c3af021cd5322ea10fd1c4e839874c1dae49 URL: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49 DIFF: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49.di

r328153 - [Modules] Fix creating fake definition data for lambdas.

Author: vsapsai Date: Wed Mar 21 14:28:54 2018 New Revision: 328153 URL: http://llvm.org/viewvc/llvm-project?rev=328153&view=rev Log: [Modules] Fix creating fake definition data for lambdas. During reading C++ definition data for lambda we can access CXXRecordDecl representing lambda before we fi

r328283 - [Modules] Update test to mention it requires C++14.

Author: vsapsai Date: Thu Mar 22 17:16:06 2018 New Revision: 328283 URL: http://llvm.org/viewvc/llvm-project?rev=328283&view=rev Log: [Modules] Update test to mention it requires C++14. Modified: cfe/trunk/test/Modules/self-referencing-lambda.cpp Modified: cfe/trunk/test/Modules/self-referen

r328671 - [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

Author: vsapsai Date: Tue Mar 27 14:29:05 2018 New Revision: 328671 URL: http://llvm.org/viewvc/llvm-project?rev=328671&view=rev Log: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages. rdar://problem/35539384 Reviewers: ahatanak, nicholas, rsmith, jkorous-apple Revie

r328807 - [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

Author: vsapsai Date: Thu Mar 29 10:34:09 2018 New Revision: 328807 URL: http://llvm.org/viewvc/llvm-project?rev=328807&view=rev Log: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots. Deprecation replacement can be any text but if it looks like a name of ObjC method an

[libcxx] r329023 - [libcxx] Disable testing with system lib for 2 tests verifying debug mode.

Author: vsapsai Date: Mon Apr 2 15:09:57 2018 New Revision: 329023 URL: http://llvm.org/viewvc/llvm-project?rev=329023&view=rev Log: [libcxx] Disable testing with system lib for 2 tests verifying debug mode. Modified: libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pa

r329735 - [Parser] Fix assertion-on-invalid for unexpected typename.

Author: vsapsai Date: Tue Apr 10 11:29:47 2018 New Revision: 329735 URL: http://llvm.org/viewvc/llvm-project?rev=329735&view=rev Log: [Parser] Fix assertion-on-invalid for unexpected typename. In `ParseDeclarationSpecifiers` for the code class A typename A; we were able to annotate token `k

r316723 - [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

Author: vsapsai Date: Thu Oct 26 17:56:23 2017 New Revision: 316723 URL: http://llvm.org/viewvc/llvm-project?rev=316723&view=rev Log: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars. Fixes an assertion failure when ivar is a struct containing incomplete array. Also completes support

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

On Nov 1, 2017, at 16:47, Zachary Turner wrote: > > This will remove the ability to use llvm-lit script even if source tree is > available. Can you please point me to the place where llvm-lit is enabled in configure_lit_site_cfg? Asking for my education, to understand lit configuration better

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

On Nov 1, 2017, at 17:22, Zachary Turner wrote: > > > > On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai > wrote: > On Nov 1, 2017, at 16:47, Zachary Turner > wrote: >> >> This will remove the ability to use llvm-lit script even if source t

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

Thanks for explanation, Zachary. We’ve fixed the buildbots in a different way, so I’ll discard this patch. > On Nov 2, 2017, at 16:06, Zachary Turner wrote: > > Yes that is the reason. But in a way it is more than that, because if those > variables aren't available to lit.cfg, then test suite

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

We have llvm source tree next to libcxx and configure libcxx with -DLLVM_PATH. > On Nov 2, 2017, at 16:53, Zachary Turner wrote: > > No problem. If you don't mind me asking, what was the configuration change > you made? Or do you have a link to the patch which fixed it that I can look > at?

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

For now it is gone in the meaning that you don’t have to dedicate time and effort to support this configuration. But I wouldn’t say that taking other dependencies on llvm is welcome. In this aspect nothing has changed. > On Nov 3, 2017, at 15:22, Zachary Turner wrote: > > The reason I ask is b

Re: [PATCH] Ensure std::getline always 0-terminates string.

Thanks for the patch, Reimar. Can you please add tests to ensure this functionality doesn’t regress? As null character is required by the standard (27.7.2.3p21), a good starting point seems to be test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size.pass.cpp

[libcxx] r317734 - [libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx versions.

Author: vsapsai Date: Wed Nov 8 14:30:29 2017 New Revision: 317734 URL: http://llvm.org/viewvc/llvm-project?rev=317734&view=rev Log: [libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx versions. r313500 added a fix for undefined "___cxa_deleted_virtual" symbol. Previo

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 9, 2017, at 12:13, Reimar Döffinger wrote: > > Hello! > > On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote: >> Thanks for the patch, Reimar. Can you please add tests to ensure this >> functionality doesn’t regress? As null character is required by the standard >> (27.7.2

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 12, 2017, at 12:37, Reimar Döffinger wrote: > > On Thu, Nov 09, 2017 at 05:37:32PM -0800, Volodymyr Sapsai wrote: >> On Nov 9, 2017, at 12:13, Reimar Döffinger wrote: >>> >>> Hello! >>> >>> On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote: Thanks for the patch, Reim

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 19, 2017, at 08:07, Reimar Döffinger wrote: > > On Wed, Nov 15, 2017 at 11:35:56AM -0800, Volodymyr Sapsai wrote: >> On Nov 12, 2017, at 12:37, Reimar Döffinger wrote: >> libc++ can be built with exceptions enabled or disabled (see >> LIBCXX_ENABLE_EXCEPTIONS >>

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 20, 2017, at 11:32, Reimar Döffinger wrote: > > On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: >>> catch (...) >>> { >>> +if (__n > 0) >>> +*__s = char_type(); >>> this->__set_badbit_and_consider_rethrow(); >>> } >> >> or maybe so

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 20, 2017, at 16:33, Reimar Döffinger wrote: > > On 20 November 2017 22:19:04 CET, Volodymyr Sapsai > wrote: >> On Nov 20, 2017, at 11:32, Reimar Döffinger >> wrote: >>> >>> On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: >catch (...) >

[clang] a845aeb - [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

Author: Volodymyr Sapsai Date: 2023-03-16T11:57:59-07:00 New Revision: a845aeb5d6c869146fa24194a7d0182a4787cad8 URL: https://github.com/llvm/llvm-project/commit/a845aeb5d6c869146fa24194a7d0182a4787cad8 DIFF: https://github.com/llvm/llvm-project/commit/a845aeb5d6c869146fa24194a7d0182a4787cad8.di

[clang] 2893d55 - [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

Author: Volodymyr Sapsai Date: 2023-02-22T11:01:40-08:00 New Revision: 2893d55f8f61edb2c253b960cab1107ea6c163c2 URL: https://github.com/llvm/llvm-project/commit/2893d55f8f61edb2c253b960cab1107ea6c163c2 DIFF: https://github.com/llvm/llvm-project/commit/2893d55f8f61edb2c253b960cab1107ea6c163c2.di

[clang] e46aa7f - Fix a typo in head comment of `CurPPLexer`.

Author: Zhouyi Zhou Date: 2023-05-02T19:49:21-07:00 New Revision: e46aa7f927293989dae40817c0087cba9cf5fae7 URL: https://github.com/llvm/llvm-project/commit/e46aa7f927293989dae40817c0087cba9cf5fae7 DIFF: https://github.com/llvm/llvm-project/commit/e46aa7f927293989dae40817c0087cba9cf5fae7.diff L

[clang] 24f36a2 - [Modules] Move modulemaps to header search directories. NFC intended.

Author: Volodymyr Sapsai Date: 2023-05-03T13:07:47-07:00 New Revision: 24f36a215b4eabd1d0e4abcce0c9277085d88a96 URL: https://github.com/llvm/llvm-project/commit/24f36a215b4eabd1d0e4abcce0c9277085d88a96 DIFF: https://github.com/llvm/llvm-project/commit/24f36a215b4eabd1d0e4abcce0c9277085d88a96.di

[clang] 2e16df3 - [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

Author: Volodymyr Sapsai Date: 2023-06-09T17:09:28-07:00 New Revision: 2e16df352c7acb910313c80ac90b650ad9c14a3d URL: https://github.com/llvm/llvm-project/commit/2e16df352c7acb910313c80ac90b650ad9c14a3d DIFF: https://github.com/llvm/llvm-project/commit/2e16df352c7acb910313c80ac90b650ad9c14a3d.di

<    1   2   3   4   >