Author: Vlad Serebrennikov
Date: 2023-11-06T14:18:26+03:00
New Revision: b178cec84f95210db615cfa0a84e78585445f16b
URL:
https://github.com/llvm/llvm-project/commit/b178cec84f95210db615cfa0a84e78585445f16b
DIFF:
https://github.com/llvm/llvm-project/commit/b178cec84f95210db615cfa0a84e78585445f16b.
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/71322
>From 40d25b8009f1c8734a99fd1350adaced6884cc7f Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 5 Nov 2023 18:53:48 +0300
Subject: [PATCH 1/5] [clang][NFC] Refacator `CXXNewExpr::InitializationStyle`
@@ -2008,22 +2008,23 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool
UseGlobal,
SourceRange TypeRange = AllocTypeInfo->getTypeLoc().getSourceRange();
SourceLocation StartLoc = Range.getBegin();
- CXXNewExpr::InitializationStyle initStyle;
+ CXXNewInitializationS
@@ -2034,18 +2035,19 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool
UseGlobal,
// - If the new-initializer is omitted, the object is default-
// initialized (8.5); if no initialization is performed,
// the object has indeterminate val
https://github.com/Endilll ready_for_review
https://github.com/llvm/llvm-project/pull/71322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/71322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71395
Reverts llvm/llvm-project#71322
>From 40921a217a4bda5ce739561606a4e16677ee48f5 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 6 Nov 2023 17:53:21 +0400
Subject: [PATCH] Revert "[clang][NFC] Refacto
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/71395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
I've seen those exact test failures locally, but since precommit CI was fine, I
landed this PR and kept a close eye on the bots.
Me and Aaron are also wondering now how did it pass CI, and what's wrong with
changes here.
I'm sorry @zmodem that we got you involved.
> It catches
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71417
This patch converts CXXNewExpr::InitializationStyle into a scoped enum at
namespace scope. It also affirms the status quo by adding a new enumerator to
represent implicit initializer.
This is a re-land of https
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/71417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-11-06T21:02:14+03:00
New Revision: 7ec8a6fd31d8ddb161b06067fb6b7f9026a460df
URL:
https://github.com/llvm/llvm-project/commit/7ec8a6fd31d8ddb161b06067fb6b7f9026a460df
DIFF:
https://github.com/llvm/llvm-project/commit/7ec8a6fd31d8ddb161b06067fb6b7f9026a460df.
Author: Vlad Serebrennikov
Date: 2023-11-06T22:17:03+03:00
New Revision: 60f7fa123d77ecf8e138be35ad8880622586fa03
URL:
https://github.com/llvm/llvm-project/commit/60f7fa123d77ecf8e138be35ad8880622586fa03
DIFF:
https://github.com/llvm/llvm-project/commit/60f7fa123d77ecf8e138be35ad8880622586fa03.
Author: Vlad Serebrennikov
Date: 2023-11-06T22:39:26+03:00
New Revision: 565e21b3e079e53c4fcf47d2ec898dbc248fbd3a
URL:
https://github.com/llvm/llvm-project/commit/565e21b3e079e53c4fcf47d2ec898dbc248fbd3a
DIFF:
https://github.com/llvm/llvm-project/commit/565e21b3e079e53c4fcf47d2ec898dbc248fbd3a.
Author: Vlad Serebrennikov
Date: 2023-11-06T22:55:51+03:00
New Revision: f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed
URL:
https://github.com/llvm/llvm-project/commit/f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed
DIFF:
https://github.com/llvm/llvm-project/commit/f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed.
Author: Vlad Serebrennikov
Date: 2023-11-06T23:08:39+03:00
New Revision: 088932d8ef1f80ba9e1349ce7cda95accd2f745e
URL:
https://github.com/llvm/llvm-project/commit/088932d8ef1f80ba9e1349ce7cda95accd2f745e
DIFF:
https://github.com/llvm/llvm-project/commit/088932d8ef1f80ba9e1349ce7cda95accd2f745e.
Author: Vlad Serebrennikov
Date: 2023-11-06T23:27:13+03:00
New Revision: b6f2597a45f426f3a276c1c59f7ff5521b6dcc89
URL:
https://github.com/llvm/llvm-project/commit/b6f2597a45f426f3a276c1c59f7ff5521b6dcc89
DIFF:
https://github.com/llvm/llvm-project/commit/b6f2597a45f426f3a276c1c59f7ff5521b6dcc89.
Endilll wrote:
> If you see failures locally, it's best to understand where they coming from:
> even if it passes on bots it just means we have a hole in our test coverage.
Sure, but it wasn't the first time I've seen local test failures that doesn't
reproduce anywhere else (`Clang :: LibClang
Author: Vlad Serebrennikov
Date: 2023-11-07T22:24:59+03:00
New Revision: fb8ff4cdaecb7fe498d4e3a9cbcb33d40cccd29a
URL:
https://github.com/llvm/llvm-project/commit/fb8ff4cdaecb7fe498d4e3a9cbcb33d40cccd29a
DIFF:
https://github.com/llvm/llvm-project/commit/fb8ff4cdaecb7fe498d4e3a9cbcb33d40cccd29a.
Author: Vlad Serebrennikov
Date: 2023-11-08T15:44:46+03:00
New Revision: 5e09c4e6a865707ed26f9a893dbef8b499591459
URL:
https://github.com/llvm/llvm-project/commit/5e09c4e6a865707ed26f9a893dbef8b499591459
DIFF:
https://github.com/llvm/llvm-project/commit/5e09c4e6a865707ed26f9a893dbef8b499591459.
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71709
This patch refactors how values are stored inside
`IdentifierInfo::ObjcOrBuiltinID` bit-field, and annotates it with
`preferred_type`. In order to make the value easier to interpret by debuggers,
a new `ObjCKey
Endilll wrote:
@ChuanqiXu9 Can I use some of your help? This PR breaks two module tests:
```
Clang :: Modules/cxx20-hu-04.cpp
Clang :: Modules/cxx20-module-file-info-macros.cpp
```
Apparently I somehow break import or export of header unit macros.
In `cxx20-module-file-info-macros.cpp`, the
@@ -86,19 +87,26 @@ enum { IdentifierInfoAlignment = 8 };
static constexpr int ObjCOrBuiltinIDBits = 16;
/// The "layout" of ObjCOrBuiltinID is:
-/// - The first value (0) represents "not a special identifier".
-/// - The next (NUM_OBJC_KEYWORDS - 1) values represent ObjCKey
Endilll wrote:
> Oh, I didn't look into the identifier's system before. I took a while to look
> at the patch but I failed to understand it and I failed to find the
> relationships between this patch and header units...
Yeah, the part this PR touches in not the most straightforward one. Thank
Author: Vlad Serebrennikov
Date: 2023-12-05T00:42:13+03:00
New Revision: e77bfaaf9d66748fc2dc3a710a0c9b4665dd3034
URL:
https://github.com/llvm/llvm-project/commit/e77bfaaf9d66748fc2dc3a710a0c9b4665dd3034
DIFF:
https://github.com/llvm/llvm-project/commit/e77bfaaf9d66748fc2dc3a710a0c9b4665dd3034.
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/74373
This patch continues the work started with
ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding
PR for details.
>From 1e5ede1925b8cfdae93415abfddb930aaaf3241e Mon Sep 17 00:00:00 2001
Endilll wrote:
This PR is created to check the patch against CI.
https://github.com/llvm/llvm-project/pull/74373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-12-05T17:16:10+03:00
New Revision: 94708fbc0fa06b18c9b263ecb78d20a95a194e7f
URL:
https://github.com/llvm/llvm-project/commit/94708fbc0fa06b18c9b263ecb78d20a95a194e7f
DIFF:
https://github.com/llvm/llvm-project/commit/94708fbc0fa06b18c9b263ecb78d20a95a194e7f.
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/74477
[clang][NFC] Refactor expected directives in C++ DRs 600-699
This patch continues the work started with
https://github.com/llvm/llvm-project/commit/ea5b1ef016d020c37f903d6c7d4f623be975dab8.
See that commit and
Endilll wrote:
This PR is created to check the patch against CI.
https://github.com/llvm/llvm-project/pull/74477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/74477
>From 12cc446ecd55936518cb3e8b13c4840bc008d2c8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 5 Dec 2023 17:14:37 +0300
Subject: [PATCH 1/2] [clang][NFC] Refactor expected directives in C++ DRs
60
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/74477
>From 12cc446ecd55936518cb3e8b13c4840bc008d2c8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 5 Dec 2023 17:14:37 +0300
Subject: [PATCH 1/3] [clang][NFC] Refactor expected directives in C++ DRs
60
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
@AaronBallman After moving the docs, none of the code blocks are rendering:
https://clang.llvm.org/docs/InternalsManual.html#verifying-diagnostics
https://github.com/llvm/llvm-project/pull/73694
___
cfe-commits mailing list
cfe-commits@l
Endilll wrote:
It would also be nice to fix the link to full `-verify` docs in
https://clang.llvm.org/docs/InternalsManual.html#the-diagnosticconsumer-interface
https://github.com/llvm/llvm-project/pull/73694
___
cfe-commits mailing list
cfe-commits@l
@@ -498,3 +498,137 @@
CodeGenTBAA::mergeTBAAInfoForMemoryTransfer(TBAAAccessInfo DestInfo,
// access type regardless of their base types.
return TBAAAccessInfo::getMayAliasInfo();
}
+
+// Determine the aliasing kind bit-converting from type Src to type Dst.
+CodeGenTBAA::A
@@ -37,6 +38,27 @@ class ASTConsumer {
friend class SemaConsumer;
+public:
+ /// Allow type-based aliasing information to be interrogated by the AST
+ /// producer (for diagnostics).
+ class TypeAliasing {
Endilll wrote:
Sorry I didn't make myself clear
@@ -498,3 +498,137 @@
CodeGenTBAA::mergeTBAAInfoForMemoryTransfer(TBAAAccessInfo DestInfo,
// access type regardless of their base types.
return TBAAAccessInfo::getMayAliasInfo();
}
+
+// Determine the aliasing kind bit-converting from type Src to type Dst.
+CodeGenTBAA::A
Author: Vlad Serebrennikov
Date: 2023-12-08T00:38:42+03:00
New Revision: c79f94d85121347d28f894d837f173f90f368e92
URL:
https://github.com/llvm/llvm-project/commit/c79f94d85121347d28f894d837f173f90f368e92
DIFF:
https://github.com/llvm/llvm-project/commit/c79f94d85121347d28f894d837f173f90f368e92.
Endilll wrote:
This PR is created to check the patch against CI.
https://github.com/llvm/llvm-project/pull/74767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-12-09T11:12:54+03:00
New Revision: 57eb2054e308da7fb394375dedf8d7b627d1b528
URL:
https://github.com/llvm/llvm-project/commit/57eb2054e308da7fb394375dedf8d7b627d1b528
DIFF:
https://github.com/llvm/llvm-project/commit/57eb2054e308da7fb394375dedf8d7b627d1b528.
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/74921
This patch continues the work started with
ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding
PR for details.
>From 436502773b1720e0511f4371c7a04079e7d38215 Mon Sep 17 00:00:00 2001
Endilll wrote:
This PR is created to check the patch against CI.
https://github.com/llvm/llvm-project/pull/74921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Yeah, I shouldn't have annotated this bit-field. Nice catch!
https://github.com/llvm/llvm-project/pull/74893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/74893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/71300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fms-compatibility -fms-compatibility-version=19.33
-std=c++20 -verify=supported %s
Endilll wrote:
Judging by the failure
https://lab.llvm.org/buildbot/#/builders/60/builds/15037, you might want to
test for specific triples
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/71300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Some bots are not happy with one of the tests. I contacted you on Discord about
your next steps.
I'll have to revert the patch if I won't hear from you soon.
https://github.com/llvm/llvm-project/pull/71300
___
cf
https://github.com/Endilll approved this pull request.
LGTM, but let's wait for CI to pass.
https://github.com/llvm/llvm-project/pull/74932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/74932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/74935
>From 4e8f48947d59474e07e08cdc98e4a6fb2e3c80c1 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 9 Dec 2023 17:21:35 +0300
Subject: [PATCH 1/2] [llvm][Support] Enable `TimeTraceProfiler` to accept
def
https://github.com/Endilll converted_to_draft
https://github.com/llvm/llvm-project/pull/74935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/71709
>From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 8 Nov 2023 20:30:37 +0300
Subject: [PATCH 1/2] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID`
This
Endilll wrote:
Finally got past previous test failures. But the following tests started to
fail:
```
Clang :: AST/HLSL/pch.hlsl
Clang :: PCH/__va_list_tag-typedef.c
Clang :: PCH/builtin-is-constant-evaluated.cpp
Clang-Unit :: Lex/./LexTests/failed_to_discover_tests_from_gtest
```
Here is
Endilll wrote:
This was fixed by e11148fda6d8c0eec496463adb46fd6f03a91081
I checked the logs, and exactly the part that this commit fixed is failing.
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Endilll wrote:
> https://github.com/amykhuang/llvm-project/tree/attr-plugin
> This branch is [2 commits
> ahead](https://github.com/amykhuang/llvm-project/compare/llvm:llvm-project:main...attr-plugin),
> [1684 commits
> behind](https://github.com/amykhuang/llvm-project/compare/attr-plugin...ll
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/71709
>From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 8 Nov 2023 20:30:37 +0300
Subject: [PATCH 1/3] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID`
This
Endilll wrote:
Aaron suggested to me offline that `IsInterestingIdentifier` that I recently
changed could be implemented in a simpler way retaining the intent. That's what
the latest update about.
https://github.com/llvm/llvm-project/pull/71709
___
c
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s -verify
-fexceptions -fcxx-exceptions -pedantic-errors \
Endilll wrote:
Is triple necessary for the test?
https://github.com/llvm/llvm-project/pull/73103
_
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/73103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
DR test side looks good, except for a small nit.
https://github.com/llvm/llvm-project/pull/73103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/70349
>From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 26 Oct 2023 16:09:25 +0300
Subject: [PATCH 1/4] [clang][NFC] Annotate `Type` bit-fields with
`clang::pr
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/70632
https://github.com/llvm/llvm-project/pull/69104 introduce a diagnostic that
checked underlying type of an enum against type of bit-field that is annotated
with `[[clang::preferred_type]]`. When I tried to introd
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingTy
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingTy
Endilll wrote:
> Why doesn't this result in any changes to tests? I would expect having to
> remove them, right?
There was a single test that was relying on sign mismatch, and then during code
review we made the diagnostic to ignore signness. So it ended up merged without
test case where this
Author: Vlad Serebrennikov
Date: 2023-10-31T18:06:34+03:00
New Revision: 49fd28d9601dde429436655ec74234e895c60b89
URL:
https://github.com/llvm/llvm-project/commit/49fd28d9601dde429436655ec74234e895c60b89
DIFF:
https://github.com/llvm/llvm-project/commit/49fd28d9601dde429436655ec74234e895c60b89.
@@ -49,7 +49,7 @@ struct ExprDependenceScope {
using ExprDependence = ExprDependenceScope::ExprDependence;
struct TypeDependenceScope {
- enum TypeDependence : uint8_t {
+ enum TypeDependence : unsigned {
Endilll wrote:
Yeah, I'm putting this on hold for a
Author: Vlad Serebrennikov
Date: 2023-10-31T18:21:36+03:00
New Revision: f5f4c5b313fc809b9b1b9d600d0ec3cec0d12941
URL:
https://github.com/llvm/llvm-project/commit/f5f4c5b313fc809b9b1b9d600d0ec3cec0d12941
DIFF:
https://github.com/llvm/llvm-project/commit/f5f4c5b313fc809b9b1b9d600d0ec3cec0d12941.
Author: Vlad Serebrennikov
Date: 2023-10-31T20:46:07+03:00
New Revision: 4ad2ada5216ee2bb3c334a3233a9ab51f2521b82
URL:
https://github.com/llvm/llvm-project/commit/4ad2ada5216ee2bb3c334a3233a9ab51f2521b82
DIFF:
https://github.com/llvm/llvm-project/commit/4ad2ada5216ee2bb3c334a3233a9ab51f2521b82.
Author: Vlad Serebrennikov
Date: 2023-10-31T21:50:18+03:00
New Revision: ae7b20b583fab1325d8b51fe5f2eaf612de8b95e
URL:
https://github.com/llvm/llvm-project/commit/ae7b20b583fab1325d8b51fe5f2eaf612de8b95e
DIFF:
https://github.com/llvm/llvm-project/commit/ae7b20b583fab1325d8b51fe5f2eaf612de8b95e.
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/70349
>From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 26 Oct 2023 16:09:25 +0300
Subject: [PATCH 1/4] [clang][NFC] Annotate `Type` bit-fields with
`clang::pr
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/70349
>From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 26 Oct 2023 16:09:25 +0300
Subject: [PATCH 1/5] [clang][NFC] Annotate `Type` bit-fields with
`clang::pr
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/70349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-11-01T11:49:59+03:00
New Revision: b120fe8d3288c4dca1b5427ca34839ce8833f71c
URL:
https://github.com/llvm/llvm-project/commit/b120fe8d3288c4dca1b5427ca34839ce8833f71c
DIFF:
https://github.com/llvm/llvm-project/commit/b120fe8d3288c4dca1b5427ca34839ce8833f71c.
Author: Vlad Serebrennikov
Date: 2023-11-01T12:40:13+03:00
New Revision: 50dec541f328a251c2830421f354e4439e635def
URL:
https://github.com/llvm/llvm-project/commit/50dec541f328a251c2830421f354e4439e635def
DIFF:
https://github.com/llvm/llvm-project/commit/50dec541f328a251c2830421f354e4439e635def.
Author: Vlad Serebrennikov
Date: 2023-11-01T13:40:11+03:00
New Revision: aaba3761db84032541712899964714f3184e8b3d
URL:
https://github.com/llvm/llvm-project/commit/aaba3761db84032541712899964714f3184e8b3d
DIFF:
https://github.com/llvm/llvm-project/commit/aaba3761db84032541712899964714f3184e8b3d.
Author: Vlad Serebrennikov
Date: 2023-11-01T16:44:34+03:00
New Revision: 65761200ce4e1f366e8418652efdafd2f744291b
URL:
https://github.com/llvm/llvm-project/commit/65761200ce4e1f366e8418652efdafd2f744291b
DIFF:
https://github.com/llvm/llvm-project/commit/65761200ce4e1f366e8418652efdafd2f744291b.
Author: Vlad Serebrennikov
Date: 2023-11-01T17:00:55+03:00
New Revision: 008af1c9f4cd0188a69bf42b821749154a8142c8
URL:
https://github.com/llvm/llvm-project/commit/008af1c9f4cd0188a69bf42b821749154a8142c8
DIFF:
https://github.com/llvm/llvm-project/commit/008af1c9f4cd0188a69bf42b821749154a8142c8.
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/70943
This patch moves definition of recently refactored enums closer to the types
where they were originally defined. Since they are scoped enums at namespace
scope now, they can be forward-declared.
Refactorings in
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/70955
During the recent refactoring (b120fe8d3288c4dca1b5427ca34839ce8833f71c) this
enum was moved out of `RecordDecl`. During post-commit review it was found out
that its association with `RecordDecl` should be expre
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/71039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Converting packed `unsigned Kind` into non-packed `SValKind Kind` is definitely
going to help debuggers to display the value correctly.
But I have to point out that this patch doesn't address the fact that `const
void* Data` is not friendly to debuggers, e
@@ -105,38 +86,25 @@ class SVal {
return llvm::dyn_cast(*this);
}
- unsigned getRawKind() const { return Kind; }
- BaseKind getBaseKind() const { return (BaseKind) (Kind & BaseMask); }
- unsigned getSubKind() const { return Kind >> BaseBits; }
+ SValKind getKind() co
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71049
This patch introduces a new enumerator `Invalid = 0`, shifting other
enumerators by +1. Contrary to how it might sound, this actually affirms status
quo of how this enum is stored in `clang::Decl`:
```
/// If
@@ -84,22 +88,33 @@ inline bool isUniqueGVALinkage(GVALinkage L) {
}
inline bool isExternallyVisible(Linkage L) {
- return L >= VisibleNoLinkage;
+ switch (L) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage hasn't been computed!");
Endilll wrote:
@@ -2214,7 +2214,7 @@ void ASTWriter::WriteDeclAbbrevs() {
Abv->Add(BitCodeAbbrevOp(0)); // TSCSpec
Abv->Add(BitCodeAbbrevOp(0)); // InitStyle
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
- Abv->Ad
Endilll wrote:
> I've considered this but I found the number of alternatives too large to make
> it feasible. Consider that we have 11 possible SValKinds, which would require
> 4 bits to encode. Requiring all Data pointers to be aligned as such seems
> rough - although not impossible.
Sorry,
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/71039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/70349
>From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 26 Oct 2023 16:09:25 +0300
Subject: [PATCH 1/6] [clang][NFC] Annotate `Type` bit-fields with
`clang::pr
@@ -1921,7 +1920,20 @@ bool NamedDecl::declarationReplaces(NamedDecl *OldD,
bool IsKnownNewer) const {
}
bool NamedDecl::hasLinkage() const {
- return getFormalLinkage() != NoLinkage;
+ switch (getFormalLinkage()) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage h
@@ -560,7 +562,7 @@ bool CXIndexDataConsumer::handleDecl(const NamedDecl *D,
if (shouldSuppressRefs())
markEntityOccurrenceInFile(D, Loc);
-
+
Endilll wrote:
I guess that's clang-format at work. I'll revert this.
https://github.com/llvm/llvm-project/
1 - 100 of 2087 matches
Mail list logo
