@@ -67,9 +67,11 @@ types specified within an ignorelist.
int a = 2147483647; // INT_MAX
++a;// Normally, an overflow with
-fsanitize=signed-integer-overflow
}
+
vitalybuka wrote:
Yes, I'ts about spaces. Even if it's useful change ju
@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap
memory, and prevents any pot
of ``nonallocating`` by the compiler.
}];
}
+
+def WrapsDocs : Documentation {
+ let Category = DocCatField;
+ let Content = [{
+The ``wraps`` attribute can be used wit
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/115094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Naming wise I prefer `wrap` -> `no_sanitize("undefined")` already exists but
does not apply to variables and types
`no_wrap` -> `sanitize("undefined")` does not exist, and a little confusing
(no_wrap as well). It may look it enabled sanitization.
Would it make sense to suppo
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl(
return CanonTTP;
}
+/// Check if a type can have its sanitizer instrumentation elided.
+/// Determine this by its presence in a SCL alongside its specified categories.
+/// For example:
+/// ignorelist.tx
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/115094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/115094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap
memory, and prevents any pot
of ``nonallocating`` by the compiler.
}];
}
+
+def WrapsDocs : Documentation {
+ let Category = DocCatField;
+ let Content = [{
+The ``wraps`` attribute can be used wit
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/115094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/109088
>From 255c4af822ea327b51547c5c666b172bb81c6454 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Wed, 18 Sep 2024 13:58:24 +0800
Subject: [PATCH 1/2] [Clang][compiler-rt][UBSan] Remove `BuiltinCheckKind`
--
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/104741
>From e2ce302a0d3649594ff1a6b94420f815d0e1acde Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Mon, 19 Aug 2024 15:22:39 +0800
Subject: [PATCH 1/2] [UBSan] Diagnose assumption violation
---
clang/lib/Cod
@@ -633,9 +633,11 @@ static void handleInvalidBuiltin(InvalidBuiltinData *Data,
ReportOptions Opts) {
ScopedReport R(Opts, Loc, ET);
- Diag(Loc, DL_Error, ET,
- "passing zero to %0, which is not a valid argument")
-<< ((Data->Kind == BCK_CTZPassedZero) ? "ctz()"
@@ -1996,16 +1996,21 @@ struct CallObjCArcUse final : EHScopeStack::Cleanup {
Value *CodeGenFunction::EmitCheckedArgForBuiltin(const Expr *E,
vitalybuka wrote:
Done
https://github.com/llvm/llvm-project/pull/104741
_
vitalybuka wrote:
clang with UBSAN is fine, i am running other tests.
https://github.com/llvm/llvm-project/pull/104741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/109088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/109088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
Sorry, I realized the my request does not make much sense.
Still PR contain message improvement and a bug fix.
LGTM.
https://github.com/llvm/llvm-project/pull/109088
___
cfe-commits mailing li
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/109088
>From 255c4af822ea327b51547c5c666b172bb81c6454 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Wed, 18 Sep 2024 13:58:24 +0800
Subject: [PATCH 1/3] [Clang][compiler-rt][UBSan] Remove `BuiltinCheckKind`
--
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/109088
>From 255c4af822ea327b51547c5c666b172bb81c6454 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Wed, 18 Sep 2024 13:58:24 +0800
Subject: [PATCH 1/4] [Clang][compiler-rt][UBSan] Remove `BuiltinCheckKind`
--
@@ -633,9 +633,11 @@ static void handleInvalidBuiltin(InvalidBuiltinData *Data,
ReportOptions Opts) {
ScopedReport R(Opts, Loc, ET);
- Diag(Loc, DL_Error, ET,
- "passing zero to %0, which is not a valid argument")
-<< ((Data->Kind == BCK_CTZPassedZero) ? "ctz()"
vitalybuka wrote:
I wonder how much code will be broken.
We have internally `fsanitize=builtin` enabled, as is patch will break and
force us to disable the sanitizers.
I will try to run internal tests, and clang itself with a new check.
If it breaks to much, we will need to create a new sanitiz
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/104741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Other tests are also fine.
https://github.com/llvm/llvm-project/pull/104741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -351,6 +353,14 @@ There are several limitations:
* Check groups (like ``undefined``) can't be used in suppressions file, only
fine-grained checks are supported.
+Security Considerations
+===
+
+UndefinedBehaviorSanitizer's runtime is meant for testing
vitalybuka wrote:
Don't forget to click "re-request review" after updating PRs, or it's not
displayed as pending review request.
https://github.com/llvm/llvm-project/pull/100937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
vitalybuka wrote:
Curios, why Asan when there is Sparc ADI?
https://github.com/llvm/llvm-project/pull/107403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/107403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Also if there is a feature similar to ARM TBI, hwasan is a better option.
https://github.com/llvm/llvm-project/pull/107403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap
memory, and prevents any pot
of ``nonallocating`` by the compiler.
}];
}
+
+def WrapsDocs : Documentation {
+ let Category = DocCatField;
+ let Content = [{
+The ``wraps`` attribute can be used wit
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/116302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> @vitalybuka any idea how lldb-server is failing with `UNRESOLVED`? How in the
> world are any of the changes here affecting lldb-server?
flake?
https://github.com/llvm/llvm-project/pull/107332
___
cfe-commits mailing list
cfe-comm
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/116302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/116302
Full list is quite long, and quality of implementation can
vary.
Drop the lists to avoid confusion like
https://github.com/rust-lang/rust/pull/123617
We don't maintain these for other sanitizers.
>From 7da
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/113227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> @vitalybuka
>
> > Would it make sense to support attributes like
> > `__attribute__((no_sanitize("-undefined")))` ? Seems like better
> > representation of the fact that we want to undo sanitizer suppression.
>
> Is there some other precedence for this `-undefined` syntax
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/117651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3919,18 +3919,16 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value
*Checked,
Builder.CreateCondBr(Checked, Cont, TrapBB);
EmitBlock(TrapBB);
-llvm::CallInst *TrapCall = Builder.CreateCall(
-CGM.getIntrinsic(llvm::Intrinsic::ubsantrap),
-llvm::
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/117649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3919,18 +3919,16 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value
*Checked,
Builder.CreateCondBr(Checked, Cont, TrapBB);
EmitBlock(TrapBB);
-llvm::CallInst *TrapCall = Builder.CreateCall(
-CGM.getIntrinsic(llvm::Intrinsic::ubsantrap),
-llvm::
@@ -3919,18 +3919,16 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value
*Checked,
Builder.CreateCondBr(Checked, Cont, TrapBB);
EmitBlock(TrapBB);
-llvm::CallInst *TrapCall = Builder.CreateCall(
-CGM.getIntrinsic(llvm::Intrinsic::ubsantrap),
-llvm::
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/117805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3919,18 +3919,16 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value
*Checked,
Builder.CreateCondBr(Checked, Cont, TrapBB);
EmitBlock(TrapBB);
-llvm::CallInst *TrapCall = Builder.CreateCall(
-CGM.getIntrinsic(llvm::Intrinsic::ubsantrap),
-llvm::
@@ -817,6 +817,37 @@ ASTContext::getCanonicalTemplateTemplateParmDecl(
return CanonTTP;
}
+/// Check if a type can have its sanitizer instrumentation elided.
+/// Determine this by its presence in a SCL alongside its specified categories.
+/// For example:
+/// ignorelist.tx
@@ -48,6 +49,63 @@ Example
$ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ;
./a.out
# No error report here.
+Usage with UndefinedBehaviorSanitizer
+=
+
+The arithmetic overflow sanitizers ``unsigned-integer-overfl
@@ -1,7 +1,28 @@
+// Verify ubsan doesn't emit checks for ignorelisted types
+// RUN: echo "[{unsigned-integer-overflow,signed-integer-overflow}]" >
%t-int.ignorelist
+// RUN: echo "type:int" >> %t-int.ignorelist
+// RUN: %clang_cc1 -triple x86_64-linux-gnu
-fsanitize=signed-int
@@ -48,6 +49,63 @@ Example
$ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ;
./a.out
# No error report here.
+Usage with UndefinedBehaviorSanitizer
+=
+
+The arithmetic overflow sanitizers ``unsigned-integer-overfl
@@ -1996,16 +1996,21 @@ struct CallObjCArcUse final : EHScopeStack::Cleanup {
Value *CodeGenFunction::EmitCheckedArgForBuiltin(const Expr *E,
vitalybuka wrote:
TO my taste, I'd rather forked EmitCheckedArgForBuiltin into a version for
Assume
very little code
@@ -633,9 +633,11 @@ static void handleInvalidBuiltin(InvalidBuiltinData *Data,
ReportOptions Opts) {
ScopedReport R(Opts, Loc, ET);
- Diag(Loc, DL_Error, ET,
- "passing zero to %0, which is not a valid argument")
-<< ((Data->Kind == BCK_CTZPassedZero) ? "ctz()"
vitalybuka wrote:
Thanks!
LGTM in general.
https://github.com/llvm/llvm-project/pull/104741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
breaks this bot https://lab.llvm.org/buildbot/#/builders/186/builds/4581
https://github.com/llvm/llvm-project/pull/117624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -1410,7 +1410,7 @@ void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
// libresolv.a, even if exists, is an empty archive to satisfy POSIX -lresolv
// requirement.
if (TC.getTriple().isOSLinux() && !TC.getTriple().isAndroid() &&
- !TC.getTriple().isMusl())
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/119071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/119178
`exit(1)` Don't calls C++ destructors, however calls
`at_exit()` handlers, including lsan.
Usually lsan can see pointers of local allocations
on stack or in registers, but those can be
discarded by noreturn `
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/119178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/119013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/119013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/119013
>From d66671a29061f80df52e4d4b7a2b6ce1de5cae27 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 6 Dec 2024 11:18:20 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?U
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/119012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/119178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121243
Follow up to #121221.
>From 85581e8a0481388781b2c715fd746c908ea5fa04 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 27 Dec 2024 18:32:15 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -186,10 +188,24 @@ struct SanitizerSet {
/// Returns a non-zero SanitizerMask, or \c 0 if \p Value is not known.
SanitizerMask parseSanitizerValue(StringRef Value, bool AllowGroups);
+/// Parse a single weighted value (e.g., 'undefined=0.05') from a -fsanitize=
or
+/// -fn
@@ -32,7 +31,7 @@ void SYCLInstallationDetector::addSYCLIncludeArgs(
// Unsupported options for SYCL device compilation.
static ArrayRef getUnsupportedOpts() {
- return {
+ static std::vector UnsupportedOpts = {
vitalybuka wrote:
and C array: UnsupportedOpt
@@ -17,8 +17,7 @@ using namespace llvm::opt;
SYCLInstallationDetector::SYCLInstallationDetector(
const Driver &D, const llvm::Triple &HostTriple,
-const llvm::opt::ArgList &Args)
-: D(D) {}
+const llvm::opt::ArgList &Args) {}
vitalybuka wrote:
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121822
>From 92796278b87c5713a0cf16119009c07f87568df5 Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Mon, 6 Jan 2025 11:42:12 -0800
Subject: [PATCH 1/3] Driver][SYCL] Address sanitizer and test issue
The fo
@@ -3615,9 +3616,12 @@ void CodeGenFunction::EmitCheck(
if (!CGM.getCodeGenOpts().SanitizeMergeHandlers.has(Checked[i].second))
NoMerge = true;
+
+if (!CGM.getCodeGenOpts().NoSanitizeTopHot.has(Checked[i].second))
+ SanitizeGuardChecks = true;
}
- if (
@@ -154,6 +154,8 @@ struct SanitizerKind {
#include "clang/Basic/Sanitizers.def"
}; // SanitizerKind
+typedef double SanitizerMaskWeights[SanitizerKind::SO_Count];
vitalybuka wrote:
float is probably enough
https://github.com/llvm/llvm-project/pull/121619
__
@@ -154,6 +154,8 @@ struct SanitizerKind {
#include "clang/Basic/Sanitizers.def"
}; // SanitizerKind
+typedef double SanitizerMaskWeights[SanitizerKind::SO_Count];
vitalybuka wrote:
typedef -> using
https://github.com/llvm/llvm-project/pull/121619
__
@@ -154,6 +154,8 @@ struct SanitizerKind {
#include "clang/Basic/Sanitizers.def"
}; // SanitizerKind
+typedef double SanitizerMaskWeights[SanitizerKind::SO_Count];
vitalybuka wrote:
also std::array<>
https://github.com/llvm/llvm-project/pull/121619
_
@@ -2649,6 +2649,11 @@ def fsanitize_undefined_strip_path_components_EQ :
Joined<["-"], "fsanitize-unde
HelpText<"Strip (or keep only, if negative) a given number of path
components "
"when emitting check metadata.">,
MarshallingInfoInt, "0",
"int">;
+def fno_
@@ -2649,6 +2649,11 @@ def fsanitize_undefined_strip_path_components_EQ :
Joined<["-"], "fsanitize-unde
HelpText<"Strip (or keep only, if negative) a given number of path
components "
"when emitting check metadata.">,
MarshallingInfoInt, "0",
"int">;
+def fno_
@@ -26,6 +26,8 @@ class SanitizerArgs {
SanitizerSet RecoverableSanitizers;
SanitizerSet TrapSanitizers;
SanitizerSet MergeHandlers;
+ SanitizerSet TopHot;
+ SanitizerMaskWeights TopHotWeights = {0};
vitalybuka wrote:
It's not `Weight`, it's `cutoff th
https://github.com/vitalybuka requested changes to this pull request.
Does not compile
I'll update and merge.
https://github.com/llvm/llvm-project/pull/121822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121822
>From 92796278b87c5713a0cf16119009c07f87568df5 Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Mon, 6 Jan 2025 11:42:12 -0800
Subject: [PATCH 1/4] Driver][SYCL] Address sanitizer and test issue
The fo
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/121822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -186,10 +188,24 @@ struct SanitizerSet {
/// Returns a non-zero SanitizerMask, or \c 0 if \p Value is not known.
SanitizerMask parseSanitizerValue(StringRef Value, bool AllowGroups);
+/// Parse a single weighted value (e.g., 'undefined=0.05') from a -fsanitize=
or
+/// -fn
@@ -1463,17 +1504,18 @@ void SanitizerArgs::addArgs(const ToolChain &TC, const
llvm::opt::ArgList &Args,
}
SanitizerMask parseArgValues(const Driver &D, const llvm::opt::Arg *A,
vitalybuka wrote:
Instead of extending this function, it would be cleaner to cre
@@ -3602,6 +3602,7 @@ void CodeGenFunction::EmitCheck(
llvm::Value *RecoverableCond = nullptr;
llvm::Value *TrapCond = nullptr;
bool NoMerge = false;
+ bool SanitizeGuardChecks = ClSanitizeGuardChecks;
vitalybuka wrote:
Usually we parse Cls as `if (ClSa
@@ -3615,9 +3616,12 @@ void CodeGenFunction::EmitCheck(
vitalybuka wrote:
maybe we can keep the patch Driver only, because we need:
passing fractions array into LLVM passes: ubsan and hwasan
https://github.com/llvm/llvm-project/pull/121619
___
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121852
After #116331 is always SpellingNotCalculated,
so I assume doing nothing is expected.
>From d5cedbc7b822671f5ac45e1f4d49ed91c13858e3 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 6 Jan 2025 14:48:15
@@ -46,26 +47,20 @@ bool clang::parseSanitizerWeightedValue(StringRef Value,
bool AllowGroups,
#include "clang/Basic/Sanitizers.def"
.Default(SanitizerMask());
- if (ParsedKind) {
-size_t equalsIndex = Value.find_first_of('=');
-if (e
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/120667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -154,6 +154,8 @@ struct SanitizerKind {
#include "clang/Basic/Sanitizers.def"
}; // SanitizerKind
+using SanitizerMaskCutoffs = std::array;
vitalybuka wrote:
I was thinking what could be a better implementation to store values. I can be
different dependi
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121159
We will introduce `--implicit-check-not=libclang_rt` in #121081,
this let us to avoid repeating the flag.
>From 446e84807400a2b83462023fc4da9c56a794a61c Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Thu,
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121081
>From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 24 Dec 2024 19:38:02 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121081
>From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 24 Dec 2024 19:38:02 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121081
>From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 24 Dec 2024 19:38:02 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121221
We need to exclude more than builtins, but it's
tricky with FileCheck regex. So switching to list
of libs we want to check.
>From a2d45112466ba69eeb8ca9236469a653d6ff700c Mon Sep 17 00:00:00 2001
From: Vit
vitalybuka wrote:
@MaskRay in case you have a nicer suggestion how to implement this check in
better way.
I'd like to force match of all libclang_rt. except specific list.
With `([^b]..|.[^u].|..[^i]).*` I can exclude only one, and expressions like
`(?!(ABC|XYZ)).*`, are not supported
https:
vitalybuka wrote:
> I've gone ahead and reverted it.
Thanks for reverting.
Could you please provide some information on how it fails? Error output would
be enough. Upstream windows bot are OK.
>Windows GetLinkerPath does append .exe
How upstream bots pass?
E.g. the one above is unrelated flak
vitalybuka wrote:
> I am puzzled by the description about Android.
There is this configured buildkite
https://buildkite.com/llvm-project/github-pull-requests/builds/132244
It's Windows, but only Android lines of the test fail.
https://github.com/llvm/llvm-project/pull/121162
___
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/121160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/121081
>From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 24 Dec 2024 19:38:02 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121160
These are not Windows tests
>From 93627c9635328bc6ede1f667023732678679a378 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Thu, 26 Dec 2024 12:45:11 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> We should avoid FILECHECK_OPTS. Consider using lit's `DEFINE:` feature.
Done https://github.com/llvm/llvm-project/pull/121159
Also extracted unrelated #121160
https://github.com/llvm/llvm-project/pull/121081
___
cfe-commits mailing
901 - 1000 of 1432 matches
Mail list logo
