[clang] [NFC][rtsan] Docs of how to disable rtsan (PR #107707)

@@ -83,3 +83,53 @@ non-zero exit code. #13 0x00010230dd64 in main main.cpp:9 #14 0x0001958960dc () #15 0x2f557ffc () + +Disabling +- + +In some circumstances, you may want to suppress error reporting in a specific scope. + +In C++, this is achieve

[clang] [NFC][rtsan] Docs of how to disable rtsan (PR #107707)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/107707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][rtsan] Docs of how to disable rtsan (PR #107707)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/107707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

vitalybuka wrote: > > @vitalybuka @nikic Let me know if anything needs to be changed in this PR? > > Else, will merge the PR after approval. > > Please review. you should click "re-request review" button next to review. https://github.com/llvm/llvm-project/pull/99439 _

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

vitalybuka wrote: I will take another look tomorrow. https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

@@ -12,12 +12,47 @@ //===--===// #include "llvm/Transforms/Instrumentation.h" +#include "llvm/IR/DiagnosticInfo.h" +#include "llvm/IR/DiagnosticPrinter.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/I

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

vitalybuka wrote: > I remain concerned that newly developed instrumentations may require this > special property. Is it useful to restrict this to HIP programs, at least > before we gain more experience to comfortably apply this to other > configurations? > > I'm also worried that this change

[clang] [clang][Interp] Improve "in call to" call argument printing (PR #102735)

vitalybuka wrote: Breaks https://lab.llvm.org/buildbot/#/builders/52/builds/1496 https://github.com/llvm/llvm-project/pull/102735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/102785 Reverts llvm/llvm-project#102735 Breaks >From 7e8bb8c52f51fd6b41c0b6485b93fd0315b58bab Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sat, 10 Aug 2024 19:55:54 -0700 Subject: [PATCH] Revert "[clang][Inte

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/102786 Reverts llvm/llvm-project#102785 >From 0066d85186fda169b17acc63e4e85ad901e0cbe4 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sat, 10 Aug 2024 20:40:10 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20"Revert=20

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

vitalybuka wrote: I am not sure what is going on there, maybe it needs // UNSUPPORTED: asan I am not going to reland, it's just a notice, to make sure you noticed the revert. https://github.com/llvm/llvm-project/pull/102786 ___ cfe-commits mailing li

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

vitalybuka wrote: > That test doesn't even use the new constant interpreter? Yes, that's looks strange, but it fixes the bot https://lab.llvm.org/buildbot/#/builders/52 https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

vitalybuka wrote: > I am not sure what is going on there, maybe it needs // UNSUPPORTED: asan > > I am not going to reland, it's just a notice, to make sure you noticed the > revert. Looks like it some kind of flakiness in the test. It returned https://lab.llvm.org/buildbot/#/builders/52/bui

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/102859 It's very flaky recently. Issue #102858 >From fcf5476d8e8ef543a50d33b379c79e761374b9ee Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 12 Aug 2024 00:42:28 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

vitalybuka wrote: > Quick question for my understanding: With `spr` we don't get meaningful > commit messages anymore? That's quite unfortunate... Can you please clarify? https://github.com/llvm/llvm-project/pull/102859 ___ cfe-commits mailing list

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/102859 >From fcf5476d8e8ef543a50d33b379c79e761374b9ee Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 12 Aug 2024 00:42:28 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/102859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

vitalybuka wrote: > > > Quick question for my understanding: With `spr` we don't get meaningful > > > commit messages anymore? That's quite unfortunate... > > > > > > Can you please clarify? > > The commit messages in this PR are `initial version` and `Update const.cpp`, > which is totally u

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

vitalybuka wrote: @hahnjo I believe I explained "Update const.cpp" issue. So I am going to merge as the that continue to sporadically brake. https://github.com/llvm/llvm-project/pull/102859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [Interp] Mark the test unsupported with Asan (PR #102859)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/102859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Document AddressSanitizer security considerations (PR #100937)

vitalybuka wrote: This applies as well to MemorySanitizer, ThreadSanitizer, LeakSanitizer, HWAddressSanitizer, more or less UBSan with diagnostics. Would you like to update those as well? https://github.com/llvm/llvm-project/pull/100937 ___ cfe-commi

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

vitalybuka wrote: We should revert this patch. It breaks mupltiple bots, introducing Msan reports. Also on a first look I don't like `-fsanitize-pattern-exclusion=` at all, very inconsistent. I assumed we agreed to splitting sanitizers into smaller sets? I would like to know why we need to intr

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/104472 This reverts commit 9a666deecb9ff6ca3a6b12e6c2877e19b74b54da. >From 29256f6703beafdfbb74df08c8358301a5873885 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Thu, 15 Aug 2024 10:09:35 -0700 Subject: [PATCH]

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

vitalybuka wrote: Already reverted. https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

vitalybuka wrote: Before reland, please include me into review I'd like to understand why `-fsanitize-pattern-exclusion=all` is better than something like `-fno-sanitize=overflow-pattern-all` https://github.com/llvm/llvm-project/pull/100272 ___ cfe-co

[clang] [compiler-rt] [ubsan] Limit _BitInt ubsan tests to x86-64 platform only (PR #104494)

@@ -1,3 +1,4 @@ +// REQUIRES: x86_64-target-arch vitalybuka wrote: What is about https://lab.llvm.org/buildbot/#/builders/107/builds/1916 https://github.com/llvm/llvm-project/pull/104494 ___ cfe-commits mailing list c

[clang] [compiler-rt] [ubsan] Limit _BitInt ubsan tests to x86-64 platform only (PR #104494)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/104494 >From 98d3d539c84c917ba7369f688ba26ff172c9d89c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=C3=A4nolituri=20L=C3=B3mitaur=C3=AB?= Date: Wed, 7 Aug 2024 17:29:35 -0400 Subject: [PATCH 1/5] [ubsan] Display corre

[clang] [compiler-rt] [ubsan] Limit _BitInt ubsan tests to x86-64 platform only (PR #104494)

@@ -1,3 +1,4 @@ +// REQUIRES: x86_64-target-arch vitalybuka wrote: I will disabled for windows as well, please investigate after we fix bots? https://github.com/llvm/llvm-project/pull/104494 ___ cfe-commits mailing lis

[clang] [compiler-rt] [ubsan] Limit _BitInt ubsan tests to x86-64 platform only (PR #104494)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/104494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [ubsan] Limit _BitInt ubsan tests to x86-64 platform only (PR #104494)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/104494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

vitalybuka wrote: > > Before reland, please include me into review I'd like to understand why > > `-fsanitize-pattern-exclusion=all` is better than something like > > `-fno-sanitize=overflow-pattern-all` > > The latter doesn't make sense to me. `no-sanitize` takes a list of sanitizers > to co

[clang] [compiler-rt] [test] Prevent generation of the bigendian code inside clang test CodeGen/bit-int-ubsan.c (PR #104607)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/104607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 633bc3b - [CodeGen][NFC] Make an opt<> static

Author: Vitaly Buka Date: 2024-04-02T15:47:04-07:00 New Revision: 633bc3bfda71c55bc38d5a3bfdb426bab61ff101 URL: https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101 DIFF: https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101.diff L

[clang] abd05eb - [clang] Init fields added by #87357

Author: Vitaly Buka Date: 2024-04-03T17:48:25-07:00 New Revision: abd05eb4a53e6c7760496620da417733f52d4bf9 URL: https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9 DIFF: https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9.diff L

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/87436 >From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 2 Apr 2024 17:18:58 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?UT

[clang] 96a99a5 - [NFC][UBSAN] Regenerate a test

Author: Vitaly Buka Date: 2024-04-04T15:54:54-07:00 New Revision: 96a99a5e2f62475f13d7ba18b15acad733909e7f URL: https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f DIFF: https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f.diff L

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/87436 >From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 2 Apr 2024 17:18:58 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?UT

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84858 >From 014644897f25ed88a1e17192531cf92110758470 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 11 Mar 2024 16:58:15 -0700 Subject: [PATCH] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtim

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

@@ -3805,6 +3812,12 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, SanitizerHandler CheckHandlerID) { llvm::BasicBlock *Cont = createBasicBlock("cont"); + if (ClSanitizeExpHot) { +Checked = +Builder.CreateOr(Chec

[clang] [llvm] [clang][ubsan] Switch UBSAN optimization to `llvm.allow.{runtime,ubsan}.check()` (PR #84858)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Rename `remove-traps` to `lower-builtin-hot` (PR #84853)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84853 >From d98585586148f2084e36d06996d6c9190cec57d7 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 11 Mar 2024 16:32:06 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?U

[clang] [llvm] [UBSAN] Rename `remove-traps` to `lower-allow-check` (PR #84853)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

vitalybuka wrote: I will land, and address followup comments, if any. It does not change behavior without -mllvm flags. https://github.com/llvm/llvm-project/pull/87436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang][CodeGen] Guard ubsan checks with `llvm.allow.ubsan.check` (PR #87436)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

vitalybuka wrote: I changed my design, so I don't need that change as is. Given https://godbolt.org/z/4KfEKq7zb, I can revert your patch, or just leave it as is. I have no preference. https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits mai

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

vitalybuka wrote: abandoning https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/83470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

vitalybuka wrote: This is fixed version of https://github.com/llvm/llvm-project/pull/75481 ? https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

https://github.com/vitalybuka commented: Fail i386 ``` UBSan-AddressSanitizer-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c UBSan-Standalone-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c ``` https://github.com/llvm/llvm-project/pull/87761 __

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

vitalybuka wrote: I'll land after presubmit checks https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

vitalybuka wrote: ok please paste here what ever looks like real failure from the patch buildbot does not sent me, as I am not on the blame list https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][UBSan] Remove rigid metadata checks for `ubsan-bitfield-conversion` (PR #88116)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/88116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` vitalybuka wrote: Not sure how t

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` vitalybuka wrote: Similar __buil

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

@@ -3233,6 +3233,17 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, if (BuiltinCountZeroBitsGeneric(*this, TheCall)) return ExprError(); break; + + case Builtin::BI__builtin_allow_runtime_check: { +Expr *Arg = TheCall->getArg(0); +

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

vitalybuka wrote: It's broken here https://lab.llvm.org/buildbot/#/builders/236/builds/11633 https://github.com/llvm/llvm-project/pull/89811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

vitalybuka wrote: Not sure, nothing in cmake cmd: ``` cmake -DLLVM_APPEND_VC_REV=OFF -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_CCACHE_BUILD=ON -DLLVM_USE_LINKER=lld -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF -DCMAKE_C_COMPILER=/b/sanitizer-aarch64-linux-bootstrap-hwa

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

vitalybuka wrote: > @vitalybuka could it be a ccache glitch? Technically can, but I would not count on hash collision :) Also there are two machines running same config consistently fail. https://github.com/llvm/llvm-project/pull/89811 ___ cfe-commi

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

vitalybuka wrote: Try `// UNSUPPORTED: hwasan` https://github.com/llvm/llvm-project/pull/89811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

vitalybuka wrote: Actually I will try myself, as I have access to the bot. https://github.com/llvm/llvm-project/pull/89811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy)" (PR #95299)

vitalybuka wrote: The patch is large, so I'll take another look, if there is a trivial fix. So please approve without merging. https://github.com/llvm/llvm-project/pull/95299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang-tools-extra] Revert "✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy)" (PR #95299)

vitalybuka wrote: I guess I will proceed with revert, I don't know meaning that failed assert in the test, and expected ownership of EmbedAnnotationData is not clear to me. https://github.com/llvm/llvm-project/pull/95299 ___ cfe-commits mailing list c

[clang] [clang-tools-extra] Revert "✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy)" (PR #95299)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/95299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/95885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on Linux only (PR #96120)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/96120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/93783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

vitalybuka wrote: If you want another round, make sure to click `re-request review` https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

@@ -1509,6 +1511,11 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList &Args, AddLinkSanitizerLibArgs(Args, CmdArgs, "asan"); } vitalybuka wrote: Driver needs tests https://github.com/llvm/llvm-project/pull/92460 __

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

vitalybuka wrote: A new memory leak https://lab.llvm.org/buildbot/#/builders/5/builds/42694 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/89006 Reverts llvm/llvm-project#88546 Leak and performance regression. Details in #88546 >From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 16 Apr 2024 17:23:47 -0

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

vitalybuka wrote: have ideas about leak, but not sure what to do with perf regression and #88330 Proposing revert https://github.com/llvm/llvm-project/pull/89006 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1163,12 +1136,7 @@ class Sema; ConversionSequenceList allocateConversionSequences(unsigned NumConversions) { ImplicitConversionSequence *Conversions = - slabAllocate(NumConversions); - - // Construct the new objects. - for (unsigned I = 0; I

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/89006 >From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 16 Apr 2024 17:23:47 -0700 Subject: [PATCH 1/2] Revert "Improve stack usage to increase recursive initializ

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

vitalybuka wrote: > I would not run clang-format on the revert Done. Reverted to github generated 1d59298 https://github.com/llvm/llvm-project/pull/89006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/89006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/87568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [clang][llvm][rtsan] Introduce RealtimeSanitizer clang codegen, llvm attributes (PR #100120)

vitalybuka wrote: Can we split into 3 patches? 1. LLVM 2. Clang 3. Compiler-rt https://github.com/llvm/llvm-project/pull/100120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][rtsan] Introduce realtime sanitizer clang codegen and -fsanitize flag (PR #100192)

@@ -1410,6 +1414,35 @@ QualType CodeGenFunction::BuildFunctionArgList(GlobalDecl GD, return ResTy; } +void InsertCallBeforeInstruction(llvm::Function *Fn, vitalybuka wrote: Also maybe I missed some dissussion these changes looks like better be done by llvm

[clang] [clang][rtsan] Introduce realtime sanitizer clang codegen and -fsanitize flag (PR #100192)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/100192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][rtsan] Introduce realtime sanitizer clang codegen and -fsanitize flag (PR #100192)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/100192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #100205)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/100205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    2   3   4   5   6   7   8   9   10   11   >