https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/118518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/127087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
Lgtm! Thank you, @Vipul-Cariappa!
https://github.com/llvm/llvm-project/pull/127087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
@@ -2639,6 +2628,19 @@ void Sema::MergeTypedefNameDecl(Scope *S,
TypedefNameDecl *New,
notePreviousDefinition(Old, New->getLocation());
}
+void Sema::CleanupMergedEnum(Scope *S, Decl *New) {
vgvassilev wrote:
I realize that `Sema::ActOnDuplicateDefinition`
@@ -2551,18 +2551,7 @@ void Sema::MergeTypedefNameDecl(Scope *S,
TypedefNameDecl *New,
// Make the old tag definition visible.
makeMergedDefinitionVisible(Hidden);
- // If this was an unscoped enumeration, yank all of its enumerators
- // out of the scop
@@ -114,6 +114,13 @@ TEST_F(InterpreterTest, Errors) {
RecoverErr = Interp->Parse("var1 = 424;");
EXPECT_TRUE(!!RecoverErr);
+
+ Err = Interp->Parse("int x = 5; auto capture = [&]() { return x * 2;
};").takeError();
vgvassilev wrote:
There is no such a
@@ -114,6 +114,13 @@ TEST_F(InterpreterTest, Errors) {
RecoverErr = Interp->Parse("var1 = 424;");
EXPECT_TRUE(!!RecoverErr);
+
+ Err = Interp->Parse("int x = 5; auto capture = [&]() { return x * 2;
};").takeError();
vgvassilev wrote:
Can we move this te
@@ -178,8 +178,8 @@ void IncrementalParser::CleanUpPTU(TranslationUnitDecl
*MostRecentTU) {
if (!ND)
continue;
// Check if we need to clean up the IdResolver chain.
-if (ND->getDeclName().getFETokenInfo() && !D->getLangOpts().ObjC &&
-!D->getLangOpts(
@@ -571,11 +571,8 @@ StmtResult Parser::ParseExprStatement(ParsedStmtContext
StmtCtx) {
}
Token *CurTok = nullptr;
- // If the semicolon is missing at the end of REPL input, consider if
- // we want to do value printing. Note this is only enabled in C++ mode
- // since
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/114240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
Please rebase this PR.
https://github.com/llvm/llvm-project/pull/114240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
Our local windows expert is @bellenot. Maybe he can help us out here.
https://github.com/llvm/llvm-project/pull/127468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,7 +1,8 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl | FileCheck %s
-// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s
+// RUN: cat %s | not clang-repl -Xcc -Xclang -Xcc -verify -Xcc -O2 | FileCheck
%s
vgvassi
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/129221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
I wonder if we had an rfc for this. Maybe we should solicit some feedback
before moving forward with this extension.
https://github.com/llvm/llvm-project/pull/121025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/127467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/130909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -711,6 +712,14 @@ llvm::Error Interpreter::Undo(unsigned N) {
}
llvm::Error Interpreter::LoadDynamicLibrary(const char *name) {
+#ifdef __EMSCRIPTEN__
+ void *handle = dlopen(name, RTLD_NOW | RTLD_GLOBAL);
+ if (!handle) {
+llvm::errs() << dlerror() << '\n';
+retu
vgvassilev wrote:
@ilya-biryukov, would you mind giving this PR a test on your infrastructure and
if it works maybe share some performance results?
https://github.com/llvm/llvm-project/pull/133057
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
vgvassilev wrote:
> > > > > While I may not able to look into them in detail recently, it may be
> > > > > helpful to split this into seperate patches to review and to land.
> > > >
> > > >
> > > > I initially considered this, but @vgvassilev said in
> > > > [root-project/root#17722
> > > >
vgvassilev wrote:
> > We really need to figure out how to add in-tree tests.
>
> Yupp sadly I was only able to test this through cppinterop and xeus-cpp as
> I've commented above ([#133037
> (comment)](https://github.com/llvm/llvm-project/pull/133037#discussion_r2015819533))
> where it works
vgvassilev wrote:
> The small-scale benchmarks we had show 10% improvement in CPU and 23%
> improvement in memory usage for some compilations!
That's very good news. I think we can further reduce these times. IIRC, we
still deserialize declarations that we do not need. One of the places to loo
vgvassilev wrote:
We really need to figure out how to add in-tree tests.
https://github.com/llvm/llvm-project/pull/133037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
Lgtm!
https://github.com/llvm/llvm-project/pull/127467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev milestoned
https://github.com/llvm/llvm-project/pull/131578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
> > Here's a new reproducer, this time verifying that a semi-fresh
> > tip-of-the-tree doesn't trigger the same error:
> > https://pastebin.com/7tYfjazz. Apologies for the delay.
>
> Thanks. I gave it a try, but I don't see any `use of overloaded operator '='
> is ambiguous`
vgvassilev wrote:
> > > Here's a new reproducer, this time verifying that a semi-fresh
> > > tip-of-the-tree doesn't trigger the same error:
> > > https://pastebin.com/7tYfjazz. Apologies for the delay.
> >
> >
> > Thanks. I gave it a try, but I don't see any `use of overloaded operator
> >
@@ -14,4 +15,13 @@ auto r2 = l2();
auto r3 = l2();
// CHECK: TWO
-%quit
+// Verify non-local lambda capture error is correctly reported
+int x = 42;
+
+// expected-error {{non-local lambda expression cannot have a capture-default}}
+auto capture = [&]() { return x * 2; };
+
--
vgvassilev wrote:
> > > While I may not able to look into them in detail recently, it may be
> > > helpful to split this into seperate patches to review and to land.
> >
> >
> > I initially considered this, but @vgvassilev said in
> > [root-project/root#17722
> > (comment)](https://github.co
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
https://github.com/vgvassilev milestoned
https://github.com/llvm/llvm-project/pull/136404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev milestoned
https://github.com/llvm/llvm-project/pull/133037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -28,20 +28,21 @@ IncrementalCUDADeviceParser::IncrementalCUDADeviceParser(
std::unique_ptr DeviceInstance,
CompilerInstance &HostInstance,
llvm::IntrusiveRefCntPtr FS,
-llvm::Error &Err, const std::list &PTUs)
vgvassilev wrote:
Why removing
@@ -172,6 +154,19 @@ llvm::Error
IncrementalCUDADeviceParser::GenerateFatbinary() {
FatbinContent.append(PTXCode.begin(), PTXCode.end());
+ auto &PTU = PTUs.back();
vgvassilev wrote:
```suggestion
const PartialTranslationUnit &PTU = PTUs.back();
```
h
@@ -760,8 +787,10 @@ std::unique_ptr Interpreter::GenModule() {
return nullptr;
}
-CodeGenerator *Interpreter::getCodeGen() const {
- FrontendAction *WrappedAct = Act->getWrapped();
+CodeGenerator *Interpreter::getCodeGen(IncrementalAction *Action) const {
+ if (!Action)
+
@@ -50,25 +50,6 @@ IncrementalCUDADeviceParser::Parse(llvm::StringRef Input) {
if (!PTU)
return PTU.takeError();
- auto PTX = GeneratePTX();
vgvassilev wrote:
If this code moved, can't we rely on the base class implementation of `Parse`
here?
https:/
@@ -28,20 +28,21 @@ IncrementalCUDADeviceParser::IncrementalCUDADeviceParser(
std::unique_ptr DeviceInstance,
CompilerInstance &HostInstance,
llvm::IntrusiveRefCntPtr FS,
-llvm::Error &Err, const std::list &PTUs)
+llvm::Error &Err, std::list &PTUs)
: In
https://github.com/vgvassilev commented:
The patch looks reasonable to me, however, I'd wait for somebody with more
experience in the macro logic in modules.
https://github.com/llvm/llvm-project/pull/135471
___
cfe-commits mailing list
cfe-commits@lis
vgvassilev wrote:
Thanks! Does the pr fix https://bugs.llvm.org//show_bug.cgi?id=32670
https://github.com/llvm/llvm-project/pull/135471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/138091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/138091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev milestoned
https://github.com/llvm/llvm-project/pull/138091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
Generally we should wait a day or two for the bots to go through these
changes...
https://github.com/llvm/llvm-project/pull/138091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
vgvassilev wrote:
Yes. Good point.
https://github.com/llvm/llvm-project/pull/108529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/108529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -760,8 +787,10 @@ std::unique_ptr Interpreter::GenModule() {
return nullptr;
}
-CodeGenerator *Interpreter::getCodeGen() const {
- FrontendAction *WrappedAct = Act->getWrapped();
+CodeGenerator *Interpreter::getCodeGen(IncrementalAction *Action) const {
+ if (!Action)
+
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/137804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/136404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
vgvassilev wrote:
> The JIT does not support native TLS on Windows yet.
I thought @sunho has implemented the native tls support in jitlink. Is that
different?
https://github.com/llvm/llvm-project/pull/127468
___
cfe-commits mailing list
cfe-commits@l
901 - 953 of 953 matches
Mail list logo
