[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC344205: [WebAssembly] Saturating float-to-int builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D53009?vs=168738&id=169132#toc Repository: rC Clang htt

[PATCH] D53685: [WebAssembly] Bitselect and min/max intrinsics

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D53685 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeG

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85 +BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc") + aheejin wrote: > Do you think we need to provide this builtin also for other vector types? This builtin is inter

[PATCH] D53722: [WebAssembly] Lower to target-independent saturating add

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Goes along with https://reviews.llvm.org/D53721. Repository: rC Clang https://reviews.llvm.org/D53722 Files: lib/CodeGen/CGBuiltin.cpp test/

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Use the same convention as all the other WebAssembly builtin names. Repository: rC Clang https://reviews.llvm.org/D53724 Files: inc

[PATCH] D53722: [WebAssembly] Lower to target-independent saturating add

This revision was automatically updated to reflect the committed changes. Closed by commit rL345300: [WebAssembly] Lower to target-independent saturating add (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53722 File

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL345301: [WebAssembly] Bitselect and min/max builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53685 Files: cfe/tru

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:12528 + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4: + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: { Value *Src = EmitScalarExpr(E->getArg(0)); aheejin wrote:

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172060. tlively added a comment. Herald added a subscriber: cfe-commits. - Restore return types in names Repository: rC Clang https://reviews.llvm.org/D53675 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

tlively updated this revision to Diff 172061. tlively added a comment. - Restore return types in names Repository: rC Clang https://reviews.llvm.org/D53724 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/bu

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added inline comments. Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587 +multiclass SIMDSelectPat { aheejin wrote: > Why do we need this pattern? Can't we also expand `SELECT` as we did for > `SELECT_CC` and `VSELECT`? It looks like the e

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172072. tlively added a comment. - Wrap comments at col 80. Restore proper revision contents. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL345804: [WebAssembly] Fix type names in truncation builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53724 Files:

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC345804: [WebAssembly] Fix type names in truncation builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D53724?vs=172061&id=172074#toc Repository: rL LLVM

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172280. tlively added a comment. - Wrap comment to 80 chars. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Target/WebAssembly/WebAssemblyInstrSIMD.td test/CodeGen/WebAssembly/simd-

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172708. tlively added a dependency: D53630: [WebAssembly] Lower vselect. tlively added a comment. - Rebase onto SIMD reorganization Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Targ

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173119. tlively added a comment. - Use automatic expansion instead of patterns Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll test/CodeGen/WebAss

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added a comment. In https://reviews.llvm.org/D53675#1290660, @aheejin wrote: > I tried to add `ISD::SELECT` in the expansion list, like > > for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { > ... > } > > > And the code generation apparently works for current test `s

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173120. tlively added a comment. - Update comment Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll test/CodeGen/WebAssembly/simd-vselect.ll Index:

[PATCH] D53675: [WebAssembly] Lower select for vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rL346462: [WebAssembly] Lower select for vectors (authored by tlively, committed by ). Repository: rL LLVM https://reviews.llvm.org/D53675 Files: llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLower

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

tlively created this revision. tlively added reviewers: aheejin, sbc100, dschuff. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jfb, rupprecht, dexonsmith, steven_wu, sunfish, hiraditya, jgravelle-google, mehdi_amini. Herald added projects: clang, LLVM. In the clang UI, replaces

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

tlively marked an inline comment as done. tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/atomic-mem-consistency.ll:1 -; RUN: not llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthroug

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

tlively added a comment. I'll wait and see if @aheejin has any concerns before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58742/new/ https://reviews.llvm.org/D58742 ___ cfe-commits mailing

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

tlively marked an inline comment as done. tlively added a comment. In D58742#1413077 , @sunfish wrote: > This is still a little confusing to me. -matomic is supposed to be a > subtarget flag, stating that the wasm implementation we will run on supports >

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD355112: [WebAssembly] Remove uses of ThreadModel (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D58742?vs=188634&id=188758#toc Repository: rLLD LLVM Linker

[PATCH] D58854: [WebAssembly] Temporarily disable bulk-memory with -pthread

tlively created this revision. tlively added a reviewer: sbc100. Herald added subscribers: cfe-commits, jfb, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. aheejin accepted this revision. This revision is now accepted and ready to land. To prevent the instability of b

[PATCH] D58854: [WebAssembly] Temporarily disable bulk-memory with -pthread

This revision was automatically updated to reflect the committed changes. Closed by commit rC355248: [WebAssembly] Temporarily disable bulk-memory with -pthread (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D58854?vs=188997&id=189000#toc Repository:

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

tlively created this revision. tlively added reviewers: sbc100, aheejin. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, dschuff. Herald added a project: clang. This eliminates a linker error the user might otherwise see about how using the 'atomics' feature requires --share

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL356817: [WebAssembly] Make driver -pthread imply linker --shared-memory (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D60013: [WebAssembly] Add mutable globals feature

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. This feature is not actually used for anything in the WebAssembly backend, bu

[PATCH] D60013: [WebAssembly] Add mutable globals feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL357321: [WebAssembly] Add mutable globals feature (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D60013?vs=192911&id=192925#toc Repository: rL LLVM CHANGES S

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52852. Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/Builtin

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52856. Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/Builtin

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively updated this revision to Diff 168222. tlively marked an inline comment as done. tlively added a comment. - use isIntegerConstantExpr to force constant folding of lanes Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/Code

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively updated this revision to Diff 168223. tlively added a comment. - Force constant folding for lane Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/b

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively updated this revision to Diff 168224. tlively added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ==

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46 +BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4iIi",

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:59 +BUILTIN(__builtin_wasm_add_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:") +BUILTIN(__builtin_wasm_add_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:") craig.topper wrote: > D

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55 +BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

tlively updated this revision to Diff 168385. tlively added a comment. - Replace Wi with LLi in signature string - Remove unnecessary V:128: attribute Repository: rC Clang https://reviews.llvm.org/D52852 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively updated this revision to Diff 168387. tlively added a comment. - Replace Wi with LLi and remove V:128: Repository: rC Clang https://reviews.llvm.org/D52856 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/Cod

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

tlively updated this revision to Diff 168388. tlively added a comment. - Remove V:128: attributes Repository: rC Clang https://reviews.llvm.org/D52858 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

tlively added a comment. In https://reviews.llvm.org/D52856#1255905, @dschuff wrote: > W is int64_t (which is long long for wasm32 and would probably be long for > wasm64 since that would probably LP64 (like Linux) rather than LLP64 (Like > Win64). So if we want it to be the same for both wasm3

[PATCH] D52910: [WebAssembly] any_true and all_true builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, craig.topper. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52858. Repository: rC Clang https://reviews.llvm.org/D52910 Files: include/clang

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, craig.topper. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52910. Repository: rC Clang https://reviews.llvm.org/D52913 Files: include/clang

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343834: [WebAssembly] __builtin_wasm_extract_lane_* builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52852 Files:

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC343835: [WebAssembly] __builtin_wasm_replace_lane_* builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D52856?vs=168387&id=168421#toc Repository: rC Clan

[PATCH] D52858: [WebAssembly] saturating arithmetic builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343836: [WebAssembly] saturating arithmetic builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52858 Files: cfe/tru

[PATCH] D52910: [WebAssembly] any_true and all_true builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343837: [WebAssembly] any_true and all_true builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52910 Files: cfe/tru

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL343838: [WebAssembly] abs and sqrt builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52913 Files: cfe/trunk/includ

[PATCH] D52913: [WebAssembly] abs and sqrt builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC343838: [WebAssembly] abs and sqrt builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D52913?vs=168402&id=168424#toc Repository: rC Clang https://review

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, jfb, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D53007 Files: test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ==

[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52959 and https://reviews.llvm.org/D53004. Repository: rC Clang https://reviews.llvm.org/D53009

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL344009: [WebAssembly][NFC] Rename test functions for builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53007 Files:

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: clang. implements llvm intrinsics and clang intrinsics for memory.init and data.drop. Repository: rG LLVM Git

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; -atomics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://revie

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; tlively wrote: > -atomics You wo

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false) sbc100 wrote: > aheejin wrote: > > This c

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1391116 , @tlively wrote: > In D57874#1389953 , @aheejin wrote: > > > - `-matomics` means `-mthread-model posix` > > > Why should this be the case? Atomic instructions are necessar

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1389953 , @aheejin wrote: > - `-matomics` means `-mthread-model posix` Why should this be the case? Atomic instructions are necessary for multithreading, but I wouldn't think multithreading would be necessary for atom

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1389953 , @aheejin wrote: > Anyway, moved all logic to the driver layer and did this: > > - `-matomics` means `-mthread-model posix` > - `-mthread-model posix` means `-matomics` > - `-pthread` means both `-matomics` and `

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1390014 , @sbc100 wrote: > In D57874#1389981 , @sunfish wrote: > > > > - `-matomics` means `-mthread-model posix` > > > > The others sound reasonable, though this one seems a littl

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:50 + bool HasNoPthread = + !Pthread && DriverArgs.hasArg(clang::driver::options::OPT_no_pthread); + Should this logic use `getLastArg` or perhaps `getLastArgNoClaim` to check o

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1391384 , @aheejin wrote: > In D57874#1391133 , @tlively wrote: > > > In D57874#1389953 , @aheejin wrote: > > > > > Anyway, moved all logic

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = Shouldn't every use of `hasFlag` be `getLastArgValue` instead? ===

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = aheejin wrote: > tlively wrote: > > Shouldn't every use of `hasFlag`

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29 +// Bulk memory builtins +TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory") +TARGET_BUILTIN(__builtin_wasm_data_drop, "vIi", "", "bulk-memory")

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively updated this revision to Diff 186393. tlively marked 12 inline comments as done. tlively added a comment. - Address comments - Use `Ui` in builtin signatures - Remove unnecessary intrinsic polymorphism - Tweak intrinsic properties Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively updated this revision to Diff 186504. tlively added a comment. - Update tests to check full polymorphism of llvm.memcpy and llvm.memmove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57736/new/ https://reviews.llvm.org/D57736 Files: clan

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL353983: [WebAssembly] Bulk memory intrinsics and builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D57736?vs=186504&id=186740#toc Repository: rL LLVM C

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL362667: [WebAssembly] Support Leak Sanitizer on Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D63575: [WebAssembly] Add builtin functions for creating vector constants

tlively created this revision. tlively added reviewers: dschuff, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. These builtins do not offer any functionality over the normal aggregate initialization for vector types, except that th

[PATCH] D63575: [WebAssembly] Add builtin functions for creating vector constants

tlively added a comment. This CL does not provide a mechanism for enforcing that the lanes of a floating point vector are constant, and it doesn't look like clang supports that kind of check. That makes this CL a half-baked solution, so I'm not sure we should actually go in this direction. Re

[PATCH] D64586: [WebAssembly] Make -pthread imply -bulk-memory

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. This paves the way for using passive segments in pthread builds, which will make separate memory files unnecessary

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > quantum wrote: > > aheejin wrote: > > > Why is it `c`(co

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209367. tlively added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driv

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209365. tlively added a comment. - Add mutable-globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209369. tlively added a comment. - and other comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/D

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

This revision was automatically updated to reflect the committed changes. Closed by commit rL365935: [WebAssembly] Make pthread imply bulk-memory, mutable-globals (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added inline comments. Comment at: lld/wasm/Driver.cpp:543 + "__wasm_init_tls", WASM_SYMBOL_VISIBILITY_HIDDEN, + make(I32ArgSignature, "__wasm_init_tls")); + quantum wrote: > aheejin wrote: > > Does this TLS thing work when `Config->Shared == tr

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added a comment. LGTM apart from one last comment Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:193 + +if (!Features[WebAssembly::FeatureBulkMemory]) Stripped |= stripThreadLocals(M); quantum wrote: > tlively wrote: > >

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively accepted this revision. tlively added a comment. Nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM modulo a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64949/new/ https://reviews.llvm.org/D64949 __

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65028/new/ https://reviews.llvm.org/D65028 _

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. These features will both be implemented soon, so I thought I would save time by adding

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively added a comment. In D62047#1505878 , @aheejin wrote: > How about using `multi_value`/`multi-value`/`MultiValue`/`MULTI-VALUE` > (depending on positions)? The repo name is also multi-value. > https://github.com/WebAssembly/multi-value > Otherwise

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

This revision was automatically updated to reflect the committed changes. Closed by commit rL361516: [WebAssembly] Add multivalue and tail-call target features (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D62047?vs=199941&id=201010#toc Repository: r

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

This revision was automatically updated to reflect the committed changes. Closed by commit rL361536: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

tlively added a comment. Please add a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62559/new/ https://reviews.llvm.org/D62559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL362004: [WebAssembly] Support VPtr sanitizer for Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on D56501 . Also adds a macro define __wasm_unimplemented_simd128__ for feature detection of unimp

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 180921. tlively added a comment. - Decouple sign-ext from simd128 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang/Basic/BuiltinsWebAssembly.def include/clang/

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 180984. tlively added a comment. - Match the new naming scheme from rL350791 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:89 +// features control availability of builtins +setSIMDLevel(Features, SIMDLevel); +if (HasNontrappingFPToInt) aheejin wrote: > Minor thing, but should we extract this as a

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively updated this revision to Diff 180989. tlively marked 3 inline comments as done. tlively added a comment. - Fix formatting, fix and test macro name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/c

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 181171. tlively marked an inline comment as done. tlively added a comment. - Change names again to reflect latest committed LLVM change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively closed this revision. tlively added a comment. Closed by commit rC350909 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 ___ cfe-c

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Implements target-specific LLVM intrinsics and clang builtins for these new SIMD operat

  1   2   3   4   5   >