[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

This revision was automatically updated to reflect the committed changes. stephanemoore marked an inline comment as done. Closed by commit rL372445: [clang-tidy] Add check for classes missing -hash ⚠️ (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscrib

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. Looks good! A couple nits/questions. Does the check allow variables in anonymous namespaces? namespace { dispatch_once_t onceToken; } I //think// such variables should satisfy initialization requirements. If not, can we update the check to not trigger on va

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. > Does the check allow variables in anonymous namespaces? > > namespace { > dispatch_once_t onceToken; > } > > > I //think// such variables should satisfy initialization requirements. > > If not, can we update the check to not trigger on variables? Either w

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. It looks like everything is in order. I will proceed with landing the patch on your behalf 👍 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 ___ cfe-commits mailing li

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

This revision was automatically updated to reflect the committed changes. Closed by commit rL373028: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non… (authored by stephanemoore, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a pro

[PATCH] D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. I wasn't sure what the policy is for renaming checks so I dug into previous check renames. https://reviews.llvm.org/D43867 seems to indicate that it's acceptable for checks to be

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore added a comment. (sorry for the delay 😅) > The difference is that the exemption list would be per-project, created by > whoever turns on the check for the project. I was assuming that this checker > would be turned on by each team, rather than globally, and that part of doing > s

[PATCH] D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

This revision was automatically updated to reflect the committed changes. Closed by commit rL373392: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

stephanemoore added a comment. Looks good to me. Repository: rL LLVM https://reviews.llvm.org/D46374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. stephanemoore added a reviewer: aaron.ballman. stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra/clang-tidy/add_new_check.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/ https://reviews.llvm.org/D6

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

stephanemoore accepted this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NSInvocationArgumentLifetimeCheck.cpp:49 + QT->getScalarTypeKind() == Type::STK_BlockPointer) && +

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/objc-nsinvocation-argument-lifetime.m:64-69 +- (void)processInvocation:(NSInvocation *)Invocation { + [Invocation getArgument:&Argument atIndex:2];

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

stephanemoore added a comment. LGTM after fixing the assertion ✅ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D135091: Load the `_cmd` selector for generated getters/setters of `direct` Objective-C properties.

stephanemoore accepted this revision. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjC.cpp:1189-1191 // Return (ivar-type) objc_getProperty((id) self, _cmd, offset, true). // FIXME: Can't this be

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1194-1196 + // emitted for it to be passed to the property helper. Since the `_cmd` + // argument was never being initialized by the caller before, still

[PATCH] D137740: [clang-tidy] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This commit

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore updated this revision to Diff 474350. stephanemoore added a comment. stephanemoore updated this revision to Diff 474356. stephanemoo

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore added a comment. In D137740#3918271 , @Eugene.Zelenko wrote: > Will be good idea to combine this patch with D137738 > . My intent was to land the simpler linter fixes first while iterating on the fixes i

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore updated this revision to Diff 475222. stephanemoore added a subscriber: Eugene.Zelenko. stephanemoore added a comment. Included namespace comment linter fixes from D137740 as advised by @Eugene.Zelenko, Repository: rG LLVM Github Monorepo CHAN

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore added a comment. The false positives from this check are causing some disruption for XCTest framework users after some changes that we believe happened in Xcode 14. It would be nice if we could land some form of fix soon. I am happy to discuss options and iterate as needed. Repo

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c2140943cbe: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢 (authored by stephanemoore). Changed prior to commit: https://reviews.llvm.org/D137738?vs=475222&id=479104#to

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

This revision was automatically updated to reflect the committed changes. Closed by commit rG9baf4958cda4: [clang-tidy] Regenerate clang-tidy check list 📋 (authored by stephanemoore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/ https://

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. One last correction and I think that you're all set! Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:284 `readability-redundant-smar

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 __

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore requested changes to this revision. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:21 + Finder->addMatcher( + objcMethodDecl(hasName("dealloc"), ha

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:19 + +void DeallocInCategoriesCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( Early return if the language is not an Objective-C

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore added a comment. Looks in good shape 👌 A couple nits and polish ideas. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp:34 + +void DeallocInCategoryCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedDecl = Result.N

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rC Clang https://reviews.llvm.org/D44692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

stephanemoore added a comment. What do you think of the name `IndentWrappedObjCMethodSignatures` as an alternative to `IndentWrappedObjCMethodNames`? In Objective-C the method name might be considered the selector whereas I believe that this option pertains to formatting of the method signature

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

stephanemoore added inline comments. Comment at: include/clang/Format/Format.h:1154-1163 + /// \brief The style of indenting long function or method names wrapped + /// onto the next line. + enum IndentWrappedMethodStyle { +/// Automatically determine indenting style. +

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

stephanemoore added a comment. Update: I am proposing to update the Google Objective-C style guide to explicitly describe the desired indentation behavior. Comment at: include/clang/Format/Format.h:1154-1163 + /// \brief The style of indenting long function or method names wr

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore abandoned this revision. stephanemoore added a comment. Abandoned this revision and folded the changes into another revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137740/new/ https://reviews.llvm.org/D137740

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore created this revision. Herald added subscribers: cfe-commits, klimek. Defaulting BinPackArguments and BinPackParameters to false is a better representation of Google Objective-C style. Repository: rC Clang https://reviews.llvm.org/D42014 Files: lib/Format/Format.cpp Index:

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore updated this revision to Diff 129718. stephanemoore added a comment. Sorted the Objective-C configuration for consistency. https://reviews.llvm.org/D42014 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore added a comment. I am still working to verify that this change represents actual consensus. I will hold off on adding reviewers until then. https://reviews.llvm.org/D42014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

stephanemoore requested changes to this revision. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: lib/Format/ContinuationIndenter.cpp:1232 + +bool BinPackParameters = +(State.Line->Type != LT_ObjCDecl && Style.BinPackPar

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Looks good to me 👌 Thanks for driving this! Repository: rC Clang https://reviews.llvm.org/D42650 ___ cfe-commits mailing list cf

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

stephanemoore added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore abandoned this revision. stephanemoore added a comment. After talking with Ben I think I will abandon this and we'll focus on separating Objective-C protocol list formatting out of BinPackParameters. https://reviews.llvm.org/D42014 __

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Make sense to me. I don't know offhand who might be a good second pair of eyes to take a look. Comment at: clang/test/SemaObjC/objc-precise-lifetime-unused-var

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

stephanemoore added a comment. Maybe ahatanak might be a good reviewer based on https://reviews.llvm.org/D112850? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120372/new/ https://reviews.llvm.org/D120372 _

<    1   2   3