https://github.com/statham-arm closed
https://github.com/llvm/llvm-project/pull/105684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
statham-arm wrote:
There are two failed CI checks here, but they both seem to be complaining about
a libc++ test called `pstl.merge.pass.cpp`, which is surely completely
unrelated to this clang driver change specific to bare-metal multilib setups.
https://github.com/llvm/llvm-project/pull/1056
statham-arm wrote:
For the record, that also looks spurious: again it's completely unrelated to
this patch, and also, [build
4752](https://lab.llvm.org/buildbot/#/builders/123/builds/4752) of the same
buildbot failed in the same way, two commits earlier. It looks more likely that
that test is
https://github.com/statham-arm closed
https://github.com/llvm/llvm-project/pull/97827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/statham-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/102126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Simon Tatham
Date: 2021-04-21T11:20:05+01:00
New Revision: 77e170db8678e582af986ffe27e12df196e4357b
URL:
https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b
DIFF:
https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b.diff
https://github.com/statham-arm created
https://github.com/llvm/llvm-project/pull/105684
Sometimes a collection of multilibs has a gap in it, where a set of driver
command-line options can't work with any of the available libraries.
For example, the Arm MVE extension requires special startup co
https://github.com/statham-arm closed
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Simon Tatham
Date: 2024-10-07T09:32:06+01:00
New Revision: e0df221dcf5696c6e99952ee62a3b3b689433f3b
URL:
https://github.com/llvm/llvm-project/commit/e0df221dcf5696c6e99952ee62a3b3b689433f3b
DIFF:
https://github.com/llvm/llvm-project/commit/e0df221dcf5696c6e99952ee62a3b3b689433f3b.diff
Author: Simon Tatham
Date: 2024-10-07T09:32:12+01:00
New Revision: 5a9e93f39cc78276a12852bbc4d639689fe73d5a
URL:
https://github.com/llvm/llvm-project/commit/5a9e93f39cc78276a12852bbc4d639689fe73d5a
DIFF:
https://github.com/llvm/llvm-project/commit/5a9e93f39cc78276a12852bbc4d639689fe73d5a.diff
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/2] [clang][Driver] Rename "FatalError" key to "Error" in
mu
https://github.com/statham-arm created
https://github.com/llvm/llvm-project/pull/110804
This PR contains two separate patches updating the "custom error message"
feature in `multilib.yaml` (#105684):
* Change the YAML keyword `FatalError` to `Error`, as @petrhosek requested
after the previous
https://github.com/statham-arm approved this pull request.
LGTM. Especially convenient to have all the patches split apart from each other
like that – it made them much easier to read!
https://github.com/llvm/llvm-project/pull/109943
___
cfe-commits m
https://github.com/statham-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
statham-arm wrote:
Seems a bit verbose to me: all references to these types end up looking like
`custo
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
+using CustomFlagDeclarationPtr = std::shared_ptr;
+
+struct CustomFlagValueDetail {
+ std::string Name;
+ std::optiona
@@ -259,11 +266,69 @@ template <> struct
llvm::yaml::MappingTraits {
}
};
+template <>
+struct llvm::yaml::MappingContextTraits> {
+ static void mapping(llvm::yaml::IO &io, custom_flag::CustomFlagValueDetail
&V,
+ llvm::SmallSet &) {
+io.mapRequir
https://github.com/statham-arm approved this pull request.
LGTM. I suppose the error wouldn't have shown up if you did the simplest
possible end-to-end test along the lines of
```c
float32x4_t foo(float32x4_t a, float32x4_t b, float32_t c, mve_pred16_t p) {
return vfmasq_m(a, b, c, p);
}
```
b
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/3] [clang][Driver] Rename "FatalError" key to "Error" in
mu
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/4] [clang][Driver] Rename "FatalError" key to "Error" in
mu
@@ -217,15 +215,15 @@ struct MultilibSetSerialization {
template <> struct llvm::yaml::MappingTraits {
static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) {
io.mapOptional("Dir", V.Dir);
-io.mapOptional("FatalError", V.FatalError);
+io.mapOptional("E
https://github.com/statham-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/118284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
statham-arm wrote:
> It is fine to add `fixes https://github.com/llvm/llvm-project/issues/123864`
> to the Description so that the issue is automatically closed.
Yes, good point! When I suggested an improved description, I left out that
part, which is the one thing @Zhenhang1213 _didn't_ forge
https://github.com/statham-arm commented:
Would it be possible to modify the description of this PR so that it generates
a commit message that explains the change on its own, without having to refer
to a Github ticket containing a discussion?
If I were writing this change, I'd write a commit m
@@ -42,4 +42,8 @@
// RUN: %clang --target=armv7-linux -### -S %s 2>&1 | \
// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER_NON %s
-// ARMv7_THREAD_POINTER_NON-NOT: "-target-feature" "+read-tp-tpidruro"
+// ARMv7_THREAD_POINTER_NON: "-target-feature" "+read-tp-tpidruro"
---
https://github.com/statham-arm edited
https://github.com/llvm/llvm-project/pull/128728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/statham-arm approved this pull request.
Thanks for the extra test. LGTM now.
https://github.com/llvm/llvm-project/pull/130027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/statham-arm edited
https://github.com/llvm/llvm-project/pull/130138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,18 +14,18 @@
// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-TPIDRPRW %s
// ARMv7_THREAD_POINTER-TPIDRPRW: "-target-feature" "+read-tp-tpidrprw"
-// RUN: %clang --target=armv6t2-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARM_THREAD_POINTER
https://github.com/statham-arm commented:
I've done as much of the review as I can. The syntax in the `REQUIRES` lines
looks sensible to me, and I see why _most_ of these tests would depend on clang
being configured to target its host Darwin platform by default:
* `apple-arm64-arch.c`, `compila
@@ -1,93 +1,94 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
@@ -1,93 +1,93 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
@@ -1,93 +1,94 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
@@ -1,93 +1,94 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
@@ -1,93 +1,94 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
@@ -1,93 +1,94 @@
-// Test of the AArch32 values of -mtp=, checking that each one maps to
-// the right target features.
-
-// RUN: %clang --target=armv7-linux -mtp=cp15 -### -S %s 2>&1 | \
-// RUN: FileCheck -check-prefix=ARMv7_THREAD_POINTER-HARD %s
-// ARMv7_THREAD_POINTER-HARD
https://github.com/statham-arm commented:
This certainly looks more organised than the previous version, but I have a few
nitpicks in comments.
https://github.com/llvm/llvm-project/pull/134098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/statham-arm edited
https://github.com/llvm/llvm-project/pull/134098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/statham-arm approved this pull request.
LGTM. Thanks for the tweaks.
As usual, probably best to give other reviewers a chance to comment too.
https://github.com/llvm/llvm-project/pull/134098
___
cfe-commits mailing list
cfe-commits@
101 - 139 of 139 matches
Mail list logo
