[PATCH] D112158: mips: fix search path for multilib o32

This revision was automatically updated to reflect the committed changes. Closed by commit rG284c2ebc5e05: [clang][MIPS] Fix search path for Debian multilib O32 (authored by wzssyqa, committed by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

atanasyan created this revision. atanasyan added a reviewer: Petar.Avramovic. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: clang. Now Clang does not check that features required by built-in functions are enabled. That causes errors in the backend reported in PR4

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70808/new/

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. I see, thanks. Is there the same or similar functionality in GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 ___ cfe-commits mai

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. Looking good to me as-is. - Current naming is okay. But what do you think about reducing name of //quarter// intrinsics: `__builtin_msa_ldr_w` instead of `__builtin_msa_ldrq_w`? Will it

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, ruiu, Petar.Avramovic, mstojanovic, arichardson. Herald added subscribers: jfb, sdardis. Herald added projects: clang, LLVM. MIPS specific part of LLVM 10.0 Release notes for LLVM, Clang and LLD. Repository: rG LLVM Github Mono

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan added a comment. In D73108#1831442 , @mstojanovic wrote: > Initial MIPS support was also added to `llvm-exegesis`. Oh, sorry. Good point, I'll add this note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan updated this revision to Diff 239333. atanasyan added a reviewer: mbrkusanin. atanasyan added a comment. - Add `llvm-exegesis` note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108 Files: clang/

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan closed this revision. atanasyan added a comment. Closed by commit rG27f93515 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D35254: [mips][mt][7/7] Add driver option for the MIPS MT ASE.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan created this revision. atanasyan added a project: clang. Herald added subscribers: arichardson, javed.absar. This patch adds support for the `long_call`, `far`, and `near` attributes for MIPS targets. The `long_call` and `far` attributes are synonyms. All these attributes override `-ml

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1490 + GPOpt->claim(); + } + Could it be rewritten a bit shorter? ``` bool NoAbiCalls = ABICalls && ABICalls->getOption().matches(options::OPT_mno_abicalls); bool WantGPOpt =

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107193. atanasyan added a comment. Addressed review comment: - Split MipsLongCall into a couple of attributes MipsLongCall and MipsShortCall. - Change the documentation wording. - Keep the attributes handling in the setTargetAttributes. - Show error in case

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107246. atanasyan added a comment. - Pass `IsForDefinition` argument to the `setTargetAttributes` method. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CodeGenMo

[PATCH] D35550: [mips] Add support for -m(no-)extern-data.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D35549: [mips] Add support for -m(no-)local-sdata

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107281. atanasyan added a comment. - Early return from `setTargetAttributes` methods if `IsForDefinition` is not true in all cases except handling MIPS "call style" attributes. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107381. atanasyan added a comment. - New wording of attributes documentation and comments. - Remove redundant `if-return` statements. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDoc

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107446. atanasyan added a comment. My bad. I did not read your comment thoroughly. - Restore `IsForDefinition` checkings in `WinX86_32TargetCodeGenInfo::setTargetAttributes` and `WindowsARMTargetCodeGenInfo::setTargetAttributes` methods. Repository: r

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107461. atanasyan added a comment. Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL308667: [CodeGen][mips] Support `long_call/far/near` attributes (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D35479?vs=107461&id=107578#toc Repository: rL LLVM https://

[PATCH] D42416: [Driver] Add support for mips32 and scudo

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D33363: [mips] Support `micromips` attribute

atanasyan created this revision. Herald added subscribers: arichardson, javed.absar. This patch adds support for the `micromips` and `nomicromips` attributes for MIPS targets. Repository: rL LLVM https://reviews.llvm.org/D33363 Files: include/clang/Basic/Attr.td include/clang/Basic/Attr

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

atanasyan created this revision. Herald added a subscriber: arichardson. This patch adds handling of the `micromips` and `nomicromips` attributes passed by front-end. The patch depends on https://reviews.llvm.org/D33363. Repository: rL LLVM https://reviews.llvm.org/D33364 Files: lib/Targe

[PATCH] D33363: [mips] Support `micromips` attribute

atanasyan updated this revision to Diff 99703. atanasyan added a comment. Thanks for review. This changes: - Allow simultaneous using of micromips and interrupt attributes. - Fix wording of micromips attribute description. Repository: rL LLVM https://reviews.llvm.org/D33363 Files: includ

[PATCH] D33363: [mips] Support `micromips` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL303546: [mips] Support `micromips` attribute (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D33363?vs=99703&id=99748#toc Repository: rL LLVM https://reviews.llvm.org/D333

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL303545: [mips] Support micromips attribute passed by front-end (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D33364?vs=99590&id=99747#toc Repository: rL LLVM https://rev

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337019 , @MaskRay wrote: > @atanasyan A few mips test/Driver tests will fail. Wonder if you have time > making them more portable... Otherwise I'll just add `UNSUPPORTED: > default-pie-on-linux` to them. > > Fail

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337045 , @atanasyan wrote: > In D120305#3337019 , @MaskRay wrote: > >> @atanasyan A few mips test/Driver tests will fail. Wonder if you have time >> making them more portabl

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116238/new/ https://reviews.llvm.org/D116238 ___ cfe-commi

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2edcde00cb39: [MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass (authored by Random06457, committed by atanasyan). Changed prior to comm

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan requested changes to this revision. atanasyan added a comment. This revision now requires changes to proceed. Thanks for the patch. Some notes are below. Comment at: llvm/lib/Target/Mips/MipsMulMulBugPass.cpp:16 +static cl::opt +EnableMulMulFix("mfix4300", cl::ini

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D112158: mips: fix search path for multilib o32

atanasyan added a comment. - Does this problem exist on all versions of Debian or starting from specific version only? - This fix needs test cases. Take a look at "Check linker invocation on Debian 6 MIPS 32/64-bit" in the `clang/test/Driver/linux-ld.c` for example. Repository: rG LLVM Githu

<    1   2