[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > What about `llvm::iplist`? It can be changed to iplist as well, but w

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > sdmitriev wrote: > > ABataev wrote: > > > What about `llvm::iplist`?

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev). Repository: rG LLVM Github

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. llvm-objcopy has been

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8998a8aa97f8: [clang-offload-bundler] Add sections and set section flags using one llvm… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: cla

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8444a8e9422: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

sdmitriev created this revision. sdmitriev added reviewers: saiislam, ABataev. sdmitriev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes clang-offload-bundler to use the origin

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b553297ef3e: [clang-offload-bundler] Reuse original file extension for device archive member (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70551 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755527 , @ABataev wrote: > Why do we need this? To pass wrapper bitcode directly to the linker when LTO is enabled. LTO plugin does not accept bc if there is no data layout. Repository: rG LLVM Github Monorepo

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755583 , @ABataev wrote: > In D70551#173 , @sdmitriev wrote: > > > In D70551#1755527 , @ABataev wrote: > > > > > Why do we need this

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755768 , @ABataev wrote: > In D70551#1755761 , @sdmitriev wrote: > > > In D70551#1755583 , @ABataev wrote: > > > > > In D70551#173 <

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Ok, it is possible to do it like you suggested, but I think that teaching wrapper tool to set data layout without external help is more preferable. There is a certain difference between opt and wrapper tool – opt works on the existing .bc that is provided in command l

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. I would agree with you if data layout was indeed available in the driver, but unfortunately driver does not have access to any existing TargetInfo instance (or maybe I just have not found it). So, I have to create TargetInfo and build data layout even for the case whe

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Wrapper tool is invoked at link phase, therefore there just could be no .bc files available to read data layout from. Ok, looks like there is no good solution for the data layout problem, so I will drop the idea of passing wrapper .bc directly to the linker when LTO i

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag tells link editor to exclude section from linker inputs when linking execut

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev updated this revision to Diff 240676. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added a comment. Any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e82d0dfd8df: [Clang][Bundler] Add 'exclude' flag to target objects sections (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fat object size has significantly increased after D65819

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241269. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241278. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:378 + // Creates temporary file with given contents. + Expected Create(Optional> Contents) { +SmallString<128u> File; -

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev added a comment. @ABataev, do you have any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

This revision was automatically updated to reflect the committed changes. Closed by commit rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert, hfinkel. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. With OpenMP offloading host compilation is done in two phases to capture host IR that is passed to all device compilations as in

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bfdb7096cf: [Clang][Driver] Disable llvm passes for the first host OpenMP offload… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73738 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/too

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG5be2ca29217a: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73738/new/

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

sdmitriev accepted this revision. sdmitriev added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117120/new/ https://reviews.llvm.org/D117120

<    1   2