[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev created this revision. sdmitriev added reviewers: ABataev, hfinkel. Herald added subscribers: cfe-commits, mgrang, guansong. Encoding offload target triples onto comdat group key for offload initialization code guarantees that it will be executed once per each unique combination of off

[PATCH] D49510: [OpenMP][Clang] Usability improvements for OpenMP offloading

sdmitriev abandoned this revision. sdmitriev added a comment. A simpler solution was proposed while discussing an RFC which I submitted a while ago per Alexey's request. It would lead to (almost) the same results but requires much smaller amount of changes. Repository: rC Clang https://revi

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159028. sdmitriev added a comment. Replaced std::sort with llvm::sort. Added a test for offload target registration code for two offload targets. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_regist

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3825 +// this particular combination of offloading targets. +SmallVector RegFnNameParts; +RegFnNameParts.push_back("omp_offloading"); ABataev wrote: > Preallocate the memory

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159058. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === --- lib/CodeGen/CGOpe

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159074. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === --- lib/CodeGen/CGOpe

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

This revision was automatically updated to reflect the committed changes. Closed by commit rC338916: [OpenMP] Encode offload target triples into comdat key for offload… (authored by sdmitriev, committed by ). Repository: rC Clang https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRu

[PATCH] D33509: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies

sdmitriev added a comment. I do not have commit access yet, so I cannot commit this patch myself. Can you please check it in for me? https://reviews.llvm.org/D33509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev created this revision. sdmitriev added a reviewer: andrew.w.kaylor. Herald added subscribers: cfe-commits, javed.absar. This patch enables Mem2Reg to handle loads/stores from/to bitcasted alloca values as long as the loaded/stored value is bitcastable to the allocated type (see example b

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev added a comment. This patch is a clang's part of this review https://reviews.llvm.org/D56810 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56811/new/ https://reviews.llvm.org/D56811 ___ cfe-commits mailing

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev created this revision. sdmitriev added reviewers: hfinkel, ABataev. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. This is the first set of changes for eliminating OpenMP linker script that adds new clang-offlo

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev added a comment. Any feedback? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 213481. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.ll clang/tools/CMakeLists.txt clang/tools/clang-offload-wrapp

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 4 inline comments as done. sdmitriev added inline comments. Comment at: clang/include/clang/Driver/Action.h:74 OffloadUnbundlingJobClass, +OffloadWrapperJobClass, ABataev wrote: > Do we really need this new kind of job here, can we use

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 14 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:69 + + using MemoryBuffersVector = SmallVectorImpl>; + ABataev wrote: > Why not `ArrayRef`? Changed to MemoryBuffe

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 3 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } vzakhari wrote: > FY

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables offer similar and platform neutral functionality (http://llvm.org/docs/LangRef.html#the-llvm-global-ctors-global-va

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 2 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:72 +private: + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { -

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 219742. sdmitriev added a reviewer: Hahnfeld. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offloa

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 219750. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/CMakeLists.txt clang/tools/clang-offload-wrapper

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#193 , @JonChesterfield wrote: > In D64943#179 , @ABataev wrote: > > > In D64943#178 , > > @JonChesterfield wrote: > > > > >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#136 , @JonChesterfield wrote: > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > runtime is ideal. Since the data is stored in a common section anyway, please > could we rename it to

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1666924 , @JonChesterfield wrote: > In D64943#1666849 , @sdmitriev wrote: > > > In D64943#136 , > > @JonChesterfield wrote: > > > >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1667469 , @JonChesterfield wrote: > I'm on board with getting rid of the linker script. Gold's limited support > for that seems conclusive. > > I believe the current script does two things: > 1/ takes a binary and em

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1668006 , @JonChesterfield wrote: > >> Does this diff mix getting rid of the linker script with other changes? > >> E.g. it looks like the metadata generation is moving from clang to the new > >> tool, but that seems

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev abandoned this revision. sdmitriev added a comment. This patch is no longer relevant since it was agreed to split https://reviews.llvm.org/D64943 into pieces in a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 __

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the first part to https://reviews.llvm.org/D68070 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. The second part was uploaded to https://reviews.llvm.org/D68166. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2284-2289 -/// Append top level actions generated by the builder. Return true if errors -/// were found. +/// Append top level actions generated by the builder. virtual void appendTopLevelA

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. sdmitriev added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68355 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev added a comment. In D68355#1691961 , @ABataev wrote: > Mark the patch as NFC. I think I have already done that by adding [NFC] to the commit message. Do I need to do anything in addition to that? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373523: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments. (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 222917. sdmitriev marked 2 inline comments as done. sdmitriev added a comment. Addressed some comments and rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 Files: clang/include/clang/Driver

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1692071 , @JonChesterfield wrote: > I think this patch is a behaviour change. Currently, the target binary is > embedded in the host binary at link time. With this change, the contents of > the binary are embedded in

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 223335. sdmitriev added a comment. Rebased patch and changed clang-offload-wrapper CMakeLists.txt to use add_clang_tool() rather than add_clang_executable() with a custom install rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ http

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d83768f108: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D68166?vs=223335&id=224146#toc Reposit

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the last part to https://reviews.llvm.org/D68746 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1702487 , @thakis wrote: > Out of interest (or ignorance :) ), why is this a separate binary instead of > just part of the normal `clang` driver? C, C++, Objective-C, and assembly all > can do with a single driver, ye

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ABataev wrote: > Same question as be

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:174 + /// Global variable that represents BinDesc is returned. + GlobalVariable *createBinDesc(ArrayRef> Bufs) { +// Create external begin/end symbols for the offload entr

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added a subscriber: grokos. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ---

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: -

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 224726. sdmitriev added a comment. Rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

sdmitriev accepted this revision. sdmitriev added a comment. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68931/new/ https://reviews.llvm.org/D68931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev abandoned this revision. sdmitriev added a comment. All three parts have been committed, so I am abandoning the original patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commi

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69140 Files: clang/test/Driver/clang-offload-wrapper.

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6caada4eb465: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd501045cdea: [Clang][Bundler] Error reporting improvements (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D67031?vs=224726&id=226521#toc Repository: rG LLVM Github Monore

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, abrachet, mgorny. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. clang-offload-bundler currently uses partial linking for creating fat

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1633164 , @ABataev wrote: > In D64943#1619958 , @sdmitriev wrote: > > > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > > on Linux and ‘atexit’ on

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-offload-bundler tool may hang under certain conditions when it extracts a subset of all available device bundles f

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev added a reviewer: hfinkel. Bundler currently requires host triple to be provided no matter if you are performi

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev added a comment. Any feedback? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66485/new/ https://reviews.llvm.org/D66485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:485 +"=" + InputFileNames[I])); +ObjcopyArgs.push_back(InputFileNames[HostInputIndex]); +

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:233 +// RUN: clang-offload-bundler -type=o -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -inputs=%t

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

This revision was automatically updated to reflect the committed changes. Closed by commit rGed153ef044fd: [Clang][Bundler] Use llvm-objcopy for creating fat object files (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66485/ne

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217232. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp I

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217234. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp I

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev added a comment. Sure. The main unbundling loop looks as follows (see loop on line 745) while (!Worklist.empty()) { StringRef CurTriple = FH.get()->ReadBundleStart(Input); if (CurTriple.empty()) break; auto Output = Worklist.find(CurTriple); if (Output == W

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:301 assert(CurBundleInfo != BundlesInfo.end() && "Invalid reader info!"); ++CurBundleInfo; } Just notic

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); ABataev

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

This revision was automatically updated to reflect the committed changes. Closed by commit rL370115: [Clang][Bundler] Fix for a hang when unbundling fat binary (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217522. sdmitriev marked an inline comment as done. sdmitriev added a comment. Added tests for each file type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundl

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rL370143: [Clang][Bundler] Do not require host triple for extracting device bundles (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Looks like there will be no more comments. If so, I will update the first part https://reviews.llvm.org/D65130 which adds clang-offload-wrapper tool with the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D6

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 217682. sdmitriev added a comment. Rebased and synced up changes with https://reviews.llvm.org/D64943 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c cl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D67031 Files: clang/test/Driver/cl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218224. sdmitriev retitled this revision from "[Clang][Bundler] Error reporting improvements [NFC]" to "[Clang][Bundler] Error reporting improvements". sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > The code still uses (in the order of marked incl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906 +Msg << ", unknown target triple '" << Triple << "'"; + reportError(createStringError(errc::invalid_argument, Msg.st

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218250. sdmitriev added a comment. Removed trailing '.' from error messages and added few additional changes for better error handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added a comment. Any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > The c

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundle

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > sdmit

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218776. sdmitriev edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > sdmit

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. I think I have addressed all comments posted so far. Do you have more notes/comments/suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing l

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

sdmitriev added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:1 -; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck %s +; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-pre

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

sdmitriev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common bader wrote: > Anastasia wrote:

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev requested review of this revision. Use a different container that preserves existing elements on modification for storing temporary file names. Cur

  1   2   >