compnerd accepted this revision.
This revision is now accepted and ready to land.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
Early returns would be nicer imo.
Comment at: src/R
Author: compnerd
Date: Thu Jul 7 16:42:29 2016
New Revision: 274797
URL: http://llvm.org/viewvc/llvm-project?rev=274797&view=rev
Log:
Driver: Stop linking to C++ when using sanitizers on Darwin
Sanitizers on Darwin are built as dynamic libraries, not static libraries.
Sanitizers will have their
Author: compnerd
Date: Thu Jul 7 19:37:31 2016
New Revision: 274814
URL: http://llvm.org/viewvc/llvm-project?rev=274814&view=rev
Log:
Revert "Driver: Stop linking to C++ when using sanitizers on Darwin"
This reverts SVN r274797. It broke the Green Dragon bot. Revert it until the
failure can be
compnerd added inline comments.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
rmaprath wrote:
> compnerd wrote:
> > Early returns would be nicer imo.
> Not sure if I follow, did you mean to check t
Author: compnerd
Date: Fri Jul 8 20:59:51 2016
New Revision: 274956
URL: http://llvm.org/viewvc/llvm-project?rev=274956&view=rev
Log:
CodeGen: tweak CFString section for COFF, ELF
Place the structure data into `cfstring`. This both isolates the structures to
permit coalescing in the future (by
Author: compnerd
Date: Sun Jul 10 18:24:36 2016
New Revision: 275032
URL: http://llvm.org/viewvc/llvm-project?rev=275032&view=rev
Log:
Reapply SVN r274797.
Original Commit Message
Driver: Stop linking to C++ when using sanitizers on Darwin
Sanitizers on Darwin are built as dynamic libra
On Mon, Jul 11, 2016 at 12:29 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Mon, Jul 11, 2016 at 12:18 PM, Nico Weber wrote:
>
>> On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer <
>> david.majne...@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, Jul 11, 2016 at 9:03 A
Author: compnerd
Date: Tue Jul 12 09:39:13 2016
New Revision: 275172
URL: http://llvm.org/viewvc/llvm-project?rev=275172&view=rev
Log:
Add option to disable __deallocate #warning
From r229162:
Visual Studio's SAL extension uses a macro named __deallocate. This
macro is used pervasively
Using
compnerd added a subscriber: compnerd.
compnerd added a comment.
Can you explain why the write back is needed? You are doing the write back on
r0, but then adjusting it back. So it is unclear why this change is needed.
Could you provide some more context. A test case would be even better.
Author: compnerd
Date: Tue Jul 12 21:58:44 2016
New Revision: 275241
URL: http://llvm.org/viewvc/llvm-project?rev=275241&view=rev
Log:
CodeGen: minor cleanup, NFC
Initialise more members in initializer lists. Invert the condition that had
grown to be pretty confusing. The `_objc_empty_vtable` i
Author: compnerd
Date: Thu Jul 14 19:49:42 2016
New Revision: 275505
URL: http://llvm.org/viewvc/llvm-project?rev=275505&view=rev
Log:
libc++abi: add a top level option for using CompilerRT
Add an option to opt into compiler-rt instead of libgcc. This option defaults
to OFF to avoid a behaviour
Author: compnerd
Date: Fri Jul 15 15:41:10 2016
New Revision: 275610
URL: http://llvm.org/viewvc/llvm-project?rev=275610&view=rev
Log:
Sema: support __declspec(dll*) on ObjC interfaces
Extend the __declspec(dll*) attribute to cover ObjC interfaces. This was
requested by Microsoft for their ObjC
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
I imagine that at this point, most usage is still based around the x86
toolchain rather than x64 (I didnt even no
Author: compnerd
Date: Sat Jul 16 17:42:06 2016
New Revision: 275697
URL: http://llvm.org/viewvc/llvm-project?rev=275697&view=rev
Log:
CodeGen: use StringRefs more in ObjC class generation, NFC
Rather than building up a number of SmallString-s in order to construct a
std::string, use more StringR
Author: compnerd
Date: Sat Jul 16 17:42:04 2016
New Revision: 275696
URL: http://llvm.org/viewvc/llvm-project?rev=275696&view=rev
Log:
CodeGen: simplify using a local variable, NFC
Add a couple of local variables for the class interface and the super class
interface. This allows for the repeated
Author: compnerd
Date: Sun Jul 17 17:27:38 2016
New Revision: 275735
URL: http://llvm.org/viewvc/llvm-project?rev=275735&view=rev
Log:
CodeGen: whitespace cleanup, StringRef usage in ObjC EH type construction
Clean up some formatting issues and use a bit more StringRef based operations
instead of
Author: compnerd
Date: Sun Jul 17 17:27:41 2016
New Revision: 275736
URL: http://llvm.org/viewvc/llvm-project?rev=275736&view=rev
Log:
CodeGen: whitespace, formatting cleanups, NFC
Format some code which was oddly formatted. Use a bit of auto to make the code
more legible. NFC.
Modified:
c
Author: compnerd
Date: Sun Jul 17 17:27:44 2016
New Revision: 275737
URL: http://llvm.org/viewvc/llvm-project?rev=275737&view=rev
Log:
CodeGen: honour dllstorage on ObjC types
Add support for ObjC types to respect the DLLImport/DLLExport storage
annotations. This only effects COFF output. This
Author: compnerd
Date: Sun Jul 17 17:54:42 2016
New Revision: 275738
URL: http://llvm.org/viewvc/llvm-project?rev=275738&view=rev
Log:
test: add missing triple to test
The test was relying on the default triple which may not be correct. Explicitly
provide it a triple. Should repair the windows
compnerd added a comment.
I was worried about the OOM situation with the 32-bit toolchain. As long as
there is a way to get to the 64-bit version, I don't think that it matters too
much that we default to x86. It sounds like even then, its not been a concern?
https://reviews.llvm.org/D22426
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:167
@@ +166,3 @@
+with the limited number of developers whose job will be to mainly merge
+thousands of patches a day.
+
rengolin wrote:
> compnerd wrote:
> > I don't fully understand how this i
Author: compnerd
Date: Sat Mar 5 15:12:33 2016
New Revision: 262780
URL: http://llvm.org/viewvc/llvm-project?rev=262780&view=rev
Log:
Misc: add a test for TargetParser usage
Ensure that an invalid value passed to target parser does not cause an assertion
in +Asserts builds.
Supporting test for
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Sorry about the delay with this change. Thanks for removing the parameter. I
think that this is fine as is. Do you have commit rights, or should I commit
this on your behalf?
http://r
compnerd added a comment.
`-p` or `-pg` also effects the math library. Please adjust the tests and the
driver to reflect that.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Wow, this is tricky: the code change is in LLVM, and test change in clang :(.
However, this does seem to preserv
Author: compnerd
Date: Mon Nov 16 23:09:18 2015
New Revision: 253310
URL: http://llvm.org/viewvc/llvm-project?rev=253310&view=rev
Log:
modularize: add install rule
This allows modularize to be installed. Previously, no install rule would be
created for it.
Modified:
clang-tools-extra/trunk/
Author: compnerd
Date: Tue Nov 17 23:33:38 2015
New Revision: 253435
URL: http://llvm.org/viewvc/llvm-project?rev=253435&view=rev
Log:
c++abi: use __builtin_offsetof instead of offsetof
Use `__builtin_offsetof` in place of `offsetof`. Certain environments provide a
macro definition of `offsetof`
uld be more
> cautious here than you would be normally.
>
I had discussed this with Argyrios Kyrtzidis. Is he not the current owner
for libclang? Ill happily speak to Doug in the future if he is a better
contact for new API introductions for libclang.
> On Wed, Nov 11, 2015 at 7:57
On Tue, Nov 17, 2015 at 5:06 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Tue Nov 17 19:06:39 2015
> New Revision: 253418
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253418&view=rev
> Log:
> Try to fix leak in CXStringSet from r252853
>
> Modifi
Author: compnerd
Date: Thu Dec 3 20:14:41 2015
New Revision: 254690
URL: http://llvm.org/viewvc/llvm-project?rev=254690&view=rev
Log:
c++abi: whitespace adjustment
Cleanup some code with clang-format to make the following change easier to
identify material difference. NFC.
Modified:
libcxx
Author: compnerd
Date: Thu Dec 3 20:14:58 2015
New Revision: 254691
URL: http://llvm.org/viewvc/llvm-project?rev=254691&view=rev
Log:
ibc++abi: mark visibility
Mark functions and types with the appropriate visibility. This is particularly
useful for environments which explicitly indicate origin
Author: compnerd
Date: Thu Dec 3 20:15:02 2015
New Revision: 254692
URL: http://llvm.org/viewvc/llvm-project?rev=254692&view=rev
Log:
.gitignore: ignore vim swap files
Modified:
libcxxabi/trunk/.gitignore
Modified: libcxxabi/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/libcxxa
Author: compnerd
Date: Thu Dec 10 00:30:23 2015
New Revision: 255225
URL: http://llvm.org/viewvc/llvm-project?rev=255225&view=rev
Log:
libclang: correct inverted logic
The complete dtor is only emitted when there is a virtual destructor. The test
itself was incorrect, so the issue in the code wa
Author: compnerd
Date: Thu Dec 10 12:45:18 2015
New Revision: 255273
URL: http://llvm.org/viewvc/llvm-project?rev=255273&view=rev
Log:
libclang: expose dllexport, dllimport attributes
These attributes were previously unexposed. Expose them through the libclang
interfaces. Add tests that cover b
Author: compnerd
Date: Fri Dec 11 00:20:59 2015
New Revision: 255328
URL: http://llvm.org/viewvc/llvm-project?rev=255328&view=rev
Log:
Driver: add multilibs for ARM EB
This improves the coverage for the multilib directories used for ARM. Also add
tests covering the internal triple (thumbv7-*).
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_person
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_person
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_person
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
&Opts, ArgList &Args,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one w
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
&Opts, ArgList &Args,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one w
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
&Opts, ArgList &Args,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one w
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
&Opts, ArgList &Args,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one w
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/95648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -365,7 +365,12 @@ int DwarfInstructions::stepWithDwarf(A
&addressSpace, pint_t pc,
// Return address is address after call site instruction, so setting IP
to
// that does simulates a return.
- newRegisters.setIP(returnAddress);
+ //
+ // In case
@@ -365,7 +365,12 @@ int DwarfInstructions::stepWithDwarf(A
&addressSpace, pint_t pc,
// Return address is address after call site instruction, so setting IP
to
// that does simulates a return.
- newRegisters.setIP(returnAddress);
+ //
+ // In case
@@ -365,7 +365,12 @@ int DwarfInstructions::stepWithDwarf(A
&addressSpace, pint_t pc,
// Return address is address after call site instruction, so setting IP
to
// that does simulates a return.
- newRegisters.setIP(returnAddress);
+ //
+ // In case
@@ -365,7 +365,12 @@ int DwarfInstructions::stepWithDwarf(A
&addressSpace, pint_t pc,
// Return address is address after call site instruction, so setting IP
to
// that does simulates a return.
- newRegisters.setIP(returnAddress);
+ //
+ // In case
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/106369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -484,8 +519,10 @@ static bool initTargetOptions(DiagnosticsEngine &Diags,
Entry.Group == frontend::IncludeDirGroup::System))
Options.MCOptions.IASSearchPaths.push_back(
Entry.IgnoreSysRoot ? Entry.Path : HSOpts.Sysroot + Entry.Path);
- Options.MCOpt
compnerd wrote:
Please also get a sign off from @aganea
https://github.com/llvm/llvm-project/pull/106369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep {
llvm::Value *EmitIvarOffset(CodeGenFunction &CGF,
const ObjCInterfaceDecl *Interface,
const ObjCIvarDecl *Ivar) override {
-const std::string
https://github.com/compnerd approved this pull request.
Might be nice to clean this up in the future but hen Microsoft releases a fix.
https://github.com/llvm/llvm-project/pull/102681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/102681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/102664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -572,6 +572,13 @@ class TagTableInfo
ReleaseOpLength - 1);
Data += ReleaseOpLength - 1;
}
+unsigned ConformsToLength =
+endian::readNext(Data);
+if (ConformsToLength > 0) {
compnerd wrote:
``
@@ -1230,6 +1231,12 @@ class TagTableInfo : public
CommonTypeTableInfo {
} else {
writer.write(0);
}
+if (auto ConformsTo = TI.SwiftConformsTo) {
+ writer.write(ConformsTo->size() + 1);
+ OS.write(ConformsTo->c_str(), ConformsTo->size());
--
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/102664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -858,6 +867,62 @@ void APINotesWriter::Implementation::writeCXXMethodBlock(
}
}
+namespace {
+/// Used to serialize the on-disk C field table.
+class FieldTableInfo
+: public VersionedTableInfo
{
+public:
+ unsigned getKeyLength(key_type_ref) {
+return sizeof(ui
@@ -1252,6 +1282,81 @@ bool APINotesReader::Implementation::readCXXMethodBlock(
return false;
}
+bool APINotesReader::Implementation::readFieldBlock(
+llvm::BitstreamCursor &Cursor, llvm::SmallVectorImpl &Scratch) {
+ if (Cursor.EnterSubBlock(FIELD_BLOCK_ID))
+retur
@@ -793,6 +827,16 @@ class YAMLConverter {
SwiftVersion);
}
+ template
+ void convertVariable(const T &Entity, VariableInfo &VI) {
compnerd wrote:
I think that `computeVariableInfo` seems better - we are "hydrating" the
variable
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/104088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
This seems like a step in the right direction - avoiding custom targets is
generally better.
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -501,6 +501,10 @@ add_header_target("windows-resource-headers"
${windows_only_files})
add_header_target("utility-resource-headers" ${utility_files})
get_clang_resource_dir(header_install_dir SUBDIR include)
+target_include_directories(clang-resource-headers INTERFACE
+ $
https://github.com/compnerd approved this pull request.
Thanks, this seems good!
https://github.com/llvm/llvm-project/pull/88317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -157,6 +158,36 @@ declaration kind), all of which are optional:
- Class: NSBundle
SwiftName: Bundle
+:SwiftImportAs:
+
+ For a class, possible values are ``owned`` (equivalent to
+ ``SWIFT_SELF_CONTAINED``), ``reference`` (equivalent to
compnerd
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/95162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -157,6 +158,36 @@ declaration kind), all of which are optional:
- Class: NSBundle
SwiftName: Bundle
+:SwiftImportAs:
+
+ For a class, possible values are ``owned`` (equivalent to
+ ``SWIFT_SELF_CONTAINED``), ``reference`` (equivalent to
+ ``SWIFT_SHARED_REFEREN
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/95162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/95320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd wrote:
@zmodem - they are aliases after all. I think that core logic being tested is
sufficient. I can see the value in testing that the flags are honoured, but the
tests would be of low value IMO. They just test the flags are listed.
https://github.com/llvm/llvm-project/pull/95320
__
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/95979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
Approving it in case it needs to be merged, but I think that we should try to
determine how it is breaking. This change feels like it should be correct and
is a pretty good cleanup, so I would prefer that fix forward rather than revert.
h
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) {
if (auto TagContext = dyn_cast(D->getDeclContext())) {
if (auto CXXMethod = dyn_cast(D)) {
- for (auto Reader : APINotes.findAPINotes(D->getLocation())) {
-if (auto Context = UnwindTagContext(TagC
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) {
if (auto TagContext = dyn_cast(D->getDeclContext())) {
if (auto CXXMethod = dyn_cast(D)) {
- for (auto Reader : APINotes.findAPINotes(D->getLocation())) {
-if (auto Context = UnwindTagContext(TagC
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) {
if (auto TagContext = dyn_cast(D->getDeclContext())) {
if (auto CXXMethod = dyn_cast(D)) {
- for (auto Reader : APINotes.findAPINotes(D->getLocation())) {
-if (auto Context = UnwindTagContext(TagC
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/101001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/101069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,7 +10,7 @@
// on AIX. Option -O3 is required so that the compiler will re-use the value
// in the condition register instead of re-evaluating the condition expression.
-// REQUIRES: target=powerpc{{(64)?}}-ibm-aix
+// REQUIRES: target={{.+}}-aix{{.*}}
c
@@ -9,7 +9,7 @@
// Check that the PowerPC vector registers are restored properly during
// unwinding. Option -mabi=vec-extabi is required to compile the test case.
-// REQUIRES: target=powerpc{{(64)?}}-ibm-aix
+// REQUIRES: target={{.+}}-aix{{.*}}
compnerd wro
@@ -6,7 +6,7 @@
//
//===--===//
-// REQUIRES: target={{powerpc.*-ibm-aix.*}}
+// REQUIRES: target={{.+}}-aix{{.*}}
compnerd wrote:
Why remove the vendor in the vendor specific directory?
ht
801 - 900 of 1057 matches
Mail list logo
