Re: r299774 - Sema: prevent __declspec(naked) use on x64

2017-04-07 Thread Saleem Abdulrasool via cfe-commits
Majnemer via cfe-commits" > > wrote: > > > > > > > > On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits > > wrote: > >> > >> On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via cfe-commits > >> wrote: > >>

r299800 - Toolchains: remove crtbegin on xwindows

2017-04-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 7 15:47:06 2017 New Revision: 299800 URL: http://llvm.org/viewvc/llvm-project?rev=299800&view=rev Log: Toolchains: remove crtbegin on xwindows crtbegin is not really a proper windows support thing. This was duplicated when the toolchain was initially built. If th

[libunwind] r292720 - config: clean up some of the macro definition

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 10:22:53 2017 New Revision: 292720 URL: http://llvm.org/viewvc/llvm-project?rev=292720&view=rev Log: config: clean up some of the macro definition Unify the definition of `_LIBUNWIND_LOG_NON_ZERO` to make it clear what it is defined to and make the definition unc

[libunwind] r292721 - DWARF: convert error logs to _LIBUNWIND_LOG

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 10:22:55 2017 New Revision: 292721 URL: http://llvm.org/viewvc/llvm-project?rev=292721&view=rev Log: DWARF: convert error logs to _LIBUNWIND_LOG Use the `_LIBUNWIND_LOG` macro instead of the explicit `fprintf` call. NFC. Modified: libunwind/trunk/src/DwarfPa

[libunwind] r292719 - rename OtherAddressSpace to RemoteAddressSpace; NFC

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 10:22:46 2017 New Revision: 292719 URL: http://llvm.org/viewvc/llvm-project?rev=292719&view=rev Log: rename OtherAddressSpace to RemoteAddressSpace; NFC Modified: libunwind/trunk/src/AddressSpace.hpp libunwind/trunk/src/libunwind.cpp Modified: libunwind/

[libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 10:22:59 2017 New Revision: 292723 URL: http://llvm.org/viewvc/llvm-project?rev=292723&view=rev Log: X86: swap EBP, ESP on !APPLE Restore the `libunwind.h` enumeration values back to the inverted values. This diverges from the DWARF definition of the register va

[libunwind] r292722 - DWARF: allow enabling tracing at runtime

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 10:22:57 2017 New Revision: 292722 URL: http://llvm.org/viewvc/llvm-project?rev=292722&view=rev Log: DWARF: allow enabling tracing at runtime Introduce `logDWARF` and the associated environment variable `LIBUNWIND_PRINT_DWARF` to trace the CFI instructions. Modi

[libunwind] r292728 - DWARF: correct cast (NFC)

2017-01-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 21 15:27:29 2017 New Revision: 292728 URL: http://llvm.org/viewvc/llvm-project?rev=292728&view=rev Log: DWARF: correct cast (NFC) Change the case of a PRIu64 value from `long` to `uint64_t`. NFC. Modified: libunwind/trunk/src/DwarfParser.hpp Modified: libunwi

[libcxxabi] r292963 - cxa_demangle: avoid butchering the last parameter type

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 12:42:56 2017 New Revision: 292963 URL: http://llvm.org/viewvc/llvm-project?rev=292963&view=rev Log: cxa_demangle: avoid butchering the last parameter type Fix an off-by-one case which would destroy the final parameter in a CV-qualified function type with a refer

[libcxxabi] r292973 - cxa_demangle: fix rvalue ref check

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 13:57:05 2017 New Revision: 292973 URL: http://llvm.org/viewvc/llvm-project?rev=292973&view=rev Log: cxa_demangle: fix rvalue ref check When checking if the type is a r-value ref, we would not do a complete check. This would result in us treating a trailing para

[libunwind] r293008 - DWARF: fix -Asserts builds

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 20:27:45 2017 New Revision: 293008 URL: http://llvm.org/viewvc/llvm-project?rev=293008&view=rev Log: DWARF: fix -Asserts builds no-op the DWARF tracing macros in non-debug builds. Modified: libunwind/trunk/src/DwarfParser.hpp libunwind/trunk/src/config.h

Re: [libunwind] r292722 - DWARF: allow enabling tracing at runtime

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
his work? > > Thanks, > Oliver > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Saleem Abdulrasool via cfe-commits > > Sent: 21 January 2017 16:23 > > To: cfe-commits@lists.llvm.org

Re: Add warning for c++ member variable shadowing

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code. The ignore warning comments are restating what is in the code, please remove them. C

r293014 - Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 24 21:36:28 2017 New Revision: 293014 URL: http://llvm.org/viewvc/llvm-project?rev=293014&view=rev Log: Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions and then later disable ARC wit

[libunwind] r293257 - Revert "DWARF: convert error logs to _LIBUNWIND_LOG"

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 26 20:26:52 2017 New Revision: 293257 URL: http://llvm.org/viewvc/llvm-project?rev=293257&view=rev Log: Revert "DWARF: convert error logs to _LIBUNWIND_LOG" This reverts SVN r292721. Avoid the use of the GNU extension as the preprocessor in C++11 mode requires at l

Re: [libunwind] r292721 - DWARF: convert error logs to _LIBUNWIND_LOG

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
projects/libunwind/src/config.h:90:41: error: token pasting of > > ',' and __VA_ARGS__ is a GNU extension > > [-Werror,-Wgnu-zero-variadic-macro-arguments] > > fprintf(stderr, "libunwind: " msg "\n", ##__VA_ARGS__) > > > > On Sat, Jan 21, 2017 at

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
n 21, 2017 at 8:22 AM, Saleem Abdulrasool via cfe-commits > wrote: > > Author: compnerd > > Date: Sat Jan 21 10:22:59 2017 > > New Revision: 292723 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=292723&view=rev > > Log: > > X86: swap EBP, ESP

[libcxx] r293439 - config: prevent the re-definition of a macro

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 12:16:33 2017 New Revision: 293439 URL: http://llvm.org/viewvc/llvm-project?rev=293439&view=rev Log: config: prevent the re-definition of a macro This causes unnecessary warnings when building with `cl`. Newer versions of the C standard permit the redefinition o

[libcxx] r293445 - experimental: remove dead function

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 16:31:28 2017 New Revision: 293445 URL: http://llvm.org/viewvc/llvm-project?rev=293445&view=rev Log: experimental: remove dead function This template was defined inline, within the TU only and had no uses across the entire repository. Remove the dead code. NFC.

[libcxx] r293449 - experimental: tolerate the existence of a `__deref` macro

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 18:15:47 2017 New Revision: 293449 URL: http://llvm.org/viewvc/llvm-project?rev=293449&view=rev Log: experimental: tolerate the existence of a `__deref` macro Microsoft's SAL has a `__deref` macro which results in a compilation failure when building the filesyste

[libcxx] r293450 - experimental: inline single use of a typedef

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 18:15:50 2017 New Revision: 293450 URL: http://llvm.org/viewvc/llvm-project?rev=293450&view=rev Log: experimental: inline single use of a typedef The typedef is not particularly long, and used in exactly one location. Just spell it out at the site. NFC. Modifie

[libcxx] r293454 - experimental: remove some extraneous _LIBCPP_FUNC_VIS

2017-01-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jan 29 21:58:26 2017 New Revision: 293454 URL: http://llvm.org/viewvc/llvm-project?rev=293454&view=rev Log: experimental: remove some extraneous _LIBCPP_FUNC_VIS These member functions were decorated with `_LIBCPP_FUNC_VIS` when the class is also decorated with external

[libcxx] r293530 - experimental: add missing file header

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 12:50:32 2017 New Revision: 293530 URL: http://llvm.org/viewvc/llvm-project?rev=293530&view=rev Log: experimental: add missing file header The directory_iterator implementation file was missing the file header. Add one. NFC. Modified: libcxx/trunk/src/exper

[libcxx] r293531 - experimental: port directory_iterator to Windows

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 12:50:34 2017 New Revision: 293531 URL: http://llvm.org/viewvc/llvm-project?rev=293531&view=rev Log: experimental: port directory_iterator to Windows This adds a basic first cut implementation for directory_iterator on Windows. It uses the FindFirstFile/FindNext

[libcxx] r293543 - experimental: avoid using raw _WIN32 in filesystem

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 13:57:27 2017 New Revision: 293543 URL: http://llvm.org/viewvc/llvm-project?rev=293543&view=rev Log: experimental: avoid using raw _WIN32 in filesystem Use the _LIBCPP_WIN32API macro instead of _WIN32 checks. Fix a missed renaming for style conformance. Modifie

r293556 - Serialization: use range based for loop (NFC)

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jan 30 16:25:28 2017 New Revision: 293556 URL: http://llvm.org/viewvc/llvm-project?rev=293556&view=rev Log: Serialization: use range based for loop (NFC) Just a small clean up noticed when doing post-commit review of Duncan's previous change for ModuleFile memory owners

Re: Add warning for c++ member variable shadowing

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
I think that the patch is starting to look pretty good! Can you add some test cases for the particular cases to diagnose in a separate test set to ensure that we have proper coverage of the various cases rather than relying on the existing test cases? Something to make sure that we get the simple

Re: [libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
Can you file a PR for changing this to internal visibility please? I think that we could probably do that in the unstable ABI versioning in fact. On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bogner > Date: Mon Jan 30 19:26:09 2017

Re: Add warning for c++ member variable shadowing

2017-01-31 Thread Saleem Abdulrasool via cfe-commits
Hmm, the braces in the if (bases.find(...)...) are not needed. Could you also add a test case for virtual inheritance? On Mon, Jan 30, 2017 at 8:34 PM, James Sun wrote: > Hi Saleem > > > > Thanks for the quick response. A test case is added. It covers some > ordinary cases as well as corner cas

r293867 - CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC)

2017-02-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Feb 1 23:45:43 2017 New Revision: 293867 URL: http://llvm.org/viewvc/llvm-project?rev=293867&view=rev Log: CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC) Drive by cleanup noticed while investigating an IR verifier assertion. Modified: cfe/trunk/lib/CodeGen

[libcxx] r294127 - filesystem: fix n4100 conformance for `temp_directory_path`

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 11:21:52 2017 New Revision: 294127 URL: http://llvm.org/viewvc/llvm-project?rev=294127&view=rev Log: filesystem: fix n4100 conformance for `temp_directory_path` N4100 states that an error shall be reported if `!exists(p) || !is_directory(p)`. We were missing the

r294148 - Basic: match GCC behaviour for SuS macro

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 16:18:15 2017 New Revision: 294148 URL: http://llvm.org/viewvc/llvm-project?rev=294148&view=rev Log: Basic: match GCC behaviour for SuS macro GCC does not generate `__unix` nor `unix` macros. The latter already intrudes into the user's namespace and should be av

[libcxx] r294171 - Refer to _LIBCPP_MSVC macro where applicable

2017-02-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 5 23:26:49 2017 New Revision: 294171 URL: http://llvm.org/viewvc/llvm-project?rev=294171&view=rev Log: Refer to _LIBCPP_MSVC macro where applicable Replace preprocess conditions of defined(_MSC_VER) && !defined(__clang__) with defined(_LIBCPP_MSVC). NFC. Patch by

[libcxx] r294270 - filesystem: return the constructed object

2017-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 6 20:46:59 2017 New Revision: 294270 URL: http://llvm.org/viewvc/llvm-project?rev=294270&view=rev Log: filesystem: return the constructed object This really should get identified properly by the compiler to convert to a NVRO, but compress the code anyways. This ma

r294332 - Revert "Basic: match GCC behaviour for SuS macro"

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 7 13:00:06 2017 New Revision: 294332 URL: http://llvm.org/viewvc/llvm-project?rev=294332&view=rev Log: Revert "Basic: match GCC behaviour for SuS macro" This reverts commit SVN r294148. Seems that it was mistaken, and GCC does still define `__unix` and `unix` when

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs wrote: > > > On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: > >> Don't use the cast for the check, use isa. Although, since you use the >> value later, it is probably better to write this as: >&g

r294401 - Sema: add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 7 21:30:13 2017 New Revision: 294401 URL: http://llvm.org/viewvc/llvm-project?rev=294401&view=rev Log: Sema: add warning for c++ member variable shadowing Add a warning for shadowed variables across records. Referencing a shadow'ed variable may not give the desire

r306347 - AST: enhance mangling for blocks with MS ABI

2017-06-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Jun 26 16:28:42 2017 New Revision: 306347 URL: http://llvm.org/viewvc/llvm-project?rev=306347&view=rev Log: AST: enhance mangling for blocks with MS ABI When generating the decorated name for a static variable inside a BlockDecl, construct a scope for the block invocati

Re: r306127 - [GSoC] Add support for CC1 options.

2017-06-26 Thread Saleem Abdulrasool via cfe-commits
I think that we shouldn't be providing completion for `-cc1` options. `-cc1as` options are fine as the IAS serves as a replacement for the traditional unix `as`. But, the `NoDriverOption` values shouldn't be exposed to users. They are internal details, with no compatibility. If users start usin

r306444 - CodeGen: load indirect ObjC ARC arguments in prologue

2017-06-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 27 11:37:51 2017 New Revision: 306444 URL: http://llvm.org/viewvc/llvm-project?rev=306444&view=rev Log: CodeGen: load indirect ObjC ARC arguments in prologue When generating a prologue, add loads for ARC arguments passed indirectly. Patch by Dave Lee! Added: c

r306447 - test: fix test for release builds

2017-06-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 27 11:57:50 2017 New Revision: 306447 URL: http://llvm.org/viewvc/llvm-project?rev=306447&view=rev Log: test: fix test for release builds Use a regex capture to avoid hardcoding the name. This should repair the failing buildbot. Modified: cfe/trunk/test/CodeGe

r306622 - CodeGen: handle missed case of COMDAT handling

2017-06-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Jun 28 17:54:44 2017 New Revision: 306622 URL: http://llvm.org/viewvc/llvm-project?rev=306622&view=rev Log: CodeGen: handle missed case of COMDAT handling When Protocol references are constructed, we need to add the reference symbol to a COMDAT group on non-MachO object

r306830 - Driver: fix option declaration

2017-06-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 30 08:15:39 2017 New Revision: 306830 URL: http://llvm.org/viewvc/llvm-project?rev=306830&view=rev Log: Driver: fix option declaration The option is a "joined" argument. Fix silly copy-paste error. This allows the parsing to work at runtime. Modified: cfe/tru

r306829 - Driver: honor -nostdinc and -isystem-after on CrossWindows

2017-06-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jun 30 08:15:38 2017 New Revision: 306829 URL: http://llvm.org/viewvc/llvm-project?rev=306829&view=rev Log: Driver: honor -nostdinc and -isystem-after on CrossWindows This changes CrossWindows to look for -nostdinc instead of -nostdlibinc. In addition, fixes a bug where

r309226 - Headers: improve ARM EHABI coverage of unwind.h

2017-07-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Jul 26 15:55:23 2017 New Revision: 309226 URL: http://llvm.org/viewvc/llvm-project?rev=309226&view=rev Log: Headers: improve ARM EHABI coverage of unwind.h Ensure that we define the `_Unwind_Control_Block` structure used on ARM EHABI targets. This is needed for buildin

r309327 - Headers: fix _Unwind_{G,S}etGR for non-EHABI targets

2017-07-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jul 27 14:56:25 2017 New Revision: 309327 URL: http://llvm.org/viewvc/llvm-project?rev=309327&view=rev Log: Headers: fix _Unwind_{G,S}etGR for non-EHABI targets The EHABI definition was being inlined into the users even when EHABI was not in use. Adjust the condition t

r323225 - test: adjust the target for some Windows tests

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 09:05:57 2018 New Revision: 323225 URL: http://llvm.org/viewvc/llvm-project?rev=323225&view=rev Log: test: adjust the target for some Windows tests The tests are targeting Windows but do not specify an environment. When executed on Linux, they would use an ELF o

r323230 - test: simplify the matching logic a bit (NFC)

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 09:57:04 2018 New Revision: 323230 URL: http://llvm.org/viewvc/llvm-project?rev=323230&view=rev Log: test: simplify the matching logic a bit (NFC) Use CHECK-SAME directives to simplify the test conditions a bit. This makes it easier to see what is being checked.

r323241 - AST: adjust ObjC MS mangling to work with typedefs

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 11:17:25 2018 New Revision: 323241 URL: http://llvm.org/viewvc/llvm-project?rev=323241&view=rev Log: AST: adjust ObjC MS mangling to work with typedefs Rather than hardcode the pointerness of the `id` and `class` types, handle them generically. This allows for t

r323247 - CodeGen: use `llvm.used` for ObjC protocols

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 11:35:51 2018 New Revision: 323247 URL: http://llvm.org/viewvc/llvm-project?rev=323247&view=rev Log: CodeGen: use `llvm.used` for ObjC protocols These symbols are supposed to be preserved even by the linker. Use the `llvm.used` to ensure that the symbols are not

r323257 - AST: correct mangling for SEL on MS ABI

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 12:56:52 2018 New Revision: 323257 URL: http://llvm.org/viewvc/llvm-project?rev=323257&view=rev Log: AST: correct mangling for SEL on MS ABI We would previously treat `SEL` as a pointer-only type. This is not the case. It should be treated similarly to `id` and

r323461 - AST: inline a single-use variable (NFC)

2018-01-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 25 11:54:31 2018 New Revision: 323461 URL: http://llvm.org/viewvc/llvm-project?rev=323461&view=rev Log: AST: inline a single-use variable (NFC) Inline the single use variable into the only use. NFC. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp Modified: cf

r323547 - AST: support protocol conformances on id/class/interfaces in MS ABI

2018-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jan 26 11:08:26 2018 New Revision: 323547 URL: http://llvm.org/viewvc/llvm-project?rev=323547&view=rev Log: AST: support protocol conformances on id/class/interfaces in MS ABI Add support for mangling ObjC protocol conformances in MS ABI as if they are COM interfaces. B

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2018-01-30 Thread Saleem Abdulrasool via cfe-commits
undles), but we haven’t had the time to implement the fix. > Feel free to fix the bug if you’d like to do so. > > > On Feb 11, 2017, at 1:34 PM, Saleem Abdulrasool via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: compnerd > > Date: Sat Feb 11 1

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2018-02-02 Thread Saleem Abdulrasool via cfe-commits
ning an object and the >> call to objc_retainAutoreleasedReturnValue. We probably should find a way to >> prevent inserting instructions between the calls (maybe using instruction >> bundles), but we haven’t had the time to implement the fix. Feel free to fix >> the bug

[libcxx] r294698 - __threading_support: fix windows build

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 9 20:49:52 2017 New Revision: 294698 URL: http://llvm.org/viewvc/llvm-project?rev=294698&view=rev Log: __threading_support: fix windows build The build was broken as there was no overload for long and std::chrono::nanoseconds. Add an explicit conversion to use the

[libcxx] r294705 - docs: add some documentation for building on Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 9 21:58:20 2017 New Revision: 294705 URL: http://llvm.org/viewvc/llvm-project?rev=294705&view=rev Log: docs: add some documentation for building on Windows This covers how to build libc++ for Windows. This allows others to replicate the MS ABI style build for libc

[libcxx] r294716 - test: allow -target usage on Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:24:34 2017 New Revision: 294716 URL: http://llvm.org/viewvc/llvm-project?rev=294716&view=rev Log: test: allow -target usage on Windows When running the tests on Windows with a debug build, _DEBUG must be added to the flags prior to the -target as the forced in

[libcxx] r294720 - test: XFAIL windows for non-portable test

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:51:21 2017 New Revision: 294720 URL: http://llvm.org/viewvc/llvm-project?rev=294720&view=rev Log: test: XFAIL windows for non-portable test This test validates that the lock_guard is declared variadically across C++03 and C++11. Given the lack of stable ABI o

[libcxx] r294719 - test: fix test under Windows

2017-02-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 10 00:51:19 2017 New Revision: 294719 URL: http://llvm.org/viewvc/llvm-project?rev=294719&view=rev Log: test: fix test under Windows When running the test under clang-cl, we do not report `__GNUC__`, which is needed to supress the warnings which are being treated as

r294853 - Sema: simplify conditional execution (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:04 2017 New Revision: 294853 URL: http://llvm.org/viewvc/llvm-project?rev=294853&view=rev Log: Sema: simplify conditional execution (NFC) The conditional cast is unnecessary since we know that it will always succeed. NFC. Modified: cfe/trunk/lib/Sema/

r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:09 2017 New Revision: 294855 URL: http://llvm.org/viewvc/llvm-project?rev=294855&view=rev Log: docs: update docs for objc_storeStrong behaviour objc_storeStrong does not return a value. Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst cfe/tr

r294854 - CodeGen: rename variables to adhere to naming convention

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:07 2017 New Revision: 294854 URL: http://llvm.org/viewvc/llvm-project?rev=294854&view=rev Log: CodeGen: rename variables to adhere to naming convention Adjust style before making more intrusive changes. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp

Re: r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Hi Hans, Would you mind grabbing this for the 4.0 release as well? It's merely correcting the documentation, so should have no impact on the toolchain itself. On Sat, Feb 11, 2017 at 9:24 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compne

r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:18 2017 New Revision: 294872 URL: http://llvm.org/viewvc/llvm-project?rev=294872&view=rev Log: CodeGen: annotate ObjC ARC functions with ABI constraints Certain ARC runtime functions have an ABI contract of being forwarding. Annotate the functions with the

r294871 - test: ignore some warnings in test code (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:15 2017 New Revision: 294871 URL: http://llvm.org/viewvc/llvm-project?rev=294871&view=rev Log: test: ignore some warnings in test code (NFC) Silence some diagnostics which clang now generates. This makes it easier to see the failures in lit output. NFC.

r294877 - CodeGen: use # as the comment leader for ARC marker

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 17:03:13 2017 New Revision: 294877 URL: http://llvm.org/viewvc/llvm-project?rev=294877&view=rev Log: CodeGen: use # as the comment leader for ARC marker Use # as the comment leader for AArch64 auto-release elision marker. This is to keep it in sync with the value

[libcxx] r294899 - cmath: adjust math forwards for Windows

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 10:44:17 2017 New Revision: 294899 URL: http://llvm.org/viewvc/llvm-project?rev=294899&view=rev Log: cmath: adjust math forwards for Windows The newer versions of ucrt have the math routines. Use the CRT version to determine if we should include the math routine

[libcxx] r294901 - test: squelch -Wreturn-type error

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:44 2017 New Revision: 294901 URL: http://llvm.org/viewvc/llvm-project?rev=294901&view=rev Log: test: squelch -Wreturn-type error Add an unreachable marker to avoid a -Wreturn-type error when building on Windows. Modified: libcxx/trunk/test/std/utilitie

[libcxx] r294903 - test: mark requirement for pthread test

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:48 2017 New Revision: 294903 URL: http://llvm.org/viewvc/llvm-project?rev=294903&view=rev Log: test: mark requirement for pthread test This test explicitly is checking the behaviour of std::thread and pthread interactions. This requires pthreads. Add an a

[libcxx] r294902 - math: pull more C functions from std

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 11:37:45 2017 New Revision: 294902 URL: http://llvm.org/viewvc/llvm-project?rev=294902&view=rev Log: math: pull more C functions from std The newer ucrt version provides the gamma meth routines. Includede them when building the library. Modified: libcxx/tru

[libcxx] r294918 - math: follow up to SVN r294902

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 15:42:37 2017 New Revision: 294918 URL: http://llvm.org/viewvc/llvm-project?rev=294918&view=rev Log: math: follow up to SVN r294902 Pull in the math functions from ucrt 14+ after auditing the library. It seems that they are now complete for C99 math. Fixes more

[libcxx] r294917 - test: use char32_t rather than wchar_t

2017-02-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 12 15:42:35 2017 New Revision: 294917 URL: http://llvm.org/viewvc/llvm-project?rev=294917&view=rev Log: test: use char32_t rather than wchar_t wchar_t is not as portable as char32_t. On Windows, wchar_t is 16-bytes and on Linux 32-bits. The conversion to utf8 caus

[libcxx] r294956 - test: mark another test as requiring pthreads

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:47 2017 New Revision: 294956 URL: http://llvm.org/viewvc/llvm-project?rev=294956&view=rev Log: test: mark another test as requiring pthreads This is checking pthread specific behaviour. Add a requirement on pthreads. Modified: libcxx/trunk/test/libcx

[libcxx] r294957 - math: actually pull the declarations/overloads into std

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:50 2017 New Revision: 294957 URL: http://llvm.org/viewvc/llvm-project?rev=294957&view=rev Log: math: actually pull the declarations/overloads into std The previous changes missed the change to include/cmath. These changes allow some of the rand.distributio

[libcxx] r294958 - config: disable thread safety analysis on COFF

2017-02-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 13 09:26:51 2017 New Revision: 294958 URL: http://llvm.org/viewvc/llvm-project?rev=294958&view=rev Log: config: disable thread safety analysis on COFF clang cannot properly handle __declspec and __attribute__ on classes right now. This prevents the shared_mutex tes

[libcxx] r295330 - math: correct the MSVCRT condition

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:50 2017 New Revision: 295330 URL: http://llvm.org/viewvc/llvm-project?rev=295330&view=rev Log: math: correct the MSVCRT condition Fixes a number of tests in the testsuite on Windows. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h

[libcxx] r295329 - threading_support: make __thread_sleep_for be alertable

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:45 2017 New Revision: 295329 URL: http://llvm.org/viewvc/llvm-project?rev=295329&view=rev Log: threading_support: make __thread_sleep_for be alertable On Windows, we were using `Sleep` which is not alertable. This means that if the thread was used for a us

[libcxx] r295511 - test: prevent incorrect quoting of paths

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:46 2017 New Revision: 295511 URL: http://llvm.org/viewvc/llvm-project?rev=295511&view=rev Log: test: prevent incorrect quoting of paths The path would previously get an extra leading space as the arguments would be parsed when generating the final command t

[libcxx] r295509 - cmath: Use c99 math on a new enough msvcrt

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:42 2017 New Revision: 295509 URL: http://llvm.org/viewvc/llvm-project?rev=295509&view=rev Log: cmath: Use c99 math on a new enough msvcrt MSVCRT 14+ supports the C99 math routines that we need. Use them accordingly. Modified: libcxx/trunk/include/cmat

[libcxx] r295510 - math: fix typo in macro

2017-02-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 17 17:08:44 2017 New Revision: 295510 URL: http://llvm.org/viewvc/llvm-project?rev=295510&view=rev Log: math: fix typo in macro MAJOR was misspelt as NAJOR. Fix the spelling. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h Modified: libcx

[libcxx] r295561 - Revert "threading_support: make __thread_sleep_for be alertable"

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:43 2017 New Revision: 295561 URL: http://llvm.org/viewvc/llvm-project?rev=295561&view=rev Log: Revert "threading_support: make __thread_sleep_for be alertable" This reverts SVN r295329. Although `__libcpp_thread_sleep_for` should be alertable, the implemen

[libcxx] r295559 - math: add type promoting template definition on MSVCRT

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:38 2017 New Revision: 295559 URL: http://llvm.org/viewvc/llvm-project?rev=295559&view=rev Log: math: add type promoting template definition on MSVCRT When building with MSVCRT, we need to manually provide the type promoting overloads to allow the correct ty

[libcxx] r295558 - test: explicitly size enumeration

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:36 2017 New Revision: 295558 URL: http://llvm.org/viewvc/llvm-project?rev=295558&view=rev Log: test: explicitly size enumeration On certain targets, enumerations may be smaller than an `unsigned long`. Use an explicitly sized enumeration. Modified: lib

[libcxx] r295560 - test: silence warnings on clang under clang-cl

2017-02-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 18 13:28:41 2017 New Revision: 295560 URL: http://llvm.org/viewvc/llvm-project?rev=295560&view=rev Log: test: silence warnings on clang under clang-cl When running under clang-cl mode, we do not define `__GNUC__`, resulting in the test failing. Modified: libcxx

r295620 - Driver: inline a single caller of a function (NFC)

2017-02-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Feb 19 15:50:40 2017 New Revision: 295620 URL: http://llvm.org/viewvc/llvm-project?rev=295620&view=rev Log: Driver: inline a single caller of a function (NFC) Inline the addCompilerRT call to the single caller. NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modifi

r295683 - Sema: use PropertyDecl for property selector

2017-02-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Feb 20 17:45:49 2017 New Revision: 295683 URL: http://llvm.org/viewvc/llvm-project?rev=295683&view=rev Log: Sema: use PropertyDecl for property selector Using the constructed name for the class properties with dot syntax may yield an inappropriate selector (i.e. if it i

r296769 - Serialization: use the PCH chain to check PCH mode

2017-03-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Mar 2 11:37:11 2017 New Revision: 296769 URL: http://llvm.org/viewvc/llvm-project?rev=296769&view=rev Log: Serialization: use the PCH chain to check PCH mode When we are deciding whether we are creating a PCH or a module, we would check if the ModuleMgr had any element

[libunwind] r297291 - DARWF: silence some warnings about conversions

2017-03-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Mar 8 10:03:27 2017 New Revision: 297291 URL: http://llvm.org/viewvc/llvm-project?rev=297291&view=rev Log: DARWF: silence some warnings about conversions Add a check for an overflow and explicitly cast the value. We would have silently overflowed previously. Modified

[libunwind] r297744 - DarwinParser: include limits

2017-03-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Mar 14 10:17:55 2017 New Revision: 297744 URL: http://llvm.org/viewvc/llvm-project?rev=297744&view=rev Log: DarwinParser: include limits In debug mode, we have assertions that the values do not exceed the limits of the type holding them. In order to account for the typ

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

2016-11-15 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7669 +// Fix a TSK_ExplicitInstantiationDeclaration or a TSK_ImplicitInstantiation +// followed by a TSK_ExplicitInstantiationDefinition +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || ---

r287238 - Sema: correct typo correction for ivars in @implementation

2016-11-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Nov 17 11:10:54 2016 New Revision: 287238 URL: http://llvm.org/viewvc/llvm-project?rev=287238&view=rev Log: Sema: correct typo correction for ivars in @implementation The previous typo correction handling assumed that ivars are only declared in the interface declaration

[libunwind] r287283 - EHABI: mark some functions as exported

2016-11-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Nov 17 17:53:35 2016 New Revision: 287283 URL: http://llvm.org/viewvc/llvm-project?rev=287283&view=rev Log: EHABI: mark some functions as exported These are part of the EHABI specification and are exported to be available to users. Mark them as `_LIBUNWIND_EXPORT` like

[libcxxabi] r287364 - __cxa_demangle: use default member initialization

2016-11-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Nov 18 13:01:53 2016 New Revision: 287364 URL: http://llvm.org/viewvc/llvm-project?rev=287364&view=rev Log: __cxa_demangle: use default member initialization Sink the Db initialization into the structure rather than out-of-line at the declaration size. This just makes

r288546 - CodeGen: export typeinfo and typeinfo name on itanium

2016-12-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Dec 2 16:46:18 2016 New Revision: 288546 URL: http://llvm.org/viewvc/llvm-project?rev=288546&view=rev Log: CodeGen: export typeinfo and typeinfo name on itanium When a C++ record is marked with dllexport mark both the typeinfo and the typeinfo name as being exported.

r288570 - Sema: delay the DLL exported member referencing

2016-12-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Dec 2 19:57:47 2016 New Revision: 288570 URL: http://llvm.org/viewvc/llvm-project?rev=288570&view=rev Log: Sema: delay the DLL exported member referencing An explicit template specialization can cause the implicit template specialization of a type which inherits the at

r288721 - CodeGen: fix windows itanium RTTI in EH mode

2016-12-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Dec 5 16:40:20 2016 New Revision: 288721 URL: http://llvm.org/viewvc/llvm-project?rev=288721&view=rev Log: CodeGen: fix windows itanium RTTI in EH mode When emitting RTTI for EH only, we would mark the locally defined (LinkOnceODR) RTTI definition as dllimport, which i

r289514 - CodeGen: clean up -Wpedantic warning (NFC)

2016-12-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Dec 12 21:27:35 2016 New Revision: 289514 URL: http://llvm.org/viewvc/llvm-project?rev=289514&view=rev Log: CodeGen: clean up -Wpedantic warning (NFC) lib/CodeGen/CGExpr.cpp:2511:2: warning: extra ';' [-Wpedantic] }; ^ Clean up warning from gcc 6. Modified:

r300908 - Parse: cleanup some bleeding whitespace

2017-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 20 17:23:07 2017 New Revision: 300908 URL: http://llvm.org/viewvc/llvm-project?rev=300908&view=rev Log: Parse: cleanup some bleeding whitespace Clean up some bleeding whitespace that I noticed. NFC Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified: cfe/tru

r300909 - Sema: protect against ObjC++ typo-correction failure

2017-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 20 17:23:10 2017 New Revision: 300909 URL: http://llvm.org/viewvc/llvm-project?rev=300909&view=rev Log: Sema: protect against ObjC++ typo-correction failure ObjC++ has two different types of "pointer" types (ObjCClassPointerType and PointerType). Both can be indire

<    1   2   3   4   5   6   7   8   9   10   >