Author: compnerd
Date: Fri Dec 30 18:00:21 2016
New Revision: 290775
URL: http://llvm.org/viewvc/llvm-project?rev=290775&view=rev
Log:
random: include __config before building
We need to include __config to ensure that we know what random
implementation is being used. Fixes compilation for Windo
Author: compnerd
Date: Sat Dec 31 11:34:26 2016
New Revision: 290785
URL: http://llvm.org/viewvc/llvm-project?rev=290785&view=rev
Log:
remove some inherited attributes on exceptions
These exception types are marked with `_LIBCPP_EXCEPTION_ABI` which
expands to `__attribute__((__visibility__("defa
Author: compnerd
Date: Sat Dec 31 12:09:51 2016
New Revision: 290788
URL: http://llvm.org/viewvc/llvm-project?rev=290788&view=rev
Log:
clean up `-Wmisleading-indentation` warning
Clean up the misleading indentation warning from GCC 6. NFC
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modi
Author: compnerd
Date: Sat Dec 31 12:13:34 2016
New Revision: 290789
URL: http://llvm.org/viewvc/llvm-project?rev=290789&view=rev
Log:
clean up some qualifier casting
This cleans up the `-Wqual-cast` warnings from gcc 6 when building
libc++. NFC.
Modified:
libcxx/trunk/include/__std_stream
Author: compnerd
Date: Sat Dec 31 15:24:04 2016
New Revision: 290791
URL: http://llvm.org/viewvc/llvm-project?rev=290791&view=rev
Log:
system_error: use strerror_r only for threaded code
When building libc++ without threading, strerror_r is not used. Define
the code only when threading is enable
Author: compnerd
Date: Sun Jan 1 13:16:02 2017
New Revision: 290799
URL: http://llvm.org/viewvc/llvm-project?rev=290799&view=rev
Log:
CodeGen: update comment about RTTI field
The MS ABI RTTI has a reserved field which is used as a cache for the
demangled name. It must be zero-initialized, which
Author: compnerd
Date: Sun Jan 1 14:20:40 2017
New Revision: 290802
URL: http://llvm.org/viewvc/llvm-project?rev=290802&view=rev
Log:
build: further improve flags handling for cl
This allows us to build with cl (or rather clang-cl) by using the
correct spelling for `-include` (`/FI` for cl). cl
Author: compnerd
Date: Sun Jan 1 14:20:43 2017
New Revision: 290804
URL: http://llvm.org/viewvc/llvm-project?rev=290804&view=rev
Log:
chrono: give Windows a steady_clock
Provide a definition for a steady monotonic clock by wrapping
QueryPerformanceCounter.
Modified:
libcxx/trunk/src/chrono.
Author: compnerd
Date: Sun Jan 1 14:20:41 2017
New Revision: 290803
URL: http://llvm.org/viewvc/llvm-project?rev=290803&view=rev
Log:
chrono: implement a Windows version of system_clock::now
system_clock::now is not entirely straight forward on Windows, which
does not have a clock_gettime functi
Author: compnerd
Date: Sun Jan 1 14:20:38 2017
New Revision: 290801
URL: http://llvm.org/viewvc/llvm-project?rev=290801&view=rev
Log:
build: dont detect libraries for Windows
Hard code the defaults for Windows for the time being. The checks
really are always going to return the same value. Tec
Author: compnerd
Date: Sun Jan 1 14:20:36 2017
New Revision: 290800
URL: http://llvm.org/viewvc/llvm-project?rev=290800&view=rev
Log:
build: differentiate between building for and on Windows
This is necessary to support cross-compiling a Windows libc++ from
Linux. The CMAKE_SYSTEM_HOST_NAME tel
Author: compnerd
Date: Sun Jan 1 16:04:38 2017
New Revision: 290806
URL: http://llvm.org/viewvc/llvm-project?rev=290806&view=rev
Log:
chrono: address post commit comments from Howard
Drawing some inspiration from code from Bill O'Neal as pointed out by
Howard, rework the code to avoid an overflo
Author: compnerd
Date: Sun Jan 1 16:04:36 2017
New Revision: 290805
URL: http://llvm.org/viewvc/llvm-project?rev=290805&view=rev
Log:
chrono: address post-commit comments from majnemer
Correct style to match libc++ style as pointed out by David Majnemer on
IRC. NFC.
Modified:
libcxx/trunk/
Thanks for the review on this! I hope you wont mind taking a look at SVN
r290806 as well which tries to address the comments.
On Sun, Jan 1, 2017 at 1:09 PM, Howard Hinnant
wrote:
> On Jan 1, 2017, at 3:20 PM, Saleem Abdulrasool via cfe-commits <
> cfe-commits@lists.llvm.o
Author: compnerd
Date: Mon Jan 2 12:41:48 2017
New Revision: 290823
URL: http://llvm.org/viewvc/llvm-project?rev=290823&view=rev
Log:
locale: update ctype access for MSVC CRT 14+
Visual C++ 14 and newer split msvcrt into msvcrt and ucrt with flavours
of the ucrt for different environments. This
Author: compnerd
Date: Mon Jan 2 12:41:50 2017
New Revision: 290824
URL: http://llvm.org/viewvc/llvm-project?rev=290824&view=rev
Log:
chrono: correct the units for the epoch bias
As pointed out by Howard, this is actually 134774 days (* 24 * 3600),
and therefore seconds, not 100ns units. Adjust
Author: compnerd
Date: Mon Jan 2 15:09:16 2017
New Revision: 290835
URL: http://llvm.org/viewvc/llvm-project?rev=290835&view=rev
Log:
win32: temporarily disable setting locale on 14+
The locale structures have been made opaque in CRT 14+. This currently
prevents building libc++ for Windows. We
Author: compnerd
Date: Mon Jan 2 15:09:19 2017
New Revision: 290836
URL: http://llvm.org/viewvc/llvm-project?rev=290836&view=rev
Log:
build: make cross-compiling to Windows work on Linux
Disable the manifest bundling on Windows when cross-compiling on
not-Windows. With this, it is possible to e
Author: compnerd
Date: Mon Jan 2 15:40:17 2017
New Revision: 290837
URL: http://llvm.org/viewvc/llvm-project?rev=290837&view=rev
Log:
build: tweak macros for Windows build
Move the windows specific macro definitions for compiling c++ into the
target. Add a number of newer options that are neces
Do we want to enable this by default on other targets under
`LIBCXX_ABI_UNSTABLE` as well?
On Mon, Jan 2, 2017 at 2:17 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Mon Jan 2 16:17:51 2017
> New Revision: 290840
>
> URL: http://llvm.org/viewvc/ll
Author: compnerd
Date: Mon Jan 2 20:00:31 2017
New Revision: 290850
URL: http://llvm.org/viewvc/llvm-project?rev=290850&view=rev
Log:
threading_support: refactor for Win32 threading
Refactor the header to allow us to implement alternate threading models
with alternate data structures. Take the
Author: compnerd
Date: Mon Jan 2 20:00:33 2017
New Revision: 290851
URL: http://llvm.org/viewvc/llvm-project?rev=290851&view=rev
Log:
system_error: provide a thread safe stringification for Windows
Provide a strerror_r replacement for Windows. This is needed to build
libc++ for Windows with thr
Author: compnerd
Date: Mon Jan 2 22:23:52 2017
New Revision: 290857
URL: http://llvm.org/viewvc/llvm-project?rev=290857&view=rev
Log:
clang-format: tweak configuration
Update the configuration to reflect the style more accurately. Pointers
are tied to the left. Braces are split on classes/stru
Author: compnerd
Date: Mon Jan 2 22:23:50 2017
New Revision: 290856
URL: http://llvm.org/viewvc/llvm-project?rev=290856&view=rev
Log:
build: remove now unused UNIX_CAT
THe previous change replaced the use of `cat` or `type` with a custom
python script. Remove the now unused command determining.
Author: compnerd
Date: Tue Jan 3 15:53:51 2017
New Revision: 290910
URL: http://llvm.org/viewvc/llvm-project?rev=290910&view=rev
Log:
clean up use of _WIN32
Replace the use of _WIN32 in libc++. Replace most use with a C runtime
check _LIBCPP_MSVCRT or the new _LIBCPP_WIN32 to indicate that we ar
Author: compnerd
Date: Tue Jan 3 19:53:24 2017
New Revision: 290924
URL: http://llvm.org/viewvc/llvm-project?rev=290924&view=rev
Log:
Refactor bitscan64 check
Introduce a `_LIBCPP_HAS_BITSCAN64` macro to specify if the 64-bit
variant of the bitscan family of APIs is available. This avoids
dupli
Author: compnerd
Date: Tue Jan 3 23:45:24 2017
New Revision: 290937
URL: http://llvm.org/viewvc/llvm-project?rev=290937&view=rev
Log:
tweak definition to avoid GCC warning
Use an `extern "C" { }` block around the definition rather than doing
the inline definition. This avoids a GCC warning abou
Author: compnerd
Date: Tue Jan 3 23:49:55 2017
New Revision: 290938
URL: http://llvm.org/viewvc/llvm-project?rev=290938&view=rev
Log:
build: use more portable spelling for flag
Use `CMAKE_LIBRARY_PATH_FLAG` instead of hard-coding it to -L. This
silences a warning with cl which expects `/LIBPATH
Author: compnerd
Date: Tue Jan 3 23:49:59 2017
New Revision: 290940
URL: http://llvm.org/viewvc/llvm-project?rev=290940&view=rev
Log:
config: MSVC 19+ has unicode chars
MSVC 19+ and clang-cl with emulation version >= 19.00 will provide
char{16,32}_t as builtin types. Adjust the configuration ac
Author: compnerd
Date: Tue Jan 3 23:49:57 2017
New Revision: 290939
URL: http://llvm.org/viewvc/llvm-project?rev=290939&view=rev
Log:
build: use the platform dependent library prefix/suffix
Use the cmake variables to get the platform dependent values for the
static library prefix and suffix, whi
Author: compnerd
Date: Tue Jan 3 23:50:01 2017
New Revision: 290941
URL: http://llvm.org/viewvc/llvm-project?rev=290941&view=rev
Log:
fix elast configuration on Windows targets
A typo and missing header inclusion was obscured by the litany of user
defined literal warnings. This fixes the detect
Author: compnerd
Date: Thu Jan 5 10:02:32 2017
New Revision: 291123
URL: http://llvm.org/viewvc/llvm-project?rev=291123&view=rev
Log:
CodeGen: plumb header search down to the IAS
inline assembly may use the `.include` directive to include other
content into the file. Without the integrated asse
Author: compnerd
Date: Thu Jan 5 10:36:15 2017
New Revision: 291125
URL: http://llvm.org/viewvc/llvm-project?rev=291125&view=rev
Log:
test: add an explicit triple
Not all targets use the integrated assembler. Specify a triple to
ensure we use the integrated as for this.
Modified:
cfe/trunk
Author: compnerd
Date: Thu Jan 5 11:09:20 2017
New Revision: 291142
URL: http://llvm.org/viewvc/llvm-project?rev=291142&view=rev
Log:
test: add a requires registered target
It seems that the ARM buildbots do not include x86 support. However,
other x86 targets do not support the ARM target. Use
Author: compnerd
Date: Thu Jan 5 11:54:45 2017
New Revision: 291145
URL: http://llvm.org/viewvc/llvm-project?rev=291145&view=rev
Log:
thread_support: split out {,non-}recursive mutex
Split out the recursive and non-recursive mutex. This split is needed
for platforms which may use differing type
Author: compnerd
Date: Thu Jan 5 15:22:22 2017
New Revision: 291174
URL: http://llvm.org/viewvc/llvm-project?rev=291174&view=rev
Log:
typeinfo: style adjustments for adding MS ABI RTTI
This is motivated by adding a third RTTI scheme to libc++. Split out
the two forms of the itanium RTTI represe
Author: compnerd
Date: Thu Jan 5 17:25:44 2017
New Revision: 291192
URL: http://llvm.org/viewvc/llvm-project?rev=291192&view=rev
Log:
config_elast: fix typo (NFC)
Missed the original typo which was duplicated. NFC.
Modified:
libcxx/trunk/src/include/config_elast.h
Modified: libcxx/trunk/s
into front end and back end
> tests and avoid using the backend in clang's test harness?
>
> Thanks!
>
> -eric
>
> On Thu, Jan 5, 2017 at 8:13 AM Saleem Abdulrasool via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: compnerd
>> Dat
Author: compnerd
Date: Thu Jan 5 20:27:40 2017
New Revision: 291208
URL: http://llvm.org/viewvc/llvm-project?rev=291208&view=rev
Log:
CodeGen: address post commit review comments for r291123
This test would force the execution of the backend. However, the
backend already has a test for this. E
module is correct via the front end if
>> you'd like. Ensuring the paths are correct is a bit of a sticky problem,
>> but this is an API boundary that we just have problems with.
>>
>> TL;DR: Would you mind splitting this test into front end and back end
>> tests a
Author: compnerd
Date: Fri Jan 6 20:48:30 2017
New Revision: 291331
URL: http://llvm.org/viewvc/llvm-project?rev=291331&view=rev
Log:
thread: implement sleep_for on Windows
Windows does not provide an implementation of `nanosleep`. Round up the
time duration to the nearest ms and use `Sleep`.
Author: compnerd
Date: Fri Jan 6 21:07:45 2017
New Revision: 291333
URL: http://llvm.org/viewvc/llvm-project?rev=291333&view=rev
Log:
provide Win32 native threading
Add an implementation for the Win32 threading model as a backing API for
the internal c++ threading interfaces. This uses the Fls*
FTR, this wasn't changed with the renaming.
But, taking a look at it does seem that it is off by one. Well spotted!
On Thu, Jan 5, 2017 at 7:16 PM David Majnemer
wrote:
> On Thu, Jan 5, 2017 at 3:25 PM, Saleem Abdulrasool via cfe-commits <
> cfe-commits@lists.llvm.org>
Author: compnerd
Date: Fri Jan 6 23:13:32 2017
New Revision: 291336
URL: http://llvm.org/viewvc/llvm-project?rev=291336&view=rev
Log:
system_error: correct ELAST emulation on Windows
ELAST should point to the last valid error string value. However,
`_sys_nerr` provides the number of elements in
wrote:
> Wouldn't it be better to introduce a __libcpp_thread_nanosleep() API call
> here?
>
> I bumped into a similar issue with a custom thread implementation and have
> a downstream patch like that.
>
> Cheers,
>
> / Asiri
>
>
> On 7 Jan 2017 2:59 a.m
;>
>> Love that you wanted to add a test for it, but I'd really prefer that you
>> not engage the backend here in order to do it. You can verify some of it
>> from the backend and just that the module is correct via the front end if
>> you'd like. Ensuring t
Just a correction on the commit message: its not Windows.h that is defining
`__out`. `__out` is a SAL keyword. Unfortunately, I don't know of a way
to disable SAL.
On Sat, Jan 7, 2017 at 3:27 AM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Sat Jan
Author: compnerd
Date: Mon Jan 9 22:18:47 2017
New Revision: 291536
URL: http://llvm.org/viewvc/llvm-project?rev=291536&view=rev
Log:
threading_support: delete the critical section
Although the CriticalSection itself doesnt need to be destroyed, there
may be debug data associated with it. Plug
compnerd added a comment.
The `Data` and `Length` fields are tied together. Wouldn't it be possible to
reorder this as `Val`, `Length`, `Data` and have it achieve similar sizes and
keep the `Data` and `Length` fields together?
https://reviews.llvm.org/D23530
__
compnerd added inline comments.
Comment at: include/clang/Basic/IdentifierTable.h:34
@@ -26,2 +33,3 @@
namespace llvm {
+
template struct DenseMapInfo;
Not sure the whitespace adds any benefit here.
Comment at: include/clang/Basic/Identifier
compnerd added a subscriber: compnerd.
Comment at: CMakeLists.txt:139
@@ -138,1 +138,3 @@
option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread
API" OFF)
+option(LIBCXX_HAS_EXTERNAL_THREAD_API
+ "Build libc++ with an externalized threading API.
-
Author: compnerd
Date: Thu Aug 18 16:40:06 2016
New Revision: 279154
URL: http://llvm.org/viewvc/llvm-project?rev=279154&view=rev
Log:
CodeGen: use range based for loop, NFC
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llv
compnerd closed this revision.
compnerd added a comment.
SVN r279173
https://reviews.llvm.org/D23530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Thu Aug 18 18:59:12 2016
New Revision: 279180
URL: http://llvm.org/viewvc/llvm-project?rev=279180&view=rev
Log:
EHABI: cover switch once more
When making WMMX support optional, we uncovered the switch. Add the missing
entries. Since the entry is a break leading to a dead
compnerd added inline comments.
Comment at: test/clang-reorder-fields/ClassMixedInitialization.cpp:1-3
@@ +1,4 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-reorder-fields -record-name Foo -fields-order e,x,pi,v,s %t.cpp
-i -- -std=c++11
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
compnerd added a subscriber: compnerd.
Comment at: include/clang/Driver/Options.td:1380
@@ +1379,3 @@
+def mlong_calls : Flag<["-"], "mlong-calls">, Group,
+ HelpText<"ARM: Generate an indirect jump to enable jumps further than 64M,
Hexagon: Generate constant-extended branches."
Author: compnerd
Date: Tue Aug 23 18:01:16 2016
New Revision: 279584
URL: http://llvm.org/viewvc/llvm-project?rev=279584&view=rev
Log:
libc++: Perform configuration checks with -nodefaultlibs
We're compiling libc++ with -nodefaultlibs, so we should also pass this option
during the configuration c
compnerd closed this revision.
compnerd added a comment.
SVN r279584.
https://reviews.llvm.org/D23791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Tue Aug 23 19:24:05 2016
New Revision: 279596
URL: http://llvm.org/viewvc/llvm-project?rev=279596&view=rev
Log:
Revert "libc++: Perform configuration checks with -nodefaultlibs"
This reverts SVN r279584 which broke the buildbots. Will re-apply once the
issue has been root-
Author: compnerd
Date: Tue Aug 23 23:22:52 2016
New Revision: 279606
URL: http://llvm.org/viewvc/llvm-project?rev=279606&view=rev
Log:
libc++: add an option to build against compiler-rt
This mirrors the option in libc++abi to build without libgcc.
Modified:
libcxx/trunk/CMakeLists.txt
li
compnerd added inline comments.
Comment at: CMakeLists.txt:372
@@ +371,3 @@
+# Relax this restriction from HandleLLVMOptions
+string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS
"${CMAKE_SHARED_LINKER_FLAGS}")
+ endif()
There is a similar change in
compnerd added a comment.
I think it would be better to use `assert(true)` to avoid the TCO from kicking
in.
https://reviews.llvm.org/D23878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:18
@@ +17,3 @@
+if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG)
+ list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs)
+ if (LIBCXX_HAS_C_LIB)
Can we not use `CMAKE_SHARED_LINKER_FLAGS` instead of
`CMAKE
compnerd added a subscriber: compnerd.
compnerd closed this revision.
compnerd added a comment.
SVN r279832
Repository:
rL LLVM
https://reviews.llvm.org/D23821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: compnerd
Date: Sun Aug 28 13:16:00 2016
New Revision: 279935
URL: http://llvm.org/viewvc/llvm-project?rev=279935&view=rev
Log:
test: fix test under ASAN and MSAN
When we're running tests under ASAN or MSAN, they're compiled with -O1, which
enables tail call elimination. This causes backtr
compnerd closed this revision.
compnerd added a comment.
SVN r279935
https://reviews.llvm.org/D23878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Sun Aug 28 15:10:33 2016
New Revision: 279941
URL: http://llvm.org/viewvc/llvm-project?rev=279941&view=rev
Log:
EHABI: fail on WMMX vops without WMMX support
When the unwinder is built without WMMX support, if we encounter a WMMX register
virtual operation, early rather tha
Author: compnerd
Date: Sun Aug 28 16:33:30 2016
New Revision: 279946
URL: http://llvm.org/viewvc/llvm-project?rev=279946&view=rev
Log:
AST: improve layout of SimpleTypoCorrector
Add the "explicit" specifier to the single-argument constructor of
SimpleTypoCorrector. Reorder the fields to remove e
compnerd closed this revision.
compnerd added a comment.
SVN r279946
https://reviews.llvm.org/D23653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Mon Aug 29 16:33:37 2016
New Revision: 280015
URL: http://llvm.org/viewvc/llvm-project?rev=280015&view=rev
Log:
libc++: perform configuration checks with -nodefaultlibs
We're compiling libc++ with -nodefaultlibs, so we should also pass this
option during the configuration c
compnerd closed this revision.
compnerd added a comment.
SVN r280015
https://reviews.llvm.org/D23856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
That is a bug in the LLVM implementation. The functionality is supported on
other (i.e. `gcc`) compilers.
Repository:
rL LLVM
https://reviews.llvm
compnerd added a subscriber: compnerd.
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:121
@@ -120,2 +120,3 @@
- std::string mangleName(const DICompileUnit *CU, const char *NewStem);
+ enum GCovFileType { GCNO, GCDA };
+ std::string mangleName(const DICompileUnit
Author: compnerd
Date: Tue Aug 30 17:10:27 2016
New Revision: 280169
URL: http://llvm.org/viewvc/llvm-project?rev=280169&view=rev
Log:
Driver: use the canonical static library naming
On Windows, static libraries are named lib.lib while import libraries are
named .lib. Use the appropriate naming
compnerd added inline comments.
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447
@@ -432,3 +446,3 @@
return Filename.str();
}
}
A quick pass over this yielded something like:
if (N->getNumOperands() != 2 && N->getNumOperan
compnerd added inline comments.
Comment at: include/__config:719
@@ -718,3 +718,3 @@
#else // _LIBCPP_HAS_NO_STRONG_ENUMS
-#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x
+#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x
#define _LI
compnerd added inline comments.
Comment at: include/__config:719
@@ -718,3 +718,3 @@
#else // _LIBCPP_HAS_NO_STRONG_ENUMS
-#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x
+#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x
#define _LI
Author: compnerd
Date: Wed Aug 31 14:27:07 2016
New Revision: 280281
URL: http://llvm.org/viewvc/llvm-project?rev=280281&view=rev
Log:
Revert "Driver: use the canonical static library naming"
This breaks chromium and its unclear if this is actually a modern convention.
This reverts SVN r280169.
Author: compnerd
Date: Wed Aug 31 15:29:05 2016
New Revision: 280286
URL: http://llvm.org/viewvc/llvm-project?rev=280286&view=rev
Log:
libc++abi: fix some -Wunused-function warnings
is_initialized is only used in the no threads case or if on non ARM Apple
targets. Use the preprocessor to remove
Author: compnerd
Date: Thu Sep 1 15:49:54 2016
New Revision: 280413
URL: http://llvm.org/viewvc/llvm-project?rev=280413&view=rev
Log:
build: don't add -fPIC on Windows
`-fPIC` doesn't make much sense for Windows, since Windows DLLs aren't compiled
position independent and are instead relocated a
Author: compnerd
Date: Thu Sep 1 16:09:19 2016
New Revision: 280417
URL: http://llvm.org/viewvc/llvm-project?rev=280417&view=rev
Log:
cstdio: limit gets to CRT versions below 14
Microsoft removed gets from the CRT in Visual Studio 2015 onwards [1].
Attempting to reference it when targeting CRT v
compnerd closed this revision.
compnerd added a comment.
SVN r280417
https://reviews.llvm.org/D24105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
Ugh, I was wrong. There is type information associated with a scoped enum.
This means that `_LIBCPP_TYPE_VIS` is the right annotation here.
https://reviews.llvm.org/D24065
___
cfe-commits mailing list
cfe-commits@lists.l
compnerd closed this revision.
compnerd added a comment.
SVN r280413
https://reviews.llvm.org/D24099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd closed this revision.
compnerd added a comment.
SVN r280988
https://reviews.llvm.org/D24314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Thu Sep 8 15:52:48 2016
New Revision: 280988
URL: http://llvm.org/viewvc/llvm-project?rev=280988&view=rev
Log:
support: clean up MSVC support
Visual Studio 2013 (CRT version 12) added support for many C99 long long and
long double functions. Visual Studio 2015 (CRT version
compnerd added inline comments.
Comment at: lib/Basic/SourceManager.cpp:395
@@ -383,2 +394,3 @@
+ for (llvm::DenseMap::iterator
I = FileInfos.begin(), E = FileInfos.end(); I != E; ++I) {
if (I->second) {
Cant this be rewritten as:
for (const aut
Author: compnerd
Date: Sat Sep 10 20:25:15 2016
New Revision: 281150
URL: http://llvm.org/viewvc/llvm-project?rev=281150&view=rev
Log:
CodeGen: remove unnecessary else case
Refactor the assignment so that its much more clear that the if-clause contains
the lookup, and once cached is directly used
Author: compnerd
Date: Mon Sep 12 16:15:23 2016
New Revision: 281261
URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
Log:
CodeGen: use some range-based for loops
Use range-based for loops to simplify the logic. Add an explicit check for
MachO as the inline asm uses MachO specific di
compnerd added inline comments.
Comment at: test/Analysis/array-struct.c:147
@@ +146,3 @@
+ bar(((gets3().a)));
+}
+
Perhaps Im missing something, but theres no change to actually verify the
output?
Repository:
rL LLVM
https://reviews.llvm.org/D24484
_
Author: compnerd
Date: Wed Sep 14 10:17:46 2016
New Revision: 281487
URL: http://llvm.org/viewvc/llvm-project?rev=281487&view=rev
Log:
CodeGen: simplify the logic a slight bit
Move the definition of `getTriple()` into the header. It would just call
`getTarget().getTriple()`. Inline the definiti
compnerd added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
Author: compnerd
Date: Fri Sep 16 09:24:26 2016
New Revision: 281730
URL: http://llvm.org/viewvc/llvm-project?rev=281730&view=rev
Log:
CodeGen: use pointer rather than reference in range loop
Address post-commit comments from Justin Bogner. Explicitly indicate
that the dereferenced iterator prov
On Tue, Sep 13, 2016 at 11:06 AM, Justin Bogner
wrote:
> Saleem Abdulrasool via cfe-commits writes:
> > Author: compnerd
> > Date: Mon Sep 12 16:15:23 2016
> > New Revision: 281261
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
>
Author: compnerd
Date: Fri Sep 16 18:41:13 2016
New Revision: 281798
URL: http://llvm.org/viewvc/llvm-project?rev=281798&view=rev
Log:
CodeGen: refactor the ObjC cstring literal creation
This refactors the cstring literal creation as mentioned in the couple of FIXMEs
littered in the various invoc
compnerd added a subscriber: compnerd.
compnerd added a comment.
So, the only thing that Im confused about is where does `__BIONIC__` get
defined?
Comment at: include/__config:766
@@ -761,3 +765,3 @@
// Most unix variants have catopen. These are the specific ones that don't.
compnerd added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
Author: compnerd
Date: Wed Apr 5 13:33:23 2017
New Revision: 299575
URL: http://llvm.org/viewvc/llvm-project?rev=299575&view=rev
Log:
Fix invalid memory access on android x86
On certain versions of android x86, the main module `app_process` is not
built as PIE. When accessing the PT_GNU_EH_FRAM
Author: compnerd
Date: Wed Apr 5 16:29:38 2017
New Revision: 299591
URL: http://llvm.org/viewvc/llvm-project?rev=299591&view=rev
Log:
AddressSpace: fix DWARF based unwinding handling on Android
It is possible that there are no program headers in the module. Do not
attempt to dereference nullptr
Author: compnerd
Date: Fri Apr 7 10:13:47 2017
New Revision: 299774
URL: http://llvm.org/viewvc/llvm-project?rev=299774&view=rev
Log:
Sema: prevent __declspec(naked) use on x64
MSDN (https://msdn.microsoft.com/en-us/library/h5w10wxs.aspx) indicates
that `__declspec(naked)` is only permitted on x
401 - 500 of 1042 matches
Mail list logo
