https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From 196ab7a875040a6b653a118b88d3e892d2256b46 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH] [Analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllowingP
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82063
>From c46f11b98f8ec159a19004952fb67705eb0988dd Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 16 Feb 2024 14:54:55 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow ASSERT and
atomic oper
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82156
>From d169fddf3896bd334bc4776059258116ac08096a Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 01:32:00 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to WTF's
contai
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/82229
This PR makes alpha.webkit.UncountedLocalVarsChecker ignore raw references and
pointers to a ref counted type which appears within "trival" statements. To do
this, this PR extends TrivialFunctionAnalysis so that it
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From d132b98b04d0cfb925f453f99a53f357d95c8e08 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH] [Analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllowingP
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From 5e365d2a873aafc17d4b03eb7fee10029ff2bea1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH] [Analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllowingP
@@ -356,6 +364,14 @@ class TrivialFunctionAnalysisVisitor
return TrivialFunctionAnalysis::isTrivialImpl(Callee, Cache);
}
+ bool VisitCXXDefaultArgExpr(const CXXDefaultArgExpr *E) {
rniwa wrote:
Yeah, I'm adding more general caching mechanism for `Stmt
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From 5e365d2a873aafc17d4b03eb7fee10029ff2bea1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH] [Analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllowingP
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/82063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/82291
None
>From b0519e342b2e145827d6d9de490f32d1dd9c5fe6 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 17 Feb 2024 18:12:16 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow a variable
decla
@@ -25,6 +25,11 @@ using namespace ento;
namespace {
+bool stringEndsWith(const std::string &str, const std::string &suffix) {
+ auto index = str.rfind(suffix);
+ return index != std::string::npos && str.size() - suffix.size() == index;
+}
rniwa wrote:
Oh,
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82156
>From 47670ce87f1c365d6c0cdeb8b8c81a230c66ae3d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 01:32:00 -0800
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to
WTF's co
@@ -25,6 +25,11 @@ using namespace ento;
namespace {
+bool stringEndsWith(const std::string &str, const std::string &suffix) {
+ auto index = str.rfind(suffix);
+ return index != std::string::npos && str.size() - suffix.size() == index;
+}
rniwa wrote:
Fix
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From 1d53adbe50d8afb7c91e8b393c64d6f590256602 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH] [analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllowingP
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82291
>From 8f9f5ff0d01b921f98322bf8ad6a9f8ffe81b4dd Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 17 Feb 2024 18:12:16 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow a variable
declaration
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/82305
[alpha.webkit.UncountedCallArgsChecker] Treat guarded local variable as safe
function arguments
This PR extracts the code in UncountedLocalVarsChecker to identify a variable
declaration which
has a guardian Ref /
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82305
>From 4d3e50636630dfe8be02c05bb7f0705461594c94 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 16 Feb 2024 19:29:54 -0800
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Don't assume
local varia
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82305
>From 4d3e50636630dfe8be02c05bb7f0705461594c94 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 16 Feb 2024 19:29:54 -0800
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Don't assume
local varia
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82291
>From fe73d25f0fb8ef3d0b17b7d375cd16a7dc98d115 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 17 Feb 2024 18:12:16 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow a variable
declaration
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229
>From c25b0ba3286c008dc8ebcea72f28db3e05fcbf3c Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 19 Feb 2024 01:07:13 -0800
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted
object refe
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229
>From e2da6c6663235cfe086b6721a219fe6bddfad415 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 19 Feb 2024 01:07:13 -0800
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted
object refe
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229
>From 383c7bf1a02f7cb2f1050fc8653ecd4d455f089c Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 19 Feb 2024 01:07:13 -0800
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted
object refe
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229
>From 8b2cf0bfe5b7b59c4ec8e28ad50b5d47128d1f86 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 19 Feb 2024 01:07:13 -0800
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted
object refe
@@ -103,15 +103,18 @@ std::optional isRefCountable(const CXXRecordDecl* R)
return hasRef && hasDeref;
}
+bool isRefType(const std::string &name) {
+ return name == "Ref" || name == "RefAllowingPartiallyDestroyed" ||
+ name == "RefPtr" || name == "RefPtrAllowingParti
rniwa wrote:
Yeah, indeed. Thank you for the review!
https://github.com/llvm/llvm-project/pull/82156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/82156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -103,15 +103,18 @@ std::optional isRefCountable(const CXXRecordDecl* R)
return hasRef && hasDeref;
}
+bool isRefType(const std::string &name) {
+ return name == "Ref" || name == "RefAllowingPartiallyDestroyed" ||
+ name == "RefPtr" || name == "RefPtrAllowingParti
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209
>From 1d53adbe50d8afb7c91e8b393c64d6f590256602 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 18 Feb 2024 21:47:48 -0800
Subject: [PATCH 1/2] [analyzer] Support RefAllowingPartiallyDestroyed and
RefPtrAllow
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/82209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82291
>From 0a8cfb11a601e7a6ec59489b8ac15c40136002b2 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 17 Feb 2024 18:12:16 -0800
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow a variable
declaration
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82305
>From 8e9b4433df511e9982d181a5c18262208a72177d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 16 Feb 2024 19:29:54 -0800
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Don't assume
local varia
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229
>From 099640652b62c52160b12542a16eb66da90cfc93 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 19 Feb 2024 01:07:13 -0800
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted
object refe
rniwa wrote:
> I want to spend a bit more time thinking whether this has to go into every
> callback, maybe it can be a set-and-forget thing? (Probably not.)
What do you mean by set-and-forget?
https://github.com/llvm/llvm-project/pull/82229
___
cfe
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/107676
This PR makes WebKit's RefCntblBaseVirtualDtor checker not generate a warning
for ThreadSafeRefCounted when the destruction thread is a specific thread.
Prior to this PR, we only allowed CRTP classes without a vi
rniwa wrote:
> Looks like you're putting no restrictions on what the opaque function is.
> This may cause some false negatives but it's probably ultimately ok, but it
> might be a good idea to confirm.
Yes, we're not putting any requirement for the functions for now.
https://github.com/llvm/l
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/107676
>From 9a8c60355f88d7d4cee6d9f75312bb87d13b74a9 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 7 Sep 2024 01:45:05 -0700
Subject: [PATCH] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted
not gene
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/107676
>From be0c2e0af8e06f4b5f33855a7020b5148cb1846c Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 10 Sep 2024 19:03:12 -0700
Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not
generat
@@ -67,6 +68,15 @@ class DerefFuncDeleteExprVisitor
const Decl *D = CE->getCalleeDecl();
if (D && D->hasBody())
return VisitBody(D->getBody());
+else if (!VisitLambdaBody) {
+ for (unsigned i = 0; i < CE->getNumArgs(); ++i) {
+auto *Arg = CE->getA
rniwa wrote:
> > Looks like you're putting no restrictions on what the opaque function is.
> > This may cause some false negatives but it's probably ultimately ok, but it
> > might be a good idea to confirm.
>
> Yes, we're not putting any requirement for the functions for now.
Actually, why n
@@ -67,6 +68,48 @@ class DerefFuncDeleteExprVisitor
const Decl *D = CE->getCalleeDecl();
if (D && D->hasBody())
return VisitBody(D->getBody());
+else {
+ auto name = safeGetName(D);
+ if (name == "ensureOnMainThread" || name == "ensureOnMainRunLoop")
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/107676
>From cb214cc1f922e16ea4bd81f3c9cac54bc97c2968 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 10 Sep 2024 19:03:12 -0700
Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not
generat
@@ -67,6 +68,48 @@ class DerefFuncDeleteExprVisitor
const Decl *D = CE->getCalleeDecl();
if (D && D->hasBody())
return VisitBody(D->getBody());
+else {
+ auto name = safeGetName(D);
+ if (name == "ensureOnMainThread" || name == "ensureOnMainRunLoop")
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/107676
>From 3a5031d022f01baaf6fd96b2c2c0891e9b627d2c Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 10 Sep 2024 19:03:12 -0700
Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not
generat
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/107676
>From 516ba7d30880f9aa2a0bf6ed884f5d5541b430ce Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 10 Sep 2024 19:03:12 -0700
Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not
generat
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/107676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/108167
Treat WTFReportBacktrace, which prints out the backtrace, as trivial.
>From ad40cdfa22ccbbea7f8b67bf0f3ac1cc0ce1a46c Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 11 Sep 2024 01:24:27 -0700
Subject: [PAT
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/108184
This PR fixes the bug that WebKit checkers didn't recognize the return value of
an Objective-C++ selector which returns Ref or RefPtr to be safe.
>From c8cd18baa5b285262905ad0d8c49ba102993ef1e Mon Sep 17 00:00:00
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/108184
>From c8cd18baa5b285262905ad0d8c49ba102993ef1e Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 11 Sep 2024 03:14:31 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow protector
functi
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/108167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/108184
>From c8cd18baa5b285262905ad0d8c49ba102993ef1e Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 11 Sep 2024 03:14:31 -0700
Subject: [PATCH 1/3] [alpha.webkit.UncountedCallArgsChecker] Allow protector
functi
@@ -143,6 +143,16 @@ bool isReturnValueRefCounted(const clang::FunctionDecl *F)
{
return false;
}
+std::optional isUncounted(const clang::QualType T) {
rniwa wrote:
Fixed!
https://github.com/llvm/llvm-project/pull/108184
__
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90153
Skip the analysis of Ref, RefPtr, and their variant classes in
UncountedCallArgsChecker since these classes are "trusted" to not do anything
dangerous.
>From 04d9b292a48604ec0601e869d48d4f2c481f91bc Mon Sep 17 00:
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90169
Treat boolean literal "true" and "false" as trivial.
>From c44d58eb513325c52199788aafa9d4112e3bfbb6 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 25 Apr 2024 23:03:00 -0700
Subject: [PATCH] [alpha.webkit.U
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90169
>From f7640709bf3cebbd3f1b04f6eba4b8f60bb18c13 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 25 Apr 2024 23:03:00 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Treat true/false as
trivial
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90180
None
>From e00d9f1a928f3bec0780a43b64ea9cab5252126e Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 01:50:35 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore methods of WTF
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90180
>From e00d9f1a928f3bec0780a43b64ea9cab5252126e Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 01:50:35 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Ignore methods of
WTF St
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90301
None
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH] Fix a crash introduced by 3d5e9ab by adding a nullptr check.
-
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90301
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH 1/2] Fix a crash introduced by 3d5e9ab by adding a nullptr
check.
--
rniwa wrote:
> Hey, do you think a regression test would be valuable?
Oh, that's a very good point. Added one.
https://github.com/llvm/llvm-project/pull/90301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90414
Treat a compound operator such as |=, array subscription, sizeof, and non-type
template parameter as trivial so long as subexpressions are also trivial.
Also treat true/false boolean literal as trivial.
>From cc3b
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90301
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH 1/3] Fix a crash introduced by 3d5e9ab by adding a nullptr
check.
--
@@ -54,7 +54,7 @@ class UncountedCallArgsChecker
bool shouldVisitImplicitCode() const { return false; }
bool TraverseDecl(Decl *D) {
-if (isa(D) && isRefType(safeGetName(D)))
+if (D && isa(D) && isRefType(safeGetName(D)))
return true;
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90414
>From 44bff2897be7531b33d558b711034aa98755a4cd Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 28 Apr 2024 13:17:48 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Support more trivial
express
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90414
>From ffc4df724e043e8655824bc2b3deb4e2ef632579 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 28 Apr 2024 13:17:48 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Support more trivial
express
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90301
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH 1/4] Fix a crash introduced by 3d5e9ab by adding a nullptr
check.
--
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90552
None
>From fa7a6e376b07ae6262dd06920c87dc69705a646d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 29 Apr 2024 20:24:24 -0700
Subject: [PATCH] Skip over std namespace in WebKit checkers.
---
.../WebKit/Un
@@ -360,6 +370,16 @@ class TrivialFunctionAnalysisVisitor
return TrivialFunctionAnalysis::isTrivialImpl(Callee, Cache);
}
+ bool
+ VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
+// Non-type template paramter is trivial if the replacemen
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
> Ok am I reading this right: this is about testing code that lives directly in
> namespace `std::` but somehow still lives in your project right? Such as your
> custom modifications to standard classes, various overloads and
> specializations of standard things.
No, this is abou
rniwa wrote:
Oh, looks like I broke tests. Reverting.
https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90701
Reverts llvm/llvm-project#90180
>From 54ff88ab2b46e0ba82cc59077c6d3b367eecd497 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 30 Apr 2024 21:28:03 -0700
Subject: [PATCH] =?UTF-8?q?Revert=20"[alpha.webkit.Un
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90704
None
>From e408befb6422d9063572ddcad2c152eede1b5ca0 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 30 Apr 2024 21:12:52 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore methods of WTF
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90414
>From 416dec586ed566e6c29ca8f5fa66be488ac09e78 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 28 Apr 2024 13:17:48 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Support more
trivial exp
rniwa wrote:
> As per the guidelines, trivial inline functions shouldn't be changed to adopt
> smart pointers.
The triviality of a function is checked by `TrivialFunctionAnalysis`. We
shouldn't assume every inline function as trivial. For example, an inline
function could call a non-inline fu
https://github.com/rniwa requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -178,6 +178,11 @@ class UncountedLocalVarsChecker
if (shouldSkipVarDecl(V))
return;
+if (auto *FD = dyn_cast(V->getDeclContext())) {
+ if (FD->isInlined())
rniwa wrote:
I don't think we should do this.
https://github.com/llvm/llvm-proje
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/90733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
> LGTM! The revert was caused entirely by something in the mock headers in
> tests right?
Yeah, there were some typos in mock-types. Not sure why checks didn't catch it.
https://github.com/llvm/llvm-project/pull/90704
___
cfe-commits mai
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91009
None
>From 2b5782f9a7f6473174ccefa005268debb79aa744 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 3 May 2024 13:35:29 -0700
Subject: [PATCH] [webkit.RefCntblBaseVirtualDtor] Ignore WTF::RefCounted
and its
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91009
>From 2b5782f9a7f6473174ccefa005268debb79aa744 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 3 May 2024 13:35:29 -0700
Subject: [PATCH 1/2] [webkit.RefCntblBaseVirtualDtor] Ignore
WTF::RefCounted and its v
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91009
>From 2b5782f9a7f6473174ccefa005268debb79aa744 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 3 May 2024 13:35:29 -0700
Subject: [PATCH 1/3] [webkit.RefCntblBaseVirtualDtor] Ignore
WTF::RefCounted and its v
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91052
None
>From 357b8bfa0cef2632930e3f037ed66360b0fa3615 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 4 May 2024 00:38:08 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Treat (foo())->bar()
li
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91052
>From 357b8bfa0cef2632930e3f037ed66360b0fa3615 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 4 May 2024 00:38:08 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Treat
(foo())->bar() like
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91009
>From 3301340a5532183252365c536572fc98e4941c8b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 3 May 2024 13:35:29 -0700
Subject: [PATCH 1/3] [webkit.RefCntblBaseVirtualDtor] Ignore
WTF::RefCounted and its v
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91102
This PR adds the support for trivial operator++ implementations. T&
operator++() and T operator++(int) are trivial if the calle is trivial.
Also allow incrementing and decrementing of a POD member variable.
>From
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91103
None
>From e2dbb580ff7fe1f2db1ad7c81902cb8a8b5a58ed Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 4 May 2024 20:41:29 -0700
Subject: [PATCH] [analyzer] Ignore system headers in WebKit checkers.
---
.../C
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Closing this in favor of https://github.com/llvm/llvm-project/pull/91103.
https://github.com/llvm/llvm-project/pull/90552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91102
>From b3ae3d7a2a8885777b691e7fde237f5745e764a1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 4 May 2024 20:29:03 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow trivial
operator++
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/91102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 754 matches
Mail list logo
