[clang-tools-extra] r360009 - Fix test to avoid assuming clang will diagnose problems in unreachable code.

2019-05-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun May 5 21:07:30 2019 New Revision: 360009 URL: http://llvm.org/viewvc/llvm-project?rev=360009&view=rev Log: Fix test to avoid assuming clang will diagnose problems in unreachable code. Modified: clang-tools-extra/trunk/clangd/unittests/DiagnosticsTests.cpp Modified:

r360010 - Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives

2019-05-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun May 5 21:14:01 2019 New Revision: 360010 URL: http://llvm.org/viewvc/llvm-project?rev=360010&view=rev Log: Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives where either the modification or the other access is unreachable. This reverts r359984 (which

r360011 - P1286R2: Remove restriction that the exception specification of a

2019-05-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun May 5 22:04:56 2019 New Revision: 360011 URL: http://llvm.org/viewvc/llvm-project?rev=360011&view=rev Log: P1286R2: Remove restriction that the exception specification of a defaulted special member matches the implicit exception specification. Modified: cfe/trunk/inc

r360117 - Improve function / variable disambiguation.

2019-05-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 7 00:36:07 2019 New Revision: 360117 URL: http://llvm.org/viewvc/llvm-project?rev=360117&view=rev Log: Improve function / variable disambiguation. Keep looking for decl-specifiers after an unknown identifier. Don't issue diagnostics about an error type specifier conf

r360217 - Split ActOnCallExpr into an ActOnCallExpr to be called by the parser,

2019-05-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 7 18:36:36 2019 New Revision: 360217 URL: http://llvm.org/viewvc/llvm-project?rev=360217&view=rev Log: Split ActOnCallExpr into an ActOnCallExpr to be called by the parser, and a BuildCallExpr to be called internally within Sema to build / rebuild calls. Modified:

r360302 - When typo-correcting a function name, consider correcting to a type name

2019-05-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 8 17:57:24 2019 New Revision: 360302 URL: http://llvm.org/viewvc/llvm-project?rev=360302&view=rev Log: When typo-correcting a function name, consider correcting to a type name for a function-style cast. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/lib/

r360310 - [cxx_status] Mark support for std::is_constant_evaluated as done.

2019-05-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 8 20:49:47 2019 New Revision: 360310 URL: http://llvm.org/viewvc/llvm-project?rev=360310&view=rev Log: [cxx_status] Mark support for std::is_constant_evaluated as done. Eric implemented this in r359067. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trun

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-05-08 Thread Richard Smith via cfe-commits
I went ahead and did this in r360310. On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > wrote: > > Do I just edit the HTML file directly? > > Or is it generated by something? > > Just edit the HTML file directly. > > > On Wed, Ap

r360370 - DR1872: don't allow any calls to virtual functions in constant

2019-05-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 9 12:45:49 2019 New Revision: 360370 URL: http://llvm.org/viewvc/llvm-project?rev=360370&view=rev Log: DR1872: don't allow any calls to virtual functions in constant evaluation. Not even in cases where we would not actually perform virtual dispatch. Modified: cf

r360369 - Simplify tracking of end of consumed decl-specifier sequence.

2019-05-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 9 12:45:46 2019 New Revision: 360369 URL: http://llvm.org/viewvc/llvm-project?rev=360369&view=rev Log: Simplify tracking of end of consumed decl-specifier sequence. Patch by Tyker! Differential Revision: https://reviews.llvm.org/D60934 Modified: cfe/trunk/lib/P

r342304 - [modules] Frontend support for building a header module from a list of

2018-09-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 14 18:21:15 2018 New Revision: 342304 URL: http://llvm.org/viewvc/llvm-project?rev=342304&view=rev Log: [modules] Frontend support for building a header module from a list of headaer files. Added: cfe/trunk/test/Modules/Inputs/no-module-map/ cfe/trunk/test/Mod

r342306 - [modules] Support use of -E on modules built from the command line.

2018-09-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 14 18:21:18 2018 New Revision: 342306 URL: http://llvm.org/viewvc/llvm-project?rev=342306&view=rev Log: [modules] Support use of -E on modules built from the command line. Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp cfe/trunk/lib/Frontend/FrontendActio

r342305 - [modules] Driver support for precompiling a collection of files as a single

2018-09-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 14 18:21:16 2018 New Revision: 342305 URL: http://llvm.org/viewvc/llvm-project?rev=342305&view=rev Log: [modules] Driver support for precompiling a collection of files as a single action. Added: cfe/trunk/test/Driver/header-module.cpp Modified: cfe/trunk/inclu

r342307 - [modules] Don't bother creating a global module fragment when building a

2018-09-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 14 18:59:39 2018 New Revision: 342307 URL: http://llvm.org/viewvc/llvm-project?rev=342307&view=rev Log: [modules] Don't bother creating a global module fragment when building a header module. Modified: cfe/trunk/lib/Sema/Sema.cpp Modified: cfe/trunk/lib/Sema/Sema

r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

2018-09-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Sep 24 16:17:44 2018 New Revision: 342925 URL: http://llvm.org/viewvc/llvm-project?rev=342925&view=rev Log: P0962R1: only use the member form of 'begin' and 'end' in a range-based for loop if both members exist. This resolves a DR whereby an errant 'begin' or 'end' member

r342926 - [www] Update cxx_status to mark P0962R1 as done.

2018-09-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Sep 24 16:19:11 2018 New Revision: 342926 URL: http://llvm.org/viewvc/llvm-project?rev=342926&view=rev Log: [www] Update cxx_status to mark P0962R1 as done. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/l

r342927 - [www] Change 'Clang 7' items from yellow to green now Clang 7 is

2018-09-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Sep 24 16:21:09 2018 New Revision: 342927 URL: http://llvm.org/viewvc/llvm-project?rev=342927&view=rev Log: [www] Change 'Clang 7' items from yellow to green now Clang 7 is released. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_status.html cfe/

r343036 - P0969R0: allow structured binding of accessible members, not only public members.

2018-09-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 25 15:12:44 2018 New Revision: 343036 URL: http://llvm.org/viewvc/llvm-project?rev=343036&view=rev Log: P0969R0: allow structured binding of accessible members, not only public members. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/

r343040 - Don't emit "will be treated as an identifier character" warning for

2018-09-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 25 15:34:45 2018 New Revision: 343040 URL: http://llvm.org/viewvc/llvm-project?rev=343040&view=rev Log: Don't emit "will be treated as an identifier character" warning for UTF-8 characters that aren't identifier characters in the current language mode. Modified: c

r343064 - P0859R0: List-initialization is potentially-constant-evaluated and

2018-09-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 25 21:36:55 2018 New Revision: 343064 URL: http://llvm.org/viewvc/llvm-project?rev=343064&view=rev Log: P0859R0: List-initialization is potentially-constant-evaluated and triggers instantiation of constexpr functions. We mostly implemented this since Clang 6, but miss

r343131 - P1008R1 Classes with user-declared constructors are never aggregates in

2018-09-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 26 12:00:16 2018 New Revision: 343131 URL: http://llvm.org/viewvc/llvm-project?rev=343131&view=rev Log: P1008R1 Classes with user-declared constructors are never aggregates in C++20. Added: cfe/trunk/test/SemaCXX/cxx2a-compat.cpp cfe/trunk/test/SemaCXX/cxx2a-i

r343279 - [cxx2a] P0624R2: Lambdas with no capture-default are

2018-09-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 27 15:47:04 2018 New Revision: 343279 URL: http://llvm.org/viewvc/llvm-project?rev=343279&view=rev Log: [cxx2a] P0624R2: Lambdas with no capture-default are default-constructible and assignable. Added: cfe/trunk/test/SemaCXX/cxx2a-lambda-default-ctor-assign.cpp Mo

Re: r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

2018-09-27 Thread Richard Smith via cfe-commits
ecuteCompilerInvocation.cpp:259:25 > #20 0x9fe4c3 in cc1_main(llvm::ArrayRef, char const*, void*) > /b/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/tools/driver/cc1_main.cpp:218:13 > #21 0x9f90d5 in ExecuteCC1Tool > /b/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/too

r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-09-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285&view=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead of rendering the program ill-formed. This change also adds a

r343293 - Handle dependent class template names in class template argument

2018-09-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 27 20:18:53 2018 New Revision: 343293 URL: http://llvm.org/viewvc/llvm-project?rev=343293&view=rev Log: Handle dependent class template names in class template argument deduction for new-expressions. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sem

r343350 - [cxx2a] P0614R1: Support init-statements in range-based for loops.

2018-09-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 28 11:44:09 2018 New Revision: 343350 URL: http://llvm.org/viewvc/llvm-project?rev=343350&view=rev Log: [cxx2a] P0614R1: Support init-statements in range-based for loops. We don't yet support this for the case where a range-based for loop is implicitly rewritten to an

Re: r343279 - [cxx2a] P0624R2: Lambdas with no capture-default are

2018-10-01 Thread Richard Smith via cfe-commits
e to pass in the comparator > on construction, etc) > Not quite: that also needs p0315r4, but that's coming in C++20 too. On Thu, Sep 27, 2018 at 3:48 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Thu Sep 27 15:4

Re: r342827 - Fix modules build with shared library.

2018-10-01 Thread Richard Smith via cfe-commits
This looks like the wrong fix to me, but I don't really know enough about what's being done with ExprMutationAnalyzer to have an opinion on what the right fix is. Shuai, what is the goal here? Why is this code being moved to Analysis/? Do you intend to call it from the compiler frontend at some po

Re: r342827 - Fix modules build with shared library.

2018-10-01 Thread Richard Smith via cfe-commits
On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > This looks like the wrong fix to me, but I

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-03 Thread Richard Smith via cfe-commits
On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Thu Sep 27 18:16:43 2018 > > New Revision: 343285 > > > > URL: http://

Re: [libcxx] r342073 - Implement the infrastructure for feature-test macros. Very few actual feature test macros, though. Reviewed as: https://reviews.llvm.org/D51955

2018-10-04 Thread Richard Smith via cfe-commits
Perhaps libc++ could provide a __version file that contains the headers, and use #include <__version> internally? We'd still need a header that just includes <__version> for conformance, but that should be after user headers on the include path so shouldn't break things. On Thu, 4 Oct 2018, 07:10

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

2019-01-31 Thread Richard Smith via cfe-commits
Given that there's uncertainty as to how to proceed and this patch affects the ABI, I would prefer that we revert it for trunk and 8.0. The suggested alternative of disallowing trivial_abi in the case where all copy/move constructors are deleted seems reasonable to me. On Thu, 31 Jan 2019 at 14:3

r352925 - Factor out duplication between ExprIterator and ConstExprIterator.

2019-02-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Feb 1 13:58:17 2019 New Revision: 352925 URL: http://llvm.org/viewvc/llvm-project?rev=352925&view=rev Log: Factor out duplication between ExprIterator and ConstExprIterator. This also exposes a more general iterator cast mechanism suitable for use in http://reviews.llvm.

r353240 - [modules] Fix handling of initializers for templated global variables.

2019-02-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 5 15:37:13 2019 New Revision: 353240 URL: http://llvm.org/viewvc/llvm-project?rev=353240&view=rev Log: [modules] Fix handling of initializers for templated global variables. For global variables with unordered initialization that are instantiated within a module, we

Re: r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

2019-02-08 Thread Richard Smith via cfe-commits
On Fri, 8 Feb 2019 at 16:45, Mikhail R. Gadelha via cfe-commits wrote: > Author: mramalho > Date: Fri Feb 8 16:46:12 2019 > New Revision: 353590 > > URL: http://llvm.org/viewvc/llvm-project?rev=353590&view=rev > Log: > This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b. > and commit a18

Re: [PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

2019-02-12 Thread Richard Smith via cfe-commits
On Tue, 12 Feb 2019, 05:28 Aaron Ballman via Phabricator via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added a comment. > > Considering that this has been fertile ground for buggy edge cases, should > we revert my original changes from the 8.0 branch to give this more time

r354090 - PR40642: Fix determination of whether the final statement of a statement

2019-02-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Feb 14 16:27:53 2019 New Revision: 354090 URL: http://llvm.org/viewvc/llvm-project?rev=354090&view=rev Log: PR40642: Fix determination of whether the final statement of a statement expression is a discarded-value expression. Summary: We used to get this wrong in three way

r354091 - Fix implementation of [temp.local]p4.

2019-02-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Feb 14 16:29:04 2019 New Revision: 354091 URL: http://llvm.org/viewvc/llvm-project?rev=354091&view=rev Log: Fix implementation of [temp.local]p4. When a template-name is looked up, we need to give injected-class-name declarations of class templates special treatment, as t

Re: r354091 - Fix implementation of [temp.local]p4.

2019-02-15 Thread Richard Smith via cfe-commits
ks, > > -- > Francis > > On Feb 14, 2019, at 4:29 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: rsmith > Date: Thu Feb 14 16:29:04 2019 > New Revision: 354091 > > URL: http://llvm.org/viewvc/llvm-project?rev=354091&

r354176 - Fix implementation of [temp.local]p4.

2019-02-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Feb 15 13:53:07 2019 New Revision: 354176 URL: http://llvm.org/viewvc/llvm-project?rev=354176&view=rev Log: Fix implementation of [temp.local]p4. When a template-name is looked up, we need to give injected-class-name declarations of class templates special treatment, as t

Re: r354091 - Fix implementation of [temp.local]p4.

2019-02-15 Thread Richard Smith via cfe-commits
e a look? > > > It's an error in the sanitizer test's code. lldb bug fixed in r354173, sanitizer test bug fixed in r354174, re-committed as r354176. >> Thanks, >> >> -- >> Francis >> >> On Feb 14, 2019, at 4:29 PM, Richard Smith via cfe-co

r354633 - Use _Q as MS ABI mangling for char8_t.

2019-02-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Feb 21 15:04:35 2019 New Revision: 354633 URL: http://llvm.org/viewvc/llvm-project?rev=354633&view=rev Log: Use _Q as MS ABI mangling for char8_t. Thanks to Yuriy Solodkyy for letting us know the mangling here. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp cfe/

r354736 - Enable coroutines under -std=c++2a.

2019-02-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Feb 23 13:06:26 2019 New Revision: 354736 URL: http://llvm.org/viewvc/llvm-project?rev=354736&view=rev Log: Enable coroutines under -std=c++2a. Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/trunk/include/clang/Basic/TokenKinds.def cfe/trunk/lib/B

r354735 - [cxx_status] Update to match Kona motions.

2019-02-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Feb 23 13:06:25 2019 New Revision: 354735 URL: http://llvm.org/viewvc/llvm-project?rev=354735&view=rev Log: [cxx_status] Update to match Kona motions. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-pr

r311823 - Add flag to request Clang is ABI-compatible with older versions of itself

2017-08-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 25 18:04:35 2017 New Revision: 311823 URL: http://llvm.org/viewvc/llvm-project?rev=311823&view=rev Log: Add flag to request Clang is ABI-compatible with older versions of itself This patch adds a flag -fclang-abi-compat that can be used to request that Clang attempts

Re: r311823 - Add flag to request Clang is ABI-compatible with older versions of itself

2017-08-25 Thread Richard Smith via cfe-commits
Hi Hans, We should get this into Clang 5 so that people can opt out of the ABI bugfix for passing C++ class types by value. On 25 August 2017 at 18:04, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Aug 25 18:04:35 2017 > New R

r311867 - [c++2a] P0683R1: Permit default member initializers for bit-fields.

2017-08-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 27 17:28:14 2017 New Revision: 311867 URL: http://llvm.org/viewvc/llvm-project?rev=311867&view=rev Log: [c++2a] P0683R1: Permit default member initializers for bit-fields. This would be trivial, except that our in-memory and serialized representations for FieldDecls a

r311868 - Add test for -Wc++17-compat warning for P0683R1.

2017-08-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 27 17:31:35 2017 New Revision: 311868 URL: http://llvm.org/viewvc/llvm-project?rev=311868&view=rev Log: Add test for -Wc++17-compat warning for P0683R1. Modified: cfe/trunk/test/SemaCXX/cxx17-compat.cpp Modified: cfe/trunk/test/SemaCXX/cxx17-compat.cpp URL: http

Re: [PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

2017-08-28 Thread Richard Smith via cfe-commits
On 28 August 2017 at 13:47, Akira Hatanaka via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > clang currently rejects "void foo(int = a);" and so does gcc. > > I'm trying to search the defect reports, but it looks like the c++ > standard's site is currently unreachable. It's

r311970 - Improve constant expression evaluation of arrays of unknown bound.

2017-08-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 28 18:52:13 2017 New Revision: 311970 URL: http://llvm.org/viewvc/llvm-project?rev=311970&view=rev Log: Improve constant expression evaluation of arrays of unknown bound. The standard is not clear on how these are supposed to be handled, so we conservatively treat as

r312049 - PR10147: When substituting a template template argument, substitute in the most

2017-08-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 29 15:14:43 2017 New Revision: 312049 URL: http://llvm.org/viewvc/llvm-project?rev=312049&view=rev Log: PR10147: When substituting a template template argument, substitute in the most recent (non-friend) declaration to pick up the right set of default template argument

r312085 - Give a better error if auto deduction fails due to inconsistent element types in a braced initializer list.

2017-08-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 29 17:44:08 2017 New Revision: 312085 URL: http://llvm.org/viewvc/llvm-project?rev=312085&view=rev Log: Give a better error if auto deduction fails due to inconsistent element types in a braced initializer list. Modified: cfe/trunk/include/clang/Basic/DiagnosticS

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

2017-08-30 Thread Richard Smith via cfe-commits
On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Victor Leschuk writes: > > > Hello Boris, looks like this revision broke tests on our win10 builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/

Re: [PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

2017-08-30 Thread Richard Smith via cfe-commits
On 28 August 2017 at 17:00, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator > via cfe-commits wrote: > >> rsmith added inline comments. >> >> >> >> Comment at: test/SemaCXX/destructor.cpp:

r312191 - [cxx_status] Update to describe current status a bit better.

2017-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 30 16:10:31 2017 New Revision: 312191 URL: http://llvm.org/viewvc/llvm-project?rev=312191&view=rev Log: [cxx_status] Update to describe current status a bit better. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.

r312467 - Implement Itanium name mangling support for C++ Modules TS.

2017-09-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Sep 3 22:37:53 2017 New Revision: 312467 URL: http://llvm.org/viewvc/llvm-project?rev=312467&view=rev Log: Implement Itanium name mangling support for C++ Modules TS. This follows the scheme agreed with Nathan Sidwell, which can be found here: https://gcc.gnu.org/wiki

r312506 - Always allocate room for a ModuleDecl on the TranslationUnitDecl.

2017-09-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Sep 4 17:50:19 2017 New Revision: 312506 URL: http://llvm.org/viewvc/llvm-project?rev=312506&view=rev Log: Always allocate room for a ModuleDecl on the TranslationUnitDecl. Sometimes we create the ASTContext and thus the TranslationUnitDecl before we know the LangOption

Re: r312467 - Implement Itanium name mangling support for C++ Modules TS.

2017-09-05 Thread Richard Smith via cfe-commits
er/modules-ts.cpp > Clang :: Modules/diag-flags.cpp > Clang :: Modules/diag-pragma.cpp > Clang :: Modules/import-syntax.c > Clang :: SemaCXX/modules-ts.cppm > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7630 > > On Sun, Sep 3, 201

r312580 - Fix memory leak after r312467. The ModuleMap is the owner of the global module object until it's reparented under a real module.

2017-09-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 5 14:46:22 2017 New Revision: 312580 URL: http://llvm.org/viewvc/llvm-project?rev=312580&view=rev Log: Fix memory leak after r312467. The ModuleMap is the owner of the global module object until it's reparented under a real module. Modified: cfe/trunk/include/cl

Re: r312467 - Implement Itanium name mangling support for C++ Modules TS.

2017-09-05 Thread Richard Smith via cfe-commits
earch/module-import.cpp >> Clang :: CXX/modules-ts/codegen-basics.cppm >> Clang :: CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.import/p1.cpp >> Clang :: CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.interface/p1. >> cpp >> Clang :: CXX/modules-ts/dcl.dcl

r312665 - [modules ts] Emit global variables in a module interface unit as part of that unit, not in importers.

2017-09-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 6 13:01:14 2017 New Revision: 312665 URL: http://llvm.org/viewvc/llvm-project?rev=312665&view=rev Log: [modules ts] Emit global variables in a module interface unit as part of that unit, not in importers. Modified: cfe/trunk/include/clang/Serialization/ASTReader

Re: r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-06 Thread Richard Smith via cfe-commits
I am extremely uncomfortable about the direction this patch series is going. We have had two different RecursiveASTVisitors before (RecursiveASTVisitor and DataRecursiveASTVisitor), and it was a maintenance nightmare: frequently changes would be made to one of them and missed in the other one, res

r312684 - [modules ts] Ensure that module linkage variables are always emitted and always have their name mangled.

2017-09-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 6 17:55:55 2017 New Revision: 312684 URL: http://llvm.org/viewvc/llvm-project?rev=312684&view=rev Log: [modules ts] Ensure that module linkage variables are always emitted and always have their name mangled. Modified: cfe/trunk/lib/AST/Mangle.cpp cfe/trunk/l

r312696 - [modules ts] Add test for [basic.link]p3.

2017-09-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 6 22:29:39 2017 New Revision: 312696 URL: http://llvm.org/viewvc/llvm-project?rev=312696&view=rev Log: [modules ts] Add test for [basic.link]p3. Added: cfe/trunk/test/CXX/modules-ts/basic/basic.link/p3.cppm Added: cfe/trunk/test/CXX/modules-ts/basic/basic.link/p

r312700 - Fix off-by-one error in block mangling.

2017-09-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 6 22:41:24 2017 New Revision: 312700 URL: http://llvm.org/viewvc/llvm-project?rev=312700&view=rev Log: Fix off-by-one error in block mangling. This restores the ABI prior to r214699. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/test/CodeGenObjCXX/

r312703 - P0702R1: in class template argument deduction from a list of one element, if

2017-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 7 00:22:36 2017 New Revision: 312703 URL: http://llvm.org/viewvc/llvm-project?rev=312703&view=rev Log: P0702R1: in class template argument deduction from a list of one element, if that element's type is (or is derived from) a specialization of the deduced template, sk

r312743 - Add IDNS_Tag to C++ declarations that conflict with tag declarations.

2017-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 7 13:22:00 2017 New Revision: 312743 URL: http://llvm.org/viewvc/llvm-project?rev=312743&view=rev Log: Add IDNS_Tag to C++ declarations that conflict with tag declarations. Fixes some accepts-invalids with tags and other declarations declared in the same scope. Adde

r312749 - Add target triple to improve the happiness of MSVC buildbots.

2017-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 7 15:07:52 2017 New Revision: 312749 URL: http://llvm.org/viewvc/llvm-project?rev=312749&view=rev Log: Add target triple to improve the happiness of MSVC buildbots. Modified: cfe/trunk/test/CXX/modules-ts/basic/basic.link/p3.cppm Modified: cfe/trunk/test/CXX/mod

Re: r312696 - [modules ts] Add test for [basic.link]p3.

2017-09-07 Thread Richard Smith via cfe-commits
sts (1): > Clang :: CXX/modules-ts/basic/basic.link/p3.cppm > > Please have a look? > Should be fixed by r312749. FYI, I did not receive any email about this failure :( > Thanks > > Galina > > On Wed, Sep 6, 2017 at 10:29 PM, Richard Smith via cfe-commits < > cf

r312850 - [cxx_status] Change "Clang 5" items from yellow to green now that Clang 5 has been released.

2017-09-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 8 18:11:04 2017 New Revision: 312850 URL: http://llvm.org/viewvc/llvm-project?rev=312850&view=rev Log: [cxx_status] Change "Clang 5" items from yellow to green now that Clang 5 has been released. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_s

r312851 - Fix ownership of the MemoryBuffer in a FrontendInputFile.

2017-09-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 8 18:14:04 2017 New Revision: 312851 URL: http://llvm.org/viewvc/llvm-project?rev=312851&view=rev Log: Fix ownership of the MemoryBuffer in a FrontendInputFile. This fixes a possible crash on certain kinds of corrupted AST file, but checking in an AST file corrupted

Re: [libcxx] r250235 - [libcxx] Capture configuration information when installing the libc++ headers

2017-09-13 Thread Richard Smith via cfe-commits
On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Tue Oct 13 17:12:02 2015 > New Revision: 250235 > > URL: http://llvm.org/viewvc/llvm-project?rev=250235&view=rev > Log: > [libcxx] Capture configuration information when install

Re: [libcxx] r250235 - [libcxx] Capture configuration information when installing the libc++ headers

2017-09-13 Thread Richard Smith via cfe-commits
On 13 September 2017 at 12:15, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Sep 13, 2017 at 1:02 PM, Richard Smith > wrote: > >> On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: ericwf >>> Date: Tue O

Re: r313315 - Diagnostic specific failed condition in a static_assert.

2017-09-16 Thread Richard Smith via cfe-commits
This is a bug in the libc++ tests. It's OK for them to check that the static_assert message is produced, but not that they're prefixed with the exact string "static_assert failed:". On 16 September 2017 at 05:54, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This triggere

Re: r313316 - [Module map] Introduce a private module re-export directive.

2017-09-18 Thread Richard Smith via cfe-commits
On 18 September 2017 at 14:34, Douglas Gregor via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Sep 18, 2017, at 1:45 PM, Galina Kistanova > wrote: > > Hello Douglas, > > Your r313316 commit broke one of our builders on Thursday, Sep-14th. > http://lab.llvm.org:8011/builders/llvm-clang-

r313729 - Implement C++ [basic.link]p8.

2017-09-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 20 00:22:00 2017 New Revision: 313729 URL: http://llvm.org/viewvc/llvm-project?rev=313729&view=rev Log: Implement C++ [basic.link]p8. If a function or variable has a type with no linkage (and is not extern "C"), any use of it requires a definition within the same tran

Re: [clang-tools-extra] r313752 - [clang-tidy] Fix linkage-related compiler errors in clang-tidy tests

2017-09-20 Thread Richard Smith via cfe-commits
Thank you! On 20 September 2017 at 05:16, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed Sep 20 05:16:35 2017 > New Revision: 313752 > > URL: http://llvm.org/viewvc/llvm-project?rev=313752&view=rev > Log: > [clang-tidy] Fix linkage-related co

r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 20 15:17:55 2017 New Revision: 313827 URL: http://llvm.org/viewvc/llvm-project?rev=313827&view=rev Log: Give external linkage and mangling to lambdas inside inline variables and variable templates. This implements the proposed approach in https://github.com/itanium-

Re: r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-20 Thread Richard Smith via cfe-commits
86_64-linux-fast/build/llvm/tools/clang/tools/driver/driver.cpp:309:12 > #27 0xeb447c in main > /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/tools/driver/driver.cpp:388:12 > #28 0x7fef65b7182f in __libc_start_main > (/lib/x86_64-linux-gnu/libc.so.6+0

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

2017-09-21 Thread Richard Smith via cfe-commits
On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vsapsai > Date: Fri Sep 15 12:51:42 2017 > New Revision: 313386 > > URL: http://llvm.org/viewvc/llvm-project?rev=313386&view=rev > Log: > [Sema] Error out early for tags defined inside an

r313943 - Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData.

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 17:11:15 2017 New Revision: 313943 URL: http://llvm.org/viewvc/llvm-project?rev=313943&view=rev Log: Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData. Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/Frontend/float16.cpp

r313948 - Fix tracking of whether a destructor would be deleted.

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 18:04:22 2017 New Revision: 313948 URL: http://llvm.org/viewvc/llvm-project?rev=313948&view=rev Log: Fix tracking of whether a destructor would be deleted. I've been unable to find any cases whose behavior is actually changed by this, but only because an implicitly

r313953 - Clean up some mistreatment of enumerations.

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 19:22:32 2017 New Revision: 313953 URL: http://llvm.org/viewvc/llvm-project?rev=313953&view=rev Log: Clean up some mistreatment of enumerations. Modified: cfe/trunk/include/clang/AST/Decl.h cfe/trunk/lib/AST/Decl.cpp cfe/trunk/lib/AST/Linkage.h Modifie

r313955 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 21:25:05 2017 New Revision: 313955 URL: http://llvm.org/viewvc/llvm-project?rev=313955&view=rev Log: Give external linkage and mangling to lambdas inside inline variables and variable templates. This implements the proposed approach in https://github.com/itanium-

r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 21:33:20 2017 New Revision: 313957 URL: http://llvm.org/viewvc/llvm-project?rev=313957&view=rev Log: Closure types have no name (and can't have a typedef name for linkage purposes), so they never formally have linkage. Modified: cfe/trunk/lib/AST/Decl.cpp c

r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

2017-09-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 22 15:21:44 2017 New Revision: 314037 URL: http://llvm.org/viewvc/llvm-project?rev=314037&view=rev Log: DR1113: anonymous namespaces formally give their contents internal linkage. This doesn't affect our code generation in any material way -- we already give such decl

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

2017-09-22 Thread Richard Smith via cfe-commits
Fri, Sep 22, 2017 at 3:21 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Fri Sep 22 15:21:44 2017 >> New Revision: 314037 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=314037&view=rev >> L

[clang-tools-extra] r314047 - Fix up clang-tidy after clang r314037.

2017-09-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 22 16:47:20 2017 New Revision: 314047 URL: http://llvm.org/viewvc/llvm-project?rev=314047&view=rev Log: Fix up clang-tidy after clang r314037. Modified: clang-tools-extra/trunk/clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tools-extra/trunk/test/clang-t

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

2017-09-22 Thread Richard Smith via cfe-commits
s/llvm-clang-lld-x86_64- >> scei-ps4-windows10pro-fast/builds/12310/steps/test/logs/stdio >> >> On Fri, Sep 22, 2017 at 3:21 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rsmith >>> Date: Fri Sep 22 15:21:44

r314054 - Correctly compute linkage for members of internal linkage classes.

2017-09-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 22 21:02:17 2017 New Revision: 314054 URL: http://llvm.org/viewvc/llvm-project?rev=314054&view=rev Log: Correctly compute linkage for members of internal linkage classes. We used to give such members no linkage instead of giving them the linkage of the class. Modifie

r314067 - Don't warn about runtime behavior problems in variable initializers that we

2017-09-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Sep 23 11:27:11 2017 New Revision: 314067 URL: http://llvm.org/viewvc/llvm-project?rev=314067&view=rev Log: Don't warn about runtime behavior problems in variable initializers that we know are going to be constant-evaluated. Any relevant diagnostics should be produced by

Re: r313955 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-23 Thread Richard Smith via cfe-commits
ke we do for functions. But in the short term we can at least suppress "runtime behavior" diagnostics in variable initializers that will always be evaluated as constants (constexpr variables and in-class initializers of static data members). I've implemented that in r314067. On Fri, Sep 22

r362147 - [c++2a] Fix assertion failure if we would walk over more than one level

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 13:45:12 2019 New Revision: 362147 URL: http://llvm.org/viewvc/llvm-project?rev=362147&view=rev Log: [c++2a] Fix assertion failure if we would walk over more than one level of derived-to-base conversion path when implicitly starting union subobject lifetimes in cons

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

2019-05-30 Thread Richard Smith via cfe-commits
On Thu, 30 May 2019 at 04:31, Stephan Bergmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Tue May 21 16:15:20 2019 > > New Revision: 361329 > > > > URL:

r362172 - Refactor OpenMP stack management.

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 16:21:14 2019 New Revision: 362172 URL: http://llvm.org/viewvc/llvm-project?rev=362172&view=rev Log: Refactor OpenMP stack management. Instead of duplicating access to the directive stack throughout SemaOpenMP.cpp, consolidate it to a few methods and call those eve

r362171 - Fix "fallthrough annotation in unreachable code" warning.

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 16:21:13 2019 New Revision: 362171 URL: http://llvm.org/viewvc/llvm-project?rev=362171&view=rev Log: Fix "fallthrough annotation in unreachable code" warning. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL: http://llvm

r362178 - Defer capture initialization for blocks until after we've left the

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 17:45:09 2019 New Revision: 362178 URL: http://llvm.org/viewvc/llvm-project?rev=362178&view=rev Log: Defer capture initialization for blocks until after we've left the function scope. This removes one of the last few cases where we build expressions in the wrong fu

r362179 - Defer capture initialization for captured regions until after we've left

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 17:45:10 2019 New Revision: 362179 URL: http://llvm.org/viewvc/llvm-project?rev=362179&view=rev Log: Defer capture initialization for captured regions until after we've left the captured region scope. This removes a case where we would build expressions (and mark d

r362182 - Defer building 'this' captures until we have left the capturing region

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 18:17:04 2019 New Revision: 362182 URL: http://llvm.org/viewvc/llvm-project?rev=362182&view=rev Log: Defer building 'this' captures until we have left the capturing region and returned to the context in which 'this' should be captured. This means we now always mark

r362184 - PR39728: When completing a class, complete the destructor first.

2019-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 30 18:25:16 2019 New Revision: 362184 URL: http://llvm.org/viewvc/llvm-project?rev=362184&view=rev Log: PR39728: When completing a class, complete the destructor first. We need to know whether the destructor is trivial in order to tell whether other parts of the class

<    1   2   3   4   5   6   7   8   9   10   >