; cfe-commits@lists.llvm.org> wrote:
>
>> On Mon, Oct 1, 2018 at 4:58 PM Richard Smith
>> wrote:
>>
>>> On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
>>>> Hi Rich
On Wed, 24 Oct 2018 at 15:40, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Oct 24 15:38:49 2018
> New Revision: 345211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev
> Log:
> [SemaCXX] Unconfuse Clang when std::align_val_t is uns
When reverting (even when reverting your own commit), please include in the
commit description a reason for the revert.
On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Thu Oct 25 12:50:43 2018
> New Revision: 345306
>
> URL
Author: rsmith
Date: Thu Oct 25 15:35:16 2018
New Revision: 345328
URL: http://llvm.org/viewvc/llvm-project?rev=345328&view=rev
Log:
Avoid STMT_ and DECL_ bitcodes overlapping.
This doesn't appear to matter for deserialization purposes, because we
always know what kind of entity (declaration or s
Author: rsmith
Date: Thu Oct 25 15:51:16 2018
New Revision: 345330
URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev
Log:
Add MS ABI mangling for operator<=>.
Thanks to Cameron DaCamara at Microsoft for letting us know what their
chosen mangling is here!
Added:
cfe/trunk/test/Code
I've already pointed Zach at this and I think he's going to handle it.
On Thu, 25 Oct 2018 at 16:00, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Could you update the demangler too?
>
> On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cf
Author: rsmith
Date: Thu Oct 25 20:21:20 2018
New Revision: 345362
URL: http://llvm.org/viewvc/llvm-project?rev=345362&view=rev
Log:
PR31978: Don't crash if CodeGen sees a top-level BindingDecl.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/test/Parser/cxx1z-decomposition.cp
Author: rsmith
Date: Fri Oct 26 12:26:45 2018
New Revision: 345419
URL: http://llvm.org/viewvc/llvm-project?rev=345419&view=rev
Log:
PR26547: alignof should return ABI alignment, not preferred alignment
Summary:
- Add `UETT_PreferredAlignOf` to account for the difference between `__alignof`
and
Author: rsmith
Date: Fri Oct 26 12:35:39 2018
New Revision: 345421
URL: http://llvm.org/viewvc/llvm-project?rev=345421&view=rev
Log:
Fix typo.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
http://llvm.org/v
Author: rsmith
Date: Fri Oct 26 12:42:43 2018
New Revision: 345423
URL: http://llvm.org/viewvc/llvm-project?rev=345423&view=rev
Log:
Fix test expectation to match reality.
Modified:
cfe/trunk/test/SemaCXX/alignof.cpp
Modified: cfe/trunk/test/SemaCXX/alignof.cpp
URL:
http://llvm.org/viewvc/l
Author: rsmith
Date: Mon Oct 29 19:02:49 2018
New Revision: 345562
URL: http://llvm.org/viewvc/llvm-project?rev=345562&view=rev
Log:
PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type
nullptr_t does not access memory.
We now reuse CK_NullToPointer to represent a conversion from
This is an ABI break (theoretically), but due to its nature I'm not too
concerned.
Please update the documentation for the attribute to describe these new
semantics, though: the documentation currently says that we're just
treating certain special members as if they were trivial when determining
w
Author: rsmith
Date: Wed Jan 16 14:01:39 2019
New Revision: 351382
URL: http://llvm.org/viewvc/llvm-project?rev=351382&view=rev
Log:
PR40329: [adl] Fix determination of associated classes when searching a
member enum and then its enclosing class.
There are situations where ADL will collect a clas
On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 16 Jan 2019, at 9:13, Aaron Ballman wrote:
>
> > On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka
> > wrote:
> >>
> >> Yes, the behavior of the compiler doesn’t match what’s explained
> >> in the doc
On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 16 Jan 2019, at 18:32, Richard Smith wrote:
>
> > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits <
> > cfe-commits@lists.llvm.org> wrote:
> >
> >> On 16 Jan 2019, at 9:13, Aaron Ballman w
Author: rsmith
Date: Thu Jan 17 14:05:50 2019
New Revision: 351487
URL: http://llvm.org/viewvc/llvm-project?rev=351487&view=rev
Log:
Fix cleanup registration for lambda captures.
Lambda captures should be destroyed if an exception is thrown only if
the construction of the complete lambda-expressi
Author: rsmith
Date: Tue Jan 22 19:37:29 2019
New Revision: 351924
URL: http://llvm.org/viewvc/llvm-project?rev=351924&view=rev
Log:
[ubsan] Check the correct size when sanitizing array new.
We previously forgot to multiply the element size by the array bound.
Modified:
cfe/trunk/lib/CodeGen
Author: rsmith
Date: Wed Jan 23 18:41:46 2019
New Revision: 352011
URL: http://llvm.org/viewvc/llvm-project?rev=352011&view=rev
Log:
Improve diagnostic for -fvisibility mismatch between module/PCH build
and use.
Modified:
cfe/trunk/include/clang/Basic/LangOptions.def
Modified: cfe/trunk/incl
Author: rsmith
Date: Thu Jan 24 12:52:56 2019
New Revision: 352102
URL: http://llvm.org/viewvc/llvm-project?rev=352102&view=rev
Log:
Add a triple to this test so it passes for targets where alignof(double)
really should be equal to alignof(float).
Modified:
cfe/trunk/test/CXX/dcl.dcl/dcl.attr
Hi Hans,
This is a safe change that fixes a crash; it'd be good to get this into
clang 8.
Thanks!
On Sun, 27 Jan 2019, 11:19 Nicolas Lesser via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: rakete
> Date: Sun Jan 27 11:19:59 2019
> New Revision: 352323
>
> URL: http://llvm.org
Hi Sterling,
For a rollback, it's useful to list in the commit message why the change is
being rolled back. Thanks!
On Tue, 29 Jan 2019, 10:27 Sterling Augustine via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: saugustine
> Date: Tue Jan 29 10:27:51 2019
> New Revision: 352524
>
>
Author: rsmith
Date: Tue Jan 29 18:23:34 2019
New Revision: 352593
URL: http://llvm.org/viewvc/llvm-project?rev=352593&view=rev
Log:
Simplify and modernize this code a little.
No functionality change intended.
Modified:
cfe/trunk/lib/Basic/FileManager.cpp
Modified: cfe/trunk/lib/Basic/FileM
Author: rsmith
Date: Wed Oct 31 13:39:26 2018
New Revision: 345774
URL: http://llvm.org/viewvc/llvm-project?rev=345774&view=rev
Log:
Part of PR39508: Emit an @llvm.invariant.start after storing to
__tls_guard.
__tls_guard can only ever transition from 0 to 1, and only once. This
permits LLVM to r
Author: rsmith
Date: Wed Oct 31 17:46:54 2018
New Revision: 345803
URL: http://llvm.org/viewvc/llvm-project?rev=345803&view=rev
Log:
Fix regression in behavior of clang -x c++-header -fmodule-name=XXX
-fsyntax-only.
The driver accidentally stopped passing the input filenames on to -cc1
in this mo
epreocssor").
>
>
>
> *From: *cfe-commits on behalf of
> Richard Smith via cfe-commits
> *Reply-To: *Richard Smith
> *Date: *Wednesday, October 31, 2018 at 5:49 PM
> *To: *"cfe-commits@lists.llvm.org"
> *Subject: *r345803 - Fix regression in behavior of
Author: rsmith
Date: Wed Oct 31 18:05:00 2018
New Revision: 345805
URL: http://llvm.org/viewvc/llvm-project?rev=345805&view=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp
URL:
http://llvm.org/viewvc/l
Author: rsmith
Date: Thu Nov 1 17:24:40 2018
New Revision: 345915
URL: http://llvm.org/viewvc/llvm-project?rev=345915&view=rev
Log:
When building a header module, treat inputs as headers rather than
source files.
This suppresses certain warnings (eg, '#include_next in main source
file').
Modifi
Author: rsmith
Date: Fri Nov 2 19:23:33 2018
New Revision: 346065
URL: http://llvm.org/viewvc/llvm-project?rev=346065&view=rev
Log:
Revert r345562: "PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue
of type"
This exposes a (known) CodeGen bug: it can't cope with emitting lvalue
expre
Author: rsmith
Date: Sat Nov 10 10:02:40 2018
New Revision: 346591
URL: http://llvm.org/viewvc/llvm-project?rev=346591&view=rev
Log:
[cxx_status] Update for San Diego motions.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-pr
On Mon, 12 Nov 2018 at 09:22, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Mon Nov 12 09:19:48 2018
> New Revision: 346677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346677&view=rev
> Log:
> Implement P1094R2 (nested inline namespaces)
>
> As
Author: rsmith
Date: Mon Nov 12 12:11:57 2018
New Revision: 346699
URL: http://llvm.org/viewvc/llvm-project?rev=346699&view=rev
Log:
PR39628 Treat all non-zero values as 'true' in bool compound-assignment
in constant evaluation, not just odd values.
Modified:
cfe/trunk/lib/AST/ExprConstant.cp
Author: rsmith
Date: Wed Nov 14 13:04:34 2018
New Revision: 346892
URL: http://llvm.org/viewvc/llvm-project?rev=346892&view=rev
Log:
[c++20] Implement P0482R6: enable -fchar8_t by default in C++20 mode.
This unfortunately results in a substantial breaking change when
switching to C++20, but it's
Good idea, this LG for a patch release.
On Sat, 17 Nov 2018, 18:48 Shoaib Meenai via cfe-commits <
cfe-commits@lists.llvm.org wrote:
> Could we merge this into 7.0.1? It's a trivial typo fix, and the error
> message could otherwise be confusing to users (someone brought this up in
> IRC a few hou
llvm.org wrote:
> Peanut gallery says: I think the one remaining instance of `-std=libc++`
> in the tests should be fixed at the same time.
>
> –Arthur
>
> On Sat, Nov 17, 2018 at 9:52 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
t; llvm::SmallVectorTemplateCommon void>::back() const [T = clang::APValue::LValuePathEntry]: Assertion
> `!empty()' failed.
>
> On Fri, Aug 3, 2018 at 5:57 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Fri Aug
p/reduced.c
>> llvm::SmallVectorTemplateCommon::const_reference
>> llvm::SmallVectorTemplateCommon> void>::back() const [T = clang::APValue::LValuePathEntry]: Assertion
>> `!empty()' failed.
>>
>> On Fri, Aug 3, 2018 at 5:57 PM Richard Smith via cfe-commits <
&
appened, but sorry for
> the noise.
>
>
>
> *From: *cfe-commits on behalf of
> Richard Smith via cfe-commits
> *Reply-To: *Richard Smith
> *Date: *Monday, November 26, 2018 at 12:01 PM
> *To: *Shoaib Meenai
> *Cc: *cfe-commits , Tom Stellard <
> tstel...@redhat.com
Author: rsmith
Date: Tue Nov 27 11:33:49 2018
New Revision: 347692
URL: http://llvm.org/viewvc/llvm-project?rev=347692&view=rev
Log:
Don't speculatively emit VTTs for classes unless we are able to correctly emit
references to all the functions they will (directly or indirectly) reference.
Summar
Author: rsmith
Date: Tue Nov 27 21:15:46 2018
New Revision: 347729
URL: http://llvm.org/viewvc/llvm-project?rev=347729&view=rev
Log:
PR12884: Add test (bug is already fixed).
Modified:
cfe/trunk/test/SemaTemplate/typename-specifier-3.cpp
Modified: cfe/trunk/test/SemaTemplate/typename-specifi
Author: rsmith
Date: Tue Nov 27 22:25:06 2018
New Revision: 347730
URL: http://llvm.org/viewvc/llvm-project?rev=347730&view=rev
Log:
PR39809: (const void*)0 is not a null pointer constant in C.
Modified:
cfe/trunk/lib/AST/Expr.cpp
cfe/trunk/test/Sema/conditional.c
Modified: cfe/trunk/lib
LGTM
Thanks, welcome aboard :)
On Thu, 29 Nov 2018, 06:01 Brad Smith via cfe-commits <
cfe-commits@lists.llvm.org wrote:
> Add myself as code owner for OpenBSD driver.
>
>
> Index: CODE_OWNERS.TXT
> ===
> --- CODE_OWNERS.TXT (re
This seems is wrong way to handle this, and seems likely to be unsound in
C++. We should be creating a ConstantExpr node wrapped around the
initializer instead.
On Sat, 1 Dec 2018, 00:32 Bill Wendling via cfe-commits <
cfe-commits@lists.llvm.org wrote:
> Author: void
> Date: Sat Dec 1 00:29:36 2
Author: rsmith
Date: Mon Dec 3 18:45:28 2018
New Revision: 348233
URL: http://llvm.org/viewvc/llvm-project?rev=348233&view=rev
Log:
Fix -Wmismatched-tags to not warn on redeclarations of structs in system
headers.
Previously, we would only check whether the new declaration is in a
system header,
Author: rsmith
Date: Tue Dec 4 14:26:32 2018
New Revision: 348313
URL: http://llvm.org/viewvc/llvm-project?rev=348313&view=rev
Log:
Fix crash if an in-class explicit function specialization has explicit
template arguments referring to template paramaeters.
Added:
cfe/trunk/test/SemaTemplate/
On Tue, 4 Dec 2018 at 16:46, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: epilk
> Date: Tue Dec 4 16:43:11 2018
> New Revision: 348325
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348325&view=rev
> Log:
> [Sema] Remove some conditions of a failing assert
>
>
On Wed, 5 Dec 2018, 10:01 George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org wrote:
> These are the cases I get:
>
> #define unexpected(a) { kprintf("unexpected %s:%d\n", __FILE__, __LINE__);
> a; }
>
> and
>
> #if 0
> #define DEBG(fmt, args...) { IOLog(fmt, ## args); kprintf(fmt,
On Wed, 5 Dec 2018 at 11:14, Alex L via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> We have about 100k unique occurrences of this warning across a slice of
> our software stack. It's simply not feasible to us to adopt it, so we would
> prefer for it to be reverted to avoid downstream diverg
On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: steveire
> Date: Mon Dec 10 12:53:32 2018
> New Revision: 348794
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348794&view=rev
> Log:
> Change InitListExpr dump to label and pointer
>
> Su
Author: rsmith
Date: Mon Mar 18 18:51:19 2019
New Revision: 356433
URL: http://llvm.org/viewvc/llvm-project?rev=356433&view=rev
Log:
Factor out repeated code parsing and concatenating header-names from
tokens.
We now actually form an angled_string_literal token for a header name by
concatenation
Author: rsmith
Date: Mon Mar 18 18:51:17 2019
New Revision: 356432
URL: http://llvm.org/viewvc/llvm-project?rev=356432&view=rev
Log:
Don't apply the include depth limit until we actually decide to enter
the file.
NFC unless a skipped #include is found at the final permitted #include
level.
Modif
On Tue, 19 Mar 2019 at 10:24, Artem Dergachev via cfe-commits
wrote:
>
> Hi,
>
> I'll try to fix this ASAP!
It sounds like there might be a missing check for
InitListExpr::isTransparent somewhere. (A transparent InitListExpr
should be treated as equivalent to its one and only subexpression.)
Eith
Author: rsmith
Date: Tue Mar 19 15:09:55 2019
New Revision: 356530
URL: http://llvm.org/viewvc/llvm-project?rev=356530&view=rev
Log:
Replace tok::angle_string_literal with new tok::header_name.
Use the new kind for both angled header-name tokens and for
double-quoted header-name tokens.
This is
Author: rsmith
Date: Thu Mar 21 12:44:17 2019
New Revision: 356704
URL: http://llvm.org/viewvc/llvm-project?rev=356704&view=rev
Log:
Refactor handling of #include directives to cleanly separate the
"skipped header because it should be imported as a module" cases from
the "skipped header because of
Author: rsmith
Date: Thu Mar 21 13:42:13 2019
New Revision: 356712
URL: http://llvm.org/viewvc/llvm-project?rev=356712&view=rev
Log:
Improve the diagnostic for #include_next occurring in a file not found
in the include path.
Instead of making the incorrect claim that the included file has an
abso
Author: rsmith
Date: Thu Apr 11 14:18:22 2019
New Revision: 358230
URL: http://llvm.org/viewvc/llvm-project?rev=358230&view=rev
Log:
Remove use of lookahead from _Pragma handling and from all other
internal lexing steps in the preprocessor.
It is not safe to use the preprocessor's token lookahead
Author: rsmith
Date: Thu Apr 11 14:18:23 2019
New Revision: 358231
URL: http://llvm.org/viewvc/llvm-project?rev=358231&view=rev
Log:
[C++20] Implement context-sensitive header-name lexing and pp-import parsing in
the preprocessor.
Added:
cfe/trunk/test/CXX/cpp/cpp.module/
cfe/trunk/test/
Author: rsmith
Date: Fri Apr 12 21:33:39 2019
New Revision: 358326
URL: http://llvm.org/viewvc/llvm-project?rev=358326&view=rev
Log:
[verify] Add support for location markers in directives.
A marker (matching /#[A-Za-z0-9_-]/) is specified by attaching a comment
containing the marker to the line
Author: rsmith
Date: Sun Apr 14 01:06:59 2019
New Revision: 358353
URL: http://llvm.org/viewvc/llvm-project?rev=358353&view=rev
Log:
[c++20] Parsing support for module-declarations, import-declarations,
and the global and private module fragment.
For now, the private module fragment introducer is
Author: rsmith
Date: Sun Apr 14 04:11:37 2019
New Revision: 358355
URL: http://llvm.org/viewvc/llvm-project?rev=358355&view=rev
Log:
[c++20] Enable driver and frontend support for building and using
modules when -std=c++2a is specified.
Added:
cfe/trunk/test/CXX/module/module.unit/p8.cpp
Author: rsmith
Date: Mon Apr 15 16:55:58 2019
New Revision: 358463
URL: http://llvm.org/viewvc/llvm-project?rev=358463&view=rev
Log:
Simplify diagnosis of misplaced attributes in module-declarations.
No functional change intended.
Modified:
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk
Author: rsmith
Date: Mon Apr 15 17:47:45 2019
New Revision: 358467
URL: http://llvm.org/viewvc/llvm-project?rev=358467&view=rev
Log:
PR41192: fix cases where "missing ';' after class" error would
incorrectly fire.
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/test/CXX/cpp/cpp.m
Author: rsmith
Date: Mon Apr 15 18:44:53 2019
New Revision: 358470
URL: http://llvm.org/viewvc/llvm-project?rev=358470&view=rev
Log:
Tweak test to pass when using a non-integrated assembler.
Modified:
cfe/trunk/test/Driver/modules.cpp
Modified: cfe/trunk/test/Driver/modules.cpp
URL:
http://
ed and an external
> assembler configurations?
Sorry about that. r358470 fixes the test to pass if I add
-fno-integrated-as to all the clang invocations. Does that resolve the
problem you're seeing?
> Douglas Yung
>
> -Original Message-
> From: cfe-commits On Beha
> -fno-integrated-as to all the clang invocations. Does that resolve the
> problem you're seeing?
>
> > Douglas Yung
> >
> > -Original Message-
> > From: cfe-commits On Behalf Of
> > Richard Smith via cfe-commits
> > Sent: Sunday, April 14, 2
Author: rsmith
Date: Wed Apr 17 17:56:58 2019
New Revision: 358631
URL: http://llvm.org/viewvc/llvm-project?rev=358631&view=rev
Log:
[c++2a] Improve diagnostic for use of declaration from another TU's
global module fragment.
We know that the declaration in question should have been introduced by
Author: rsmith
Date: Wed Apr 17 17:57:01 2019
New Revision: 358632
URL: http://llvm.org/viewvc/llvm-project?rev=358632&view=rev
Log:
Add '#pragma clang __debug module_map module.name' to dump the module
map being used for the module 'module.name'.
Modified:
cfe/trunk/include/clang/Basic/Diagn
Author: rsmith
Date: Wed Apr 17 17:57:02 2019
New Revision: 358633
URL: http://llvm.org/viewvc/llvm-project?rev=358633&view=rev
Log:
Split out modules-specific declaration handling from SemaDecl.cpp into a
new SemaModule.cpp.
Added:
cfe/trunk/lib/Sema/SemaModule.cpp
Modified:
cfe/trunk/li
Author: rsmith
Date: Thu Apr 18 14:12:54 2019
New Revision: 358713
URL: http://llvm.org/viewvc/llvm-project?rev=358713&view=rev
Log:
[c++2a] Add semantic support for private module fragments.
Added:
cfe/trunk/test/CXX/basic/basic.link/p2.cpp
cfe/trunk/test/CXX/module/module.interface/
Author: rsmith
Date: Thu Apr 18 19:46:50 2019
New Revision: 358733
URL: http://llvm.org/viewvc/llvm-project?rev=358733&view=rev
Log:
Fix overly-long line after r358731.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
Author: rsmith
Date: Mon Apr 22 15:50:11 2019
New Revision: 358932
URL: http://llvm.org/viewvc/llvm-project?rev=358932&view=rev
Log:
[c++2a] Implement semantic restrictions for 'export' declarations.
Added:
cfe/trunk/test/CXX/module/module.interface/Inputs/
cfe/trunk/test/CXX/module/modul
Author: rsmith
Date: Tue Apr 23 16:48:00 2019
New Revision: 359048
URL: http://llvm.org/viewvc/llvm-project?rev=359048&view=rev
Log:
C++ DR2387: a variable template declared wtih (or instantiated with) a
const-qualified type is not implicitly given internal linkage. But a
variable template declare
Author: rsmith
Date: Tue Apr 23 17:08:02 2019
New Revision: 359051
URL: http://llvm.org/viewvc/llvm-project?rev=359051&view=rev
Log:
Add missing diagnostic for anonymous struct/union definitions that don't
introduce any names.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/Analy
Author: rsmith
Date: Tue Apr 23 18:29:28 2019
New Revision: 359059
URL: http://llvm.org/viewvc/llvm-project?rev=359059&view=rev
Log:
Fix interactions between __builtin_constant_p and constexpr to match
current trunk GCC.
GCC permits information from outside the operand of
__builtin_constant_p (bu
Author: rsmith
Date: Tue Apr 23 19:22:38 2019
New Revision: 359066
URL: http://llvm.org/viewvc/llvm-project?rev=359066&view=rev
Log:
Revert r350917 "[Sema] If CheckPlaceholderExpr rewrites the initializer
of an auto"
This commit changed the initializer expression passed into
initialization (strip
Hi Akira,
I've reverted this in r359066. This subtly breaks the semantics of C++
initializers by strripping off an outer level of parentheses / braces
in some cases. Testcase:
struct A {
A();
A(const A&) = delete;
};
auto x = [a{A()}] {};
(This should be accepted in C++17 mode onwa
Thanks for the revert.
Looks like this is probably an unfortunate interaction with the
internal_linkage attribute.
On Wed, 24 Apr 2019, 01:48 Ilya Biryukov via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Reverted in r359076.
>
> On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov
> wrote:
>
On Wed, 24 Apr 2019 at 13:28, Richard Smith wrote:
>
> Thanks for the revert.
>
> Looks like this is probably an unfortunate interaction with the
> internal_linkage attribute.
I think this is a libc++ bug. When
_LIBCPP_HIDE_FROM_ABI_PER_TU_BY_DEFAULT is enabled, we have:
#define _LIBCPP_HIDE_FR
Thanks! Can you update cxx_status.html to mark P0595R2 as done?
On Tue, 23 Apr 2019 at 19:21, Eric Fiselier via cfe-commits
wrote:
>
> Author: ericwf
> Date: Tue Apr 23 19:23:30 2019
> New Revision: 359067
>
> URL: http://llvm.org/viewvc/llvm-project?rev=359067&view=rev
> Log:
> [Builtins] Implem
Author: rsmith
Date: Wed Apr 24 16:45:56 2019
New Revision: 359155
URL: http://llvm.org/viewvc/llvm-project?rev=359155&view=rev
Log:
PR41427: This has apparently been fixed already, just add a regression
test.
Added:
cfe/trunk/test/SemaTemplate/ctad.cpp
Added: cfe/trunk/test/SemaTemplate/cta
Author: rsmith
Date: Wed Apr 24 17:22:11 2019
New Revision: 359158
URL: http://llvm.org/viewvc/llvm-project?rev=359158&view=rev
Log:
Fix typo in comment in r312851.
Thanks to Nico Weber for pointing this out!
Modified:
cfe/trunk/include/clang/Basic/SourceManager.h
Modified: cfe/trunk/includ
On Fri, 29 Mar 2019 at 05:41, Nico Weber via cfe-commits
wrote:
>
>
> (below)
>
> On Fri, Sep 8, 2017 at 9:15 PM Richard Smith via cfe-commits
> wrote:
>>
>> Author: rsmith
>> Date: Fri Sep 8 18:14:04 2017
>> New Revision: 312851
>>
>> UR
On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits
wrote:
> Do I just edit the HTML file directly?
> Or is it generated by something?
Just edit the HTML file directly.
> On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote:
>>
>> Thanks! Can you update cxx_status.html to mark P0595R2 as
Author: rsmith
Date: Thu Apr 25 18:51:07 2019
New Revision: 359259
URL: http://llvm.org/viewvc/llvm-project?rev=359259&view=rev
Log:
Add missing diagnostic for explicit instantiation declarations naming
internal linkage entities.
Such constructs are ill-formed by [temp.explicit]p13. We make a spe
Author: rsmith
Date: Thu Apr 25 18:51:08 2019
New Revision: 359260
URL: http://llvm.org/viewvc/llvm-project?rev=359260&view=rev
Log:
C++ DR2387: a variable template declared wtih (or instantiated with) a
const-qualified type is not implicitly given internal linkage. But a
variable template declare
Author: rsmith
Date: Thu Apr 25 18:51:08 2019
New Revision: 359261
URL: http://llvm.org/viewvc/llvm-project?rev=359261&view=rev
Log:
[www] Rebuild cxx_dr_status.
Modified:
cfe/trunk/test/CXX/drs/dr17xx.cpp
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/test/CXX/drs/dr17xx.cpp
URL:
Author: rsmith
Date: Thu Apr 25 19:11:23 2019
New Revision: 359266
URL: http://llvm.org/viewvc/llvm-project?rev=359266&view=rev
Log:
PR41607: Don't forget to substitute outer template arguments into a
class-scope explicit specialization of a class template.
Modified:
cfe/trunk/include/clang/A
Author: rsmith
Date: Fri Apr 26 19:58:17 2019
New Revision: 359367
URL: http://llvm.org/viewvc/llvm-project?rev=359367&view=rev
Log:
Reinstate r359059, reverted in r359361, with a fix to properly prevent
us emitting the operand of __builtin_constant_p if it has side-effects.
Original commit messa
Author: rsmith
Date: Wed May 1 17:49:14 2019
New Revision: 359747
URL: http://llvm.org/viewvc/llvm-project?rev=359747&view=rev
Log:
Replace ad-hoc tracking of pattern for an instantiated class-scope
explicit function specialization with the MemberSpecializationInfo used
everywhere else.
Not NFC:
Author: rsmith
Date: Wed May 1 17:49:05 2019
New Revision: 359746
URL: http://llvm.org/viewvc/llvm-project?rev=359746&view=rev
Log:
Diagnose non-dependent qualified friend function template declarations
that don't match any existing declaration. Don't get confused and treat
such declarations as t
On Thu, 2 May 2019 at 10:43, Reid Kleckner via cfe-commits
wrote:
>
> Author: rnk
> Date: Thu May 2 10:45:54 2019
> New Revision: 359809
>
> URL: http://llvm.org/viewvc/llvm-project?rev=359809&view=rev
> Log:
> Use primary template parameter names for variable template debug info
>
> Summary:
> F
Author: rsmith
Date: Thu May 2 16:21:28 2019
New Revision: 359844
URL: http://llvm.org/viewvc/llvm-project?rev=359844&view=rev
Log:
Fix -Wunsequenced false-positives in code controlled by a branch on
__builtin_constant_p.
If the operand of __builtin_constant_p is not constant and has
side-effect
This will trigger computation and caching the linkage of the
declaration too early (before we actually know it) in some cases. For
instance, I believe this is causing a rejects-valid on:
typedef struct __attribute__((visibility("hidden"))) {} A;
... which we used to accept but now reject with:
:
Author: rsmith
Date: Fri May 3 16:51:38 2019
New Revision: 359947
URL: http://llvm.org/viewvc/llvm-project?rev=359947&view=rev
Log:
CWG issue 727: Fix numerous bugs in support for class-scope explicit
specializations for variable templates.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cf
Author: rsmith
Date: Fri May 3 17:23:18 2019
New Revision: 359951
URL: http://llvm.org/viewvc/llvm-project?rev=359951&view=rev
Log:
[cxx_status] Replace "SVN" entries with Clang 8 as appropriate.
Also: use the "svn" color for "explicit(bool)" rather than the "full" color.
Modified:
cfe/trun
Author: rsmith
Date: Fri May 3 17:27:21 2019
New Revision: 359953
URL: http://llvm.org/viewvc/llvm-project?rev=359953&view=rev
Log:
[cxx_status] Don't list -fmodules / -fmodules-ts against C++ modules
support; those turn on different modules modes. The real C++ modules
support is behind -std=c++2
Author: rsmith
Date: Fri May 3 21:00:45 2019
New Revision: 359958
URL: http://llvm.org/viewvc/llvm-project?rev=359958&view=rev
Log:
Disallow the operand of __builtin_constant_p from modifying enclosing
state when it's encountered while evaluating a constexpr function.
We attempt to follow GCC tr
Author: rsmith
Date: Fri May 3 22:20:14 2019
New Revision: 359962
URL: http://llvm.org/viewvc/llvm-project?rev=359962&view=rev
Log:
Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives
where either the modification or the other access is unreachable.
Modified:
cfe/trunk/incl
Author: rsmith
Date: Fri May 3 23:46:18 2019
New Revision: 359964
URL: http://llvm.org/viewvc/llvm-project?rev=359964&view=rev
Log:
[c++20] Implement tweaked __VA_OPT__ rules from P1042R1:
* __VA_OPT__ is expanded if the *expanded* __VA_ARGS__ is non-empty,
not if the original argument conta
Author: rsmith
Date: Sun May 5 20:47:15 2019
New Revision: 360006
URL: http://llvm.org/viewvc/llvm-project?rev=360006&view=rev
Log:
[c++20] Implement P1009R2: allow omitting the array bound in an array
new expression.
This was voted into C++20 as a defect report resolution, so we
retroactively a
Author: rsmith
Date: Sun May 5 21:00:45 2019
New Revision: 360007
URL: http://llvm.org/viewvc/llvm-project?rev=360007&view=rev
Log:
Fix up after r360006.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/modernize/MakeS
301 - 400 of 4192 matches
Mail list logo
