Re: r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

2018-08-07 Thread Richard Smith via cfe-commits
ls very standard-ese-y to me? & I appreciate teh > desire/need for precision, I wonder if there's better ways to communicate > it to the user... :/ > > On Tue, Jul 31, 2018 at 6:03 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> A

r339187 - Clean up and simplify RequireCompleteType.

2018-08-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 7 14:35:41 2018 New Revision: 339187 URL: http://llvm.org/viewvc/llvm-project?rev=339187&view=rev Log: Clean up and simplify RequireCompleteType. No functional change intended, except that we will now produce more "declared here" notes. Modified: cfe/trunk/lib/S

r339210 - PR38286: Don't crash when attempting to define a constructor for an

2018-08-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 7 17:42:42 2018 New Revision: 339210 URL: http://llvm.org/viewvc/llvm-project?rev=339210&view=rev Log: PR38286: Don't crash when attempting to define a constructor for an incomplete class template. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/test/S

Re: r339210 - PR38286: Don't crash when attempting to define a constructor for an

2018-08-07 Thread Richard Smith via cfe-commits
Would be good to get this into the Clang 7 release. On Tue, 7 Aug 2018 at 17:43, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Aug 7 17:42:42 2018 > New Revision: 339210 > > URL: http://llvm.org/viewvc/llvm-project?rev=

r339304 - Delete some unreachable AST printing code.

2018-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 8 17:44:49 2018 New Revision: 339304 URL: http://llvm.org/viewvc/llvm-project?rev=339304&view=rev Log: Delete some unreachable AST printing code. Modified: cfe/trunk/lib/AST/TypePrinter.cpp Modified: cfe/trunk/lib/AST/TypePrinter.cpp URL: http://llvm.org/viewvc

r339306 - Refactor attribute printing to be a bit more obviously-correct.

2018-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 8 18:21:06 2018 New Revision: 339306 URL: http://llvm.org/viewvc/llvm-project?rev=339306&view=rev Log: Refactor attribute printing to be a bit more obviously-correct. No functionality change intended. Added: cfe/trunk/test/Misc/ast-print-attr.c Modified: cfe

Re: r339387 - Revert -r339382, which apparently breaks the Windows build.

2018-08-09 Thread Richard Smith via cfe-commits
On Thu, 9 Aug 2018 at 14:14, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Thu Aug 9 14:13:46 2018 > New Revision: 339387 > > URL: http://llvm.org/viewvc/llvm-project?rev=339387&view=rev > Log: > Revert -r339382, which apparently breaks the Windows

r339624 - Fix Clang warnings and bad #include filenames in r339595 and r339599.

2018-08-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 13 15:07:11 2018 New Revision: 339624 URL: http://llvm.org/viewvc/llvm-project?rev=339624&view=rev Log: Fix Clang warnings and bad #include filenames in r339595 and r339599. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h

r339623 - Model type attributes as regular Attrs.

2018-08-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 13 15:07:09 2018 New Revision: 339623 URL: http://llvm.org/viewvc/llvm-project?rev=339623&view=rev Log: Model type attributes as regular Attrs. Specifically, AttributedType now tracks a regular attr::Kind rather than having its own parallel Kind enumeration, and Attri

r339747 - Silence "unused variable" warning.

2018-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 14 18:06:30 2018 New Revision: 339747 URL: http://llvm.org/viewvc/llvm-project?rev=339747&view=rev Log: Silence "unused variable" warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngi

[libcxxabi] r339952 - Factor Node creation out of the demangler. No functionality change intended.

2018-08-16 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 16 15:04:36 2018 New Revision: 339952 URL: http://llvm.org/viewvc/llvm-project?rev=339952&view=rev Log: Factor Node creation out of the demangler. No functionality change intended. (This is a port of llvm r339944 to libcxxabi.) Modified: libcxxabi/trunk/src/cxa_d

r340074 - Improve diagnostic for missing comma in template parameter list.

2018-08-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 17 12:43:40 2018 New Revision: 340074 URL: http://llvm.org/viewvc/llvm-project?rev=340074&view=rev Log: Improve diagnostic for missing comma in template parameter list. Given 'typename T typename U', we would correctly diagnose the missing comma, but incorrectly disam

r340215 - Model type attributes as regular Attrs.

2018-08-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 20 14:47:29 2018 New Revision: 340215 URL: http://llvm.org/viewvc/llvm-project?rev=340215&view=rev Log: Model type attributes as regular Attrs. Specifically, AttributedType now tracks a regular attr::Kind rather than having its own parallel Kind enumeration, and Attri

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-21 Thread Richard Smith via cfe-commits
align 128 > %indirect-arg-temp) #2 > ... > > declare i32 @somefunc() local_unnamed_addr #1 > > Equivalent C code at least generates variadic function prototype correctly > : > > %call1 = call i32 (<16 x i64>*, ...) bitcast (i32 (...)* @somefunc to i32 > (<16 x i64&

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-22 Thread Richard Smith via cfe-commits
itcast (i32 ()* @somefunc to i32 > (<16 x i64>*, ...)*)(<16 x i64>* byval nonnull align 128 > %indirect-arg-temp) #2 > ... > > declare i32 @somefunc() local_unnamed_addr #1 > > Equivalent C code at least generates variadic function prototype correctly: > > %call1

r332076 - Improve diagnostics and error recovery for template name lookup.

2018-05-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 10 19:43:08 2018 New Revision: 332076 URL: http://llvm.org/viewvc/llvm-project?rev=332076&view=rev Log: Improve diagnostics and error recovery for template name lookup. For 'x::template y', consistently give a "no member named 'y' in 'x'" diagnostic if there is no suc

r332130 - [libclang] Stop assuming that the internal C++ ABI ExceptionSpecificationType enumeration is the same as CXCursor_ExceptionSpecificationKind.

2018-05-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 11 12:46:31 2018 New Revision: 332130 URL: http://llvm.org/viewvc/llvm-project?rev=332130&view=rev Log: [libclang] Stop assuming that the internal C++ ABI ExceptionSpecificationType enumeration is the same as CXCursor_ExceptionSpecificationKind. Modified: cfe/tru

r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

2018-05-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 14 13:15:04 2018 New Revision: 332286 URL: http://llvm.org/viewvc/llvm-project?rev=332286&view=rev Log: PR37450: Fix bug that disabled some type checks for variables with deduced types. Also improve diagnostic for the case where a type is non-literal because it's a

r332291 - Fix regression in r332076.

2018-05-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 14 13:52:48 2018 New Revision: 332291 URL: http://llvm.org/viewvc/llvm-project?rev=332291&view=rev Log: Fix regression in r332076. If the name after 'template' is an unresolved using declaration (not containing 'typename'), then we don't yet know if it's a valid templ

r332401 - Don't produce a redundant "auto type is incompatible with C++98" on every lambda with no explicit return type.

2018-05-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 15 14:27:30 2018 New Revision: 332401 URL: http://llvm.org/viewvc/llvm-project?rev=332401&view=rev Log: Don't produce a redundant "auto type is incompatible with C++98" on every lambda with no explicit return type. We already warned about the lambda, and we don't hav

Re: r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

2018-05-15 Thread Richard Smith via cfe-commits
> You didn't get a notification because your commit was around the same time > as a fix for an unrelated testcase issue that caused same bots to be red. > > -- > Maxim Kuvyrkov > www.linaro.org > > > > > On May 14, 2018, at 11:15 PM, Richard Smith via cfe-commi

r332425 - Fix 32-bit buildbots.

2018-05-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 15 18:08:07 2018 New Revision: 332425 URL: http://llvm.org/viewvc/llvm-project?rev=332425&view=rev Log: Fix 32-bit buildbots. Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp URL: http://llvm.org/vie

Re: r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

2018-05-15 Thread Richard Smith via cfe-commits
ue that caused same bots to be >> red. >> >> -- >> Maxim Kuvyrkov >> www.linaro.org >> >> >> >> > On May 14, 2018, at 11:15 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> > >> > Auth

Re: r276514 - [cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a literal-type in C++1z

2018-05-16 Thread Richard Smith via cfe-commits
On 17 February 2017 at 18:03, Richard Smith wrote: > On 22 July 2016 at 21:05, Faisal Vali via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: faisalv >> Date: Fri Jul 22 23:05:19 2016 >> New Revision: 276514 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=276514&view=rev >> Lo

Re: r332470 - Add support for __declspec(code_seg("segname"))

2018-05-18 Thread Richard Smith via cfe-commits
On 16 May 2018 at 06:57, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Wed May 16 06:57:17 2018 > New Revision: 332470 > > URL: http://llvm.org/viewvc/llvm-project?rev=332470&view=rev > Log: > Add support for __declspec(code_seg("segname")) > > Add s

Re: r332470 - Add support for __declspec(code_seg("segname"))

2018-05-18 Thread Richard Smith via cfe-commits
Here's an example regression: https://godbolt.org/g/S72Nki I'll check that into the test suite alongside the revert once my testing finishes. On 18 May 2018 at 13:03, Richard Smith wrote: > On 16 May 2018 at 06:57, Erich Keane via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author:

r332760 - Revert r332470 (and corresponding tests in r332492).

2018-05-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 18 13:18:17 2018 New Revision: 332760 URL: http://llvm.org/viewvc/llvm-project?rev=332760&view=rev Log: Revert r332470 (and corresponding tests in r332492). This regressed our support for __attribute__((section)). See added test file for example of code broken by this

r332879 - Revert r332028; see PR37545 for details.

2018-05-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 21 13:10:54 2018 New Revision: 332879 URL: http://llvm.org/viewvc/llvm-project?rev=332879&view=rev Log: Revert r332028; see PR37545 for details. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/trunk/test/CodeGenCXX/rtti-linkage.cpp Modified: cfe/trunk/l

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
On 21 May 2018 at 09:09, Serge Pavlov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sepavloff > Date: Mon May 21 09:09:54 2018 > New Revision: 332847 > > URL: http://llvm.org/viewvc/llvm-project?rev=332847&view=rev > Log: > [CodeGen] Recognize more cases of zero initialization > >

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
On 21 May 2018 at 13:22, Richard Smith wrote: > On 21 May 2018 at 09:09, Serge Pavlov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: sepavloff >> Date: Mon May 21 09:09:54 2018 >> New Revision: 332847 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=332847&view=rev >> Log:

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
Reverted in r332886; I added a testcase for the miscompile below to test/CodeGenCXX/reference-init.cpp On 21 May 2018 at 13:28, Richard Smith wrote: > On 21 May 2018 at 13:22, Richard Smith wrote: > >> On 21 May 2018 at 09:09, Serge Pavlov via cfe-commits < >> cfe-commits@lists.llvm.org> wrote:

r332886 - Revert r332847; it caused us to miscompile certain forms of reference initialization.

2018-05-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 21 13:36:58 2018 New Revision: 332886 URL: http://llvm.org/viewvc/llvm-project?rev=332886&view=rev Log: Revert r332847; it caused us to miscompile certain forms of reference initialization. Added: cfe/trunk/test/SemaCXX/large-array-init.cpp - copied unchang

r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 22 17:09:29 2018 New Revision: 333044 URL: http://llvm.org/viewvc/llvm-project?rev=333044&view=rev Log: Use zeroinitializer for (trailing zero portion of) large array initializers more reliably. Clang has two different ways it emits array constants (from InitListExprs

Re: r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-23 Thread Richard Smith via cfe-commits
OK, thanks for the revert. On Wed, 23 May 2018, 01:28 Hans Wennborg via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > We're hitting asserts after this in Chromium. I've filed PR37560 and > reverted in r333067. > > On Wed, May 23, 2018 at 2:09 AM, Richard Sm

r333126 - Rework __builtin_classify_type support to better match GCC and to not assert on

2018-05-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 23 14:18:00 2018 New Revision: 333126 URL: http://llvm.org/viewvc/llvm-project?rev=333126&view=rev Log: Rework __builtin_classify_type support to better match GCC and to not assert on unusual types. Following the observed behavior of GCC, we now return -1 for vector t

r333141 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 23 16:41:38 2018 New Revision: 333141 URL: http://llvm.org/viewvc/llvm-project?rev=333141&view=rev Log: Use zeroinitializer for (trailing zero portion of) large array initializers more reliably. This re-commits r333044 with a fix for PR37560. Modified: cfe/trunk/

r333220 - Improve diagnostics for config mismatches with -fmodule-file.

2018-05-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 24 13:03:51 2018 New Revision: 333220 URL: http://llvm.org/viewvc/llvm-project?rev=333220&view=rev Log: Improve diagnostics for config mismatches with -fmodule-file. Unless the user uses -Wno-module-file-config-mismatch (or -Wno-error=...), allow the AST reader to pro

r333233 - Switch a couple of users of LangOpts::GNUMode to the more appropriate LangOpts::GNUKeywords.

2018-05-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 24 14:51:52 2018 New Revision: 333233 URL: http://llvm.org/viewvc/llvm-project?rev=333233&view=rev Log: Switch a couple of users of LangOpts::GNUMode to the more appropriate LangOpts::GNUKeywords. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp cfe/trunk/li

r333234 - Improve diagonstic for braced-init-list as operand to ?: expression.

2018-05-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 24 15:02:52 2018 New Revision: 333234 URL: http://llvm.org/viewvc/llvm-project?rev=333234&view=rev Log: Improve diagonstic for braced-init-list as operand to ?: expression. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp cfe/trunk/test/Parser/cxx11-brace-initializ

Re: r333333 - Test commit; please ignore.

2018-05-25 Thread Richard Smith via cfe-commits
Congratulations? On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Fri May 25 19:29:14 2018 > New Revision: 33 > > URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev > Log: > Test commit; please ignore. > > Modi

Re: r333141 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-29 Thread Richard Smith via cfe-commits
e). See the tests in CodeGenCXX/cxx11-initializer-aggregate.cpp in namespace PR37560 for examples. > On Wed, May 23, 2018 at 4:45 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 23 16:41:38 2018 >> New Revi

r333482 - Revert r332839.

2018-05-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 29 17:45:10 2018 New Revision: 333482 URL: http://llvm.org/viewvc/llvm-project?rev=333482&view=rev Log: Revert r332839. This is causing miscompiles and "definition with same mangled name as another definition" errors. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI

Re: r332839 - [CodeGen] Disable aggressive structor optimizations at -O0, take 2

2018-05-29 Thread Richard Smith via cfe-commits
Sorry, this is still resulting in problems: we're seeing miscompiles and "definition with same mangled name as another definition" errors after this change. It seems plausible that this is a pre-existing issue that's just being exposed by this change, but either way I've temporarily reverted this i

r333489 - Make the mangled name collision diagnostic a bit more useful by listing the mangling.

2018-05-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 29 18:52:16 2018 New Revision: 333489 URL: http://llvm.org/viewvc/llvm-project?rev=333489&view=rev Log: Make the mangled name collision diagnostic a bit more useful by listing the mangling. This helps especially when the collision is for a template specialization, wh

r314231 - Resolve a defect in C++17 copy omission.

2017-09-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 26 11:37:55 2017 New Revision: 314231 URL: http://llvm.org/viewvc/llvm-project?rev=314231&view=rev Log: Resolve a defect in C++17 copy omission. When selecting constructors for initializing an object of type T from a single expression of class type U, also consider co

r314246 - Fix uninitialized member found by msan build bot.

2017-09-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 26 14:33:43 2017 New Revision: 314246 URL: http://llvm.org/viewvc/llvm-project?rev=314246&view=rev Log: Fix uninitialized member found by msan build bot. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm

r314570 - Add a "vexing parse" warning for ambiguity between a variable declaration and a

2017-09-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 29 16:57:25 2017 New Revision: 314570 URL: http://llvm.org/viewvc/llvm-project?rev=314570&view=rev Log: Add a "vexing parse" warning for ambiguity between a variable declaration and a function-style cast. This fires for cases such as T(x); ... where 'x' was previo

r314733 - PR33839: Fix -Wunused handling for structured binding declarations.

2017-10-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 2 15:43:36 2017 New Revision: 314733 URL: http://llvm.org/viewvc/llvm-project?rev=314733&view=rev Log: PR33839: Fix -Wunused handling for structured binding declarations. We warn about a structured binding declaration being unused only if none of its bindings are use

r314754 - R34811: Allow visibilities other than 'default' for VisibleNoLinkage entities.

2017-10-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 2 18:58:15 2017 New Revision: 314754 URL: http://llvm.org/viewvc/llvm-project?rev=314754&view=rev Log: R34811: Allow visibilities other than 'default' for VisibleNoLinkage entities. Modified: cfe/trunk/lib/AST/Decl.cpp cfe/trunk/test/CodeGenCXX/visibility-inl

Re: r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-10-02 Thread Richard Smith via cfe-commits
en they should have some other visibility (it should only cause too much visibility, not too little), and it's not obvious to me how that could result in the link error on the Chromium bot. > Peter > > On Thu, Sep 21, 2017 at 9:33 PM, Richard Smith via cfe-commits < > cfe-commits@lists

r314838 - Suppress -Wmissing-braces warning when aggregate-initializing a struct with a single field that is itself an aggregate.

2017-10-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 3 13:36:00 2017 New Revision: 314838 URL: http://llvm.org/viewvc/llvm-project?rev=314838&view=rev Log: Suppress -Wmissing-braces warning when aggregate-initializing a struct with a single field that is itself an aggregate. In C++, such initialization of std::array t

r314871 - PR34822: Fix a collection of related bugs with our handling of C89 implicit function declarations.

2017-10-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 3 18:49:22 2017 New Revision: 314871 URL: http://llvm.org/viewvc/llvm-project?rev=314871&view=rev Log: PR34822: Fix a collection of related bugs with our handling of C89 implicit function declarations. We were injecting the function into the wrong semantic context,

r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2017-10-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 3 18:58:22 2017 New Revision: 314872 URL: http://llvm.org/viewvc/llvm-project?rev=314872&view=rev Log: We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKi

r314955 - Remove PendingBody mechanism for function and ObjC method deserialization.

2017-10-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 4 17:43:38 2017 New Revision: 314955 URL: http://llvm.org/viewvc/llvm-project?rev=314955&view=rev Log: Remove PendingBody mechanism for function and ObjC method deserialization. In its place, track on the canonical function declaration whether there is a declaration

r314957 - Add testcase for r314956:

2017-10-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 4 17:48:18 2017 New Revision: 314957 URL: http://llvm.org/viewvc/llvm-project?rev=314957&view=rev Log: Add testcase for r314956: PR33924: Merge block-scope anonymous declarations if there are multiple definitions of the enclosing function. Added: cfe/trunk/test

r315005 - Fix two-phase name lookup for non-dependent overloaded operators.

2017-10-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 5 12:35:51 2017 New Revision: 315005 URL: http://llvm.org/viewvc/llvm-project?rev=315005&view=rev Log: Fix two-phase name lookup for non-dependent overloaded operators. If we resolve an overloaded operator call to a specific function during template definition, don't

r315251 - [Modules TS] Module ownership semantics for redeclarations.

2017-10-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 9 16:42:09 2017 New Revision: 315251 URL: http://llvm.org/viewvc/llvm-project?rev=315251&view=rev Log: [Modules TS] Module ownership semantics for redeclarations. When declaring an entity in the "purview" of a module, it's never a redeclaration of an entity in the pu

r315256 - [Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module.

2017-10-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 9 17:49:38 2017 New Revision: 315256 URL: http://llvm.org/viewvc/llvm-project?rev=315256&view=rev Log: [Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module. This works around a language issue where adding a typ

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

2017-10-10 Thread Richard Smith via cfe-commits
rs. Did it not? I'll also send you the repros separately. Regards, Eric On Tue, Oct 10, 2017 at 1:42 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Oct 9 16:42:09 2017 > New Revision: 315251 > > URL: http://llvm.org

r315366 - Add test for regression caused by reverted patch r315251.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 14:07:44 2017 New Revision: 315366 URL: http://llvm.org/viewvc/llvm-project?rev=315366&view=rev Log: Add test for regression caused by reverted patch r315251. Modified: cfe/trunk/test/SemaCXX/linkage2.cpp Modified: cfe/trunk/test/SemaCXX/linkage2.cpp URL: htt

r315379 - [Modules TS] Module ownership semantics for redeclarations.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 15:33:17 2017 New Revision: 315379 URL: http://llvm.org/viewvc/llvm-project?rev=315379&view=rev Log: [Modules TS] Module ownership semantics for redeclarations. When declaring an entity in the "purview" of a module, it's never a redeclaration of an entity in the pu

r315381 - [Modules TS] Diagnose attempts to enter module implementation units without the module interface being available.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 15:35:27 2017 New Revision: 315381 URL: http://llvm.org/viewvc/llvm-project?rev=315381&view=rev Log: [Modules TS] Diagnose attempts to enter module implementation units without the module interface being available. Added: cfe/trunk/test/CXX/modules-ts/dcl.dcl/

r315397 - [Modules TS] Diagnose missing/duplicate module-declaration.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 17:36:56 2017 New Revision: 315397 URL: http://llvm.org/viewvc/llvm-project?rev=315397&view=rev Log: [Modules TS] Diagnose missing/duplicate module-declaration. Added: cfe/trunk/test/CXX/modules-ts/dcl.dcl/dcl.module/p1.cpp Modified: cfe/trunk/include/clang

r315402 - [modules] Only take visible using-directives into account during name lookup.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 18:19:11 2017 New Revision: 315402 URL: http://llvm.org/viewvc/llvm-project?rev=315402&view=rev Log: [modules] Only take visible using-directives into account during name lookup. Added: cfe/trunk/test/Modules/using-directive.cpp Modified: cfe/trunk/lib/Sema

r315408 - [modules] Fix visibility checking for using declarations via ADL.

2017-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 10 18:49:57 2017 New Revision: 315408 URL: http://llvm.org/viewvc/llvm-project?rev=315408&view=rev Log: [modules] Fix visibility checking for using declarations via ADL. We want to check whether the using (shadow) declaration itself is visible, not whether its target

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

2017-10-11 Thread Richard Smith via cfe-commits
On 22 September 2017 at 18:00, Volodymyr Sapsai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Sep 21, 2017, at 15:17, Richard Smith wrote: > > On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: vsapsai >> Date: Fri S

Re: [PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

2017-10-12 Thread Richard Smith via cfe-commits
On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > lebedev.ri reopened this revision. > lebedev.ri added a comment. > This revision is now accepted and ready to land. > > Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that i

Re: [PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

2017-10-12 Thread Richard Smith via cfe-commits
On 12 October 2017 at 15:41, Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith > wrote: > > On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via > cfe-commits > > wrote: > >> > >> lebedev.ri reopened this revision. > >>

r315662 - Support for destroying operator delete, per C++2a proposal P0722.

2017-10-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 12 18:55:36 2017 New Revision: 315662 URL: http://llvm.org/viewvc/llvm-project?rev=315662&view=rev Log: Support for destroying operator delete, per C++2a proposal P0722. This feature is not (yet) approved by the C++ committee, so this is liable to be reverted or signi

r315784 - Fix backwards warning for use of C++17 attributes-on-namespaces-and-enumerators feature.

2017-10-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 13 17:56:24 2017 New Revision: 315784 URL: http://llvm.org/viewvc/llvm-project?rev=315784&view=rev Log: Fix backwards warning for use of C++17 attributes-on-namespaces-and-enumerators feature. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td cf

r316055 - [modules] When finding the owning module of an instantiated context in template

2017-10-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 17 18:41:38 2017 New Revision: 316055 URL: http://llvm.org/viewvc/llvm-project?rev=316055&view=rev Log: [modules] When finding the owning module of an instantiated context in template instantiation, follow lexical parents not semantic ones: we want to find the module w

r316056 - Provide a flag group to turn on/off all "binary literals" extension warnings.

2017-10-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 17 19:19:24 2017 New Revision: 316056 URL: http://llvm.org/viewvc/llvm-project?rev=316056&view=rev Log: Provide a flag group to turn on/off all "binary literals" extension warnings. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/

r316136 - Don't suppress instantiation of definitions for variables subject to explicit

2017-10-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 18 15:45:01 2017 New Revision: 316136 URL: http://llvm.org/viewvc/llvm-project?rev=316136&view=rev Log: Don't suppress instantiation of definitions for variables subject to explicit instantiation declarations if they are usable from constant expressions. We are permit

r316195 - Revert r316193.

2017-10-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 19 17:25:07 2017 New Revision: 316195 URL: http://llvm.org/viewvc/llvm-project?rev=316195&view=rev Log: Revert r316193. This patch breaks users using -fno-canonical-prefixes, for whom resolving symlinks is not acceptable. Removed: cfe/trunk/test/Preprocessor/depe

r316245 - Implement current CWG direction for support of arrays of unknown bounds in

2017-10-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 20 15:56:25 2017 New Revision: 316245 URL: http://llvm.org/viewvc/llvm-project?rev=316245&view=rev Log: Implement current CWG direction for support of arrays of unknown bounds in constant expressions. We permit array-to-pointer decay on such arrays, but disallow point

r316310 - For better compatibility with C++11 and C++14, emit a nondiscardable definition

2017-10-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Oct 22 20:58:34 2017 New Revision: 316310 URL: http://llvm.org/viewvc/llvm-project?rev=316310&view=rev Log: For better compatibility with C++11 and C++14, emit a nondiscardable definition of a static constexpr data member if it's defined 'constexpr' out of line, not only i

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-23 Thread Richard Smith via cfe-commits
lso generated IR doesn't seem to be correct > if I compare with the similar code in C. > > Example: > 1 typedef long long16 __attribute__((ext_vector_type(16))); > 2 void test_somefunc( __global int *d, __global void *s ) > 3 { > 4 int i = get_global_id(0); > 5 d[i

[libcxxabi] r340671 - Port my recent changes from LLVM copy of the demangler:

2018-08-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 24 16:30:26 2018 New Revision: 340671 URL: http://llvm.org/viewvc/llvm-project?rev=340671&view=rev Log: Port my recent changes from LLVM copy of the demangler: r340663 - Allow Allocator::make to make a node of a different type than that requested. r340664 -

[libcxx] r340778 - Fix ODR violation: namespace-scope helpers should not be declared 'static'.

2018-08-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 27 14:41:50 2018 New Revision: 340778 URL: http://llvm.org/viewvc/llvm-project?rev=340778&view=rev Log: Fix ODR violation: namespace-scope helpers should not be declared 'static'. Modified: libcxx/trunk/include/variant Modified: libcxx/trunk/include/variant URL:

r341009 - Adjust Attr representation so that changes to documentation don't affect

2018-08-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 29 18:01:07 2018 New Revision: 341009 URL: http://llvm.org/viewvc/llvm-project?rev=341009&view=rev Log: Adjust Attr representation so that changes to documentation don't affect how we parse source code. Instead of implicitly opting all undocumented attributes out of '

r341098 - Add missing -Wc++11-compat / -Wc++14-compat warnings for:

2018-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 30 12:16:35 2018 New Revision: 341098 URL: http://llvm.org/viewvc/llvm-project?rev=341098&view=rev Log: Add missing -Wc++11-compat / -Wc++14-compat warnings for: * generic lambdas * return type deduction * class template argument deduction Added: cfe/trunk/tes

r341097 - Improve attribute documentation to list which spellings are used in which syntaxes.

2018-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 30 12:16:33 2018 New Revision: 341097 URL: http://llvm.org/viewvc/llvm-project?rev=341097&view=rev Log: Improve attribute documentation to list which spellings are used in which syntaxes. Summary: Instead of listing all the spellings (including attribute namespaces)

r341099 - Add test file missed from r341097.

2018-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 30 12:17:11 2018 New Revision: 341099 URL: http://llvm.org/viewvc/llvm-project?rev=341099&view=rev Log: Add test file missed from r341097. Added: cfe/trunk/test/SemaCXX/cxx14-compat.cpp Added: cfe/trunk/test/SemaCXX/cxx14-compat.cpp URL: http://llvm.org/viewvc/l

r341100 - Update FIXME as requested in code review.

2018-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 30 12:19:15 2018 New Revision: 341100 URL: http://llvm.org/viewvc/llvm-project?rev=341100&view=rev Log: Update FIXME as requested in code review. Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp URL:

Re: r341099 - Add test file missed from r341097.

2018-08-30 Thread Richard Smith via cfe-commits
On Thu, 30 Aug 2018 at 12:18, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 30 12:17:11 2018 > New Revision: 341099 > > URL: http://llvm.org/viewvc/llvm-project?rev=341099&view=rev > Log: > Add test file miss

Re: [PATCH] D51473: Improve attribute documentation to list which spellings are used in which syntaxes.

2018-08-30 Thread Richard Smith via cfe-commits
On Thu, 30 Aug 2018 at 12:27, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via > Phabricator wrote: > > rsmith marked an inline comment as done. > > rsmith added inline comments. > > > > > > > > Com

r341110 - [cxx_status] Use the correct color for a feature in "SVN" status

2018-08-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 30 13:15:28 2018 New Revision: 341110 URL: http://llvm.org/viewvc/llvm-project?rev=341110&view=rev Log: [cxx_status] Use the correct color for a feature in "SVN" status Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://l

Re: [PATCH] D51507: Allow all supportable attributes to be used with #pragma clang attribute.

2018-08-31 Thread Richard Smith via cfe-commits
On Fri, 31 Aug 2018 at 06:35, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > My reasoning is because type attributes have more impact than variable > attributes and types appear more frequently. Consider using > address_space where the region includes function definitions. Sh

Re: r341373 - Fix the -print-multi-directory flag to print the selected multilib.

2018-09-04 Thread Richard Smith via cfe-commits
This is breaking buildbots: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/19509 Can you take a look? Thanks! On Tue, 4 Sep 2018 at 08:36, Christian Bruel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chrib > Date: Tue Sep 4 08:22:13 2018 > New Re

r341437 - Allow all supportable non-type attributes to be used with #pragma clang attribute.

2018-09-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 4 17:28:57 2018 New Revision: 341437 URL: http://llvm.org/viewvc/llvm-project?rev=341437&view=rev Log: Allow all supportable non-type attributes to be used with #pragma clang attribute. Summary: We previously disallowed use of undocumented attributes with #pragma cl

r341499 - PR38627: Fix handling of exception specification adjustment for

2018-09-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Sep 5 15:30:37 2018 New Revision: 341499 URL: http://llvm.org/viewvc/llvm-project?rev=341499&view=rev Log: PR38627: Fix handling of exception specification adjustment for destructors. We previously tried to patch up the exception specification after completing the class,

r341700 - PR38870: Add warning for zero-width unicode characters appearing in

2018-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 7 12:25:39 2018 New Revision: 341700 URL: http://llvm.org/viewvc/llvm-project?rev=341700&view=rev Log: PR38870: Add warning for zero-width unicode characters appearing in identifiers. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/lib

r341710 - Make -Watomic-alignment say whether the atomic operation was oversized

2018-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 7 14:24:27 2018 New Revision: 341710 URL: http://llvm.org/viewvc/llvm-project?rev=341710&view=rev Log: Make -Watomic-alignment say whether the atomic operation was oversized or misaligned. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/tru

r341734 - Do not use optimized atomic libcalls for misaligned atomics.

2018-09-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 7 16:57:54 2018 New Revision: 341734 URL: http://llvm.org/viewvc/llvm-project?rev=341734&view=rev Log: Do not use optimized atomic libcalls for misaligned atomics. Summary: The optimized (__atomic_foo_) libcalls assume that the atomic object is properly aligned, so s

r341775 - Part of PR33222: defer enforcing return type mismatch for dependent

2018-09-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Sep 9 22:32:13 2018 New Revision: 341775 URL: http://llvm.org/viewvc/llvm-project?rev=341775&view=rev Log: Part of PR33222: defer enforcing return type mismatch for dependent friend function declarations of class templates. Modified: cfe/trunk/include/clang/Sema/Sema

r341778 - PR33222: Require the declared return type not the actual return type to

2018-09-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Sep 9 23:35:32 2018 New Revision: 341778 URL: http://llvm.org/viewvc/llvm-project?rev=341778&view=rev Log: PR33222: Require the declared return type not the actual return type to match when checking for redeclaration of a function template. This properly handles differen

r341858 - Enhance -Wc++14-compat for class template argument deduction to list the

2018-09-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Sep 10 13:31:03 2018 New Revision: 341858 URL: http://llvm.org/viewvc/llvm-project?rev=341858&view=rev Log: Enhance -Wc++14-compat for class template argument deduction to list the deduced type (if known). Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r342017 - Fix tracking of merged definitions when the merge target is also merged

2018-09-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 11 19:13:46 2018 New Revision: 342017 URL: http://llvm.org/viewvc/llvm-project?rev=342017&view=rev Log: Fix tracking of merged definitions when the merge target is also merged into something else. Added: cfe/trunk/test/Modules/merge-template-pattern-visibility-2.c

r342018 - Consistently create a new declaration when merging a pre-existing but

2018-09-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 11 19:13:47 2018 New Revision: 342018 URL: http://llvm.org/viewvc/llvm-project?rev=342018&view=rev Log: Consistently create a new declaration when merging a pre-existing but hidden definition with a would-be-parsed redefinition. This permits a bunch of cleanups. In pa

r342019 - Track definition merging on the canonical declaration even when local

2018-09-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 11 19:13:48 2018 New Revision: 342019 URL: http://llvm.org/viewvc/llvm-project?rev=342019&view=rev Log: Track definition merging on the canonical declaration even when local submodule visibility is disabled. Attempting to pick a specific declaration to make visible wh

  1   2   3   4   5   6   7   8   9   10   >