rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D23902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: rnk
Date: Mon Aug 29 11:24:57 2016
New Revision: 279978
URL: http://llvm.org/viewvc/llvm-project?rev=279978&view=rev
Log:
Try to fix clang-offload-bunder.c test once more
Modified:
cfe/trunk/test/Driver/clang-offload-bundler.c
Modified: cfe/trunk/test/Driver/clang-offload-bundler.c
U
rnk added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:916
@@ +915,3 @@
+def warn_pragma_expected_builtin : Warning<
+ "expected builtin function in '#pragma %0' - ignored">,
+ InGroup;
I'd use this wording:
'%0' is not a recognized
rnk added a comment.
The code looks good and I'm happy to leave the naming as it is for now.
Apparently MSVC is warning on these attributes and calling them "ATL
attributes" now: https://msdn.microsoft.com/en-us/library/mt723604.aspx I'm not
sure if that warning applies to all square-bracketed
rnk added a comment.
In https://reviews.llvm.org/D23895#528208, @aaron.ballman wrote:
> You are removing a lot of instances of `MaybeParseMicrosoftAttributes()`, but
> I'm not certain I understand why. Can you describe why you need to remove
> those?
That shouldn't change functionality, Nico
rnk added a comment.
One buglet, otherwise looks good.
Comment at: lib/Parse/ParsePragma.cpp:2169
@@ +2168,3 @@
+IdentifierInfo *II = Tok.getIdentifierInfo();
+if (II->getBuiltinID() < 2)
+ PP.Diag(Tok.getLocation(), diag::warn_pragma_intrinsic_builtin)
rnk accepted this revision.
rnk added a comment.
lgtm
https://reviews.llvm.org/D23944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Wed Aug 31 11:11:43 2016
New Revision: 280255
URL: http://llvm.org/viewvc/llvm-project?rev=280255&view=rev
Log:
[codeview] Pass through vftable shape information
The shape is really just the number of methods in the vftable, since we
don't support 16 bit far calls. All calls are
This broke the win asan build:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/28203
More generally, though, this seems like it's a Boost convention and an
MSVCRT convention, and not a general Windows convention:
http://www.boost.org/doc/libs/1_42_0/more/getting_started/windows.html#lib
Author: rnk
Date: Wed Aug 31 15:35:01 2016
New Revision: 280287
URL: http://llvm.org/viewvc/llvm-project?rev=280287&view=rev
Log:
[codeview] Don't emit vshape info for classes without vfptrs
Classes with no virtual methods or whose virtual methods were all
inherited from virtual bases don't have
rnk added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3943
@@ +3942,3 @@
+ } else {
+// something like uuid({00A0---C000-0049}) -- no
+// quotes in the parens. Just append the spelling of all tokens encountered
This isn't s
rnk added a comment.
Won't the mid-level optimizer turn these register variables into undefs, and
we'll end up with this kind of IR?
void f() {
int register var asm ("eax") ;
asm volatile ("add %%eax, %0\n\tret" : : "r"(var));
}
->
define void @"\01?f@@YAXXZ"() local_unnamed_addr
Author: rnk
Date: Wed Sep 7 10:15:51 2016
New Revision: 280815
URL: http://llvm.org/viewvc/llvm-project?rev=280815&view=rev
Log:
[MS] Fix 'this' type when calling virtual methods with inalloca
If the virtual method comes from a secondary vtable, then the type of
the 'this' parameter should be i8
Author: rnk
Date: Wed Sep 7 11:38:32 2016
New Revision: 280825
URL: http://llvm.org/viewvc/llvm-project?rev=280825&view=rev
Log:
Parsing MS pragma intrinsic
Parse pragma intrinsic, display warning if the function isn't a builtin
function in clang and suggest including intrin.h.
Patch by Albert
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280825: Parsing MS pragma intrinsic (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D23944?vs=69768&id=70551#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23944
Files:
cfe
rnk added a comment.
Looks good to me. David, do you remember any subtleties here? I seem to recall
there were some bugs in our intrin.h implementations, or inconsistencies
between us and MSVC.
Comment at: test/CodeGen/ms-intrinsics.c:297
@@ +296,3 @@
+// CHECK: define{{.*}}i1
Author: rnk
Date: Wed Sep 7 11:55:12 2016
New Revision: 280826
URL: http://llvm.org/viewvc/llvm-project?rev=280826&view=rev
Log:
Add MS __nop intrinsic to intrin.h
Summary: There was no definition for __nop function - added inline
assembly.
Patch by Albert Gutowski!
Reviewers: rnk, thakis
Sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280826: Add MS __nop intrinsic to intrin.h (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D24286?vs=70495&id=70555#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24286
Files
Author: rnk
Date: Wed Sep 7 13:21:30 2016
New Revision: 280836
URL: http://llvm.org/viewvc/llvm-project?rev=280836&view=rev
Log:
[MS] Fix prologue this adjustment when 'this' is passed indirectly
Move the logic for doing this from the ABI argument lowering into
EmitParmDecl, which runs for all p
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:740
@@ +739,3 @@
+Value *LeftShifted = Builder.CreateShl(Val, Shift);
+Value *RightShifted = Builder.CreateLShr(Val, RightShift);
+Value *Shifted = Builder.CreateOr(LeftShifted, RightShifted);
---
rnk added a comment.
You should locally verify that this generates the correct assembly when
optimizations are enabled, and if it doesn't, try to make the input look more
like llvm/test/CodeGen/X86/rotate.ll
Comment at: test/CodeGen/ms-intrinsics-rotations.c:2
@@ +1,3 @@
+// R
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Sema/SemaChecking.cpp:7841
@@ +7840,3 @@
+if (S.getLangOpts().CPlusPlus11 &&
+!BitfieldEnumDecl->getIntegerTypeSourceInfo() &&
+BitfieldEnum
rnk added a comment.
+Richard for ideas on how to navigate the intel intrinsics
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__built
rnk added inline comments.
Comment at: lib/AST/ExprConstant.cpp:7024-7050
@@ -7023,1 +7023,29 @@
+ case Builtin::BI_rotl8:
+ case Builtin::BI_rotl16:
+ case Builtin::BI_rotl:
+ case Builtin::BI_lrotl:
+ case Builtin::BI_rotl64: {
+APSInt Val, Shift;
+if (!EvaluateIn
rnk added a comment.
I was thinking of suggesting to put it under -Wextra, but -Wall is fine too.
I still don't think it should be on by default. I think there are a lot of
Unix-only projects out there that aren't concerned with MSVC compatibility, and
a warning about how things with in the Mic
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__builtin_ia32_stmxcsr, "Ui", "", "sse")
rsmi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Fri Sep 9 11:27:04 2016
New Revision: 281053
URL: http://llvm.org/viewvc/llvm-project?rev=281053&view=rev
Log:
[codeview] Extend the heuristic for detecting classes imported from DLLs
If a dynamic class contains a dllimport method, then assume the class
may not be constructed i
Author: rnk
Date: Fri Sep 9 11:42:50 2016
New Revision: 281056
URL: http://llvm.org/viewvc/llvm-project?rev=281056&view=rev
Log:
Make -fstandalone-debug and -flimit-debug-info available in clang-cl
Our limited debug info optimizations are breaking down at DLL
boundaries, so we're going to evalua
Author: rnk
Date: Fri Sep 9 12:03:53 2016
New Revision: 281057
URL: http://llvm.org/viewvc/llvm-project?rev=281057&view=rev
Log:
[DebugInfo] Ensure complete type is emitted with -fstandalone-debug
The logic for upgrading a class from a forward decl to a complete type
was not checking the debug i
rnk added a comment.
In https://reviews.llvm.org/D24378#538430, @efriedma wrote:
> This is probably going to lead to someone complaining about clang realigning
> the stack on 32-bit Windows; are your sure we're choosing the right alignment
> there?
I checked, and MSVC emits a call to __alloca
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Parse/ParseDecl.cpp:1456
@@ -1451,1 +1455,3 @@
+ TypeAttrTail = AL;
+ TypeAttrTail->setNext(nullptr);
mmm hand rolled singly linked
Author: rnk
Date: Mon Sep 12 19:01:23 2016
New Revision: 281278
URL: http://llvm.org/viewvc/llvm-project?rev=281278&view=rev
Log:
[DebugInfo] Deduplicate debug info limiting logic
We should be doing the same checks when a type is completed as we do
when a complete type is used during emission. Pr
On Mon, Sep 12, 2016 at 11:41 AM, David Blaikie wrote:
> (idle thought: It'd be good to make the code common between the first time
> a type is encountered, and the later callbacks when the type is completed,
> required to be complete, vtable is emitted, etc - the inconsistency here (&
> it's spr
rnk added a subscriber: rnk.
Comment at: lib/CodeGen/CGDebugInfo.cpp:608
@@ -608,2 +607,3 @@
uint64_t Size = CGM.getContext().getTypeSize(Ty);
+ uint64_t Align = 0;
IMO this is what we should be doing everywhere, rather than manually checking
AlignedAttr:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D23901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
rnk added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
declaration
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Sorry, I lost track of this.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm after merging the test back.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring libra
Author: rnk
Date: Tue Sep 13 17:22:56 2016
New Revision: 281408
URL: http://llvm.org/viewvc/llvm-project?rev=281408&view=rev
Log:
Fix a FIXME about MSVC 2013 in the diagnostic doc generation code
Ultimately it boiled down to adding a move constructor.
Modified:
cfe/trunk/utils/TableGen/Clang
rnk added a comment.
lgtm We could define a macro that conditionally expands to `extern "C"`, but
then we'd have to undef it, and that seems like no good.
https://reviews.llvm.org/D24330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: rnk
Date: Wed Sep 14 17:31:24 2016
New Revision: 281550
URL: http://llvm.org/viewvc/llvm-project?rev=281550&view=rev
Log:
[clang-cl] Accept the joined equals version of -resource-dir=
lib/Tooling injects this argument without regard for what driver syntax
is in use.
Modified:
cfe/tru
rnk added a comment.
In https://reviews.llvm.org/D24289#543874, @thakis wrote:
> Works for me if rnk likes it :-)
Yep, looks good.
> (We could bikeshed on if this should be one of the -Wmicrosoft warnings, but
> the warning can't be both in -Wall and -Wmicrosoft, so let's don't).
I also don
Author: rnk
Date: Tue Mar 14 13:01:02 2017
New Revision: 297761
URL: http://llvm.org/viewvc/llvm-project?rev=297761&view=rev
Log:
Warn on enum assignment to bitfields that can't fit all values
This adds -Wbitfield-enum-conversion, which warns on implicit
conversions that happen on bitfield assign
Author: rnk
Date: Tue Mar 14 13:24:41 2017
New Revision: 297764
URL: http://llvm.org/viewvc/llvm-project?rev=297764&view=rev
Log:
Fix arch-specific-libdir tests on Windows
This is pretty horrible, but I forget if we have any better ways to
handle these backslashing issues.
Modified:
cfe/trun
Author: rnk
Date: Thu Mar 16 13:55:46 2017
New Revision: 297975
URL: http://llvm.org/viewvc/llvm-project?rev=297975&view=rev
Log:
Use arg_begin() instead of getArgumentList().begin(), the argument list is an
implementation detail
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified:
Author: rnk
Date: Thu Mar 16 16:21:00 2017
New Revision: 297998
URL: http://llvm.org/viewvc/llvm-project?rev=297998&view=rev
Log:
Create msbuild only when using MSVC
Patch by: Mateusz Mikula
Reviewers: rnk
Reviewed By: rnk
Subscribers: asl, mgorny, cfe-commits
Tags: #clang-c
Differential Rev
David Blaikie wrote:
>
>
> On Thu, Mar 16, 2017 at 12:07 PM Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Thu Mar 16 13:55:46 2017
>> New Revision: 297975
>>
>> URL: http://llvm.org/viewvc/llvm-pro
Author: rnk
Date: Tue Mar 21 11:57:30 2017
New Revision: 298394
URL: http://llvm.org/viewvc/llvm-project?rev=298394&view=rev
Log:
Update Clang for LLVM rename AttributeSet -> AttributeList
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/CodeGen/CGCXX.cpp
cfe/trunk/lib/Code
Author: rnk
Date: Wed Mar 29 20:12:08 2017
New Revision: 299045
URL: http://llvm.org/viewvc/llvm-project?rev=299045&view=rev
Log:
Use 'unsigned' for enum bitfields
Fixes this clang warning on Windows:
warning: implicit truncation from 'clang::LangOptions::FPContractModeKind' to
bit-field change
Author: rnk
Date: Thu Mar 30 19:34:05 2017
New Revision: 299144
URL: http://llvm.org/viewvc/llvm-project?rev=299144&view=rev
Log:
Try to fix the libcxx build with mingw64
Summary:
mingw64 has lots of default libs that libc++ and its test programs
should link against.
With this patch, cmake now r
Author: rnk
Date: Wed Apr 5 13:56:48 2017
New Revision: 299577
URL: http://llvm.org/viewvc/llvm-project?rev=299577&view=rev
Log:
[lit] Fix Analysis test format pickling error
Move the test format into a standalone .py file and add it to the site
module search path. This allows us to run the test
Author: rnk
Date: Mon Apr 10 11:50:55 2017
New Revision: 299849
URL: http://llvm.org/viewvc/llvm-project?rev=299849&view=rev
Log:
XFAIL clangd tests on Windows
They all assert. Filed as PR32596.
Modified:
clang-tools-extra/trunk/test/clangd/completion.test
clang-tools-extra/trunk/test/cl
Author: rnk
Date: Mon Apr 10 11:55:48 2017
New Revision: 299850
URL: http://llvm.org/viewvc/llvm-project?rev=299850&view=rev
Log:
Revert "XFAIL clangd tests on Windows"
This reverts r299849, apparently these tests only fail on my machine.
Modified:
clang-tools-extra/trunk/test/clangd/complet
Author: rnk
Date: Mon Apr 10 12:03:44 2017
New Revision: 299854
URL: http://llvm.org/viewvc/llvm-project?rev=299854&view=rev
Log:
[clangd] Relax absolute path checking assertion
clangd can process absolute paths from systems that don't use the native
path style, so this assertion needs to check b
Author: rnk
Date: Mon Apr 10 18:31:05 2017
New Revision: 299899
URL: http://llvm.org/viewvc/llvm-project?rev=299899&view=rev
Log:
Reland "[IR] Make AttributeSetNode public, avoid temporary AttributeList copies"
This re-lands r299875.
I introduced a bug in Clang code responsible for replacing K&R
Author: rnk
Date: Tue Apr 11 19:38:00 2017
New Revision: 300014
URL: http://llvm.org/viewvc/llvm-project?rev=300014&view=rev
Log:
[IR] Add AttributeSet to hide AttributeSetNode* again, NFC
Summary:
For now, it just wraps AttributeSetNode*. Eventually, it will hold
AvailableAttrs as an inline bits
Author: rnk
Date: Wed Apr 12 17:50:51 2017
New Revision: 300122
URL: http://llvm.org/viewvc/llvm-project?rev=300122&view=rev
Log:
[clang-cl] Make all sanitizer flags available in clang-cl
Summary:
Use a tablegen let {} block so that new sanitizer flags are available by
default in all driver modes
Author: rnk
Date: Wed Apr 12 19:58:09 2017
New Revision: 300153
URL: http://llvm.org/viewvc/llvm-project?rev=300153&view=rev
Log:
[IR] Take func, ret, and arg attrs separately in AttributeList::get
This seems like a much more natural API, based on Derek Schuff's
comments on r300015. It further hi
Author: rnk
Date: Thu Apr 13 11:32:26 2017
New Revision: 300209
URL: http://llvm.org/viewvc/llvm-project?rev=300209&view=rev
Log:
Re-land "[clang-cl] Make all sanitizer flags available in clang-cl"
Adding RUN lines with %clang_cl was causing these tests to fail on Mac
because absolute paths there
Author: rnk
Date: Thu Apr 13 11:36:28 2017
New Revision: 300214
URL: http://llvm.org/viewvc/llvm-project?rev=300214&view=rev
Log:
Use the clang-cl recognized spelling of --target=
This fixes a warning. The test was passing without this change.
Modified:
cfe/trunk/test/Driver/fsanitize.c
Mod
ck/30152/
>
> Could you take a look?
>
>
> On Apr 12, 2017, at 3:50 PM, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: rnk
> Date: Wed Apr 12 17:50:51 2017
> New Revision: 300122
>
> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: rnk
Date: Thu Apr 13 18:12:13 2017
New Revision: 300272
URL: http://llvm.org/viewvc/llvm-project?rev=300272&view=rev
Log:
[IR] Make getParamAttributes take argument numbers, not ArgNo+1
Add hasParamAttribute() and use it instead of hasAttribute(ArgNo+1,
Kind) everywhere.
The fact that th
Author: rnk
Date: Tue Apr 18 12:44:41 2017
New Revision: 300572
URL: http://llvm.org/viewvc/llvm-project?rev=300572&view=rev
Log:
Remove unused varible
The Result variable is unused both in Sema::CheckARMBuiltinFunctionCall
and Sema::CheckAArch64BuiltinFunctionCall, remove it.
Patch by Wei-Ren C
Author: rnk
Date: Tue Apr 18 18:50:03 2017
New Revision: 300628
URL: http://llvm.org/viewvc/llvm-project?rev=300628&view=rev
Log:
Use less temporary AttributeLists NFC
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCall.h
cfe/trunk/lib/CodeGen/CGVTables.cpp
cfe
Author: rnk
Date: Fri Jan 13 11:18:19 2017
New Revision: 291917
URL: http://llvm.org/viewvc/llvm-project?rev=291917&view=rev
Log:
Use less byval on 32-bit Windows x86 for classes with bases
This comes up in V8, which has a Handle template class that wraps a
typed pointer, and is frequently passed
Author: rnk
Date: Fri Jan 20 14:44:50 2017
New Revision: 292643
URL: http://llvm.org/viewvc/llvm-project?rev=292643&view=rev
Log:
Revert "Don't inline dllimport functions referencing non-imported methods"
This reverts commit r292522. It appears to be causing crashes in builds
using dllimport.
Mo
The first Chrome DLL build with this change is crashing during compilation:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dll%29/builds/8380/
The previous build fails with a link error, so the revision range for the
new crash is 292501 - 292526.
Only the DLL builders are affe
Thanks! Does this match the logic for starting a function in OpenMP?
Also, the test shouldn't have REQUIRES: x86-registered-target.
On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
> Date: Fri Jan 20 02:57:28 2017
> New Revisi
Author: rnk
Date: Tue Jan 31 13:37:45 2017
New Revision: 293677
URL: http://llvm.org/viewvc/llvm-project?rev=293677&view=rev
Log:
Extend -Wcast-calling-convention to warn on declarations as well as definitions
My original warning was very conservative and I never revisited the
heuristics that wer
Author: rnk
Date: Thu Feb 2 13:29:46 2017
New Revision: 293923
URL: http://llvm.org/viewvc/llvm-project?rev=293923&view=rev
Log:
[Driver] Updated for Visual Studio 2017
Summary:
The patch updates the MSVC ToolChain for the changes made in Visual
Studio 2017[1].
Other notable changes:
- Path h
Author: rnk
Date: Thu Feb 2 13:36:22 2017
New Revision: 293924
URL: http://llvm.org/viewvc/llvm-project?rev=293924&view=rev
Log:
Revert "[Driver] Updated for Visual Studio 2017"
This reverts commit r293923. It causes test failures on Linux that need
time to debug.
Modified:
cfe/trunk/includ
Author: rnk
Date: Wed Feb 8 10:09:32 2017
New Revision: 294465
URL: http://llvm.org/viewvc/llvm-project?rev=294465&view=rev
Log:
[MS] Fix C++ destructor thunk line info for a declaration
Sometimes the MS ABI needs to emit thunks for declarations that don't
have bodies. Destructor thunks make cal
Author: rnk
Date: Thu Feb 9 12:31:06 2017
New Revision: 294606
URL: http://llvm.org/viewvc/llvm-project?rev=294606&view=rev
Log:
[MS] Implement the __fastfail intrinsic as a builtin
__fastfail terminates the process immediately with a special system
call. It does not run any process shutdown cod
Author: rnk
Date: Thu Jun 29 15:31:16 2017
New Revision: 306751
URL: http://llvm.org/viewvc/llvm-project?rev=306751&view=rev
Log:
Fix openmp-offload.c test on Windows
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified: cfe/trunk/test/Driver/openmp-offload.c
URL:
http://llvm.org/viewv
Author: rnk
Date: Fri Jun 30 09:11:49 2017
New Revision: 306835
URL: http://llvm.org/viewvc/llvm-project?rev=306835&view=rev
Log:
Revert "[CodeGen] Propagate dllexport to thunks"
This reverts r306770, it causes LNK4102 warnings in MSVC builds.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
Author: rnk
Date: Fri Jun 30 09:12:14 2017
New Revision: 306836
URL: http://llvm.org/viewvc/llvm-project?rev=306836&view=rev
Log:
[MS] Test that deleting destructor thunks are not exported
The MSVC linker emits the LNK4102 warning if they are.
Added:
cfe/trunk/test/CodeGenCXX/dllexport-dtor-
Author: rnk
Date: Fri Jul 7 15:04:29 2017
New Revision: 307446
URL: http://llvm.org/viewvc/llvm-project?rev=307446&view=rev
Log:
[MS] Don't statically initialize dllimport member function pointers
Summary:
r306137 made dllimport pointers to member functions non-constant. This
is correct because
Author: rnk
Date: Tue Jul 11 09:18:05 2017
New Revision: 307670
URL: http://llvm.org/viewvc/llvm-project?rev=307670&view=rev
Log:
Add missing dllimport member pointer template argument test from r307446
Added:
cfe/trunk/test/CodeGenCXX/dllimport-memptr-global.cpp
Added: cfe/trunk/test/CodeGe
Author: rnk
Date: Tue Jul 11 13:22:17 2017
New Revision: 307701
URL: http://llvm.org/viewvc/llvm-project?rev=307701&view=rev
Log:
Fix clang-tidy diagnostic.cpp test on Windows
Modified:
clang-tools-extra/trunk/test/clang-tidy/diagnostic.cpp
Modified: clang-tools-extra/trunk/test/clang-tidy/d
Author: rnk
Date: Mon Jul 24 13:48:15 2017
New Revision: 308926
URL: http://llvm.org/viewvc/llvm-project?rev=308926&view=rev
Log:
Revert "[X86][InlineAsm][Ms Compatibility]Prefer variable name over a register
when the two collides"
This reverts r308867 and r308866.
It broke the sanitizer-window
This commit hasn't been imported to
https://github.com/llvm-project/llvm-project-20170507. Do we need to do
anything to make sure it gets picked up eventually? I wonder if there are
more "missing commits" like this. Have we seen divergence between SVN and
the prototype git monorepo in the past?
On
Looks like this was resolved. I noticed that we have a window of commits
with extra git-svn-rev notes:
commit 820faedb92322a3a550bd994b652f2e3d0c77b13
Author: Eric Beckmann
Date: Wed Jul 26 21:47:17 2017 +
Clang and LLVM search for different versions of libxml2, reset found
variabl
I backported these to the release_50 branch in the following revisions:
llvm r324007, r324009
cfe r324012
lld r324025, r324026
The regression test suites pass on my machine with the exception of two
pre-existing failures. I also built my small retpoline execution test that
does a variety of indir
Author: rnk
Date: Mon Feb 13 12:49:21 2017
New Revision: 294978
URL: http://llvm.org/viewvc/llvm-project?rev=294978&view=rev
Log:
[CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility
Fixes https://bugs.llvm.org/show_bug.cgi?id=31932
Based on a patch by Roland McGrath
Reviewed
Author: rnk
Date: Tue Feb 14 12:38:40 2017
New Revision: 295083
URL: http://llvm.org/viewvc/llvm-project?rev=295083&view=rev
Log:
Remove unnecessary std::string construction
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/trunk/lib/Lex/PPDirectives.cpp
URL:
http://llvm.org/viewvc
Author: rnk
Date: Tue Feb 14 12:38:19 2017
New Revision: 295082
URL: http://llvm.org/viewvc/llvm-project?rev=295082&view=rev
Log:
Fix some warnings in intrin.h
Modified:
cfe/trunk/lib/Headers/intrin.h
Modified: cfe/trunk/lib/Headers/intrin.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
Author: rnk
Date: Tue Feb 14 15:38:17 2017
New Revision: 295107
URL: http://llvm.org/viewvc/llvm-project?rev=295107&view=rev
Log:
MS inline asm: Filter MXCSR out of the inferred clobber list
Since r295004, LLVM has started modelling this new register, but we
don't have GCC constraint inline asm s
Author: rnk
Date: Mon Mar 6 13:43:16 2017
New Revision: 297057
URL: http://llvm.org/viewvc/llvm-project?rev=297057&view=rev
Log:
[MS] Add support for __ud2 and __int2c MSVC intrinsics
This was requested in PR31958 and elsewhere.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cf
Author: rnk
Date: Mon Mar 6 16:18:34 2017
New Revision: 297084
URL: http://llvm.org/viewvc/llvm-project?rev=297084&view=rev
Log:
Don't assume cleanup emission preserves dominance in expr evaluation
Summary:
Because of the existence branches out of GNU statement expressions, it
is possible that e
Author: rnk
Date: Mon Mar 6 17:49:18 2017
New Revision: 297099
URL: http://llvm.org/viewvc/llvm-project?rev=297099&view=rev
Log:
Relax stmtexpr.cpp checks for PPC64
Modified:
cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
Modified: cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
URL:
http://llvm.org/viewvc
Author: rnk
Date: Mon Mar 6 17:52:53 2017
New Revision: 297101
URL: http://llvm.org/viewvc/llvm-project?rev=297101&view=rev
Log:
Fix some widespread warnings in headers from the new coroutine code
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/include/clang/Sema/ScopeInfo.h
Modi
Author: rnk
Date: Mon Mar 13 13:42:30 2017
New Revision: 297654
URL: http://llvm.org/viewvc/llvm-project?rev=297654&view=rev
Log:
Widen bitfield for type specifiers for OpenCL types
Added a static_assert to catch this issue at compile time.
Modified:
cfe/trunk/include/clang/Basic/Specifiers.
Author: rnk
Date: Mon Mar 13 17:33:07 2017
New Revision: 297681
URL: http://llvm.org/viewvc/llvm-project?rev=297681&view=rev
Log:
Fix -Wunused-lambda-capture warning in new code
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
http://l
Author: rnk
Date: Mon Mar 13 17:33:04 2017
New Revision: 297680
URL: http://llvm.org/viewvc/llvm-project?rev=297680&view=rev
Log:
Widen AST bitfields too small to represent all enumerators
All of these were found by a new warning that I am prototyping,
-Wbitfield-enum-conversion.
Stmt::ExprBits:
Author: rnk
Date: Wed Nov 16 17:40:00 2016
New Revision: 287177
URL: http://llvm.org/viewvc/llvm-project?rev=287177&view=rev
Log:
Add warning when assigning enums to bitfields without an explicit unsigned
underlying type
Summary:
Add a warning when assigning enums to bitfields without an explici
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287177: Add warning when assigning enums to bitfields
without an explicit unsigned… (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D24289?vs=70760&id=78281#toc
Repository:
rL LL
rnk added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstantiat
rnk added a comment.
If I understand correctly, this patch takes template function patterns, copies
them into instantiated context, parses them in that context, and then
instantiates them in that context. The key difference is that today's
fdelayed-template-parsing doesn't parse the body of the
601 - 700 of 1541 matches
Mail list logo
