r345676 - [Win64] Handle passing i128 by value

2018-10-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Oct 30 16:58:41 2018 New Revision: 345676 URL: http://llvm.org/viewvc/llvm-project?rev=345676&view=rev Log: [Win64] Handle passing i128 by value For arguments, pass it indirectly, since the ABI doc says pretty clearly that arguments larger than 8 bytes are passed indirectly.

r351249 - [clang-cl] Alias /Zc:alignedNew[-] to -f[no-]aligned-allocation

2019-01-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jan 15 13:24:55 2019 New Revision: 351249 URL: http://llvm.org/viewvc/llvm-project?rev=351249&view=rev Log: [clang-cl] Alias /Zc:alignedNew[-] to -f[no-]aligned-allocation Implements PR40180. clang-cl has one minor behavior difference with cl with this change. Clang allows

r351383 - Fix libc++ mac driver test to pass on Windows

2019-01-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jan 16 14:05:34 2019 New Revision: 351383 URL: http://llvm.org/viewvc/llvm-project?rev=351383&view=rev Log: Fix libc++ mac driver test to pass on Windows There is a substitution for 'clang-check' to absolutize it, so the '$(which clang-check)' is unnecessary. Modified:

r351478 - Fix -Wsign-compare in new tests

2019-01-17 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Jan 17 12:52:46 2019 New Revision: 351478 URL: http://llvm.org/viewvc/llvm-project?rev=351478&view=rev Log: Fix -Wsign-compare in new tests Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp URL: http://llvm.org/

r352119 - [clang-cl] Ignore space-separated /AI arguments

2019-01-24 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Jan 24 14:26:51 2019 New Revision: 352119 URL: http://llvm.org/viewvc/llvm-project?rev=352119&view=rev Log: [clang-cl] Ignore space-separated /AI arguments The /AI flag is for #using directives, which I don't think we support. This is consistent with how the /I flag is handl

r352232 - [CodeGen] Implement isTriviallyRecursive with StmtVisitor instead of RecursiveASTVisitor

2019-01-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jan 25 11:18:40 2019 New Revision: 352232 URL: http://llvm.org/viewvc/llvm-project?rev=352232&view=rev Log: [CodeGen] Implement isTriviallyRecursive with StmtVisitor instead of RecursiveASTVisitor This code doesn't need to traverse types, lambdas, template arguments, etc to

Re: r345676 - [Win64] Handle passing i128 by value

2018-10-31 Thread Reid Kleckner via cfe-commits
On Wed, Oct 31, 2018 at 7:39 AM wrote: > Also, don't we usually put ABI changes under an ABI compatibility check? > This would be making Clang incompatible with itself. > I don't think it's worth it because nobody can use i128 in a meaningful way on x64 Windows right now. If you do i128 multipli

r345748 - Re-land r345676 "[Win64] Handle passing i128 by value"

2018-10-31 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 31 10:43:55 2018 New Revision: 345748 URL: http://llvm.org/viewvc/llvm-project?rev=345748&view=rev Log: Re-land r345676 "[Win64] Handle passing i128 by value" Fix the unintended switch/case fallthrough to avoid changing long double behavior. Added: cfe/trunk/test/Co

r345862 - Replace two fallthrough annotations after covered switch with unreachable

2018-11-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Nov 1 10:51:48 2018 New Revision: 345862 URL: http://llvm.org/viewvc/llvm-project?rev=345862&view=rev Log: Replace two fallthrough annotations after covered switch with unreachable Both preceding switches handle all possible enumerators, so the fallthrough is actually unrea

r345873 - Add LLVM_FALLTHROUGH annotation after switch

2018-11-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Nov 1 11:53:02 2018 New Revision: 345873 URL: http://llvm.org/viewvc/llvm-project?rev=345873&view=rev Log: Add LLVM_FALLTHROUGH annotation after switch This silences a -Wimplicit-fallthrough warning from clang. GCC does not appear to warn when the case body ends in a switch

[clang-tools-extra] r345882 - Fix clang -Wimplicit-fallthrough warnings across llvm, NFC

2018-11-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Nov 1 12:54:45 2018 New Revision: 345882 URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev Log: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC This patch should not introduce any behavior changes. It consists of mostly one of two changes: 1. Replacing

r345882 - Fix clang -Wimplicit-fallthrough warnings across llvm, NFC

2018-11-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Nov 1 12:54:45 2018 New Revision: 345882 URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev Log: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC This patch should not introduce any behavior changes. It consists of mostly one of two changes: 1. Replacing

r346265 - [MS] Zero out ECX in __cpuid in intrin.h

2018-11-06 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Nov 6 12:45:26 2018 New Revision: 346265 URL: http://llvm.org/viewvc/llvm-project?rev=346265&view=rev Log: [MS] Zero out ECX in __cpuid in intrin.h Summary: Some CPUID leafs depend on the value of ECX as well as EAX, but we left it uninitialized. Originally reported as htt

r346907 - [codeview] Make "clang -g" emit codeview by default when targetting MSVC

2018-11-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Nov 14 14:59:27 2018 New Revision: 346907 URL: http://llvm.org/viewvc/llvm-project?rev=346907&view=rev Log: [codeview] Make "clang -g" emit codeview by default when targetting MSVC Summary: If you're using the Microsoft ABI, chances are that you want PDBs and codeview debug

r347072 - [codeview] Expose -gcodeview-ghash for global type hashing

2018-11-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Nov 16 10:47:41 2018 New Revision: 347072 URL: http://llvm.org/viewvc/llvm-project?rev=347072&view=rev Log: [codeview] Expose -gcodeview-ghash for global type hashing Summary: Experience has shown that the functionality is useful. It makes linking optimized clang with debug

r347111 - Add missing test for r347072 -gcodeview-ghash

2018-11-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Nov 16 15:17:11 2018 New Revision: 347111 URL: http://llvm.org/viewvc/llvm-project?rev=347111&view=rev Log: Add missing test for r347072 -gcodeview-ghash Added: cfe/trunk/test/Driver/gcodeview-ghash.c Added: cfe/trunk/test/Driver/gcodeview-ghash.c URL: http://llvm.org/

r347627 - [MS] Push fewer DeclContexts for delayed template parsing

2018-11-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Nov 26 18:21:51 2018 New Revision: 347627 URL: http://llvm.org/viewvc/llvm-project?rev=347627&view=rev Log: [MS] Push fewer DeclContexts for delayed template parsing Only push the outermost record as a DeclContext when parsing a function body. See the comments in Sema::getCo

r347630 - Revert r347627 "[MS] Push fewer DeclContexts for delayed template parsing"

2018-11-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Nov 26 18:54:17 2018 New Revision: 347630 URL: http://llvm.org/viewvc/llvm-project?rev=347630&view=rev Log: Revert r347627 "[MS] Push fewer DeclContexts for delayed template parsing" It broke the Windows self-host: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/bui

r347633 - [docs] UBSan and ASan are supported on Windows

2018-11-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Nov 26 19:55:15 2018 New Revision: 347633 URL: http://llvm.org/viewvc/llvm-project?rev=347633&view=rev Log: [docs] UBSan and ASan are supported on Windows Also fix a bullet list. Fixes PR39775 Modified: cfe/trunk/docs/AddressSanitizer.rst cfe/trunk/docs/UndefinedBe

r347713 - [MS] Push outermost class DeclContexts only in -fdelayed-template-parsing

2018-11-27 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Nov 27 13:20:42 2018 New Revision: 347713 URL: http://llvm.org/viewvc/llvm-project?rev=347713&view=rev Log: [MS] Push outermost class DeclContexts only in -fdelayed-template-parsing This is more or less a complete rewrite of r347627, and it fixes PR38460 I added a reduced te

r354838 - [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword

2019-02-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Feb 25 18:22:17 2019 New Revision: 354838 URL: http://llvm.org/viewvc/llvm-project?rev=354838&view=rev Log: [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword Patch by Zahira Ammarguellat! Differential Revision: https://reviews.llvm.org/D41950 Added

r354839 - Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."

2019-02-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Feb 25 18:22:22 2019 New Revision: 354839 URL: http://llvm.org/viewvc/llvm-project?rev=354839&view=rev Log: Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes." Test does not pass on Windows Removed: cfe/trunk/test/ASTMerge/ Modified: cfe/t

r354924 - [MS] Don't emit coverage for deleting dtors

2019-02-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Feb 26 12:42:52 2019 New Revision: 354924 URL: http://llvm.org/viewvc/llvm-project?rev=354924&view=rev Log: [MS] Don't emit coverage for deleting dtors Summary: The MS C++ ABI has no constructor variants, but it has destructor variants, so we should move the deleting destruc

r355044 - [InstrProf] Use separate comdat group for data and counters

2019-02-27 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Feb 27 15:38:44 2019 New Revision: 355044 URL: http://llvm.org/viewvc/llvm-project?rev=355044&view=rev Log: [InstrProf] Use separate comdat group for data and counters Summary: I hadn't realized that instrumentation runs before inlining, so we can't use the function as the c

r355625 - Fix some clang analysis tests passing arguments incorrectly

2019-03-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 7 10:57:04 2019 New Revision: 355625 URL: http://llvm.org/viewvc/llvm-project?rev=355625&view=rev Log: Fix some clang analysis tests passing arguments incorrectly Modified: cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp Modified: cfe/trunk/unittests/Anal

Re: r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

2019-03-07 Thread Reid Kleckner via cfe-commits
I would recommend doing what was done for _xgetbv as in r351391: - Provide __builtin_ia32_rot* everywhere (or something like that in the implementor's namespace) - Conditionally #define _rot* to __builtin_ia32_rot* in ia32intrin.h, maybe ifdef _GNUC - Also provide _rot* builtins when -fms-extension

Re: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

2019-03-13 Thread Reid Kleckner via cfe-commits
Aaron, I've followed both links you point to to answer the questions being asked, and to me they don't seem to contain obvious answers. I understand that repeatedly answering the same question over and over again is tedious and we are all busy, but please remind us why both DIFlagTrivial and DIFlag

r356185 - Add PragmaHandler for MSVC pragma execution_character_set

2019-03-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 14 11:12:17 2019 New Revision: 356185 URL: http://llvm.org/viewvc/llvm-project?rev=356185&view=rev Log: Add PragmaHandler for MSVC pragma execution_character_set __pragma(execution_character_set(push, "UTF-8")) is used in TraceLoggingProvider.h. This commit implements a

[clang-tools-extra] r356185 - Add PragmaHandler for MSVC pragma execution_character_set

2019-03-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 14 11:12:17 2019 New Revision: 356185 URL: http://llvm.org/viewvc/llvm-project?rev=356185&view=rev Log: Add PragmaHandler for MSVC pragma execution_character_set __pragma(execution_character_set(push, "UTF-8")) is used in TraceLoggingProvider.h. This commit implements a

r356425 - [MS] Skip vbase construction in abstract class ctors

2019-03-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Mar 18 15:41:50 2019 New Revision: 356425 URL: http://llvm.org/viewvc/llvm-project?rev=356425&view=rev Log: [MS] Skip vbase construction in abstract class ctors As background, when constructing a complete object, virtual bases are constructed first. If an exception is thrown

r356964 - [MS] Add frontend support for __declspec(allocator)

2019-03-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Mar 25 16:20:18 2019 New Revision: 356964 URL: http://llvm.org/viewvc/llvm-project?rev=356964&view=rev Log: [MS] Add frontend support for __declspec(allocator) The intention is to add metadata to direct call sites of functions marked with __declspec(allocator), which will ul

r357220 - [MS] Make __iso_volatile_* available on all targets

2019-03-28 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 28 15:59:09 2019 New Revision: 357220 URL: http://llvm.org/viewvc/llvm-project?rev=357220&view=rev Log: [MS] Make __iso_volatile_* available on all targets Future versions of MSVC make these intrinsics available on x86 & x64, according to: http://lists.llvm.org/pipermail

[clang-tools-extra] r357429 - Fix clangd unittest _WIN32 ifdef

2019-04-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 1 14:16:17 2019 New Revision: 357429 URL: http://llvm.org/viewvc/llvm-project?rev=357429&view=rev Log: Fix clangd unittest _WIN32 ifdef WIN32 is not defined, _WIN32 is, use that instead. Modified: clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp Mod

r359148 - [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-24 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Apr 24 15:45:44 2019 New Revision: 359148 URL: http://llvm.org/viewvc/llvm-project?rev=359148&view=rev Log: [codeview] Fix symbol names for dynamic initializers and atexit stubs Summary: Add a new variant to GlobalDecl for these so that we can detect them more easily during

r359250 - [COFF] Statically link certain runtime library functions

2019-04-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Apr 25 16:04:20 2019 New Revision: 359250 URL: http://llvm.org/viewvc/llvm-project?rev=359250&view=rev Log: [COFF] Statically link certain runtime library functions Statically link certain runtime library functions for MSVC/GNU Windows environments. This is consistent with M

r359251 - Revert [COFF] Statically link certain runtime library functions

2019-04-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Apr 25 16:30:41 2019 New Revision: 359251 URL: http://llvm.org/viewvc/llvm-project?rev=359251&view=rev Log: Revert [COFF] Statically link certain runtime library functions This reverts r359250 (git commit 4730604bd3a361c68b92b18bf73a5daa15afe9f4) The newly added test should

r359507 - Simplify exclusion of nested classes from extern template instantiation, NFC

2019-04-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 29 14:32:05 2019 New Revision: 359507 URL: http://llvm.org/viewvc/llvm-project?rev=359507&view=rev Log: Simplify exclusion of nested classes from extern template instantiation, NFC Summary: This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is Wind

r359513 - Re-land r359250, [COFF] Statically link certain runtime library functions

2019-04-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 29 16:05:47 2019 New Revision: 359513 URL: http://llvm.org/viewvc/llvm-project?rev=359513&view=rev Log: Re-land r359250, [COFF] Statically link certain runtime library functions Reverts the revert of r359251, this time with fixed tests. Differential Revision: https://re

r359623 - Remove two unnecessary wrappers of canPassInRegisters

2019-04-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Apr 30 15:23:20 2019 New Revision: 359623 URL: http://llvm.org/viewvc/llvm-project?rev=359623&view=rev Log: Remove two unnecessary wrappers of canPassInRegisters These extra layers aren't necessary. Modified: cfe/trunk/lib/CodeGen/CGCXXABI.cpp cfe/trunk/lib/CodeGen/

r359722 - Make clang/utils/creduce-clang-crash.py executable

2019-05-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 1 13:15:39 2019 New Revision: 359722 URL: http://llvm.org/viewvc/llvm-project?rev=359722&view=rev Log: Make clang/utils/creduce-clang-crash.py executable Modified: cfe/trunk/utils/creduce-clang-crash.py (props changed) Propchange: cfe/trunk/utils/creduce-clang-cr

r359809 - Use primary template parameter names for variable template debug info

2019-05-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu May 2 10:45:54 2019 New Revision: 359809 URL: http://llvm.org/viewvc/llvm-project?rev=359809&view=rev Log: Use primary template parameter names for variable template debug info Summary: Fixes PR41677 Consider: template constexpr bool is_same_v = false; template const

r360207 - [COFF] Use COFF stubs for extern_weak functions

2019-05-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue May 7 16:06:21 2019 New Revision: 360207 URL: http://llvm.org/viewvc/llvm-project?rev=360207&view=rev Log: [COFF] Use COFF stubs for extern_weak functions Summary: A COFF stub indirects the reference to a symbol through memory. A .refptr.$sym global variable pointer is crea

r360291 - Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility.

2019-05-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 8 15:01:20 2019 New Revision: 360291 URL: http://llvm.org/viewvc/llvm-project?rev=360291&view=rev Log: Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This reverts r360271 (git commit a0933bd8ec1515167ea653f7ee788b8bbde27d5

r360297 - Try to restore some clang test headers lost in r360291

2019-05-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 8 15:30:46 2019 New Revision: 360297 URL: http://llvm.org/viewvc/llvm-project?rev=360297&view=rev Log: Try to restore some clang test headers lost in r360291 I'm not sure why 'git llvm revert' removed them. Added: cfe/trunk/test/Headers/Inputs/ cfe/trunk/test/H

r342516 - [MS] Defer dllexport inline friend functions like other inline methods

2018-09-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 18 16:16:30 2018 New Revision: 342516 URL: http://llvm.org/viewvc/llvm-project?rev=342516&view=rev Log: [MS] Defer dllexport inline friend functions like other inline methods This special case was added in r264841, but the code breaks our invariants by calling EmitTopLev

Re: r229575 - clang-cl: Disable frame pointer elimination at -O0

2018-09-20 Thread Reid Kleckner via cfe-commits
It looks like we don't do anything special if you run clang-cl -O0 or /O0, but it's not an error. I don't have my computer and can't run a test, but from the outside, it looks like clang-cl -O0 does generate unoptimized code without warning about an unrecognized flag, but it doesn't disable FP elim

[clang-tools-extra] r343610 - Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC"

2018-10-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Oct 2 10:31:43 2018 New Revision: 343610 URL: http://llvm.org/viewvc/llvm-project?rev=343610&view=rev Log: Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC" Declaring a field with the same name as a type causes GCC to error out: D

Re: [clang-tools-extra] r343589 - [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

2018-10-02 Thread Reid Kleckner via cfe-commits
I reverted this in r343610 because I noticed many bots were failing to build after this change. Declaring the field `Corpus Corpus;` upsets GCC. I considered trying to pick a different field name, but I wasn't able to come up with one I liked, so I'm punting it back to you. =/ On Tue, Oct 2, 2018

r343641 - Remove spurious assertion in -Wdocumentation

2018-10-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Oct 2 15:23:27 2018 New Revision: 343641 URL: http://llvm.org/viewvc/llvm-project?rev=343641&view=rev Log: Remove spurious assertion in -Wdocumentation Some code in OpenCV uses interesting doxygen directives that make it so we don't see any tokens inside a @note, despite th

r343809 - Update Clang Windows getting started docs

2018-10-04 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 4 13:34:52 2018 New Revision: 343809 URL: http://llvm.org/viewvc/llvm-project?rev=343809&view=rev Log: Update Clang Windows getting started docs Summary: - Update the example VS project generation to use VS2017. - Add docs for generating ninja build files, since they ar

r353653 - Fix clang tests broken by r353547 that depend on InstrProf

2019-02-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Sun Feb 10 12:17:07 2019 New Revision: 353653 URL: http://llvm.org/viewvc/llvm-project?rev=353653&view=rev Log: Fix clang tests broken by r353547 that depend on InstrProf Modified: cfe/trunk/test/CoverageMapping/unused_names.c cfe/trunk/test/Profile/cxx-lambda.cpp cf

r353654 - Fix test to pass on LLP64 targets

2019-02-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Sun Feb 10 12:20:26 2019 New Revision: 353654 URL: http://llvm.org/viewvc/llvm-project?rev=353654&view=rev Log: Fix test to pass on LLP64 targets Modified: cfe/trunk/test/Analysis/osobjectcstylecastchecker_test.cpp Modified: cfe/trunk/test/Analysis/osobjectcstylecastchecker

r353878 - [X86] Use __m128_u for _mm_loadu_ps after r353555

2019-02-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Feb 12 13:04:21 2019 New Revision: 353878 URL: http://llvm.org/viewvc/llvm-project?rev=353878&view=rev Log: [X86] Use __m128_u for _mm_loadu_ps after r353555 Add secondary triple to existing SSE test for it. I audited other uses of __attribute__((__packed__)) in the intrins

r353893 - Revert r353880 "[HIP] Handle compile -m options and propagate into LLC"

2019-02-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Feb 12 14:51:54 2019 New Revision: 353893 URL: http://llvm.org/viewvc/llvm-project?rev=353893&view=rev Log: Revert r353880 "[HIP] Handle compile -m options and propagate into LLC" This was still causing test failures in the clang test suite. Removed: cfe/trunk/test/Driv

r354162 - [MSVC] Recognize `static_assert` keyword in C and C++98

2019-02-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Feb 15 11:59:45 2019 New Revision: 354162 URL: http://llvm.org/viewvc/llvm-project?rev=354162&view=rev Log: [MSVC] Recognize `static_assert` keyword in C and C++98 Summary: The main effect is that clang now accepts the following conforming C11 code with MSVC headers: #incl

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

2019-02-15 Thread Reid Kleckner via cfe-commits
Reverted: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351 On Fri, Feb 15, 2019 at 11:07 AM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Jan, > > It looks like this commit broke tests on couple of win builders: > > http://lab.llvm.org:8011/buil

r354169 - Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file"

2019-02-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Feb 15 12:48:12 2019 New Revision: 354169 URL: http://llvm.org/viewvc/llvm-project?rev=354169&view=rev Log: Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file" The new test doesn't pass on Windows. Modified: cfe/trunk/lib/Basic/Fil

r354626 - [clang-cl] Whitelist -fbracket-depth=123 in clang-cl

2019-02-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Feb 21 13:53:12 2019 New Revision: 354626 URL: http://llvm.org/viewvc/llvm-project?rev=354626&view=rev Log: [clang-cl] Whitelist -fbracket-depth=123 in clang-cl Users apparently need it when expanding large quantities of macros. Fixes PR38685 Modified: cfe/trunk/includ

r311899 - Fix inaccurate comment about -fdelayed-template-parsing and MSVC

2017-08-28 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Aug 28 10:59:24 2017 New Revision: 311899 URL: http://llvm.org/viewvc/llvm-project?rev=311899&view=rev Log: Fix inaccurate comment about -fdelayed-template-parsing and MSVC Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Cla

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

2017-08-28 Thread Reid Kleckner via cfe-commits
On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > Feels like this alignment attribute may be a bit of a death trap, then? > Should other uses of the attribute be scrutinized, or could we come up with > a portable way to use it safely? (using a different attribute on different > compilers -

r312017 - [ms] Fix vbtable index for covariant overrides of vbase methods

2017-08-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Aug 29 10:40:04 2017 New Revision: 312017 URL: http://llvm.org/viewvc/llvm-project?rev=312017&view=rev Log: [ms] Fix vbtable index for covariant overrides of vbase methods Overriding a method from a virtual base with a covariant return type consumes a slot from the vftable i

r312572 - [ms] Implement the __annotation intrinsic

2017-09-05 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 5 13:27:35 2017 New Revision: 312572 URL: http://llvm.org/viewvc/llvm-project?rev=312572&view=rev Log: [ms] Implement the __annotation intrinsic Added: cfe/trunk/test/CodeGen/ms-annotation.c cfe/trunk/test/Sema/ms-annotation.c Modified: cfe/trunk/include/cla

r312573 - Commit changes missing from r312572

2017-09-05 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 5 13:38:29 2017 New Revision: 312573 URL: http://llvm.org/viewvc/llvm-project?rev=312573&view=rev Log: Commit changes missing from r312572 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/ms-annotation.c Modified: cfe/trunk/lib/CodeGen/CGBui

r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

2017-09-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050&view=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

[clang-tools-extra] r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

2017-09-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050&view=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

[libclc] r314050 - [Support] Rename tool_output_file to ToolOutputFile, NFC

2017-09-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 22 18:03:17 2017 New Revision: 314050 URL: http://llvm.org/viewvc/llvm-project?rev=314050&view=rev Log: [Support] Rename tool_output_file to ToolOutputFile, NFC This class isn't similar to anything from the STL, so it shouldn't use the STL naming conventions. Modified:

r314051 - Commit missing fixes for tool_file_rename

2017-09-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 22 18:04:42 2017 New Revision: 314051 URL: http://llvm.org/viewvc/llvm-project?rev=314051&view=rev Log: Commit missing fixes for tool_file_rename Modified: cfe/trunk/unittests/CrossTU/CrossTranslationUnitTest.cpp cfe/trunk/unittests/Frontend/ASTUnitTest.cpp c

r363000 - Require stdcall etc parameters to be complete on ODR use

2019-06-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jun 10 15:53:12 2019 New Revision: 363000 URL: http://llvm.org/viewvc/llvm-project?rev=363000&view=rev Log: Require stdcall etc parameters to be complete on ODR use Functions using stdcall, fastcall, or vectorcall with C linkage mangle in the size of the parameter pack. Calc

r363007 - Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

2019-06-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jun 10 16:25:43 2019 New Revision: 363007 URL: http://llvm.org/viewvc/llvm-project?rev=363007&view=rev Log: Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist" Reverts r362998, r362996, and r362994 because the tests do not pass on Windows due t

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-06-11 Thread Reid Kleckner via cfe-commits
The new assert is firing across Chromium, please fix or revert. This is a reduced test case: int a; struct Foo { template void operator()(b, c = a); }; Foo d; bool e; decltype(d(e)) gv; This causes the "missing non-odr-use marking for unevaluated decl ref" assertion on SemaExpr.cpp:16227 to fi

r363191 - [MS] Pretend constexpr variable template specializations are inline

2019-06-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 12 11:53:49 2019 New Revision: 363191 URL: http://llvm.org/viewvc/llvm-project?rev=363191&view=rev Log: [MS] Pretend constexpr variable template specializations are inline Fixes link errors with clang and the latest Visual C++ 14.21.27702 headers, which was reported as P

r363195 - Add comment to r363191 code as requested in code review

2019-06-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 12 12:50:06 2019 New Revision: 363195 URL: http://llvm.org/viewvc/llvm-project?rev=363195&view=rev Log: Add comment to r363191 code as requested in code review Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.or

r363450 - Use unsigned for bitfields to avoid sign extension

2019-06-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 14 13:19:29 2019 New Revision: 363450 URL: http://llvm.org/viewvc/llvm-project?rev=363450&view=rev Log: Use unsigned for bitfields to avoid sign extension Modified: cfe/trunk/include/clang/Sema/DeclSpec.h cfe/trunk/lib/Sema/DeclSpec.cpp Modified: cfe/trunk/inclu

r363973 - Fix passing structs and AVX vectors through sysv_abi

2019-06-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Jun 20 13:07:20 2019 New Revision: 363973 URL: http://llvm.org/viewvc/llvm-project?rev=363973&view=rev Log: Fix passing structs and AVX vectors through sysv_abi Do this the same way we did it for ms_abi in r324594. Fixes PR36806. Added: cfe/trunk/test/CodeGen/sysv_abi.

Re: r365724 - clang-cl: Remove -O0 option

2019-07-11 Thread Reid Kleckner via cfe-commits
This seems to have caused a libfuzzer test to fail here: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/48261 It's not easy to fix because -O0 is passed to clang-cl on Windows and clang elsewhere, so /Od won't do the trick without a substitution. This was kind of why I added -O0 in the

r365956 - Revert driver: Don't warn about assembler flags being unused when not assembling

2019-07-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jul 12 13:44:57 2019 New Revision: 365956 URL: http://llvm.org/viewvc/llvm-project?rev=365956&view=rev Log: Revert driver: Don't warn about assembler flags being unused when not assembling This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40) and r365714

r366282 - Fix darwin-ld.c if dsymutil.exe exists on PATH

2019-07-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 16 16:38:05 2019 New Revision: 366282 URL: http://llvm.org/viewvc/llvm-project?rev=366282&view=rev Log: Fix darwin-ld.c if dsymutil.exe exists on PATH Modified: cfe/trunk/test/Driver/darwin-ld.c Modified: cfe/trunk/test/Driver/darwin-ld.c URL: http://llvm.org/viewv

r366284 - Fix OpenCLCXX test on 32-bit Windows where thiscall is present

2019-07-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 16 16:44:33 2019 New Revision: 366284 URL: http://llvm.org/viewvc/llvm-project?rev=366284&view=rev Log: Fix OpenCLCXX test on 32-bit Windows where thiscall is present Modified: cfe/trunk/test/SemaOpenCLCXX/address-space-deduction.cl Modified: cfe/trunk/test/SemaOpen

r367249 - Fix taint-generic.c on Windows, handle case in OS error

2019-07-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jul 29 11:48:50 2019 New Revision: 367249 URL: http://llvm.org/viewvc/llvm-project?rev=367249&view=rev Log: Fix taint-generic.c on Windows, handle case in OS error Modified: cfe/trunk/test/Analysis/taint-generic.c Modified: cfe/trunk/test/Analysis/taint-generic.c URL:

r367337 - Remove cache for macro arg stringization

2019-07-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 30 10:58:22 2019 New Revision: 367337 URL: http://llvm.org/viewvc/llvm-project?rev=367337&view=rev Log: Remove cache for macro arg stringization Summary: The cache recorded the wrong expansion location for all but the first stringization. It seems uncommon to stringize t

r367733 - The MinGW linker supports response files

2019-08-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Aug 2 15:55:00 2019 New Revision: 367733 URL: http://llvm.org/viewvc/llvm-project?rev=367733&view=rev Log: The MinGW linker supports response files This affects both LLD and ld.bfd. This isn't testable with a normal driver test with -### because those command lines are pri

r368348 - Fix up fd limit diagnosis code

2019-08-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 8 14:35:03 2019 New Revision: 368348 URL: http://llvm.org/viewvc/llvm-project?rev=368348&view=rev Log: Fix up fd limit diagnosis code Apparently Windows returns the "invalid argument" error code when the path contains invalid characters such as '<'. The test/Preprocesso

r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 8 14:45:59 2019 New Revision: 368354 URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev Log: Mark clang-scan-deps test as requiring thread support Otherwise the test calls a pure virtual method and crashes. Perhaps this could be improved. Modified: cfe/tr

Re: r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-08 Thread Reid Kleckner via cfe-commits
. On Thu, Aug 8, 2019 at 2:45 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu Aug 8 14:45:59 2019 > New Revision: 368354 > > URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev > Log: > Mark clang-scan-d

Re: r368348 - Fix up fd limit diagnosis code

2019-08-09 Thread Reid Kleckner via cfe-commits
pilers tolerate, afaik.) > > // Martin > > > On Thu, 8 Aug 2019, Reid Kleckner via cfe-commits wrote: > > > Author: rnk > > Date: Thu Aug 8 14:35:03 2019 > > New Revision: 368348 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=368348&vie

r368475 - Don't diagnose errors when a file matches an include component

2019-08-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Aug 9 12:49:14 2019 New Revision: 368475 URL: http://llvm.org/viewvc/llvm-project?rev=368475&view=rev Log: Don't diagnose errors when a file matches an include component This regressed in r368322, and was reported as PR42948 and on the mailing list. The fix is to ignore the

Re: r368348 - Fix up fd limit diagnosis code

2019-08-09 Thread Reid Kleckner via cfe-commits
gt; on it. (And this is code that all other major compilers tolerate, afaik.) > > // Martin > > > On Thu, 8 Aug 2019, Reid Kleckner via cfe-commits wrote: > > > Author: rnk > > Date: Thu Aug 8 14:35:03 2019 > > New Revision: 368348 > > > > URL: ht

Re: r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-13 Thread Reid Kleckner via cfe-commits
so the >>> TLS variables are simply global, and the RAII objects assert that things >>> haven't been constructed and destructed in the correct order. >>> >>> So, going forward you will probably need to remember to add REQUIRES: >>> thread_support t

r369043 - [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 15 12:45:28 2019 New Revision: 369043 URL: http://llvm.org/viewvc/llvm-project?rev=369043&view=rev Log: [Sema] Implement DR2386 for C++17 structured binding Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal

[clang-tools-extra] r364087 - Quote path to Python executable in case it has spaces

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 11:17:04 2019 New Revision: 364087 URL: http://llvm.org/viewvc/llvm-project?rev=364087&view=rev Log: Quote path to Python executable in case it has spaces These days Python 3 is typically installed into C:/Program Files, so cope with that. Similar to r364077 in compi

r364089 - Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 11:33:20 2019 New Revision: 364089 URL: http://llvm.org/viewvc/llvm-project?rev=364089&view=rev Log: Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c This reverts r363985 (git commit d5f16d6cfccc4b0b13b6c01d16c673886d53e695) This test can't use printf on

r364108 - Fix has_attribute.cpp test on Windows after r364102

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 15:28:52 2019 New Revision: 364108 URL: http://llvm.org/viewvc/llvm-project?rev=364108&view=rev Log: Fix has_attribute.cpp test on Windows after r364102 Modified: cfe/trunk/test/Preprocessor/has_attribute.cpp Modified: cfe/trunk/test/Preprocessor/has_attribute.cp

Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

2019-06-21 Thread Reid Kleckner via cfe-commits
I added -P to remove the line markers which were introducing the colons. On Fri, Jun 21, 2019 at 2:58 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit added broken test to the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x8

r364476 - Revert r363191 "[MS] Pretend constexpr variable template specializations are inline"

2019-06-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 26 14:16:51 2019 New Revision: 364476 URL: http://llvm.org/viewvc/llvm-project?rev=364476&view=rev Log: Revert r363191 "[MS] Pretend constexpr variable template specializations are inline" The next Visual Studio update will fix this issue, and it doesn't make sense to i

r365393 - Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

2019-07-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jul 8 14:59:07 2019 New Revision: 365393 URL: http://llvm.org/viewvc/llvm-project?rev=365393&view=rev Log: Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings This reverts r365382 (git commit 8b1becf2e31d9

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-09 Thread Reid Kleckner via cfe-commits
FYI, your test seems to fail on Windows: FAIL: Clang :: CodeGenOpenCL/pipe_builtin.cl (4679 of 15176) TEST 'Clang :: CodeGenOpenCL/pipe_builtin.cl' FAILED Script: -- : 'RUN: at line 1'; c:\b\slave\clang-x64-windows-msvc\build\build\stage1\bin\clang.exe -cc1

r365556 - De-templatize non-dependent VS macro logic, NFC

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 13:57:28 2019 New Revision: 365556 URL: http://llvm.org/viewvc/llvm-project?rev=365556&view=rev Log: De-templatize non-dependent VS macro logic, NFC These macro definitions don't depend on the template parameter, so they don't need to be part of the template. Move the

r365557 - Use the Itanium C++ ABI for the pipe_builtin.cl test

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 14:02:06 2019 New Revision: 365557 URL: http://llvm.org/viewvc/llvm-project?rev=365557&view=rev Log: Use the Itanium C++ ABI for the pipe_builtin.cl test Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI. Add a FIXME for it if anyone cares to implement

r365579 - [MS] Treat ignored explicit calling conventions as an explicit __cdecl

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 16:17:43 2019 New Revision: 365579 URL: http://llvm.org/viewvc/llvm-project?rev=365579&view=rev Log: [MS] Treat ignored explicit calling conventions as an explicit __cdecl The CCCR_Ignore action is only used for Microsoft calling conventions, mainly because MSVC does

r365581 - Revert [clang] DirectoryWatcher

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 16:22:01 2019 New Revision: 365581 URL: http://llvm.org/viewvc/llvm-project?rev=365581&view=rev Log: Revert [clang] DirectoryWatcher This reverts r365574 (git commit 31babea94a3ed38a140540f2252cf043dacec1f7) Removed: cfe/trunk/include/clang/DirectoryWatcher/

<    1   2   3   4   5   6   7   8   9   10   >