Author: rnk
Date: Mon Aug 13 18:55:37 2018
New Revision: 339638
URL: http://llvm.org/viewvc/llvm-project?rev=339638&view=rev
Log:
Revert r339623 "Model type attributes as regular Attrs."
This breaks compiling atlwin.h in Chromium. I'm sure the code is invalid
in some way, but we put a lot of work
Author: rnk
Date: Tue Aug 14 14:15:57 2018
New Revision: 339728
URL: http://llvm.org/viewvc/llvm-project?rev=339728&view=rev
Log:
Fix lit fatal errors about requiring a USE_Z3_SOLVER param
Modified:
cfe/trunk/test/lit.site.cfg.py.in
Modified: cfe/trunk/test/lit.site.cfg.py.in
URL:
http://ll
After this, check-clang no longer worked, it emitted a fatal error because
USE_Z3_SOLVER was not in lit_config.params. I worked around it in r339728,
but you might want to double check it.
On Mon, Aug 13, 2018 at 4:13 PM George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Auth
Author: rnk
Date: Fri Aug 17 13:59:27 2018
New Revision: 340079
URL: http://llvm.org/viewvc/llvm-project?rev=340079&view=rev
Log:
[MS] Mangle a hash of the main file path into anonymous namespaces
Summary:
This is needed to avoid conflicts in mangled names for codeview types in
anonymous namespac
Author: rnk
Date: Fri Aug 17 13:59:52 2018
New Revision: 340080
URL: http://llvm.org/viewvc/llvm-project?rev=340080&view=rev
Log:
Update comments in CGDebugInfo to reflect changes in the MS mangler, NFC
I've tried to elaborate on the purpose of these type identifiers and why
and when clang uses t
Author: rnk
Date: Fri Aug 17 15:11:31 2018
New Revision: 340101
URL: http://llvm.org/viewvc/llvm-project?rev=340101&view=rev
Log:
Don't warn on returning the address of a label from a statement expression
Summary:
There isn't anything inherently wrong with returning a label from a
statement expre
Author: rnk
Date: Wed Aug 22 10:47:41 2018
New Revision: 340427
URL: http://llvm.org/viewvc/llvm-project?rev=340427&view=rev
Log:
Disable the aligned allocation test on old mac versions instead of XFAILing it
It looks like this test XPASSes when the deployment target is older than
the OS of the s
Author: rnk
Date: Thu May 10 11:57:35 2018
New Revision: 332018
URL: http://llvm.org/viewvc/llvm-project?rev=332018&view=rev
Log:
Allow dllimport non-type template arguments in C++17
Summary:
Fixes PR35772.
Reviewers: rsmith
Differential Revision: https://reviews.llvm.org/D43320
Added:
cfe
Author: rnk
Date: Thu May 10 15:24:00 2018
New Revision: 332053
URL: http://llvm.org/viewvc/llvm-project?rev=332053&view=rev
Log:
[clang-cl] Make -f[no-]coverage-mapping available
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
ht
Author: rnk
Date: Thu May 10 18:26:11 2018
New Revision: 332074
URL: http://llvm.org/viewvc/llvm-project?rev=332074&view=rev
Log:
Don't propagate dllimport to base class template static data members
MSVC doesn't, so we shouldn't. Fixes PR37232.
Added:
cfe/trunk/test/CodeGenCXX/dllimport-temp
Author: rnk
Date: Thu May 17 11:12:18 2018
New Revision: 332639
URL: http://llvm.org/viewvc/llvm-project?rev=332639&view=rev
Log:
Fix a mangling failure on clang-cl C++17
MethodVFTableLocations in MigrosoftVTableContext contains canonicalized
decl. But, it's sometimes asked to lookup for non-cano
Author: rnk
Date: Thu May 17 11:34:05 2018
New Revision: 332646
URL: http://llvm.org/viewvc/llvm-project?rev=332646&view=rev
Log:
Add missing test case for r332639
Added:
cfe/trunk/test/CodeGenCXX/PR37481.cpp
Added: cfe/trunk/test/CodeGenCXX/PR37481.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Thanks! Added in 332646
On Thu, May 17, 2018 at 11:30 AM Nico Weber wrote:
> You might've forgotten to svn add the test :-)
>
> On Thu, May 17, 2018, 2:16 PM Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Th
Author: rnk
Date: Mon Oct 2 10:16:14 2017
New Revision: 314689
URL: http://llvm.org/viewvc/llvm-project?rev=314689&view=rev
Log:
Revert "[Sema] Warn on attribute nothrow conflicting with language specifiers"
This reverts r314461.
It is warning on user code that uses END_COM_MAP(), which expands
Author: rnk
Date: Mon Oct 2 17:14:03 2017
New Revision: 314743
URL: http://llvm.org/viewvc/llvm-project?rev=314743&view=rev
Log:
[clang-cl] Claim ignored /O[12xd] arguments
Fixes PR34809
Modified:
cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
cfe/trunk/test/Driver/cl-options.c
Modified: cfe
Author: rnk
Date: Tue Oct 3 13:37:06 2017
New Revision: 314840
URL: http://llvm.org/viewvc/llvm-project?rev=314840&view=rev
Log:
Fix hicpp-signed-bitwise.cpp test on Windows, where the MSVC ABI changes enum
underlying types
Modified:
clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitw
Author: rnk
Date: Fri Oct 6 14:02:28 2017
New Revision: 315107
URL: http://llvm.org/viewvc/llvm-project?rev=315107&view=rev
Log:
[MS] Raise the default value of _MSC_VER to 1911, which is VS 2017
Summary:
This raises our default past 1900, which controls whether char16_t is a
builtin type or not
Author: rnk
Date: Fri Oct 6 14:28:21 2017
New Revision: 315111
URL: http://llvm.org/viewvc/llvm-project?rev=315111&view=rev
Log:
Revert "For dllexport class templates, export specializations of member
functions (PR34849)"
This reverts r315025, it caused http://crbug.com/772461
Modified:
cf
Author: rnk
Date: Thu Oct 12 17:53:02 2017
New Revision: 315656
URL: http://llvm.org/viewvc/llvm-project?rev=315656&view=rev
Log:
[MS] Don't bail on replacing dllimport vbase dtors with base dtors
Fix PR32990 by effectively reverting r283063 and solving it a different
way.
We want to limit the h
Author: rnk
Date: Fri Oct 13 09:18:32 2017
New Revision: 315699
URL: http://llvm.org/viewvc/llvm-project?rev=315699&view=rev
Log:
Hide "#pragma optimize("", off)" from clang when it pretends to be MSVC 2017
These pragmas work around a bug in VC 1911 that isn't present in clang,
and clang warns ab
Author: rnk
Date: Fri Oct 13 09:55:14 2017
New Revision: 315707
URL: http://llvm.org/viewvc/llvm-project?rev=315707&view=rev
Log:
[SEH] Use the SEH personality on frontend-outlined funclets
This allows __try inside __finally to work.
Fixes PR34939
Modified:
cfe/trunk/lib/CodeGen/CGException
Author: rnk
Date: Mon Oct 16 16:07:15 2017
New Revision: 315953
URL: http://llvm.org/viewvc/llvm-project?rev=315953&view=rev
Log:
Don't print end-of-directive tokens in -E output
This comes up when pre-processing standalone .s files containing
hash-prefixed comments. The pre-processor should skip
Author: rnk
Date: Thu Sep 6 11:25:39 2018
New Revision: 341572
URL: http://llvm.org/viewvc/llvm-project?rev=341572&view=rev
Log:
Re-land r334417 "[MS] Use mangled names and comdats for string merging with
ASan"
The issue with -fprofile-generate was fixed and the dependent CL
relanded in r340232
Author: rnk
Date: Fri Sep 14 13:50:39 2018
New Revision: 342281
URL: http://llvm.org/viewvc/llvm-project?rev=342281&view=rev
Log:
Relax assumption about default method calling convention in new test
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-lambda.cpp
Modified: cfe/trunk/test/CodeGenCXX
Author: rnk
Date: Fri Sep 14 13:51:07 2018
New Revision: 342282
URL: http://llvm.org/viewvc/llvm-project?rev=342282&view=rev
Log:
Mark index-tools.test as REQUIRES: shell so that it does not run with the
internal lit shell which does not support "if"
Modified:
clang-tools-extra/trunk/test/cl
That construct does not work on Windows, where we don't use bash. We use
the lit internal shell, which doesn't support 'if [ ...]'. I marked it
REQUIRES: shell in r342282.
On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: omtcyfz
> Date:
Author: rnk
Date: Fri Jul 20 13:55:00 2018
New Revision: 337616
URL: http://llvm.org/viewvc/llvm-project?rev=337616&view=rev
Log:
[codeview] Don't emit variable templates as class members
MSVC doesn't, so neither should we.
Fixes PR38004, which is a crash that happens when we try to emit debug
i
Author: rnk
Date: Fri Jul 20 15:36:33 2018
New Revision: 337629
URL: http://llvm.org/viewvc/llvm-project?rev=337629&view=rev
Log:
Disable clang crash-report-modules.m test on Windows again
It still appears to be failing:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12825
$
Author: rnk
Date: Mon Jul 23 10:44:00 2018
New Revision: 337715
URL: http://llvm.org/viewvc/llvm-project?rev=337715&view=rev
Log:
[MS] Update _MSVC_LANG values for C++17 and C++2a
Fixes PR38262
Added:
cfe/trunk/test/Preprocessor/predefined-win-macros.c
Modified:
cfe/trunk/lib/Basic/Targe
Author: rnk
Date: Mon Jul 23 14:29:43 2018
New Revision: 337746
URL: http://llvm.org/viewvc/llvm-project?rev=337746&view=rev
Log:
[clang-cl] Expose -fblocks and -fno-builtin as driver flags
Users have requested them.
Helps with PR36427.
Modified:
cfe/trunk/include/clang/Driver/Options.td
Author: rnk
Date: Thu Jul 26 16:18:44 2018
New Revision: 338083
URL: http://llvm.org/viewvc/llvm-project?rev=338083&view=rev
Log:
[MS] Add L__FUNCSIG__ for compatibility
Clang already has L__FUNCTION__ as a workaround for dealing with
pre-processor code that expects to be able to do L##__FUNCTION
Author: rnk
Date: Thu Jul 26 16:21:51 2018
New Revision: 338084
URL: http://llvm.org/viewvc/llvm-project?rev=338084&view=rev
Log:
Revert r338057 "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status
with the requested name"
This broke clang/test/PCH/case-insensitive-include.c on Windo
I reverted this in r338084 because it broke clang tests on Windows:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12916
On Thu, Jul 26, 2018 at 11:55 AM Simon Marchi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: simark
> Date: Thu Jul 26 11:55:02 2018
> New
On Wed, Jul 25, 2018 at 4:39 AM Nico Weber wrote:
> I thought about adding -fblocks when that thread happened, but since
> there's no runtime for them that just works exposing it doesn't seem very
> helpful. Maybe we should instead change the warning text to not suggest
> -fblocks when building o
Author: rnk
Date: Tue Jul 31 14:57:35 2018
New Revision: 338444
URL: http://llvm.org/viewvc/llvm-project?rev=338444&view=rev
Log:
Revert r337635 "[Driver] Sanitizer support based on runtime library presence"
This change causes issues with distributed build systems, which may only
have compiler bi
Author: rnk
Date: Wed Aug 1 15:10:03 2018
New Revision: 338643
URL: http://llvm.org/viewvc/llvm-project?rev=338643&view=rev
Log:
Fix -Wcovered-switch-default uncovered after r338630
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
Modified: cfe/trunk/lib/AST/DeclBase.cpp
URL:
http://llvm.org/viewv
Author: rnk
Date: Thu Feb 8 16:16:41 2018
New Revision: 324689
URL: http://llvm.org/viewvc/llvm-project?rev=324689&view=rev
Log:
[WinEH] Put funclet bundles on inline asm calls
Summary:
Fixes PR36247, which is where WinEHPrepare replaces inline asm in
funclets with unreachable.
Make getBundlesF
Author: rnk
Date: Mon Feb 12 09:37:06 2018
New Revision: 324913
URL: http://llvm.org/viewvc/llvm-project?rev=324913&view=rev
Log:
[Sema] Don't mark plain MS enums as fixed
Summary:
This fixes a flaw in our AST: PR27098
MSVC always gives plain enums the underlying type 'int'. Clang does this
as w
Author: rnk
Date: Fri Feb 16 11:44:47 2018
New Revision: 325375
URL: http://llvm.org/viewvc/llvm-project?rev=325375&view=rev
Log:
[MS] Make constexpr static data members implicitly inline
This handles them exactly the same way that we handle const integral
static data members with inline definiti
Author: rnk
Date: Mon Feb 26 14:55:33 2018
New Revision: 326141
URL: http://llvm.org/viewvc/llvm-project?rev=326141&view=rev
Log:
Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."
Reverts r326116 and re-lands r326113 with a fix to ASan so that it
enables column info
Author: rnk
Date: Mon Feb 26 15:06:40 2018
New Revision: 326144
URL: http://llvm.org/viewvc/llvm-project?rev=326144&view=rev
Log:
Fix codeview-column-info.c test with a triple
Modified:
cfe/trunk/test/Driver/codeview-column-info.c
Modified: cfe/trunk/test/Driver/codeview-column-info.c
URL:
I agree with Nico in retrospect. Setting -fno-operator-names is too big a
hammer. Instead we should add some MSVCCompat hacks to pretend we saw an
identifier token instead of a keyword token when these keywords are used as
declarators.
On Thu, May 25, 2017 at 10:14 AM, Nico Weber wrote:
> Among
Author: rnk
Date: Thu May 25 15:28:26 2017
New Revision: 303908
URL: http://llvm.org/viewvc/llvm-project?rev=303908&view=rev
Log:
Revert "[AMDGPU] add __builtin_amdgcn_s_getpc"
This reverts commit r303861, the LLVM intrinsic was reverted.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGP
Author: rnk
Date: Fri May 26 12:11:10 2017
New Revision: 304006
URL: http://llvm.org/viewvc/llvm-project?rev=304006&view=rev
Log:
Update MS mangling EBNF, NFC
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: rnk
Date: Fri May 26 12:38:15 2017
New Revision: 304012
URL: http://llvm.org/viewvc/llvm-project?rev=304012&view=rev
Log:
Enable __float128 for mingw for GCC compatibility and define
__SIZEOF_FLOAT128__ on x86
GCC defines __FLOAT128__ on Power and __SIZEOF_FLOAT128__ on x86. We're
just f
Author: rnk
Date: Fri May 26 12:48:01 2017
New Revision: 304013
URL: http://llvm.org/viewvc/llvm-project?rev=304013&view=rev
Log:
Only define __SIZEOF_FLOAT128__ on x86 as intended in r304012
GCC only defines it on x86.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Frontend/Ini
Author: rnk
Date: Wed May 31 09:50:28 2017
New Revision: 304303
URL: http://llvm.org/viewvc/llvm-project?rev=304303&view=rev
Log:
[clang-cl] Ignore /Zc:ternary, clang behaves this way already
Addresses part of PR33237
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/
Author: rnk
Date: Wed May 31 10:39:28 2017
New Revision: 304305
URL: http://llvm.org/viewvc/llvm-project?rev=304305&view=rev
Log:
[clang-cl] Improve default calling convention flag handling
Ignore default CC flags that don't make sense for the target arch. This
is consistent with MSVC.
Addresses
Author: rnk
Date: Wed May 31 10:50:35 2017
New Revision: 304308
URL: http://llvm.org/viewvc/llvm-project?rev=304308&view=rev
Log:
Fix incorrect spelling of calling conv flag and add -Wno-msvc-not-found to test
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
cfe/trunk/test/Driver/cl-cc
Author: rnk
Date: Wed May 31 12:37:49 2017
New Revision: 304316
URL: http://llvm.org/viewvc/llvm-project?rev=304316&view=rev
Log:
[clang-cl] Implement /diagnostic: flag
This flag has three possible values: caret, column, and classic.
"caret" corresponds to clang's default mode, "column" removes
Author: rnk
Date: Wed May 31 14:59:41 2017
New Revision: 304335
URL: http://llvm.org/viewvc/llvm-project?rev=304335&view=rev
Log:
Don't try to spill static allocas when emitting expr cleanups with branches
Credit goes to Gor Nishanov for putting together the fix in
https://reviews.llvm.org/D33733
Author: rnk
Date: Wed May 31 15:02:27 2017
New Revision: 304336
URL: http://llvm.org/viewvc/llvm-project?rev=304336&view=rev
Log:
Add test case for r304316 which implemented clang-cl /diagnostics:*
Added:
cfe/trunk/test/Driver/cl-diagnostics.c
Added: cfe/trunk/test/Driver/cl-diagnostics.c
UR
Author: rnk
Date: Wed May 31 15:07:36 2017
New Revision: 304337
URL: http://llvm.org/viewvc/llvm-project?rev=304337&view=rev
Log:
Fix cl-diagnostics.c test by hardcoding the version of MSVC to mimic
Modified:
cfe/trunk/test/Driver/cl-diagnostics.c
Modified: cfe/trunk/test/Driver/cl-diagnosti
Author: rnk
Date: Wed May 31 15:42:43 2017
New Revision: 304345
URL: http://llvm.org/viewvc/llvm-project?rev=304345&view=rev
Log:
[clang-cl] Expose -nostdinc and -nobuiltininc
These are already wired up to work in the MSVC toolchain header search
code. However, they were unreachable from clang-cl
On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool
wrote:
> I'm worried about changing this signature all the time. I suspect that it
> will cause the following to be emitted for valid code:
>
> warning: incompatible pointer types passing 'unsigned long *' to parameter
> of type 'unsigned int *'
Author: rnk
Date: Mon Jun 12 14:57:56 2017
New Revision: 305224
URL: http://llvm.org/viewvc/llvm-project?rev=305224&view=rev
Log:
Correct debug info bit offset calculation for big-endian targets
Summary:
The change "[CodeView] Implement support for bit fields in
Clang" (r274201, https://reviews.l
We should fix it. We just need a new character code in the builtin function
prototype encoding. Currently there is no encoding for a portable int32_t
that magically becomes "long" on 32-bit Windows. The closest thing we have
is 'W', which is used by Neon intrinsics to select between "long" and "lon
Author: rnk
Date: Tue Jun 20 15:34:13 2017
New Revision: 305841
URL: http://llvm.org/viewvc/llvm-project?rev=305841&view=rev
Log:
Fix discovery of cxxabi.h in the monorepo layout
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-pro
Author: rnk
Date: Fri Jun 23 13:29:13 2017
New Revision: 306137
URL: http://llvm.org/viewvc/llvm-project?rev=306137&view=rev
Log:
[MS] Don't statically initialize dllimport member function pointers
We were already applying the same rules to dllimport function pointers.
David Majnemer added that l
Author: rnk
Date: Fri Jun 23 17:39:01 2017
New Revision: 306175
URL: http://llvm.org/viewvc/llvm-project?rev=306175&view=rev
Log:
Revert "[MS] Don't statically initialize dllimport member function pointers"
This reverts commit r306137. It has problems on code like this:
struct __declspec(dllim
Author: rnk
Date: Thu Dec 14 11:00:21 2017
New Revision: 320730
URL: http://llvm.org/viewvc/llvm-project?rev=320730&view=rev
Log:
[CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic
Summary:
InterlockedCompareExchange128 is a bit more complicated than the other
InterlockedCompareExc
Author: rnk
Date: Thu Dec 21 11:44:23 2017
New Revision: 321298
URL: http://llvm.org/viewvc/llvm-project?rev=321298&view=rev
Log:
Revert "Fix for PR32990"
This reverts commit r321239. It broke the Chromium DLL build:
[8834/50217] LINK(DLL) icui18n.dll icui18n.dll.lib icui18n.dll.pdb
FAILED: icui
Author: rnk
Date: Tue Jan 2 13:34:16 2018
New Revision: 321676
URL: http://llvm.org/viewvc/llvm-project?rev=321676&view=rev
Log:
[WinEH] Allow for multiple terminatepads
Fixes verifier errors with Windows EH and OpenMP, which injects a
terminate scope around parallel blocks.
Fixes PR35778
Modi
Thanks, this is the correct fix, and the pattern used in all the rest of
the clang-cl driver tests.
On Mon, Feb 26, 2018 at 10:06 PM Shoaib Meenai wrote:
> r326171 works locally. I'll keep an eye on the bots.
>
>
>
> *From: * on behalf of Adam Nemet
> *Date: *Monday, February 26, 2018 at 9:51
was the
> patch did, but I misread.) I.e. with an MSVC triple, default to emitting
> codeview?
>
> On Mon, Feb 26, 2018 at 5:55 PM, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Mon Feb 26 14:55:33 2018
>> New
Author: rnk
Date: Fri Mar 2 13:41:08 2018
New Revision: 326622
URL: http://llvm.org/viewvc/llvm-project?rev=326622&view=rev
Log:
Don't claim that va_start has special semantic checks
We don't have special checks for BI_va_start in
Sema::CheckBuiltinFunctionCall, so setting the 't' flag for va_st
Author: rnk
Date: Mon Mar 5 13:36:23 2018
New Revision: 326744
URL: http://llvm.org/viewvc/llvm-project?rev=326744&view=rev
Log:
[msvc] Allow MSVC toolchain driver to find the aarch64 / arm64 cross-compiler.
Starting with the Fall Creators Update, Windows 10 Desktop can run on
machines that are
Author: rnk
Date: Wed Mar 7 10:55:10 2018
New Revision: 326926
URL: http://llvm.org/viewvc/llvm-project?rev=326926&view=rev
Log:
Push a function scope when parsing function bodies without a declaration
Summary:
This is PR36536.
There are a few ways to reach Sema::ActOnStartOfFunctionDef with a
Author: rnk
Date: Wed Mar 7 14:48:35 2018
New Revision: 326957
URL: http://llvm.org/viewvc/llvm-project?rev=326957&view=rev
Log:
Avoid including ScopeInfo.h from Sema.h
Summary:
This provides no measurable build speedup, but it reinstates an
optimization from r112038 that was lost in r179618. I
Author: rnk
Date: Wed Mar 7 15:26:02 2018
New Revision: 326962
URL: http://llvm.org/viewvc/llvm-project?rev=326962&view=rev
Log:
[MS] Accept __unaligned as a qualifier on member function pointers
We need to treat __unaligned like the other 'cvr' qualifiers when it
appears at the end of a functio
Author: rnk
Date: Wed Mar 7 16:14:34 2018
New Revision: 326965
URL: http://llvm.org/viewvc/llvm-project?rev=326965&view=rev
Log:
[Sema] Make getCurFunction() return null outside function parsing
Summary:
Before this patch, Sema pre-allocated a FunctionScopeInfo and kept it in
the first, always p
Author: rnk
Date: Wed Mar 7 16:55:09 2018
New Revision: 326971
URL: http://llvm.org/viewvc/llvm-project?rev=326971&view=rev
Log:
[MS] Pass CVRU qualifiers properly in Itanium mangler
We already have a mangling for the __unaligned qualifier, we just have
to call Qualifiers::getFromCVRUMask instea
Author: rnk
Date: Wed Mar 7 17:12:22 2018
New Revision: 326974
URL: http://llvm.org/viewvc/llvm-project?rev=326974&view=rev
Log:
Revert "[Sema] Make getCurFunction() return null outside function parsing"
This reverts r326965. It seems to have caused repeating test failures in
clang/test/Sema/dia
Author: rnk
Date: Mon Mar 12 14:43:02 2018
New Revision: 327334
URL: http://llvm.org/viewvc/llvm-project?rev=327334&view=rev
Log:
Re-land "[Sema] Make getCurFunction() return null outside function parsing"
This relands r326965.
There was a null dereference in typo correction that was triggered i
Author: rnk
Date: Fri Mar 16 12:40:50 2018
New Revision: 327732
URL: http://llvm.org/viewvc/llvm-project?rev=327732&view=rev
Log:
[MS] Always use base dtors in place of complete/vbase dtors when possible
Summary:
Previously we tried too hard to uphold the fiction that destructor
variants work lik
Author: rnk
Date: Fri Mar 16 13:37:59 2018
New Revision: 327739
URL: http://llvm.org/viewvc/llvm-project?rev=327739&view=rev
Log:
[MS] Commit some changes that were intended to be part of r327738
Modified:
cfe/trunk/test/CodeGenCXX/regcall.cpp
Modified: cfe/trunk/test/CodeGenCXX/regcall.cpp
Author: rnk
Date: Fri Mar 16 13:53:13 2018
New Revision: 327741
URL: http://llvm.org/viewvc/llvm-project?rev=327741&view=rev
Log:
[MS] Fix tests after r327738 that only fail with a default Windows target
Modified:
cfe/trunk/test/CodeGenCXX/trap-fnattr.cpp
cfe/trunk/test/PCH/chain-openmp-t
Author: rnk
Date: Fri Mar 16 15:20:57 2018
New Revision: 327754
URL: http://llvm.org/viewvc/llvm-project?rev=327754&view=rev
Log:
[MS] Fix bug in r327732 with devirtualized complete destructor calls
Added:
cfe/trunk/test/CodeGenCXX/devirtualize-ms-dtor.cpp
Modified:
cfe/trunk/lib/CodeGen/
Yes: https://reviews.llvm.org/D7775
This side is very mechanical, so I did not send it for review.
On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote:
> Was this discussed or reviewed somewhere? (It looks like a good change to
> me, I'm just wondering if there was something that triggered this and
Author: rnk
Date: Thu May 31 11:42:29 2018
New Revision: 333680
URL: http://llvm.org/viewvc/llvm-project?rev=333680&view=rev
Log:
Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()
Ensure latest MPT decl has a MSInheritanceAttr when instantiating
templates, to avoid null M
Author: rnk
Date: Mon Jun 4 14:39:20 2018
New Revision: 333958
URL: http://llvm.org/viewvc/llvm-project?rev=333958&view=rev
Log:
Revert r333791 "Cap "voluntary" vector alignment at 16 for all Darwin
platforms."
Adding __attribute__((aligned(32))) to __m256 breaks the implementation
of _mm256_lo
Author: rnk
Date: Mon Jun 4 18:33:40 2018
New Revision: 333978
URL: http://llvm.org/viewvc/llvm-project?rev=333978&view=rev
Log:
Reimplement the bittest intrinsic family as builtins with inline asm
We need to implement _interlockedbittestandset as a builtin for
windows.h, so we might as well do
On Tue, Jun 5, 2018 at 2:33 AM Martin Storsjö wrote:
> > // Many of MSVC builtins are on both x64 and ARM; to avoid repeating
> code, we
> > // handle them here.
>
> This doesn't seem thought through wrt non-x86 architectures. I'm not sure
> if there's any similar suitable instruction to use on A
Author: rnk
Date: Tue Jun 5 18:35:08 2018
New Revision: 334059
URL: http://llvm.org/viewvc/llvm-project?rev=334059&view=rev
Log:
Implement bittest intrinsics generically for non-x86 platforms
I tested these locally on an x86 machine by disabling the inline asm
codepath and confirming that it doe
Author: rnk
Date: Tue Jun 5 18:44:10 2018
New Revision: 334060
URL: http://llvm.org/viewvc/llvm-project?rev=334060&view=rev
Log:
Fix std::tuple errors
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: rnk
Date: Wed Jun 6 11:39:47 2018
New Revision: 334112
URL: http://llvm.org/viewvc/llvm-project?rev=334112&view=rev
Log:
[MS][ARM64]: Promote _setjmp to_setjmpex as there is no _setjmp in the ARM64
libvcruntime.lib
Factor out the common setjmp call emission code.
Based on a patch by Ch
Author: rnk
Date: Thu Jun 7 14:39:04 2018
New Revision: 334239
URL: http://llvm.org/viewvc/llvm-project?rev=334239&view=rev
Log:
[MS] Re-add support for the ARM interlocked bittest intrinscs
Adds support for these intrinsics, which are ARM and ARM64 only:
_interlockedbittestandreset_acq
_int
set_acq'
> use of undeclared identifier '_interlockedbittestandset_rel'
> use of undeclared identifier '_interlockedbittestandset_nf'
>
> I see that you have removed them in your patch. Apparently they are needed
> (at least for ARM64 Win).
>
> --Mandeep
>
&
Author: rnk
Date: Mon Jun 11 09:49:43 2018
New Revision: 334417
URL: http://llvm.org/viewvc/llvm-project?rev=334417&view=rev
Log:
[MS] Use mangled names and comdats for string merging with ASan
This should reduce the binary size penalty of ASan on Windows. After
r334313, ASan will add red zones t
Author: rnk
Date: Mon Jun 11 09:50:07 2018
New Revision: 334418
URL: http://llvm.org/viewvc/llvm-project?rev=334418&view=rev
Log:
Enable crash recovery tests on Windows, globs work in the lit internal shell now
Modified:
cfe/trunk/test/Driver/crash-report-header.h
cfe/trunk/test/Driver/cr
On Tue, Jun 12, 2018 at 4:43 AM Hans Wennborg wrote:
> Actually, maybe switching the order from "not env ... %clang" to "env
> ... not %clang" might work...
>
Thanks, I was going to try that next.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
The length of that path is about 257, or very near MAX_PATH, which suggests
that the version of rm you are using does not tolerate deep paths. This has
been a long standing problem, and our solution to it was to install a
special version of rm.exe on all of our buildbots that reliably handles
long
This test has been failing on Windows since it has been added:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12549
I took a look at the unittest code, but I'm not familiar enough with this
code to debug it. Can you take a look at this?
On Fri, Jun 15, 2018 at 1:35 AM Ilya Bi
Author: rnk
Date: Mon Jun 18 11:55:10 2018
New Revision: 334973
URL: http://llvm.org/viewvc/llvm-project?rev=334973&view=rev
Log:
Fix clangd test to pass when delayed template parsing is on by default
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-to
And, as soon as I sent that, I realized what was up. Apparently
auto-complete is driven by the parser, and delayed template parsing means
we don't parse templates. That seems like a serious issue that should get
fixed eventually.
Anyway, I landed a crummy workaround in r334973 to green the bots.
Author: rnk
Date: Wed Jun 20 14:12:20 2018
New Revision: 335175
URL: http://llvm.org/viewvc/llvm-project?rev=335175&view=rev
Log:
[MS] Make sure __GetExceptionInfo works on types with no linkage
Fixes PR36327
Modified:
cfe/trunk/lib/Sema/Sema.cpp
cfe/trunk/test/CodeGenCXX/microsoft-abi-t
Author: rnk
Date: Sat Jun 23 10:32:51 2018
New Revision: 335419
URL: http://llvm.org/viewvc/llvm-project?rev=335419&view=rev
Log:
Attempt to fix latent tablegen dependency issue
Modified:
cfe/trunk/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
Modified: cfe/trunk/tools/clang-fuzzer/handle-ll
Author: rnk
Date: Wed Oct 10 14:59:56 2018
New Revision: 344190
URL: http://llvm.org/viewvc/llvm-project?rev=344190&view=rev
Log:
[AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals
Summary:
In r340386 we added code to give static locals in inline functions
default visibility
Author: rnk
Date: Fri Oct 12 11:08:11 2018
New Revision: 344389
URL: http://llvm.org/viewvc/llvm-project?rev=344389&view=rev
Log:
Revert r344375 "[Driver] check for exit code from SIGPIPE"
This doesn't build on Windows.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Drive
This patch makes a lot of posix assumptions, and that header file doesn't
exist on Windows. I reverted this to fix the build, but you might want to
reconsider how this is designed.
On Fri, Oct 12, 2018 at 10:24 AM Nick Desaulniers via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nic
1 - 100 of 1444 matches
Mail list logo
