[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][CLange] Rename NodeType::Record to NodeType::Rec (PR #108826)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108826 Fixes build failure by avoiding conflicting with `Record` class name. >From 4c9eb0b0edb3487097f44d1afc58397f03a370b7 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 16 Sep 2024 06:50:09 -0700 Subject: [PA

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

jurahul wrote: I have a proposed fix here: https://github.com/llvm/llvm-project/pull/108826 https://github.com/llvm/llvm-project/pull/108627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [LLVM][CLange] Rename NodeType::Record to NodeType::Rec (PR #108826)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][CLange] Rename NodeType::Record to NodeType::Rec (PR #108826)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

jurahul wrote: Fix has been merged: https://github.com/llvm/llvm-project/pull/108826 https://github.com/llvm/llvm-project/pull/108627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

jurahul wrote: This was not flagged by pre-commit CI. I am wondering if the CI can be tweaked to flag this pre commit. https://github.com/llvm/llvm-project/pull/108627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

jurahul wrote: I see that the warning is not yet implemented in clang, but its in GCC, so only GCC based builds flagged it as an error. So what we really need it a GCC based build, which is not a tweak. https://github.com/llvm/llvm-project/pull/108627 __

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/107533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: @JDevlieghere or @dwblaikie one last ping to comment if consistency of file names is a strong enough motivation. If not, I will drop this. https://github.com/llvm/llvm-project/pull/110692 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Thanks. So it seems we have 2 ways forwards: 1. Add back getDeclaration, marked deprecated, and then delete it in say 2-3 weeks, and then reintroduce it with different semantics 6 months down the road. Meanwhile, add findDeclaration as an alias, start using it, and then 6 months d

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: I will add getDeclaration back and mark it deprecated. What’s the timeframe for deprecation thought? A couple of weeks? Because I do want to add back the getDeclaration with different semantics. Unless we go with @nikic’s recommendation of getDeclarationIfExists. I am going to wait

[clang] [Clang][TableGen] Use const pointer for various `Init` pointers. (PR #112318)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/112318 None >From a9ded784183d3df06434814af9e0ca32d9ef907f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 22:56:07 -0700 Subject: [PATCH] [Clang][TableGen] Use const pointer for various `Init` poin

[clang] [Clang][TableGen] NeonEmitter (PR #112317)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/112317 None >From 6dfa15a4c498855bc8bfe363671b7ee17d55d980 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 23:12:24 -0700 Subject: [PATCH] [Clang][TableGen] NeonEmitter --- clang/utils/TableGen/Neo

[clang] [Clang][TableGen] NeonEmitter (PR #112317)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use const pointers for various Init objects in NeonEmitter (PR #112317)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use const pointers for various Init objects in NeonEmitter (PR #112317)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/112317 >From a0b77a500db2147a57d77f575b65c0c38af0c2f8 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 23:12:24 -0700 Subject: [PATCH] [Clang][TableGen] NeonEmitter --- clang/utils/TableGen/NeonEmitt

[clang] [Clang][TableGen] Use const pointers for various Init objects in Diagnostic Emitter (PR #112318)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/112318 >From 2fe295768c87dca53e4cecd8a93f6936de0fe50c Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 22:56:07 -0700 Subject: [PATCH] [Clang][TableGen] Use const pointer for various `Init` pointers.

[clang] [Clang][TableGen] Use const pointers for various `Init *` pointers (PR #112321)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/112321 >From 4743134d6b6ef21fc6b09dea59c30d6be31ef3fd Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 23:01:19 -0700 Subject: [PATCH] [Clang][TableGen] Use const pointers for various `Init *` pointer

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Yes, and that’s the motivation for this (this is a prep PR for that change) On Thu, Oct 10, 2024 at 12:41 AM Matt Arsenault ***@***.***> wrote: > ***@***. approved this pull request. > > There are definitely places that would benefit from a getDeclaration. > There are several

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Btw, the findDeclaration was a temporary state and the plan is to switch to getDeclaration eventually. The findDeclaration was for staging the rename. On Fri, Oct 11, 2024 at 2:55 PM Rahul Joshi ***@***.***> wrote: > That’s a possibility. I was trying to keep the naming consisten

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/110692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: Sounds good. thanks. https://github.com/llvm/llvm-project/pull/110692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-files.txt file (PR #109220)

jurahul wrote: @AaronBallman ping to comment on this again. Not only does this have files missing, it also includes file names that do not exist anymore in the repo: ``` clang/docs/tools/clang-formatted-files.txt:llvm/include/llvm/DWP/DWPStringPool.h clang/docs/tools/clang-formatted-files.txt:l

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Fix for build break available here: https://github.com/llvm/llvm-project/pull/111990 https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/111990 Fix build failure from the rename change. Looks like one additional reference sneaked in between pre-commit checks and the commit itself. >From 0f71249d70bc5f1505bd4b0145c8e361494e435d Mon Sep 17 00:00:00 2001

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/111990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/111990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Fix for build break is now committed. https://github.com/llvm/llvm-project/commit/c8da2253f9aa4dff039e9ed766ff0f865632a0eb https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: You’re right. Though I am hoping to add a new function with that name and a different behavior. But I can see how this might be problematic for out of tree backends as well as that code will compile fine but might fail at runtime with the new function. I can call the function “find

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: That’s a possibility. I was trying to keep the naming consistent with similar functions in the Module class. But if folks feel its too much churn and are ok with the inconsistent naming convention, I am fine with reverting it and going with the naming scheme proposed above. On Fr

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Makes sense, thanks. On Fri, Oct 11, 2024 at 9:49 AM Nikita Popov ***@***.***> wrote: > test_demangle should definitely *not* be updated when renaming functions. > > — > Reply to this email directly, view it on GitHub >

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: Yes I purposely did not change it as it just seems to test mangling and using this function as an example. I can change it if it makes sense. On Fri, Oct 11, 2024 at 9:10 AM Daniel Chen ***@***.***> wrote: > @jurahul > It seems this PR is missing a te

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: @JDevlieghere @cyndyishida @topperc gentle ping. It's mostly mechanical. https://github.com/llvm/llvm-project/pull/110692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

jurahul wrote: more of a hypothetical concern at this point. It's also making file names under Option consistent, in the sense that we have `Option.h` and `Option.cpp` but `OptTable.h` `OptSpecifier.h` and `OptTable.cpp` https://github.com/llvm/llvm-project/pull/110692 ___

[clang] [Clang][TableGen] Use const pointers for various Init objects in MveEmitter (PR #112320)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/112320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [LLVM][TableGen] Change all `Init` pointers to const (PR #112705)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/112705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [LLVM][TableGen] Change all `Init` pointers to const (PR #112705)

@@ -551,18 +552,18 @@ std::string BitsInit::getAsString() const { // resolveReferences - If there are any field references that refer to fields // that have been filled in, we can propagate the values now. -Init *BitsInit::resolveReferences(Resolver &R) const { +const Init *Bi

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

https://github.com/jurahul converted_to_draft https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

jurahul wrote: > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are > you trying to achieve and why? Is there an RFC for this given it seems to be > having significant consequences across the tree? Yes, please see here: https://discourse.llvm.org/t/rfc-compress-intrins

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

jurahul wrote: > > > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly > > > are you trying to achieve and why? Is there an RFC for this given it > > > seems to be having significant consequences across the tree? > > > > > > Yes, please see here: > > https://discourse.l

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/110845 >From 71482b22871022ad783386680362f9e2430d9a38 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 2 Oct 2024 07:01:40 -0700 Subject: [PATCH] [NFC][TableGen] Change `Record::getSuperClasses` to use const Reco

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/110845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

jurahul wrote: > We have downstream code that used `getDeclaration` and now we have changed to > `getOrInsertDeclaration` for all places. My understanding from reading the > thread is that `getOrInsertDelcaration` will stay and a new `findDeclaration` > will be added temporarily, and it will e

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/113645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

jurahul wrote: @AaronBallman can you PTAL? https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

jurahul wrote: Thanks. I haven't seen any responses from @mydeveloperday earlier, hopefully @owenca can chime in. https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

jurahul wrote: Started https://github.com/llvm/llvm-project/pull/114331 https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

jurahul wrote: Let me delete those references. The ones in generated_formatted_state.py are fine https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

jurahul wrote: > LGTM - thanks Thanks. Will merge once checks are green https://github.com/llvm/llvm-project/pull/114331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/114331 >From 466b99a4d2f53daeecb4d0cfeb3ed5a05c2af03e Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Oct 2024 16:51:36 -0700 Subject: [PATCH 1/2] [NFC] Remove referenced to deleted `ClangFormattedStatus` fil

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/113645 >From 9192413d91525ef47cb7ee1837afcd0e89849481 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 24 Oct 2024 15:25:22 -0700 Subject: [PATCH] [Clang][TableGen] Use StringRef::str() instead of std::string() c

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; jurahul wrote: In short, I'll defer it to you. If we don't want to commit this, I am fine and the find the reasoning behind if rea

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; jurahul wrote: > TG is not perf critical I have seen bugs about Tg perf, but may be not this particular backend, https://github.

[clang] [NFC][Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

jurahul wrote: Thanks. I'll queue this behind https://github.com/llvm/llvm-project/pull/113809. https://github.com/llvm/llvm-project/pull/113645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; jurahul wrote: In all these instances, the strings are derived from TableGen Records, so they do outlive. I do agree that TG is no

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/113809 >From 5fd76fe7a8fe6a009966cf0d7d67a53b68b601a1 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Sun, 27 Oct 2024 06:51:55 -0700 Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling Change Flatt

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/113809 >From 60da18c88e63612c791ccbb423d752bac311650b Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Sun, 27 Oct 2024 06:51:55 -0700 Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling Change Flatt

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/113809 >From 6b128746e5f6bfa13e0ea9a900f0bc8529437717 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Sun, 27 Oct 2024 06:51:55 -0700 Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling Change Flatt

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/113809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

@@ -54,19 +54,18 @@ class FlattenedSpelling { const Record &OriginalSpelling; public: - FlattenedSpelling(const std::string &Variety, const std::string &Name, + FlattenedSpelling(const std::string &Variety, StringRef Name, const std::string &Namespace,

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/113809 Change FlattenedSpelling to use StringRef instead of std::String. >From 4a2e738c6b49ee7433cd9fa039b4028e862d92fe Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Sun, 27 Oct 2024 06:51:55 -0700 Subject: [PATCH]

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-files.txt file (PR #109220)

https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Refactor ClangDiagnosticEmitter to use more StringRef (PR #115212)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/113645 Use `StringRef::str()` instead of std::string(StringRef) to cast from StringRef to std::string. >From c160176853c01ab33e53a508414d1532184dc6a8 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 24 Oct 2024

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

@@ -1570,8 +1541,7 @@ static void emitDiagSubGroups(std::map &DiagsInGroup, for (auto const &Group : GroupsInPedantic) { const std::string &GroupName = std::string(Group->getValueAsString("GroupName")); - std::map::const_iterator RI = -

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/115959 Use StringRef instead of std::string in ClangDiagnosticEmitter. >From 5f67dd57f3e6333da438dc07a2efdfcb0c1874b1 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115959 >From 5ba5485bbc8895743130f58779cf5c78eb0941aa Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEm

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use StringRef and range for loops in SA/Syntax Emitters (PR #115972)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/115972 Use StringRef and range for loops in Clang SACheckers and Syntax emitters. >From 7e297e5641cead196772b33fc6633efe9837f09d Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 17:06:08 -0800 Subject

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115959 >From cdcd09ec7c11a21da0804a6e886aff6410c42daf Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEm

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

jurahul wrote: Its not clear to me if the failure is real or intermittent: FAILURE Failed to match LIBC_NAMESPACE::mkdirat(AT_FDCWD, TEST_DIR, S_IRWXU) against Succeeds(0). Expected return value to be equal to 0 but got -1. Expected errno to be equal to "Success" but got "File exists". https:

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/115573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/115962 Simplify `EmitClangDiagsIndexName` to directly sort records instead of creating an array of `RecordIndexElement` containing record name and sorting it. >From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115959 >From 04b7434139ffdb412797e9d4fe7d31ecbdbe7748 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEm

[clang] [NFC][Clang] Refactor ClangDiagnosticEmitter to use more StringRef (PR #115212)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/115212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115962 >From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:51:54 -0800 Subject: [PATCH 1/2] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` Simp

[clang] [NFC][Clang] Use StringRef and range for loops in SA/Syntax Emitters (PR #115972)

https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

@@ -1419,16 +1412,14 @@ void clang::EmitClangDiagsDefs(const RecordKeeper &Records, raw_ostream &OS, InferPedantic inferPedantic(DGParentMap, Diags, DiagGroups, DiagsInGroup); inferPedantic.compute(&DiagsInPedantic, (RecordVec*)nullptr); - for (unsigned i = 0, e = Diags.

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115959 >From d63b8a017e73586cc8c4c9d5afe4b0d59f81ea17 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEm

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

@@ -1419,16 +1412,14 @@ void clang::EmitClangDiagsDefs(const RecordKeeper &Records, raw_ostream &OS, InferPedantic inferPedantic(DGParentMap, Diags, DiagGroups, DiagsInGroup); inferPedantic.compute(&DiagsInPedantic, (RecordVec*)nullptr); - for (unsigned i = 0, e = Diags.

[clang] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEmitter (PR #115959)

https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115959 >From aa016d306c717ddffc0a7227678d8928be9583b4 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:38:02 -0800 Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in ClangDiagnosticEm

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/115962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >