https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
> > compile-time tests with clang for example
>
> I can check. How do I run them?
I am wondering if running mlir-tblgen is a better benchmark, given that
formatv() is widely used there (as opposed to clang), in case this measurement
has to be done manually.
https://github.com/
jurahul wrote:
I did 2 sets of experiments, but data wise I am inconclusive if this causes a
real compile time regression.
1. Build MLIR verbose and capture all mlir-gen command lines to a file:
ninja -C build check-mlir --verbose | tee build_log.txt
grep "NATIVE/bin/mlir-tblgen " build_l
jurahul wrote:
Yeah. For the unbalanced {{ I actually committed a change to fail in
release builds as well by printing an error message as formatv() output.
The only issue with debug only is that many folks build tablegen in release
mode, so those bad uses may not get flagged. But as long as the
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From d805dcdc44d22bb21d086b186cc7f644323f68ef Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
jurahul wrote:
I have uploaded a new version where the validation is enabled only in debug
builds, and also added a benchmark for formatv(). On my machine, the benchmark
results are as follows:
```
Old:
BM_FormatVariadic_mean 3427456 ns 3427426 ns 10
New
BM_FormatVariadic_
jurahul wrote:
Looks like the CI builds are release but with LLVM_ENABLE_ASSERTION=ON, so this
validation code will be enabled and potential bad usage will be flagged as well
going forward as long as it's exercised during the build or test.
https://github.com/llvm/llvm-project/pull/105745
@@ -655,7 +655,7 @@ DWARFUnit::GetDIE(dw_offset_t die_offset) {
if (!ContainsDIEOffset(die_offset)) {
GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
-"GetDIE for DIE {0:x16} is outside of its CU {0:x16}", die_offset,
+"GetDIE for DIE {0:x
jurahul wrote:
> LGTM
Thanks. I'll split out an additional PR for the independent fixes, and then in
this one I'll change ENABLE_VALIDATION back to 0 and also remove the
`formatvv()` and use `formatv(false` instead so we just have one function name.
https://github.com/llvm/llvm-project/pull/1
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/106454
Fix several uses of formatv() that would be flagged as invalid by an upcoming
change that will add additional validation to formatv().
>From b97456af86580c7f2d4473fbc13d3e345f071486 Mon Sep 17 00:00:00 2001
Fro
jurahul wrote:
Started https://github.com/llvm/llvm-project/pull/106454 for the independent
fixes.
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106454
>From 581c47377f77a9d2819a5997b1c0a3c23b2c3346 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 28 Aug 2024 13:55:58 -0700
Subject: [PATCH] [NFC] Fix formatv() usage in preparation of validation
Fix severa
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/106454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From 55abaa86e523483f5b58af6749a525b77896d37f Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From 432c425216732648105b35401b98bf17e2f4bd79 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
@@ -655,7 +655,7 @@ DWARFUnit::GetDIE(dw_offset_t die_offset) {
if (!ContainsDIEOffset(die_offset)) {
GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
-"GetDIE for DIE {0:x16} is outside of its CU {0:x16}", die_offset,
+"GetDIE for DIE {0:x
@@ -143,15 +140,76 @@ formatv_object_base::splitLiteralAndReplacement(StringRef
Fmt) {
return std::make_pair(ReplacementItem{Fmt}, StringRef());
}
+#ifndef NDEBUG
+#define ENABLE_VALIDATION 1
+#else
+#define ENABLE_VALIDATION 1 // Convienently enable validation in release m
jurahul wrote:
The final version is good to go @joker-eph if you want to take another look.
Nothing significant changed, just formatvv() is now gone and replaced with
formatv(false,...).
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commit
@@ -1654,12 +1654,12 @@ void OperationFormat::genElementParser(FormatElement
*element, MethodBody &body,
dir->shouldBeQualified() ? qualifiedTypeParserCode : typeParserCode;
TypeSwitch(dir->getArg())
.Case([&](auto operand) {
-body << form
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/106658
Split RecordKeeper `getAllDerivedDefinitions` family of functions into two
variants: (a) non-const ones that return vectors of `Record *` and (b) const
ones, that return vectors of `const Record *`.
This will
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106658
>From 5ee1d2e03be855f5cbdd3d1555860f7d4205ebe2 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 29 Aug 2024 20:36:05 -0700
Subject: [PATCH] [TableGen] Add const variants of accessors for backend
Split Reco
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106658
>From ac3265781bb9c2d7422ec761e1b5f703dcdd407b Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 29 Aug 2024 20:36:05 -0700
Subject: [PATCH] [TableGen] Add const variants of accessors for backend
Split Reco
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Note, this is related to the following discourse thread that I had started:
https://discourse.llvm.org/t/changing-tablegen-getallderiveddefinitions-to-return-arrayref-const-record/80586/5
https://github.com/llvm/llvm-project/pull/106658
__
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -189,7 +189,7 @@ static StringRef NormalizeGNUAttrSpelling(StringRef
AttrSpelling) {
typedef std::vector> ParsedAttrMap;
-static ParsedAttrMap getParsedAttrList(const RecordKeeper &Records,
jurahul wrote:
Please see the discourse thread:
https://discour
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/105544
- Refactor SetTheory code to use const pointers when possible.
- Use auto for variables initialized using dyn_cast<>.
- Use range based for loops and early continue.
>From b9b2cea49dab03ad2f01b70ffa784be8a5e23b6
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105544
>From 6ead1e81f891a826b55aa74ef13b132eb854bb47 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 21 Aug 2024 05:59:33 -0700
Subject: [PATCH] [NFC][SetTheory] Refactor to use const pointers and range
loops
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/105544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/105544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -74,16 +75,31 @@ class formatv_object_base {
static std::pair
splitLiteralAndReplacement(StringRef Fmt);
- formatv_object_base(StringRef Fmt,
+ formatv_object_base(StringRef Fmt, bool ValidateNumArgs,
ArrayRef Adapters)
- : Fmt(Fmt), Adapte
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/105824
- After the table is populated and emitted as a string, we do not expect any
modifications to the table. So use const reference and const members to access
the table from that point on.
>From 154c0728820a8a6e1
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/105824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/105824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108275
None
>From 340f6e2f06a210ae733e6cbbc8babf218d12ded6 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:58:45 -0700
Subject: [PATCH] [NFC] Reformat ClangASTPropertiesEmitter `ASTPropsEmitter`
jurahul wrote:
This is in preparation of https://github.com/llvm/llvm-project/pull/108274
which touches this class and end up reformatting a bunch of untouched code in
the process.
https://github.com/llvm/llvm-project/pull/108275
___
cfe-commits mail
jurahul wrote:
I just left indented the code in that class and then ran `git clang-format
HEAD^^`.
https://github.com/llvm/llvm-project/pull/108275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/108275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108274
>From 6454a52add345be58efcac015d61ec7983badf08 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:51:51 -0700
Subject: [PATCH] [clang][TableGen] Change ASTProperties Emitter to use const
Recor
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108269
>From 0360eda45d51e2892f804b2bbe5789a6b90f55a1 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:32:36 -0700
Subject: [PATCH] [clang][TableGen] Change AttrEmitter to use const
RecordKeeper
-
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108274
>From c2c1486a0427ff33e3caf584bac3f0baed3c1476 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:51:51 -0700
Subject: [PATCH] [clang][TableGen] Change ASTProperties Emitter to use const
Recor
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108476
Change TypeNodesEmitter to use const RecordKeeper.
>From 8ac46e76011d91b23bfe2b7fe6aa4f14391ff8e6 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 18:42:31 -0700
Subject: [PATCH] [clang][TableG
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108477
Change SACheckersEmitter to use const RecordKeeper.
>From fd8c24e54a55144d0b8c64a203648e427e0504f9 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 18:46:56 -0700
Subject: [PATCH] [clang][Tabl
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108478
Change SyntaxEmitter to use const RecordKeeper.
>From d6c867550f90d27db4324e555b303715ee118319 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 18:51:44 -0700
Subject: [PATCH] [clang][TableGe
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108500
[clang][TableGen] Change MVE Emitter to use const RecordKeeper
>From 9cfc9872bc14c2a887128f83f3f9b38e70ea3258 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:50:11 -0700
Subject: [PATCH] [c
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108501
[clang][TableGen] Change NeonEmitter to use const RecordKeeper.
>From 0ef4d6b31bfe72904706362635d328ba8629ed8b Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:46:23 -0700
Subject: [PATCH] [
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108502
[clang][TableGen] Change RISCVVEmitter to use const RecordKeeper.
>From e2974b932d37a2e992cefbeb658268eddd92af0a Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:58:44 -0700
Subject: [PATCH]
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108503
[clang][TableGen] Change SVE Emitter to use const RecordKeeper.
>From 11449fe4a67f1c60d47b9ed8bcae5520fdc8b565 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:55:10 -0700
Subject: [PATCH] [
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108500
>From d27e44464aed725ae22d918644d6c3eaa5559876 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:50:11 -0700
Subject: [PATCH] [clang][TableGen] Change MVE Emitter to use const
RecordKeeper
-
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108500
>From e07fa2170e4a9699e89f54442a730d1c14702fa5 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:50:11 -0700
Subject: [PATCH] [clang][TableGen] Change MVE Emitter to use const
RecordKeeper
-
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Just a minor clang-format diff between what I have locally vs what the CI uses.
Otherwise, checks were green earlier.
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108580
Change macroName() to accept a StringRef to avoid extra string copy.
Simplify ASTNode comparison function.
Use equal_range() instead of calling lower_bound() and upper_bound() separately
for std::multimap.
No n
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108580
>From 4976e21df6cbbc7b97277a00b85c97a70ecef96c Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 13 Sep 2024 07:55:02 -0700
Subject: [PATCH] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter
Change macro
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108627
Remove llvm:: from .cpp files, and add "using namespace llvm" if needed.
>From 73a8e42a15441b38a1d88e2fd4de0dd420a33398 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 13 Sep 2024 11:55:45 -0700
Subject:
jurahul wrote:
Looks like these tests are failing in CI: see
https://buildkite.com/llvm-project/github-pull-requests/builds/100644#0191ec9f-441f-4299-ad47-a9318fbae7a8
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-c
jurahul wrote:
Also note that this was also detected by CI prior to merging the PR.
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108630
Reverts llvm/llvm-project#97369
>From 4e53d121f3f83f7ffe23a9dc835a0ffd68a5a1c9 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 13 Sep 2024 12:13:02 -0700
Subject: [PATCH] Revert "[Utils] add update-veri
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Reverted in https://github.com/llvm/llvm-project/pull/108630
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108580
>From 8d249f31cb3f07ad630092945e870b3527aca0bf Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 13 Sep 2024 07:55:02 -0700
Subject: [PATCH] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter
Change macro
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108627
>From 18064b1c154672e2f7e6387fdb70efde85b9bb81 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 13 Sep 2024 11:55:45 -0700
Subject: [PATCH] [NFC][clang][TableGen] Remove redundant llvm:: namespace
qualifie
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 469 matches
Mail list logo
