[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-14 Thread Puneetha K via Phabricator via cfe-commits
puneetha updated this revision to Diff 102516. puneetha added a comment. Incorrectly rejecting __is_destructible queries on arrays of unknown bound of incomplete types. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp =

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-14 Thread Puneetha K via Phabricator via cfe-commits
puneetha updated this revision to Diff 102635. puneetha added a comment. Added testcase. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits.cpp Index: test/SemaCXX/type-traits.cpp === ---

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-21 Thread Puneetha K via Phabricator via cfe-commits
puneetha updated this revision to Diff 103337. puneetha added a comment. Updated files to address the review comments. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits.cpp Index: test/SemaCXX/type-traits.cpp =

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-21 Thread Puneetha K via Phabricator via cfe-commits
puneetha marked 2 inline comments as done. puneetha added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4128 +return true; +} + rjmccall wrote: > I don't understand the difference you're creating between traits here. Three > specific traits

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-21 Thread Puneetha K via Phabricator via cfe-commits
puneetha updated this revision to Diff 103530. puneetha added a comment. Added test cases for all the affecting traits. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits.cpp Index: test/SemaCXX/type-traits.cpp =

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

2017-06-28 Thread Puneetha K via Phabricator via cfe-commits
puneetha added a comment. This is committed by karthik, at r306519. Thank you. https://reviews.llvm.org/D34198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits