[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From ee164634ffd2db4a7e590faeba7a3a631e8e75db Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

pileghoff wrote: > It looks like a bunch of formatting changes came in with SemaChecking.cpp. > You should only be formatting the code that your patch needs to touch. We've > got a script for that: > https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting or > https://clang

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff created https://github.com/llvm/llvm-project/pull/79588 Fixes #79435 Im not sure if this is the best solution, but it seems to work well. Should i be adding tests for this? If i should, i would need some help on how. I was able to run the test suite, but i have no

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

pileghoff wrote: @AaronBallman If you have time for review, the PR is ready 👍🏽 https://github.com/llvm/llvm-project/pull/79588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff edited https://github.com/llvm/llvm-project/pull/79588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

pileghoff wrote: > Thank you for the Fix! Your summary should be a description of the problem > and how your solution fixes that problem. You should also link to the github > issue in the summary. > > Questions about the changes in the PR should go as a comment to the PR. > > Please add a rel

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

pileghoff wrote: I can also see i broke the `n3042.c` test. Stuff like `if (null_val) {}` now throws a warning, since `null_val` is a constant. I would expect this warning to be okay in that scenario? https://github.com/llvm/llvm-project/pull/79588 _

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 43241ab75d4c15e6885337be1b0ce4cf0217f384 Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/li

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

pileghoff wrote: For testing i have fixed the new warnings in `n3042.c` and i have expanded `warn-int-in-bool-context.c` to check c23 specefically (which was broken, but is now fixed) and i added a few extra cases to the test. I will take a look at the release notes later today. https://githu

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 2c942f755c147a8413af4784f85da46f1f5384bd Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/li

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 34bb01d59005059c7f8f1156a164993c1839ee36 Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 29a1eea6b27210ba35ad035b3c10aa8f5c73d86c Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 6ea74d7aa0eadd4093350c04de95cbb2bdbaf0eb Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From b059e03eb5330054e76c833699611fdc9bfb1967 Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From f22d0a6888be86c5105a00e3f83201f71165f78f Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 38d96aba5818091d48c40a46738f5adbf881b2a8 Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion --- clang/do