[PATCH] D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356848: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D59682?vs=192010&id=192017#toc Repositor

[PATCH] D59757: [clangd] Send empty diagnostics when a file is closed

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356880: [clangd] Send empty diagnostics when a file is closed (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59757?vs=192062&id=192064#toc Repository: rC

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC356888: [OpenCL] Allow addr space spelling without __ prefix in C++. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D59603?vs=1916

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

serge-sans-paille added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:51 + +yaml_imported = True +try: Could be ``` try: import yaml except ImportError: yaml = None ``` and later ``` if yaml: ... ``` CHANGES SINCE LAST ACTION h

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

serge-sans-paille added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:210 +help='Create a yaml file to store suggested fixes in, ' +'which can be applied with clang-apply-replacements.') parser.add_argument('-j',

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. @mikhail.ramalho Can you plz add some wrappers of overflow predicates like Z3_mk_bvadd_no_overflow, Z3_mk_bvadd_no_underflow, ... to SMTAPI.h and Z3Solver.cpp? It could help me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://review

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. > ! In D54978#1441417 , > @mikhail.ramalho wrote: > Sure, I'll create a new revision with the added functions tonight. I am very happy with your quickly reply. btw, `Z3_get_bv_sort_size` is also needed :) CHANGES SINCE LAST AC

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. > ! In D54978#1441547 , > @mikhail.ramalho wrote: > You can get the sort size by calling getBitvectorSortSize(). found, thx CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 _

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille added a comment. @rsmith up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59413/new/ https://reviews.llvm.org/D59413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356916: [clangd] Add .cu files to VSCode extension (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59759?vs=192109&id=192124#toc Repository: rCTE Clang To

[PATCH] D58827: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

This revision was automatically updated to reflect the committed changes. Closed by commit rL356925: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Cha

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

This revision was automatically updated to reflect the committed changes. Closed by commit rL356931: clang -dumpversion returns 4.2.1 for legacy reason, update it (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

This revision was automatically updated to reflect the committed changes. Closed by commit rC356953: [WebAssembly] Don't use default GetLinkerPath (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D59743?vs=192126&id=192201#toc Repository: rC Clang CHANGES

[PATCH] D59776: [Sema] Don't check for array bounds when the types in the base expression are dependent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356957: [Sema] Don't check for array bounds when the types in the base expression are… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356969: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in ExprEngine. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59622?vs=191606&id=19222

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. @lebedev.ri where are tests for AST serialization are located ? i didn't find them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL357042: gn build: Add build files for clang-include-fixer and find-all-symbols (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59838?vs=192334&id=192387#toc Reposi

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

MyDeveloperDay added a comment. We normally add something to the documentation about the checker and/or the release notes to say what had changed Comment at: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp:48 case CK_IntegralToBoolean: -return

[PATCH] D59874: [PR41247] Fixed parsing of private keyword in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL357162: [PR41247] Fixed parsing of private keyword in C++. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D59899: gn build: Add some build files for clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL357182: gn build: Add some build files for clangd (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59899?vs=192509&id=192663#toc Repository: rL LLVM CHANGES SINC

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. My own out-of-tree pass `#include ` and use cmake's `add_llvm_library` to compile it into a `.so` However, `opt -load-pass-plugin=my-pass.so -passes="foo" bar.ll` fails: `opt: symbol lookup error: Passes/libStackPasses.so: undefined symbol: _ZN4llvm14CreateZ3SolverEv` (

[PATCH] D59953: Add .py extension to clang-tools-extra lit cfg files

This revision was automatically updated to reflect the committed changes. Closed by commit rL357231: Add .py extension to clang-tools-extra lit cfg files (authored by nico, committed by ). Herald added subscribers: llvm-commits, mstorsjo. Herald added a project: LLVM. Changed prior to commit: h

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357232: gn build: Add check-clang-tools to run clang-tools-extra lit tests (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D59955?vs

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 192811. Tyker retitled this revision from "[clang] Adding the Likely Attribute from C++2a to AST" to "[clang] Adding the Likelihood Attribute from C++2a". Tyker added a comment. @aaron.ballman fixed based on feedback. added semantic support for switch statment.

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357323: [analyzer] Introduce a simplified API for adding custom path notes. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D58367?vs=192502&id=192932#toc Repo

[PATCH] D59857: [analyzer] PR37501: Disable the assertion for reverse-engineering logical op short circuits.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357325: [analyzer] PR37501: Disable assertion for logical op short circuit evaluation. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59857?vs=192390&id=19293

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

This revision was automatically updated to reflect the committed changes. Closed by commit rC357326: [analyzer] Move taint API from ProgramState to a separate header. NFC. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59861?vs=192919&id=192934#toc R

[PATCH] D59901: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357329: [analyzer] PR41239: Fix a crash on invalid source location in… (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59914: [analyzer] MIGChecker: Add support for more deallocator APIs.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357335: [analyzer] MIGChecker: Add support for more deallocator APIs. (authored by dergachev, committed by ). Herald added

[PATCH] D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import

This revision was automatically updated to reflect the committed changes. Closed by commit rC357345: [clang-format] [PR41187] moves Java import statements to the wrong location if… (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llv

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 192979. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticS

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { riccibruno wrote: > I don't understand why this is needed. Can you explain it ? Al

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193015. Tyker added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. @riccibruno i fixed based on feedback everything except the CFG edit as i still need to analyse the situation. added AST and CodeGen for For, While, Do and CXXFor

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/test/SemaCXX/cxx2a-likelihood-attr.cpp:70 + +// clang-format off just saw the //clang format off at the bottom ill remove it CHANGES SINC

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:528 +if (ElseLikelihoodAttr && ThenLikelihoodAttr->isEqual(ElseLikelihoodAttr)) { + Diag(ElseLikelihoodAttr->getLocation(), + diag::warn_conflicting_li

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Basic/Attr.td

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL357369: gn build: Add build files for most clang-tools-extra unit tests (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60038?vs=192995&id=193019#toc Repository:

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357371: Spelling correction for docs for cppcoreguidelines-owning-memory (authored by sylvestre, committed by ). Herald ad

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As was already stated in a previous comment, the parameter isn't necessarily referring to one of the DeclContext's parameter. We should check the index is within the range to avoid out-of-boundary

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193041. Violet added a comment. Wrong bug number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/SemaCXX

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193045. Violet added a comment. a more straightforward testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp cla

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

MyDeveloperDay added a comment. In D59932#1446533 , @JonasToth wrote: > I think the idea is good and implementation, too. If we iterate all checks > anyway (probably?) we could think about adding a severity to the checks, too? In a similar vein, I often

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { NoQ wrote: > Tyker wrote: > > riccibruno wrote: > > > I don't understand why this

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

This revision was automatically updated to reflect the committed changes. Closed by commit rL357454: [clangd] Use capacity() instead of size() in RefSlab::bytes() (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille added a comment. @rsmith : up :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59413/new/ https://reviews.llvm.org/D59413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

tschuett added a comment. Are you planning to do this recursively? The minimizer does not help much for the following example, while Sema.h contains 10,000 lines of useless code. #include "clang/Sema/Sema.h" int foo() {} Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { NoQ wrote: > Tyker wrote: > > NoQ wrote: > > > Tyker wrote: > > > > riccibruno wro

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193269. Tyker added a comment. fixed the CFG issue is an proper way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/c

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Basic/Attr.td

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL357476: gn build: Add build files for non-framework xpc clangd bits (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60124?vs=193264&id=193290#toc Repository: rL

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

This revision was automatically updated to reflect the committed changes. Closed by commit rC357501: [os_log] Mark os_log_helper `nounwind` (authored by vedantk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60108?vs=193217&id=193322#toc Repo

[PATCH] D60099: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC357515: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60099?vs=193179&id=193347#toc Repo

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rC357516: [Sema] Fix a use-after-deallocate of a ParsedAttr (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60101?vs=193185&id=193348#toc Repository: rC Clang CH

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

This revision was automatically updated to reflect the committed changes. Closed by commit rL357526: [HIP-Clang] Fat binary should not be produced for non GPU code 2 (authored by aaronenyeshi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60110: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357557: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D60183: Fix typos in tests. NFC.

Higuoxing created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kubamracek. Herald added projects: clang, Sanitizers, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60183 Files: clang/test/Analysis/analyzer-list-configs.c compiler-rt/t

[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL357561: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

This revision was automatically updated to reflect the committed changes. Closed by commit rC357566: Adding 'CLion integration' to clang-format doc (authored by sylvestre, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llv

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357574: gn build: Add build files for clangd xpc framework code (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60130?vs=193313&id=

[PATCH] D60183: Fix typos in tests. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357577: Fix typos in tests. NFC. (authored by Higuoxing, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D60183?vs=193439&id=193482#toc Repositor

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, djasper, JonasToth, russellmcc, reuk. MyDeveloperDay added a project: clang-tools-extra. Code::Blocks and Qt Creator code uses a style guide which recommends indenting the next line after the access modifier e.g. cla

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3177-3178 return false; // Don't split tagged template literal so there is a break between the tag // identifier and template st

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357654: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60201?vs=1934

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rC357682: [PR41276] Fixed incorrect generation of addr space cast for 'this' in C++. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

This revision was automatically updated to reflect the committed changes. Closed by commit rC357684: [PR41157][OpenCL] Prevent implicit init of local addr space var in C++ mode. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.or

[PATCH] D60203: Updating Chromium's Java import order

This revision was automatically updated to reflect the committed changes. Closed by commit rC357700: Updating Chromium's Java import order (authored by nico, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357719: check-clang-tools: Actually build and run XPC test (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60120?vs=193256&id=19377

[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357724: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60247?

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.org/D59309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59540/new/ https://reviews.llvm.org/D59540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. just a few nits, apart form that it LG Comment at: clang/include/clang/Format/Format.h:1721 + /// Defines whether a space should be placed after a logical `!` + bool SpaceAfterLogicalNot; nit: end the sentence with a "." ==

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. I actually also tend to change doc/ClangFormatStyleOptions.rst too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357810: [analyzer] NoStoreFuncVisitor: Suppress reports with no-store in system headers. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357823: [Lexer] NFC: Fix an off-by-one bug in getAsCharRange(). (authored by dergachev, committed by ). Herald added a pro

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL357837: [clang-format] BreakAfterReturnType ignored on functions with numeric template… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. In D54978#1457318 , @mikhail.ramalho wrote: > In D54978#1447107 , @gou4shi1 wrote: > > > My own out-of-tree pass `#include ` and use cmake's > > `add_llvm_library` to compile it into a `.

[PATCH] D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for doing this, it LGTM, I like your solution better ;-) I will abandon D60361: [clang-format] [PR41407] Constructor initializer list indented incorrectly

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

MyDeveloperDay added a comment. Herald added a project: clang. @owenpan can I help you bring this back up to date and review, I think I saw another issue in the bugzilla requesting this. I know the code owners like new option to have a style guide used by a large code base, but to me this seem

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. In D60320#1457568 , @reuk wrote: > I updated `ClangFormatStyleOptions.rst` by hand, is there a way to do that > automatically instead (for future patches)? I do it by hand, I know there is a python script out there, go wi

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (minor nit) Comment at: clang/lib/Format/TokenAnnotator.cpp:2834 } - if (Left.is(TT_UnaryOperator)) -return Right.is(TT_BinaryOperator); + if (L

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:968 if (Current.is(tok::r_paren) && State.Stack.size() > 1 && - (!Current.Next || Current.Next->isOneOf(tok::semi, tok::l_brace))) + (!Current.Next || Current.Next->isOneOf(to

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. maybe add the following as a test because I think it shows the inconsistency void Foo::bar( // some comment ) {} void Foo::bar( // some comment ) const {} Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https:/

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough Repository: rC Clang CHANGES SIN

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. In D60374#1457705 , @owenpan wrote: > In D60374#1457693 , @MyDeveloperDay > wrote: > > > LGTM , if you also think the test will help show the use case then please > > add it, otherw

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. In D59087#1456129 , @krasimir wrote: > I believe there is no such thing as an "short else statement". The `else` is > part of the `if` statement and if it is present, I don't

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

MyDeveloperDay added a subscriber: reuk. MyDeveloperDay added a comment. @ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style. Comment at: include/clang/

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein added a comment. Hello @alexfh , Let me extend your example $ cat a.cc #include "b.h" #include "d.h" int main(){check(nullptr);} $ cat b.h #include "c.h" inline void b() { c(/*y=*/42); } $ cat c.h void c(int x); $ cat d.h inline char* check(char* buffer)

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. PING ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 194152. Violet added a comment. Address reviewer comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet marked 2 inline comments as done. Violet added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i < FD->getNumParams()

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay added a comment. In D60363#1459297 , @lebedev.ri wrote: > Please either subscribe the correct lists or set the correct repo in > differential params. Thanks for the correction, I was never really clear which one to use for the project as

[PATCH] D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

Abpostelnicu created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D60453 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py ==

[PATCH] D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number… (authored by Abpostelnicu, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rep

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. In D60055#1459602 , @lebedev.ri wrote: > I won't be able to properly review this, sorry. Can you suggest someone with familiarity for this part of code? The reviewers I randomly added by `git blame` doesn't seem to be reviewing.

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm marked 25 inline comments as done. bd1976llvm added a comment. I have updated the diff to address review comments. I think we can continue to refine this patch in parallel with discussing the design further (I am not dismissing the concerns raised by @compnerd and @jyknight). I am un

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm marked 5 inline comments as done. bd1976llvm added inline comments. Comment at: lld/ELF/InputFiles.cpp:402 + if (Config->DepLibs) +if (fs::exists(Specifier)) + Driver->addFile(Specifier, /*WithLOption=*/false); jyknight wrote: > bd1976llvm wr

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. Thanks. Can you land it for me? I'm a newcommer without landing privilege. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commi

[PATCH] D60523: [clang] Bugfixe for 41400

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this is a bugfixe for bugtracker added nullptr check at the relevent place and test Repository: rC Clang https://r

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this is a bugfix for this added a constant copy of argument to CallStackFrame. and use it in describeCall instead of th

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 194684. Tyker added a comment. @Quuxplusone edited based of feedback i simplified the test but didn't put the original because this one test arguments for variable and literal and there may be corner case differences CHANGES SINCE LAST ACTION https://revi

<    13   14   15   16   17   18   19   20   21   22   >