[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rC327317: Check that ubsan is the only supported sanitizer on OpenBSD (authored by vedantk, committed by ). Repository: rC Clang https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index:

[PATCH] D44120: [CFG] [analyzer] Heavier CFGCXXRecordTypedCall elements.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327343: [CFG] [analyzer] Add construction context to C++ return-by-value call elements. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D44120?vs=137116&id=1381

[PATCH] D44124: [analyzer] Support destruction and lifetime-extension of inlined function return values.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327345: [analyzer] Destroy and lifetime-extend inlined function return values properly. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44124 Files: lib/Static

[PATCH] D44129: [analyzer] NFC: Refactor the code for obtaining temporary lifetime info into a method.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327347: [analyzer] NFC: Move the code for setting temp object lifetime into method. (authored by dergachev, committed by )

[PATCH] D44131: [analyzer] Support temporaries conjured by conservatively evaluated functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327348: [analyzer] Support temporaries conjured by conservatively evaluated functions. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44131 Files: lib/StaticA

[PATCH] D44273: [CFG] [analyzer] Fix a crash on finding construction context for an lvalue/xvalue call expression.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327352: [CFG] [analyzer] Don't add construction context to a return-by-reference call. (authored by dergachev, committed b

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rC327438: [OpenMP] Add flag for linking runtime bitcode library (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D43197?vs=138242&id=138245#toc Repository: rC Cla

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rL327460: [OpenMP] Add flag for linking runtime bitcode library (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43197?vs=1

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

This revision was automatically updated to reflect the committed changes. Closed by commit rC327504: [Sema] Pop function scope when instantiating a func with skipped body (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44439?vs=138333&id=138338#toc Re

[PATCH] D44188: Misc typos

luzpaz added a comment. Please advise how to proceed Repository: rC Clang https://reviews.llvm.org/D44188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL327513: [OpenMP] Add OpenMP data sharing infrastructure using global memory (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

This revision was automatically updated to reflect the committed changes. Closed by commit rC327513: [OpenMP] Add OpenMP data sharing infrastructure using global memory (authored by gbercea, committed by ). Repository: rC Clang https://reviews.llvm.org/D43660 Files: lib/CodeGen/CGDecl.cpp

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327532: [clangd] Remove forceReparse, add a flag to addDocument instead (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327537: [clangd] Don't expose vfs in TUScheduler::runWithPreamble. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44463?vs=138409&id=138411#toc Repository:

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

This revision was automatically updated to reflect the committed changes. Closed by commit rL327558: [Parser] (C++) Make -Wextra-semi slightly more useful (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43162?vs

[PATCH] D44567: [clangd] Handle multiple callbacks from Sema's completion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327717: [clangd] Handle multiple callbacks from Sema's completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44567?vs=138706&id=138713#toc Repository:

[PATCH] D44567: [clangd] Handle multiple callbacks from Sema's completion

This revision was automatically updated to reflect the committed changes. Closed by commit rL327717: [clangd] Handle multiple callbacks from Sema's completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44567 F

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

This revision was automatically updated to reflect the committed changes. Closed by commit rL327768: Adding nocf_check attribute for cf-protection fine tuning (authored by orenb, committed by ). Changed prior to commit: https://reviews.llvm.org/D41880?vs=136235&id=138816#toc Repository: rL L

[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327852: Updated a usage of createTemporaryFile that does not expect file to be created. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://revi

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327962: [analyzer] Fix the crash in IteratorChecker.cpp when 'SymbolConjured' has a… (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs (authored by ibiryukov, committed by ). Hera

[PATCH] D47065: [clangd] Enable parsing of non-doxygen comments in global-symbol-builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL333528: [clangd] Enable parsing of non-doxygen comments in global-symbol-builder (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D47451: [analyzer] Remove the redundant check about same state transition in `ArrayBoundCheckerV2.cpp`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333531: [analyzer] Remove the redundant check about same state transition in… (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

This revision was automatically updated to reflect the committed changes. Closed by commit rL333538: [Sema] Don't skip function bodies with 'auto' without trailing return type (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D46918: [Coverage] Discard the last uncompleted deferred region in a decl

This revision was automatically updated to reflect the committed changes. Closed by commit rL333609: [Coverage] Discard the last uncompleted deferred region in a decl (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D46918: [Coverage] Discard the last uncompleted deferred region in a decl

This revision was automatically updated to reflect the committed changes. Closed by commit rC333609: [Coverage] Discard the last uncompleted deferred region in a decl (authored by vedantk, committed by ). Repository: rL LLVM https://reviews.llvm.org/D46918 Files: lib/CodeGen/CoverageMapping

[PATCH] D47577: [clang-format] Separate block comments with CRLF correctly

Uran198 created this revision. Uran198 added a reviewer: alexfh. Herald added subscribers: cfe-commits, klimek. When formatting the following string: "/*\r\n" " * Comment with\r\n" "\r\n" " * blanks.\r\n" " */\r\n" clang-format produced: "/*\r\n" " * Comment with\r\n" "\

[PATCH] D47155: [analyzer] Improve simplifySVal performance.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333670: [analyzer] Improve performance of the SVal simplification mechanism. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D47402: [analyzer] Improve simplifySVal performance further.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333671: [analyzer] Improve performance of the SVal simplification mechanism further. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D47499: [analyzer] Annotate program state update methods with LLVM_NODISCARD.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333679: [analyzer] Annotate ProgramState update methods with LLVM_NODISCARD. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D47303: [analyzer] NFC: Merge object construction related state traits into one.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333719: [analyzer] NFC: Track all constructed objects in a single state trait. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL333737: [clangd] Keep only a limited number of idle ASTs in memory (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47063

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs created this revision. Herald added a subscriber: cfe-commits. Adds MSVC intrinsics for atomic exchange and compare & exchange. Repository: rC Clang https://reviews.llvm.org/D47672 Files: lib/Headers/immintrin.h lib/Headers/intrin.h Index: lib/Headers/intrin.h =

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

mephi42 added a comment. This change is very useful for me (I even rebuilt my clang-format with it), but there were no updates for quite some time - do you still intend to integrate it? Apologies in advance if Phabricator is not the right place for such discussions. Repository: rC Clang htt

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. In general, make sure the documentation page renders well in a browser. Mostly style and phrasing stuff inline: Comment at: clang-tidy/bugprone/NotNullTerm

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing created this revision. Herald added a subscriber: cfe-commits. Higuoxing edited the summary of this revision. Hi, As you see, to avoid some expression like assert(x || y && "some messages"); clang will skip all the parentheses check if the expression is in `macro`; and this rule is

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. As for some test cases, $ cat a.cc #include #include #define bar(x) \ ( \ ( std::cout << x ) \ ) bool x; int val; void foo(bool b) { std::cout << b << std::endl; } int main () { foo(x && val == 4 || (!x && v

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1120226, @lebedev.ri wrote: > In https://reviews.llvm.org/D47687#1120213, @Higuoxing wrote: > > > As for some test cases, > > > The tests need to be within the patch itself, in this case > i guess that should go into `clang/test/Sema/

[PATCH] D47640: Moved RangedConstraintManager header to the StaticAnalyser include dir

This revision was automatically updated to reflect the committed changes. Closed by commit rC333862: Moved RangedConstraintManager header to the StaticAnalyser include dir (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[PATCH] D47689: Created a tiny SMT interface and make Z3ConstraintManager implement it

This revision was automatically updated to reflect the committed changes. Closed by commit rC333899: Created a tiny SMT interface and make Z3ConstraintManager implement it (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.

[PATCH] D45517: [analyzer] False positive refutation with Z3

This revision was automatically updated to reflect the committed changes. Closed by commit rC333903: [analyzer] False positive refutation with Z3 (authored by mramalho, committed by ). Changed prior to commit: https://reviews.llvm.org/D45517?vs=149664&id=149764#toc Repository: rC Clang http

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 149766. Higuoxing edited the summary of this revision. Higuoxing added a comment. Update with test cases :) https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c =

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE333906: [clangd] Boost scores for decls from current file in completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D46943?vs=149765&id=149771#toc Reposi

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas created this revision. gramanas added a reviewer: vsk. Herald added subscribers: cfe-commits, JDevlieghere, eraman, aprantl. This test is a strip down version of a function inside the amalgamated sqlite source. When converted to IR clang produces a phi instruction without debug location.

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. Thanks for reviewing! I think the logic that *do not emit warning in macros* is not so proper ... Best Regards, Xing https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333941: [CFG] Fix automatic destructors when a member is bound to a reference. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44238 Files: lib/Analysis/CFG.cp

[PATCH] D44239: [analyzer] Re-enable constructor inlining when lifetime extension through fields occurs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333946: [analyzer] Re-enable constructors when lifetime extension through fields occurs. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44239 Files: include/c

[PATCH] D47607: [libcxx] Almost fix some UB in and

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333948: Fix a strict aliasing violation in map and unordered_map. (authored by epilk, committed by ). Herald added a subsc

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added a comment. In https://reviews.llvm.org/D47672#1121181, @rnk wrote: > > They are a hint to the processor that this is a short critical section, and > it is likely that the entire critical section can be entered, run, and > committed to memory before another thread needs to use

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 149996. gramanas added a comment. Add comment explaining the test Repository: rC Clang https://reviews.llvm.org/D47720 Files: test/CodeGen/debug-info-inline-for.c Index: test/CodeGen/debug-info-inline-for.c ==

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 150036. gramanas marked an inline comment as done. gramanas added a comment. Add artificial debug location to the phi instruction Repository: rC Clang https://reviews.llvm.org/D47720 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/debug-info-inline

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas added inline comments. Comment at: test/CodeGen/debug-info-inline-for.c:13 + +// CHECK: ![[DbgLoc]] = !DILocation( aprantl wrote: > Shouldn't you also check *which* location is attached to it? I wasn't sure if this should be an artificial location or not

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. Thanks for reviewing! I think enabling parentheses-checking in macros could be helpful, and `assert(something)` is widely used : ) https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

gramanas added a comment. What about this? Ping! Repository: rC Clang https://reviews.llvm.org/D47097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas updated this revision to Diff 150135. gramanas added a comment. make code more readable Repository: rC Clang https://reviews.llvm.org/D47720 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/debug-info-inline-for.c Index: test/CodeGen/debug-info-inline-for.c ===

[PATCH] D46602: [clang-tidy] Store checks profiling info as JSON files

This revision was automatically updated to reflect the committed changes. Closed by commit rL334101: [clang-tidy] Store checks profiling info as JSON files (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D46602?vs=149933&id=150142#toc Repository: rL

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs marked an inline comment as done. ethanhs added a comment. In https://reviews.llvm.org/D47672#1123953, @craig.topper wrote: > We (Intel) have discussed this a little internally. I'll be responding more > shortly. Great! FWIW, re intrin.h vs immintrin.h, the documentation for these put

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs updated this revision to Diff 150189. ethanhs added a comment. Guard to be used only under MSVC, define default FN attrs Repository: rC Clang https://reviews.llvm.org/D47672 Files: lib/Headers/immintrin.h lib/Headers/intrin.h Index: lib/Headers/intrin.h =

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added inline comments. Comment at: lib/Headers/immintrin.h:387 +#if defined(__i386__) || defined(__x86_64__) +static __inline__ long __DEFAULT_FN_ATTRS +_InterlockedExchange_HLEAcquire(long volatile *_Target, long _Value) { craig.topper wrote: > what is _

[PATCH] D47291: Proposal to make rtti errors more generic.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334153: Change the wording of RTTI errors to make them more generic. (authored by ssrivastava, committed by ). Repository: rC Clang https://reviews.llvm.org/D47291 Files: include/clang/Basic/Diagnos

[PATCH] D47724: [X86] Add back _mask, _maskz, and _mask3 builtins for some 512-bit fmadd/fmsub/fmaddsub/fmsubadd builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334159: [X86] Add back _mask, _maskz, and _mask3 builtins for some 512-bit… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs created this revision. ethanhs added a reviewer: bkramer. Herald added a subscriber: cfe-commits. This fixes all but one of the test cases for Windows. TestCDB will take more work to debug, as CompilationDatabase seems not to work correctly. Repository: rC Clang https://reviews.llvm.o

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 150253. Higuoxing added a reviewer: echristo. Higuoxing added a comment. update with comments & remove some useless blank lines. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

gramanas updated this revision to Diff 150357. gramanas added a comment. Make more elaborate comment. Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index: test/CodeGen/debug-info-preserve-scope.c

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs added a comment. In https://reviews.llvm.org/D47864#1124948, @bkramer wrote: > I don't know much about the python bindings, but this is probably fine. Yeah I wasn't really sure who to add so I looked at the commit history. Thank you for adding the right people. Repository: rC Clang

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1125926, @rnk wrote: > @dexonsmith is there someone from Apple who can comment on rdar://8678458 and > the merits of disabling this warning in macros? I strongly suspect the > original report was dealing with code like `assert(x || y

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote: > At worst, we can issue this warning in a new `-Wparentheses-in-macros` > subgroup, which, if apple so insists, could be off-by-default. > That would less worse than just completely silencing it for the e

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 150465. Higuoxing added a comment. I step out a little further... I made an attempt to add a new warning `[-Wlogical-op-parentheses-in-macros]`. Comparing to the previous one, which do you prefer? I am new to llvm community, and as you see, this is my firs

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. Thanks, let me have a try https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 150495. Higuoxing added a comment. Update without conflict with test case `parentheses.c`... I add a separate option [-Wlogical-op-parentheses-in-macros] and will be silence by default thanks https://reviews.llvm.org/D47687 Files: include/clang/Basic/

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 150507. Higuoxing marked 4 inline comments as done. Higuoxing added a comment. Hope this not disturb you too much : ) thanks https://reviews.llvm.org/D47687 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td li

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing marked 2 inline comments as done. Higuoxing added a comment. Sorry, I will check it and update the test case Besides, shall I add the macro-parentheses checking test cases to the original 'parentheses.c'? https://reviews.llvm.org/D47687

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 150517. https://reviews.llvm.org/D47687 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/logical-op-parentheses-in-macros.c Index: test/Sema/logical-op-parentheses-in-macros.c

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. This diff version pass the both `parentheses.c` and `logical-op-parentheses.c` https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing marked 3 inline comments as done. Higuoxing added a comment. In https://reviews.llvm.org/D47687#1126607, @dexonsmith wrote: > In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D47687#1126032, @Higuoxing wrote: > > > > > In https://reviews.l

[PATCH] D47135: [analyzer] A checker for dangling internal buffer pointers in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL334348: [analyzer] Add dangling internal buffer check. (authored by rkovacs, committed by ). Herald added subscribers: llvm-commits, mikhail.ramalho. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL334352: [analyzer] Clean up the program state map of DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D47693: [X86] Use target independent masked expandload and compressstore intrinsics to implement expandload/compressstore builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334366: [X86] Use target independent masked expandload and compressstore intrinsics to… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D47693?vs=149657&id=150654

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1128757, @dexonsmith wrote: > > Yes, I think understand the patch; but I think it's the wrong direction. I > think we should just make the existing `-Wlogical-op-parentheses` smart > enough to show actionable warnings in macros

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added a comment. In https://reviews.llvm.org/D47672#1128863, @rnk wrote: > In https://reviews.llvm.org/D47672#1128308, @hans wrote: > > > It sounds like adding proper support for HLE prefixes is a largeish project. > > > > ctopper, rnk: Do you think it would be worth adding inline asm ver

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs accepted this revision. ethanhs added a comment. Works great! https://reviews.llvm.org/D47672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48068: [clangd] Move caching of compile args out of ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE334585: [clangd] Move caching of compile args out of ClangdServer. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D48068?vs=151113&id=151114#toc Repository:

[PATCH] D47304: [analyzer] NFC: Merge the functions for obtaining constructed object location and storing this location for later use.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334678: [analyzer] NFC: Merge code for finding and tracking construction target. (authored by dergachev, committed by ). Herald added a subscriber: mikhail.ramalho. Repository: rC Clang https://reviews

[PATCH] D47305: [analyzer] pr37270: Fix binding constructed object to DeclStmt when ConstructionContext is already lost.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334681: [analyzer] pr37270: Track constructor target region, even if just a variable. (authored by dergachev, committed by ). Herald added subscribers: llvm-commits, mikhail.ramalho. Changed prior to comm

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334682: [analyzer] Track class member initializer constructors path-sensitively. (authored by dergachev, committed by ). Herald added a subscriber: mikhail.ramalho. Repository: rC Clang https://reviews

[PATCH] D47351: [analyzer] Re-enable C++17-specific variable and member variable construction contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334683: [analyzer] Re-enable C++17-specific variable and member construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: mikhail.ramalho. Repository: rC Clang https://r

[PATCH] D47405: [analyzer] Re-enable C++17-specific return value constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334684: [analyzer] Re-enable C++17-specific RVO construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: mikhail.ramalho. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151290. Higuoxing added a comment. Ping, well, I think I understand `@dexonsmith`'s idea. `Actionable` macro argument is just like something like this #define foo(x) ( (void)(x) ) when we using it by foo(a && b || c); we could add parentheses for it

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

This revision was automatically updated to reflect the committed changes. Closed by commit rL334751: [X86] Add inline assembly versions of _InterlockedExchange_HLEAcquire/Release… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151460. Higuoxing added a comment. I think I am almost there. Here, In my sight #define foo(op0, op1, x, y, z) ( (void)(x op0 y op1 z) ) is un-actionable, because `x op0 y op1 z` are from different arguments of function-like macro, so, we will not chec

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. Ping https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48171: [clangd] Do not report comments that only have special chars.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334807: [clangd] Do not report comments that only have special chars. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D4817

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151599. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/parentheses.c +++ test/Sema/parentheses.c @@

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151604. Higuoxing added a comment. Ping, thanks https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/pare

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151605. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/parentheses.c +++ test/Sema/parentheses.c @@ -

[PATCH] D48221: [analyzer] Add method to the generic SMT API to dump the SMT formula

This revision was automatically updated to reflect the committed changes. Closed by commit rL334891: [analyzer] Add method to the generic SMT API to dump the SMT formula (authored by mramalho, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D48221: [analyzer] Add method to the generic SMT API to dump the SMT formula

This revision was automatically updated to reflect the committed changes. Closed by commit rC334891: [analyzer] Add method to the generic SMT API to dump the SMT formula (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Ah, and the function names in the test files have been made more logical. Let's roll. 😉 https://reviews.llvm.org/D45532 ___ cfe-commits

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151633. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/parentheses.c +++ test/Sema/parentheses.c @@ -

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added inline comments. Comment at: lib/Sema/SemaExpr.cpp:12304-12309 // Diagnose "arg1 & arg2 | arg3" if ((Opc == BO_Or || Opc == BO_Xor) && !OpLoc.isMacroID()/* Don't warn in macros. */) { DiagnoseBitwiseOpInBitwiseOp(Self, Opc, OpLoc, LHSExpr);

<    7   8   9   10   11   12   13   14   15   16   >