[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

penzn added inline comments. Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229 +RangeSelector tooling::statements(StringRef ID) { + return RelativeSelector(ID); +} Sorry for posting here, haven't gotten my bugzilla access yet (requested though

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

penzn marked an inline comment as done. penzn added inline comments. Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229 +RangeSelector tooling::statements(StringRef ID) { + return RelativeSelector(ID); +} penzn wrote: > Sorry for posting here, h

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn created this revision. penzn added a reviewer: tlively. Herald added subscribers: pmatos, asb, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. penzn requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin.

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn added a comment. I still need to run a few external tests, like the ones mentioned in https://github.com/emscripten-core/emscripten/issues/9340 https://github.com/WebAssembly/simd/issues/196 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14077

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn updated this revision to Diff 486636. penzn edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140773/new/ https://reviews.llvm.org/D140773 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/wasm_simd128.h clang/test/CodeGen/builtins-wasm

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn marked an inline comment as done. penzn added a comment. Moved the test out. Comment at: llvm/test/CodeGen/WebAssembly/simd-shuffle.ll:1-2 +; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

penzn accepted this revision. penzn added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101112/new/ https://reviews.llvm.org/D101112

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

penzn added a comment. I think there is another dimension to this aside from project composition - intrinsics have a tendency to "interact" with their surroundings, and it better to capture the IR rather than the end result. Even if we can verify that simple calls produce instructions we expect