https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/101259
>From f20e9d0bc3fc66ebcda8286682a2d38e006bb9d0 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Wed, 24 Jul 2024 10:47:49 -0700
Subject: [PATCH] [Driver] Normalize the baremetal handling of libc++ and
runtimes
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/118978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -291,6 +365,36 @@ BareMetal::OrderedMultilibs
BareMetal::getOrderedMultilibs() const {
return llvm::reverse(Default);
}
+ToolChain::CXXStdlibType BareMetal::GetDefaultCXXStdlibType() const {
+ if (getTriple().isRISCV()) {
+return GCCInstallation.isValid() ? ToolChai
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/121875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/119403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -20,7 +20,12 @@ set(LIBUNWIND_C_SOURCES
)
set_source_files_properties(${LIBUNWIND_C_SOURCES}
PROPERTIES
- COMPILE_FLAGS "-std=c99")
+ # We need to set `-fexceptions` here so that key
+
petrhosek wrote:
These cache files seem to be largely the same as
[PGO.cmake](https://github.com/llvm/llvm-project/blob/4cec0ba92955c353c52efe728b2cfef3fbdf60f8/clang/cmake/caches/PGO.cmake),
[PGO-stage2.cmake](https://github.com/llvm/llvm-project/blob/04b002bbb838bc502bd6d5f602af95efd6cc96b3/
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/123258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/126876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/127967
This was accidentaly introduced in #126876.
>From 811f3ce860a5e544000166ccd06df3bb8cf5ec6b Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Thu, 20 Feb 2025 07:39:23 +
Subject: [PATCH] [CMake] Fix variable
@@ -11,6 +11,7 @@ config.python_exe = "@Python3_EXECUTABLE@"
config.cmake_exe = "@CMAKE_COMMAND@"
config.llvm_src_dir ="@CMAKE_SOURCE_DIR@"
config.cmake_generator ="@CMAKE_GENERATOR@"
+config.use_llvm_build = @CLANG_PGO_TRAINING_USE_LLVM_BUILD@
petrhosek wrote:
https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/128680
>From 0662cddc6837c281c102995e2789bb0f81adb415 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Fri, 7 Feb 2025 08:49:18 -0800
Subject: [PATCH 1/2] [Fuchsia] Support PGO
Enable 2-stage builds with PGO.
---
..
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/128680
Enable 2-stage builds with PGO.
>From 0662cddc6837c281c102995e2789bb0f81adb415 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Fri, 7 Feb 2025 08:49:18 -0800
Subject: [PATCH 1/2] [Fuchsia] Support PGO
Enable
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/127967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
Can you update the PR description and explain why this is desirable?
https://github.com/llvm/llvm-project/pull/126785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
petrhosek wrote:
> It seems like for gcc at least, IIUC, `cc` does a bit more than `c` so while
> we are supporting `cc` for compatibility we are not fully supporting it?
> Specifically:
>
> `except try harder to print it with no punctuation`
>
> Perhaps we should document that in the comment
petrhosek wrote:
> LGTM. This seems to work locally for me, but I haven't tested w/ cross
> compiling. Is that still potentially an issue?
It's not addressed since that's going to require more changes, I assume we'll
disable PGO on cross-compiling builders by not setting `FUCHSIA_ENABLE_PGO`.
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/127719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -110,20 +111,93 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+// GCC sysroot here means form sysroot from either --gcc-install-dir, or from
+// --gcc-toolchain or if the toolchain is installed alongside
@@ -97,7 +97,8 @@ static bool findRISCVMultilibs(const Driver &D,
return false;
}
-static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) {
+static std::string computeInstalledToolchainSysRoot(const Driver &D,
petrhosek wrote:
Can we avo
@@ -110,20 +111,93 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+// GCC sysroot here means form sysroot from either --gcc-install-dir, or from
+// --gcc-toolchain or if the toolchain is installed alongside
@@ -110,20 +111,93 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+// GCC sysroot here means form sysroot from either --gcc-install-dir, or from
+// --gcc-toolchain or if the toolchain is installed alongside
@@ -110,20 +111,93 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+// GCC sysroot here means form sysroot from either --gcc-install-dir, or from
+// --gcc-toolchain or if the toolchain is installed alongside
petrhosek wrote:
Can you check the toolchain binary size increase? Is `llc` included in the
`llvm` binary?
https://github.com/llvm/llvm-project/pull/130999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/132428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -835,19 +835,39 @@ class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
public:
UEFIX86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: UEFITargetInfo(Triple, Opts) {
+LongWidth = LongAlign = 32;
+DoubleAlign = LongLongAlign = 64;
+Int
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/131939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -835,8 +835,24 @@ class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
public:
UEFIX86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: UEFITargetInfo(Triple, Opts) {
+// The UEFI spec does not mandate specific C++ ABI, integer widths, or
+
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/132482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/134893
This generalizes the support added in #99287 renaming the option to
RUNTIMES_USE_LIBC and integrating the module into libc++abi and libunwind as
well.
>From 1677ee5c547018472a1f6a29282d3af3500abcd7 Mon Sep 1
https://github.com/petrhosek approved this pull request.
This is definitely an improvement over status quo! Ideally, developers wouldn't
have to list Clang libraries separately from other libraries but that would
require some non-trivial build system refactoring that would be better done in
fo
@@ -835,16 +835,22 @@ class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
public:
UEFIX86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: UEFITargetInfo(Triple, Opts) {
+LongWidth = LongAlign = 32;
+DoubleAlign = LongLongAlign = 64;
+Int
https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/128680
>From 0662cddc6837c281c102995e2789bb0f81adb415 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Fri, 7 Feb 2025 08:49:18 -0800
Subject: [PATCH 1/3] [Fuchsia] Support PGO
Enable 2-stage builds with PGO.
---
..
@@ -77,3 +104,25 @@ add_subdirectory(Index)
add_subdirectory(InstallAPI)
add_subdirectory(Serialization)
add_subdirectory(Support)
+
+
+# If we're doing a single merged clang unit test binary, add that target after
+# all the previous subdirectories have been processed.
+get_pr
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/135505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+static bool hasGCCToolChainAlongSideClang(const Driver &D) {
petrhosek wrote:
If understand correctly, this should cover t
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/135456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -261,7 +261,7 @@ static bool isPublic(const clang::AccessSpecifier AS,
const clang::Linkage Link) {
if (AS == clang::AccessSpecifier::AS_private)
return false;
- else if ((Link == clang::Linkage::Module) ||
+ if ((Link == clang::Linkage::Module)
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3038,8 +3038,30 @@ static Address EmitX86_64VAArgFromMemory(CodeGenFunction
&CGF,
return Address(Res, LTy, Align);
}
+static RValue EmitMSABIVAArg(CodeGenFunction &CGF, Address VAListAddr,
+ QualType Ty, AggValueSlot Slot,
+
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/135515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/136376
We aren't distributing any shared libraries so we don't need PIC and using PIE
instead of PIC can improve performance.
>From 55816661f262410862b91e8e54e2f2d947af11fb Mon Sep 17 00:00:00 2001
From: Petr Hosek
@@ -352,6 +352,8 @@ static MCAsmInfo *createAArch64MCAsmInfo(const
MCRegisterInfo &MRI,
MAI = new AArch64MCAsmInfoMicrosoftCOFF();
else if (TheTriple.isOSBinFormatCOFF())
MAI = new AArch64MCAsmInfoGNUCOFF();
+ else if (TheTriple.isUEFI())
+MAI = new AArch64MCAsm
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/136376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/127290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/137872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/136843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -795,43 +787,52 @@ emitInfo(const CXXMethodDecl *D, const FullComment *FC,
int LineNumber,
}
std::pair, std::unique_ptr>
-emitInfo(const TypedefDecl *D, const FullComment *FC, int LineNumber,
- StringRef File, bool IsFileInRootDir, bool PublicOnly) {
- TypedefInfo
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/137732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/137853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/138052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -60,6 +60,7 @@ struct CommentInfo {
// the vector.
bool operator<(const CommentInfo &Other) const;
+ // TODO: The Kind field should be an enum, so we can switch on it easily
petrhosek wrote:
```suggestion
// TODO: The Kind field should be an enum, s
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/138783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
901 - 961 of 961 matches
Mail list logo
