[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek created this revision. phosek added reviewers: rnk, echristo, chandlerc, beanz. Herald added subscribers: cfe-commits, JDevlieghere, mgorny. Previously we used target triple as provided which matches the GCC behavior, but it also means that all clients have to be consistent in their spellin

[PATCH] D50663: [libunwind] [cmake] Add MINGW_LIBRARIES to the linker flags

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rUNW libunwind https://reviews.llvm.org/D50663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D50691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D50618: Refactor Darwin driver to refer to runtimes by component

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D50755: [Driver] -print-target-triple and -print-effective-triple options

phosek created this revision. phosek added reviewers: beanz, rnk. Herald added a subscriber: cfe-commits. These can be used to print Clang target and effective triple. Repository: rC Clang https://reviews.llvm.org/D50755 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Drive

[PATCH] D50755: [Driver] -print-target-triple and -print-effective-triple options

This revision was automatically updated to reflect the committed changes. Closed by commit rL339834: [Driver] -print-target-triple and -print-effective-triple options (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161031. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp Index: clang/lib/Driver/ToolChain.cpp === --- cla

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added a comment. In https://reviews.llvm.org/D50547#1198218, @rnk wrote: > Would it be to much to check both the normalized and non-normalized? Done, currently I'm only checking the provided target triple followed by the normalized one, I'm not checking the effective triple but it'd be

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161818. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp Index: clang/lib/Driver/ToolChain.cpp === --- cla

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added a comment. I also need to create the following empty files for tests to pass (somehow those are not displayed by Phabricator): clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchsia/lib/libclang_rt.asan-preinit.a clang/test/Driver/Inputs/resource_dir_with

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161821. Herald added a reviewer: javed.absar. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchs

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:372 - const Driver &D = getDriver(); - SmallString<128> P(D.ResourceDir); - llvm::sys::path::append(P, D.getTargetTriple(), "lib"); - if (getVFS().exists(P)) { + for (const auto &LibPath : getLibraryP

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

This revision was automatically updated to reflect the committed changes. Closed by commit rC340471: [Driver] Check normalized triples for multiarch runtime path (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D50547?vs=161821&id=162090#toc Repository:

[PATCH] D46610: [CMake] Set CMAKE_BUILD_WITH_INSTALL_RPATH for Fuchsia runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This doesn't make any difference since we don't use RPATH/RUNPATH on Fuchsia but it avoids the CMake error when re-linking libraries while building with Ninja. Repository: rC Clang

[PATCH] D46610: [CMake] Set CMAKE_BUILD_WITH_INSTALL_RPATH for Fuchsia runtimes

phosek added a comment. Actually after testing this I believe this is really what we want, without this option CMake sets RPATH for build libraries and then removes it when installing these. With this option it doesn't even set the RPATH for build libraries. Repository: rC Clang https://rev

[PATCH] D46612: [CMake] Include llvm-strip in Fuchsia toolchain distribution

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Now that llvm-strip is available, include it in the Fuchsia toolchain. Repository: rC Clang https://reviews.llvm.org/D46612 Files: clang/cmake/caches/Fuchsia-stage2.cmake I

[PATCH] D46612: [CMake] Include llvm-strip in Fuchsia toolchain distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rC331826: [CMake] Include llvm-strip in Fuchsia toolchain distribution (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D46612?vs=145815&id=145818#toc Repository:

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added a subscriber: cfe-commits. The fact that libc++ depends on libc++abi and libunwind is an internal detail that's captured by the libc++.so linker script. Repository: rC Clang https://review

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

phosek updated this revision to Diff 146396. Repository: rC Clang https://reviews.llvm.org/D46768 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.cpp Index: clang/test/Driver/fuchsia.cpp === --- clan

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL332138: [Driver] Only use -lc++ on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46768?vs=146396&id=146408#toc

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

phosek added inline comments. Comment at: lib/Index/USRGeneration.cpp:691 +case BuiltinType::ULongAccum: + llvm_unreachable("No USR name mangling for fixed point types."); case BuiltinType::Float16: We need some solution for fixed point

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

phosek updated this revision to Diff 147431. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46910 Files: clang/lib/Frontend/CompilerInvocation.cpp llvm/cmake/modules/GetHostTriple.cmake llvm/lib/Support/Unix/Host.inc llvm/lib/Support/Windows/Host

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

phosek added a comment. Applied, thanks so much for looking into it. Repository: rC Clang https://reviews.llvm.org/D46910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

This revision was automatically updated to reflect the committed changes. Closed by commit rC332750: [Support] Avoid normalization in sys::getDefaultTargetTriple (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D46910?vs=147431&id=147567#toc Repository:

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

phosek added a comment. In https://reviews.llvm.org/D46910#1105992, @thakis wrote: > This changes the default triple on Windows from x86_64-pc-win32 to > x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple() > (http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234) >

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows adding additional bootstrap dependencies to the bootstrap compiler that may be needed by later stages. Repository: rC Clang https://reviews.llvm.org/D47355 Files: clang/

[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

phosek created this revision. phosek added reviewers: beanz, jakehehrlich, mcgrathr. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a reviewer: EricWF. We want to build the second stage compiler with libc++ and compiler-rt, also include builtins and runtimes into extra bootst

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek added inline comments. Comment at: clang/CMakeLists.txt:586 + if(CLANG_BOOTSTRAP_EXTRA_COMPONENTS) +add_dependencies(clang-bootstrap-deps ${CLANG_BOOTSTRAP_EXTRA_COMPONENTS}) I don't know if `COMPONENTS` is the best term, this could also possibly be

[PATCH] D47357: [Driver] Rename DefaultTargetTriple to TargetTriple

phosek created this revision. phosek added reviewers: hans, rnk, echristo. Herald added a subscriber: cfe-commits. While this value is initialized with the DefaultTargetTriple, it can be later overriden using the -target flag so TargetTriple is a more accurate name. This change also provides an ac

[PATCH] D47357: [Driver] Rename DefaultTargetTriple to TargetTriple

This revision was automatically updated to reflect the committed changes. Closed by commit rC333468: [Driver] Rename DefaultTargetTriple to TargetTriple (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D47357?vs=148539&id=148996#toc Repository: rC Clang

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D39017 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

phosek added a comment. It seems like with the current patch, CMake already sets `-Wl,-O3` so that should be sufficient. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

This revision was automatically updated to reflect the committed changes. Closed by commit rL316053: [CMake] Build Fuchsia toolchain as -O3 (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39017?vs=119372&id=119417#toc Repository: rL LLVM https://reviews.llvm.org/D39

[PATCH] D39176: [Driver] Use ld.lld directly for Fuchsia rather than passing flavor

phosek created this revision. phosek added a project: clang. Passing a flavor to LLD requires command line argument, but if these are being passed through a response file, this will fail because LLD needs to know which driver to use before processing the response file. Use ld.lld directly instead

[PATCH] D39176: [Driver] Use ld.lld directly for Fuchsia rather than passing flavor

phosek updated this revision to Diff 119923. Repository: rL LLVM https://reviews.llvm.org/D39176 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp =

[PATCH] D39176: [Driver] Use ld.lld directly for Fuchsia rather than passing flavor

This revision was automatically updated to reflect the committed changes. Closed by commit rL316379: [Driver] Use ld.lld directly for Fuchsia rather than passing flavor (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39176?vs=119923&id=119938#toc Repository: rL LLVM

[PATCH] D39266: [clang-refactor] Use add_clang_tool CMake template

phosek created this revision. phosek added a project: clang. Herald added a subscriber: mgorny. This allows including clang-refactor in LLVM_DISTRIBUTION_COMPONENTS to build clang-refactor as part of the toolchain distribution. Repository: rL LLVM https://reviews.llvm.org/D39266 Files: too

[PATCH] D39270: [CMake] Include clang-refactor in Fuchsia toolchain

phosek created this revision. phosek added a project: clang. Herald added a subscriber: mgorny. This includes the clang-refactor in the toolchain distribution. Repository: rL LLVM https://reviews.llvm.org/D39270 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.

[PATCH] D39266: [clang-refactor] Use add_clang_tool CMake template

This revision was automatically updated to reflect the committed changes. Closed by commit rL316540: [clang-refactor] Use add_clang_tool CMake template (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39266?vs=120155&id=120164#toc Repository: rL LLVM https://reviews.

[PATCH] D39273: [CMake] Build host builtins in Fuchsia toolchain even on Darwin

phosek created this revision. phosek added a project: clang. Herald added a subscriber: mgorny. This is needed for the toolchain to be actually usable as a host toolchain on Darwin. Repository: rL LLVM https://reviews.llvm.org/D39273 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/

[PATCH] D39270: [CMake] Include clang-refactor in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL316541: [CMake] Include clang-refactor in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39270?vs=120163&id=120178#toc Repository: rL LLVM https://reviews

[PATCH] D39273: [CMake] Build host builtins in Fuchsia toolchain even on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL316542: [CMake] Build host builtins in Fuchsia toolchain even on Darwin (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39273?vs=120165&id=120179#toc Repository: rL LLVM htt

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

phosek added a comment. What about other compiler-rt runtimes? Shouldn't we use the same approach for those? In case of multiarch runtime layout, we already add the runtime directory to the new `LibraryPaths` list,

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

phosek added a comment. In https://reviews.llvm.org/D51440#1218859, @mstorsjo wrote: > I'll see if I can get to looking at that sometime soon. I had this patch > lying around as an attempt to work around the libtool issue in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27866 which doesn't se

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek created this revision. phosek added a reviewer: beanz. Herald added a subscriber: cfe-commits. This is necessary to handle the multiarch runtime directories. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163630. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp === --- clang/lib/Driver/Driver.cpp +++ clang/lib/Driver/D

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163633. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/linux-per-target-runtime-dir.c Index: clang/test/Driver/linux-per-target-runtime-dir.c ==

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163636. phosek marked 4 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/linux-per-target-runtime-dir.c Index: clang/test/Driver/linux-per-target-runtime-dir.c =

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4187 SmallString<128> R(ResourceDir); llvm::sys::path::append(R, Name); mcgrathr wrote: > You could fold these cases into the lambda too by having it take a bool > UseSysRoot and passi

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

This revision was automatically updated to reflect the committed changes. Closed by commit rC342021: [Driver] Search LibraryPaths when handling -print-file-name (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D51573?vs=163636&id=165008#toc Repository: r

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added inline comments. Comment at: libcxx/lib/CMakeLists.txt:269 +AND (TARGET cxxabi_static OR HAVE_LIBCXXABI)) +#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR +#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND HAVE_LIBCXXABI)) ---

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek updated this revision to Diff 156382. phosek edited subscribers, added: cfe-commits; removed: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49573 Files: libcxx/CMakeLists.txt libcxx/lib/CMakeLists.txt libcxxabi/CMakeLists.txt libcxxabi/src/CMakeLists.txt libunwin

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek updated this revision to Diff 156416. phosek marked 8 inline comments as done. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49502 Files: libcxx/CMakeLists.txt libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/lib/CMakeLists.txt libcxxabi

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

phosek created this revision. phosek added reviewers: ldionne, EricWF. Herald added subscribers: cfe-commits, christof, mgorny. This is a follow-up to r335809 and r337118. While libc++ headers are now installed into the right location in both standard as well as multiarch runtimes layout, turned

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added inline comments. Comment at: libcxx/lib/CMakeLists.txt:269 +AND (TARGET cxxabi_static OR HAVE_LIBCXXABI)) +#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR +#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND HAVE_LIBCXXABI)) ---

[PATCH] D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: ldionne. Replaced by https://reviews.llvm.org/D49587. Repository: rCXX libc++ https://reviews.llvm.org/D41755 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D41753: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek abandoned this revision. phosek added a comment. Replaced by https://reviews.llvm.org/D49587. Repository: rUNW libunwind https://reviews.llvm.org/D41753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: ldionne. Replaced by https://reviews.llvm.org/D49587. Repository: rCXXA libc++abi https://reviews.llvm.org/D41754 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

phosek added a subscriber: beanz. phosek added a comment. We currently support two different layouts: 1. The standard layout (for a lack of a better name) which is used when libc++ is built standalone as well as being built as part of LLVM without any other options which is `$DESTDIR/include/c+

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. In https://reviews.llvm.org/D49573#1169615, @ldionne wrote: > I don't like the fact that we're adding options like crazy, thus making the > build more complicated. If you don't want to have some libraries that were > built, why not just remove them afterwards? The moti

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337630: [CMake] Install C++ ABI headers into the right location (authored by phosek, committed by ). Herald added a subscr

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, chrib, mgorny. Herald added a reviewer: EricWF. When building libc++ for Fuchsia, we want to distribute shared libc++, libc++abi and libunwind as separate libraries, b

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337668: [CMake] Support statically linking dependencies only to shared or static library (authored by phosek, committed by

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. You're right that we don't need these flags for libc++, we only need them for libc++abi and libunwind for the cases when one of these is linked into libc++ or libc++abi respectively. I added them for consistency, but I'm fine dropping them from libc++, would that be more

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek created this revision. phosek added reviewers: EricWF, ldionne, aheejin, arphaman. Herald added subscribers: cfe-commits, christof, mgorny. This is an alternative approach to r337727 which broke the build because libc++ headers were copied into the location outside of directories used by Cl

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek added a comment. I've tested this on macOS and everything seems to be working, Repository: rCXX libc++ https://reviews.llvm.org/D49711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek updated this revision to Diff 157043. Repository: rCXX libc++ https://reviews.llvm.org/D49711 Files: libcxx/CMakeLists.txt libcxx/cmake/Modules/HandleLibCXXABI.cmake Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake =

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek updated this revision to Diff 157050. Repository: rCXX libc++ https://reviews.llvm.org/D49711 Files: libcxx/CMakeLists.txt libcxx/cmake/Modules/HandleLibCXXABI.cmake Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake =

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337833: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build (authored by phosek, committed by ). Herald added

[PATCH] D49752: [CMake] Don't install c++abi headers in standalone libc++ build

phosek created this revision. phosek added reviewers: mclow.lists, EricWF, ldionne. Herald added subscribers: cfe-commits, christof, mgorny. This is a refinement on r337833. Previously we were installing two copies of c++abi headers in libc++ build directory, one in include/c++build and another on

[PATCH] D49752: [CMake] Don't install c++abi headers in standalone libc++ build

phosek added a comment. This was pointed out by @mclow.lists on IRC in our discussion related to https://reviews.llvm.org/D49711, I believe this change should resolve that issue. Repository: rCXX libc++ https://reviews.llvm.org/D49752 ___ cfe-c

[PATCH] D49765: [CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi build

phosek created this revision. phosek added reviewers: mgorny, EricWF. Herald added subscribers: cfe-commits, ldionne, christof. This was changed unintentionally in r335809. Repository: rCXXA libc++abi https://reviews.llvm.org/D49765 Files: libcxxabi/CMakeLists.txt Index: libcxxabi/CMakeL

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX337867: [CMake] Option to control whether shared/static library is installed (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D49573?vs=156382&id=157170#toc Repo

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

phosek updated this revision to Diff 157182. Repository: rC Clang https://reviews.llvm.org/D49628 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake === --- clang/cmake/caches/Fuchsia

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL337877: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D49765: [CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi build

This revision was automatically updated to reflect the committed changes. Closed by commit rL337937: [CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49765?vs=1

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

phosek added a comment. In https://reviews.llvm.org/D42019#1162644, @mcgrathr wrote: > Is this still live? Should it be different after all the multiarch stuff? I'm about to revive this and was pondering if maybe we should generalize this to all targets now that the multiarch runtime bit has l

[PATCH] D49752: [CMake] Don't install c++abi headers in standalone libc++ build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337979: [CMake] Don't install c++abi headers in standalone libc++ build (authored by phosek, committed by ). Herald added

[PATCH] D49825: [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCXXA libc++abi https://reviews.llvm.org/D49825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D49834: [CMake] Don't generate linker script only when shared library isn't statically linked

phosek created this revision. phosek added reviewers: EricWF, ldionne, mclow.lists. Herald added subscribers: cfe-commits, christof, mgorny. Since r337668, we support statically linking dependencies only to shared or static library. However, that change hasn't updated the check whether to generate

[PATCH] D49834: [CMake] Don't generate linker script only when shared library isn't statically linked

This revision was automatically updated to reflect the committed changes. Closed by commit rL338006: [CMake] Don't generate linker script only when shared library isn't statically… (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D49899: Make test/Driver/fuchsia.c(pp) work with lld or gold

phosek requested changes to this revision. phosek added a comment. This revision now requires changes to proceed. We don't actively support gold in Fuchsia driver and currently have no plans on doing so. We should instead modify the driver to always use lld even if gold is set as the default Cla

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. I think we just ran into one such issue. We're using our own Clang that's usually following tip-of-tree and we recently switched to C++17, but that started failing on our macOS 10.12 bots with: Undefined symbols for architecture x86_64: "operator delete(void*, std:

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

phosek added a comment. This has been breaking our bots since it has landed (both Linux and macOS ones), here's a log: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8939527016533487696%2F%2B%2Fsteps%2Fclang%2F0%2Fsteps%2Fcheck-clang%2F0%2Fstdout In our Clan

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

phosek created this revision. phosek added reviewers: rsmith, mgrang, Hahnfeld. Herald added a subscriber: cfe-commits. Tests added r338294 implicitly assume that the libstdc++ is the standard C++ library and libgcc is the runtime library, but that's not the case when the user configures Clang to

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

phosek added a comment. This broke all our bots so I plan on submitting this if I don't hear back soon. Repository: rC Clang https://reviews.llvm.org/D50123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL338482: [OpenEmbedded] Explicitly specify -rtlib in tests (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50123?vs=158444

[PATCH] D50135: [libunwind] [CMake] Allow building standalone without any llvm-config available

phosek added inline comments. Comment at: CMakeLists.txt:363 -add_subdirectory(test) +if (EXISTS ${LLVM_CMAKE_PATH}) + add_subdirectory(test) libcxx seems to be using a different condition: `IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/test"`, should this be uni

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

phosek added a comment. This change broke the acquire+release case. Concretely, in Flutter we have this code: https://github.com/flutter/engine/blob/master/lib/ui/isolate_name_server/isolate_name_server.h#L26. This worked fine previously, but after this change we're getting an error in https:/

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

phosek added a comment. In https://reviews.llvm.org/D49355#1188520, @aaronpuchert wrote: > Could you explain what annotations like `LOCK_UNLOCK` are useful for? What do > they check? The annotation should certainly not be necessary. > > Shouldn't you just use `REQUIRES(!...)` or `EXCLUDES(...)`?

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead add_clang_executable

phosek created this revision. phosek added reviewers: klimek, sammccall, bkramer, hokein. Herald added subscribers: cfe-commits, mgorny. This makes it possible to include clang-include-fixer as distribution component when building Clang based toolchain using CMake. Repository: rCTE Clang Tools

[PATCH] D43404: [Fuchsia] Include libClang and clang-include-fixer in the toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. libClang is used by other Clang based tools such as cquery while clang-include-fixer is generally a useful tool. Repository: rC Clang https://reviews.llvm.org/D43404 F

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325381: [clang-include-fixer] Use add_clang_tool instead add_clang_executable (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43371?vs=134559&id=134691#toc Rep

[PATCH] D43545: [Driver] Make -fno-common default for Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added a subscriber: cfe-commits. We never want to generate common symbols on Fuchsia. Repository: rC Clang https://reviews.llvm.org/D43545 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/f

[PATCH] D43404: [Fuchsia] Include libClang and clang-include-fixer in the toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC325665: [Fuchsia] Include libClang and clang-include-fixer in the toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43404?vs=134687&id=135195#toc Reposit

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

phosek created this revision. phosek added reviewers: kcc, vitalybuka. Herald added a subscriber: cfe-commits. This allows reporting an error when user tries to use SafeStack with incompatible sanitizers. Repository: rC Clang https://reviews.llvm.org/D43606 Files: clang/lib/Driver/Sanitize

[PATCH] D43545: [Driver] Make -fno-common default for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL325945: [Driver] Make -fno-common default for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43545?vs=135193&id=

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

phosek updated this revision to Diff 136002. phosek marked an inline comment as done. Herald added subscribers: Sanitizers, llvm-commits. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D43606 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize.c Index: clang

  1   2   3   4   5   6   7   8   9   10   >