[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist added a comment. Sorry for the delay in replying. I'll try to respond to the various points you made: - I don't quite understand the first bullet, "more ways to initialize the resource dir". As far as I can see there's only one place it's set. If my change is using a "non-offic

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

madscientist added a comment. I built latest main with this patch applied and it does fix the issues in my environment. My headers that include xmmintrin.h etc. don't throw errors in clangd. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

madscientist added a comment. (just a note that another way to do this check is to look for some common intrinsic file in each directory generated by the compiler driver, and remove any directory containing those files. But, if the `-print-file-name=include` trick works reliably that's good to

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. madscientist published this revision for review. madscientist added a comment. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist added a comment. Thanks for adding Sam. I tried to do this but failed: his Phabricator handle isn't available in CODE_OWNERS.txt and my attempts to add him via his email address failed. I have no Phabricator fu! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION