@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
@@ -182,23 +231,12 @@ Example usage for a project using a compile commands
database:
{"index.js", "index_json.js"}};
if (Format == "html") {
-void *MainAddr = (void *)(intptr_t)GetExecutablePath;
-std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)
@@ -81,6 +81,12 @@ static llvm::cl::list UserStylesheets(
llvm::cl::desc("CSS stylesheets to extend the default styles."),
llvm::cl::cat(ClangDocCategory));
+static llvm::cl::opt
+UserAssetPath("asset",
+ llvm::cl::desc("User supplied asset path fo
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi commented:
This is getting pretty close, but there's a few things I'd like to iron out
before landing. Plus I believe this has a dependency on the `--assets` flag
changes.
https://github.com/llvm/llvm-project/pull/93928
___
@@ -0,0 +1,361 @@
+// RUN: rm -rf %t && mkdir -p %t/build %t/include %t/src %t/docs
ilovepi wrote:
I think this is a `.cp` file because it used to hold `main()`, right? Probably
just `basic-project.test` is fine. or `shape-project.test`. It's typical to use
a `
@@ -0,0 +1,361 @@
+// RUN: rm -rf %t && mkdir -p %t/build %t/include %t/src %t/docs
+// RUN: sed 's|$test_dir|%/t|g'
%S/Inputs/clang-doc-project1/database_template.json >
%t/build/compile_commands.json
+// RUN: cp %S/Inputs/clang-doc-project1/*.h %t/include
+// RUN: cp %S/Input
@@ -0,0 +1,361 @@
+// RUN: rm -rf %t && mkdir -p %t/build %t/include %t/src %t/docs
+// RUN: sed 's|$test_dir|%/t|g'
%S/Inputs/clang-doc-project1/database_template.json >
%t/build/compile_commands.json
+// RUN: cp %S/Inputs/clang-doc-project1/*.h %t/include
+// RUN: cp %S/Input
@@ -0,0 +1,17 @@
+[
+ {
+"directory": "$test_dir/build",
+"command": "clang++ -o Calculator.o -I../include
$test_dir/src/Calculator.cpp",
ilovepi wrote:
```suggestion
"command": "clang++ -o Calculator.o -I../include ../src/Calculator.cpp",
```
This
@@ -0,0 +1,17 @@
+[
+ {
+"directory": "$test_dir/build",
ilovepi wrote:
Would the following work? It would be really nice if we could make this operate
w/o the `sed` command.
```suggestion
"directory": "./build",
```
or
```suggestion
"directory": "
https://github.com/ilovepi commented:
I forgot to mention, that this needs some kind of test. Please add something
simple, like extra `RUN:` lines in the `SingleSource.cpp` test, that check the
diagnostics emitted when using/not using the `--assets` flag.
https://github.com/llvm/llvm-project/
ilovepi wrote:
> @ilovepi I minimised the failing issue from:
> https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/src/graphics/lib/compute/spinel/ext/transform_stack/transform_stack.c
> to:
>
> ```c++
> #include
> #include
>
> #define SPN_TRANSFORM_STACK_TAN(x_) tanf(x_)
>
> floa
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
@@ -0,0 +1,14 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
ilovepi wrote:
```suggestion
// RUN: rm -rf %t && mkdir %t
```
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
@@ -0,0 +1,14 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "" > %t/compile_flags.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp
-output=%t/docs > %t/output.txt
+// RUN: cat %t/output.txt | FileCheck %s --check-
@@ -0,0 +1,14 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "" > %t/compile_flags.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp
-output=%t/docs > %t/output.txt
+// RUN: cat %t/output.txt | FileCheck %s --check-
@@ -0,0 +1,188 @@
+// RUN: %clang -Wno-constant-conversion -Wno-array-bounds
-Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative
-Wno-int-to-pointer-cast -O0
-fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s
@@ -0,0 +1,41 @@
+// RUN: %clang -Wno-constant-conversion -Wno-array-bounds
-Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative
-Wno-int-to-pointer-cast -O0
-fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-si
@@ -0,0 +1,188 @@
+// RUN: %clang -Wno-constant-conversion -Wno-array-bounds
-Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative
-Wno-int-to-pointer-cast -O0
-fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s
@@ -182,23 +261,11 @@ Example usage for a project using a compile commands
database:
{"index.js", "index_json.js"}};
if (Format == "html") {
-void *MainAddr = (void *)(intptr_t)GetExecutablePath;
-std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)
@@ -131,12 +137,85 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+llvm::Error GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs:
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/95060
Reverts llvm/llvm-project#86609
This change causes compile-time regressions for stage2 builds
(https://llvm-compile-time-tracker.com/compare.php?from=3254f31a66263ea9647c9547f1531c3123444fcd&to=c5978f1eb5eeca861
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/95136
Reverts llvm/llvm-project#95060, and relands #86609, with the unintended code
generation changes addressed.
This patch implements the changes to LLVM IR discussed in
https://discourse.llvm.org/t/rfc-update-branc
https://github.com/ilovepi converted_to_draft
https://github.com/llvm/llvm-project/pull/95136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Still looking into the codegen issue, but I'd expect there's probably just 1-2
cases where I failed to update a pass to use APIs from ProfDataUtils.
https://github.com/llvm/llvm-project/pull/95136
___
cfe-commits mailing list
cfe-commit
ilovepi wrote:
> What is the summary of the new changes that address the compile time issue?
I'm still looking at that, that's why I marked it as a draft, but I suspect I
just missed updating
https://github.com/llvm/llvm-project/blob/163d036d64609bf59183664aec244da5078dc1f1/llvm/lib/IR/ProfDat
@@ -182,23 +261,11 @@ Example usage for a project using a compile commands
database:
{"index.js", "index_json.js"}};
if (Format == "html") {
-void *MainAddr = (void *)(intptr_t)GetExecutablePath;
-std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)
@@ -133,17 +133,17 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -127,16 +133,91 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -127,16 +133,91 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -127,16 +133,91 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -127,16 +133,91 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -182,23 +263,11 @@ Example usage for a project using a compile commands
database:
{"index.js", "index_json.js"}};
if (Format == "html") {
-void *MainAddr = (void *)(intptr_t)GetExecutablePath;
-std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM, modulo the one nit, and premerge checks passing.
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -127,16 +133,85 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
@@ -127,16 +133,85 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/95185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Jeez. IDK what I've done w/ SPR to do this, but I apologize.
https://github.com/llvm/llvm-project/pull/95185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/95185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/95187
While we copy the asset files, like index.js, into the correct location in the
install step, tests do not have access to those resources in the build
directory.
This patch copies the contents of the clang-doc/a
ilovepi wrote:
@petrhosek I'm pretty sure there's a better way to spell this, but I think we
need something similar to properly test clang-doc w/o an install step.
cc: @PeterChou1
https://github.com/llvm/llvm-project/pull/95187
___
cfe-commits mailin
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/95281
…f weights" #95136
Reverts #95060, and relands #86609, with the unintended code generation changes
addressed.
This patch implements the changes to LLVM IR discussed in
https://discourse.llvm.org/t/rfc-update-b
ilovepi wrote:
So, I think I made a mistake when I started the revert w/ the `revert` button.
That created a very long branch name, and I'm a bit concerned I can't update it
easily.
I'm about 80% sure `git push g...@github.com:llvm/llvm-project.git
HEAD:revert-95060-revert-86609-users/ilovepi
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/95136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/95281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -241,9 +264,11 @@ void scaleProfData(Instruction &I, uint64_t S, uint64_t T)
{
if (ProfDataName->getString() == "branch_weights" &&
ProfileData->getNumOperands() > 0) {
// Using APInt::div may be expensive, but most cases should fit 64 bits.
-APInt Val(128,
ilovepi wrote:
@nikic can you confirm the latest version doesn't regress anything? I tested
locally, and with the missing line, the text section is unchanged from the
previous commit.
https://github.com/llvm/llvm-project/pull/95281
___
cfe-commits ma
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/95281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -241,9 +264,11 @@ void scaleProfData(Instruction &I, uint64_t S, uint64_t T)
{
if (ProfDataName->getString() == "branch_weights" &&
ProfileData->getNumOperands() > 0) {
// Using APInt::div may be expensive, but most cases should fit 64 bits.
-APInt Val(128,
ilovepi wrote:
> > @petrhosek I'm pretty sure there's a better way to spell this, but I think
> > we need something similar to properly test clang-doc w/o an install step.
> > cc: @PeterChou1
>
> It looks like copy_directory_if_different is not available on windows
Ugh. I forgot to check the m
@@ -25,3 +25,11 @@ install(FILES ../assets/clang-doc-default-stylesheet.css
install(FILES ../assets/index.js
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
COMPONENT clang-doc)
+
+add_custom_target(copy-clang-doc-assets
ilovepi wrote:
OK, I’ll take a pass at
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/95187
>From 753c6d43e44911cc7478738f1fc5d95d5780dbda Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 12 Jun 2024 01:05:59 +
Subject: [PATCH 1/2] [clang-doc][cmake] Copy assets to build directory
While we copy
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/95187
>From 753c6d43e44911cc7478738f1fc5d95d5780dbda Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 12 Jun 2024 01:05:59 +
Subject: [PATCH 1/3] [clang-doc][cmake] Copy assets to build directory
While we copy
@@ -25,3 +25,11 @@ install(FILES ../assets/clang-doc-default-stylesheet.css
install(FILES ../assets/index.js
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
COMPONENT clang-doc)
+
+add_custom_target(copy-clang-doc-assets
ilovepi wrote:
I think this is address
@@ -25,3 +25,11 @@ install(FILES ../assets/clang-doc-default-stylesheet.css
install(FILES ../assets/index.js
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
COMPONENT clang-doc)
+
+add_custom_target(copy-clang-doc-assets
+COMMAND ${CMAKE_COMMAND} -E copy_directory
"${
https://github.com/ilovepi commented:
The files in the `Input` folder don't need a `clang-doc` prefix. They're
already under `test/clang-doc`
I'd also suggest renaming the folder from `project1` to something like
`basic-project`.
https://github.com/llvm/llvm-project/pull/93928
___
https://github.com/ilovepi commented:
Also, I'm not sure I understand the need for empty files. If we don't need
them, then lets remove them. If you need to use an empty file for some test,
you can create those w/ `touch` in the test itself, but I don't see those
referenced at all in `basic-pr
ilovepi wrote:
Petr and I spoke offline. https://github.com/llvm/llvm-project/pull/95187, is
still independently useful, since it matches our normal conventions about the
build directory matching the install directory.
I think we agree on it not being a fatal error, though if it can generate
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/95187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
ilovepi wrote:
```sugges
@@ -127,16 +135,85 @@ std::string getFormatString() {
// GetMainExecutable (since some platforms don't support taking the
// address of main, and some platforms can't implement GetMainExecutable
// without being given the address of a function in the main executable).
-std::str
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,8 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "" > %t/compile_flags.txt
+// RUN: cp "%s" "%t/test.cpp"
ilovepi wrote:
Why copy this file and rename it?
https://github.com/llvm/llvm-project/pull/94717
_
@@ -0,0 +1,14 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
ilovepi wrote:
These still seem to be different steps. combining them is intentional.
Actually, do you even need this directory? I don't think you do.
https://github.com/llvm/llvm-project/pull/94717
@@ -49,6 +49,8 @@
using namespace clang::ast_matchers;
using namespace clang::tooling;
using namespace clang;
+using DirIterator = llvm::sys::fs::directory_iterator;
ilovepi wrote:
There is a` DirIterator` in LLVM's VFS, and it is confusing to see you reuse
t
@@ -0,0 +1,8 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "" > %t/compile_flags.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp
-output=%t/docs > %t/output.txt
ilovepi wrote:
```suggestion
// R
@@ -0,0 +1,8 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "" > %t/compile_flags.txt
ilovepi wrote:
nit: remove. This isn't required. AFAICT its a clang-tidy/clangd thing.
https://github.com/llvm/llvm-project/pull/94717
__
@@ -0,0 +1,358 @@
+// RUN: rm -rf %t && mkdir -p %t/docs && mkdir -p %t/build
ilovepi wrote:
```suggestion
// RUN: rm -rf %t && mkdir -p %t/docs %t/build
```
you don't need to run `mkdir` twice.
https://github.com/llvm/llvm-project/pull/93928
__
@@ -299,8 +299,7 @@ Example usage for a project using a compile commands
database:
llvm::outs() << "Generating assets for docs...\n";
Err = G->get()->createResources(CDCtx);
if (Err) {
-llvm::errs() << toString(std::move(Err)) << "\n";
-return 1;
+llvm::outs(
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
Modulo a few small nits, this is LGTM. Once those are addressed and CI passes,
I can land this for you.
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lis
@@ -50,6 +50,7 @@ using namespace clang::ast_matchers;
using namespace clang::tooling;
using namespace clang;
+
ilovepi wrote:
nit: remove newline
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mai
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
ilovepi wrote:
This stil
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,2 +1,2 @@
// RUN: clang-doc --format=html --executor=standalone %s -output=%t/docs |
FileCheck %s
-// CHECK: Using default asset: {{.*}}..\share\clang
\ No newline at end of file
+// CHECK: Using default asset: {{.*}}{{[\\/]}}share{{[\\/]}}clang
ilovepi wr
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,2 @@
+// RUN: clang-doc --format=html --executor=standalone %s -output=%t/docs |
FileCheck %s
+// CHECK: Using default asset: {{.*}}%{pathsep}share%{pathsep}clang
ilovepi wrote:
The regular expression doesn't look right to me. I assume that `pathsep`
@@ -0,0 +1,2 @@
+// RUN: clang-doc --format=html --executor=standalone %s -output=%t/docs |
FileCheck %s
+// CHECK: Using default asset: {{.*}}%{pathsep}share%{pathsep}clang
ilovepi wrote:
hmm, maybe I've sent you down the wrong path. I don't know if the `%{path
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Hi, we're seeing a codegen issue building Fuchsia after this patch. I'm
looking now, but so far I'm not sure why this is happening. Would you mind
taking a look?
Error:
```
FAILED:
obj/src/graphics/lib/compute/spinel/ext/transform_stack/transform_stack.transform_stack.c.o
..
ilovepi wrote:
Thanks for the prompt revert. That's a big help.
> @ilovepi, How many platforms do you build Fuchsia for? It will be important
> to know which backends needs support before we try to re-land this.
Fuchsia builds for Aarch64, RISC-V 64, and X86_64. Our toolchain is also used
in
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi commented:
Modulo some nits, this seems fine to me. I'll leave approval to one of the code
owners, though, as I've had little to do w/ big integer code or UBSAN.
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commit
@@ -0,0 +1,188 @@
+// RUN: %clang -Wno-constant-conversion -Wno-array-bounds
-Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative
-Wno-int-to-pointer-cast -O0
-fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s
@@ -3318,6 +3350,20 @@ llvm::Constant
*CodeGenFunction::EmitCheckTypeDescriptor(QualType T) {
DiagnosticsEngine::ak_qualtype, (intptr_t)T.getAsOpaquePtr(),
StringRef(),
StringRef(), std::nullopt, Buffer, std::nullopt);
+ if (IsBitInt) {
+// The Structure is:
@@ -0,0 +1,188 @@
+// RUN: %clang -Wno-constant-conversion -Wno-array-bounds
-Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative
-Wno-int-to-pointer-cast -O0
-fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s
ilovepi wrote:
Can you update the title and description to match the normal format as
discussed previously? I see you've followed that in your subsequent commits,
but it isn't reflected there, probably because they're commits after the
initial one.
https://github.com/llvm/llvm-project/pull/93
@@ -0,0 +1,370 @@
+// RUN: mkdir -p %T/clang-doc/build
+// RUN: mkdir -p %T/clang-doc/include
+// RUN: mkdir -p %T/clang-doc/src
+// RUN: mkdir -p %T/clang-doc/docs
ilovepi wrote:
```suggestion
// RUN: mkdir -p %t/clang-doc/build
// RUN: mkdir -p %t/clang-doc/inc
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -188,6 +188,7 @@ Example usage for a project using a compile commands
database:
llvm::sys::path::native(ClangDocPath, NativeClangDocPath);
llvm::SmallString<128> AssetsPath;
AssetsPath = llvm::sys::path::parent_path(NativeClangDocPath);
+
ilovep
https://github.com/ilovepi requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,370 @@
+// RUN: mkdir -p %T/clang-doc/build
+// RUN: mkdir -p %T/clang-doc/include
+// RUN: mkdir -p %T/clang-doc/src
+// RUN: mkdir -p %T/clang-doc/docs
+// RUN: sed 's|$test_dir|%/T/clang-doc|g'
%S/Inputs/clang-doc-project1/database_template.json >
%T/clang-doc/buil
301 - 400 of 1144 matches
Mail list logo
