https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/72180
https://github.com/llvm/llvm-project/issues/70703 pointed out that cloning LLVM
modules could lead to miscompiles when using FatLTO.
This is due to an existing issue when cloning modules with labels (see #55991
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://githu
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/75079
Since FatLTO now uses the UnifiedLTO pipeline, we should not set the ThinLTO
module flag to true, since it may cause an assertion failure. See
https://github.com/llvm/llvm-project/issues/70703 for context.
>Fro
ilovepi wrote:
Hi, we're seeing some breakages, similar to the above in our debugger tests
with this patch.
A failing bot can be found here:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug/b8764552260903625809/overview
You can find a fuller discussion
ilovepi wrote:
Fantastic!
https://github.com/llvm/llvm-project/pull/71780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
I'm unclear on the specifics of the check, but it's probably something we can
adjust if that is the long-term solution.
CC @petrhosek Since he was interested in getting this resolved soon.
https://github.com/llvm/llvm-project/pull/71780
__
ilovepi wrote:
This looks great, thanks for keeping me in the loop. :)
https://github.com/llvm/llvm-project/pull/72730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/75296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/75296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
I think our Linux CI is seeing failures related to this patch:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8761705440671462977/overview
Profile-aarch64 :: instrprof-binary-correlate.c is failing on that bot for
both x86_64 and arm64.
http
ilovepi wrote:
Test output:
```
TEST 'Profile-aarch64 :: instrprof-binary-correlate.c'
FAILED
Exit Code: 1
Command Output (stdout):
--
Binary files
/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/compiler-rt/test/profile/Profi
ilovepi wrote:
Seems like a mismatch on the diff, so maybe the check is too stringent.
If this will take a while to fix, would you mind reverting until it can be
addressed?
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
ilovepi wrote:
Our next cI run should finish in about 25 minutes, so we'll find out soon.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8761696932167687409/overview
https://github.com/llvm/llvm-project/pull/69493
__
ilovepi wrote:
Well, seems like someone broke ToT w/ a compiler error. I'll let you know if
the forward fix fails to address the issue.
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
ilovepi wrote:
Indeed. Thank you!
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> Actually I'm going to go down the `Module::getCodeModel()` route. Right now I
> think frontends adding module metadata for the code model is probably not
> common, but we should aim for that. And this will in the short term still
> work for Fuchsia without breaking API for oth
ilovepi wrote:
well I guess I should say I thought it would be reliable rather than available,
but I see why it wouldn't be.
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM modulo one small comment in the test. Thanks for getting this done so
quickly.
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
@@ -0,0 +1,35 @@
+;; Check that certain globals are in large sections under x86-64 large code
model (but not in other arches).
+; RUN: opt %s -mtriple=x86_64-unknown-linux -passes=instrprof -S | FileCheck %s
ilovepi wrote:
The comment makes it sound like this sh
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 1/4] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
T
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 1/5] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
T
@@ -3107,6 +3136,41 @@ void RISCVAsmParser::emitLoadTLSGDAddress(MCInst &Inst,
SMLoc IDLoc,
RISCV::ADDI, IDLoc, Out);
}
+void RISCVAsmParser::emitLoadTLSDescAddress(MCInst &Inst, SMLoc IDLoc,
+MCStreamer &Out) {
@@ -3246,6 +3310,18 @@ bool RISCVAsmParser::checkPseudoAddTPRel(MCInst &Inst,
return false;
}
+bool RISCVAsmParser::checkPseudoTLSDESCCall(MCInst &Inst,
ilovepi wrote:
done
https://github.com/llvm/llvm-project/pull/66915
___
@@ -6843,6 +6845,24 @@ SDValue
RISCVTargetLowering::getDynamicTLSAddr(GlobalAddressSDNode *N,
return LowerCallTo(CLI).first;
}
+SDValue
+RISCVTargetLowering::getGeneralDynamicTLSDescAddr(GlobalAddressSDNode *N,
ilovepi wrote:
Well, AArch64 handles lowering
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 1/7] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
T
@@ -6843,6 +6845,24 @@ SDValue
RISCVTargetLowering::getDynamicTLSAddr(GlobalAddressSDNode *N,
return LowerCallTo(CLI).first;
}
+SDValue
+RISCVTargetLowering::getGeneralDynamicTLSDescAddr(GlobalAddressSDNode *N,
ilovepi wrote:
done.
https://github.com/llvm
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/75079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -810,7 +810,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
// Only enable CGProfilePass when using integrated assembler, since
// non-integrated assemblers don't recognize .cgprofile section.
PTO.CallGraphProfile = !CodeGenOpts.DisableIntegratedAS;
- PTO.Unifi
@@ -810,7 +810,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
// Only enable CGProfilePass when using integrated assembler, since
// non-integrated assemblers don't recognize .cgprofile section.
PTO.CallGraphProfile = !CodeGenOpts.DisableIntegratedAS;
- PTO.Unifi
@@ -810,7 +810,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
// Only enable CGProfilePass when using integrated assembler, since
// non-integrated assemblers don't recognize .cgprofile section.
PTO.CallGraphProfile = !CodeGenOpts.DisableIntegratedAS;
- PTO.Unifi
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/72180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -810,7 +810,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
// Only enable CGProfilePass when using integrated assembler, since
// non-integrated assemblers don't recognize .cgprofile section.
PTO.CallGraphProfile = !CodeGenOpts.DisableIntegratedAS;
- PTO.Unifi
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/2] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -810,7 +810,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
// Only enable CGProfilePass when using integrated assembler, since
// non-integrated assemblers don't recognize .cgprofile section.
PTO.CallGraphProfile = !CodeGenOpts.DisableIntegratedAS;
- PTO.Unifi
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/3] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -1861,6 +1861,13 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
if (Args.hasArg(OPT_funified_lto))
Opts.PrepareForThinLTO = true;
}
+ if (Arg *A = Args.getLastArg(options::OPT_ffat_lto_objects,
+
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/4] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -29,30 +29,31 @@ Overview
Within LLVM, FatLTO is supported by choosing the ``FatLTODefaultPipeline``.
This pipeline will:
-#) Clone the IR module.
-#) Run the pre-link (Thin)LTO pipeline using the cloned module.
+#) Run the pre-link UnifiedLTO pipeline on the current module
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/5] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/6] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
ilovepi wrote:
@nikic are there any other changes you'd like to see? otherwise, I plan to
rebase and land this later today.
https://github.com/llvm/llvm-project/pull/72180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/7] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -29,34 +29,42 @@ Overview
Within LLVM, FatLTO is supported by choosing the ``FatLTODefaultPipeline``.
This pipeline will:
-#) Clone the IR module.
-#) Run the pre-link (Thin)LTO pipeline using the cloned module.
+#) Run the pre-link UnifiedLTO pipeline on the current module
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6d971446fac3c65b1e7d48a7c9277b35133460ff Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/8] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/72180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/12] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
@@ -1722,6 +1722,35 @@ let hasSideEffects = 0, mayLoad = 0, mayStore = 0, Size
= 8, isCodeGenOnly = 0,
isAsmParserOnly = 1 in
def PseudoLA_TLS_GD : Pseudo<(outs GPR:$dst), (ins bare_symbol:$src), [],
"la.tls.gd", "$dst, $src">;
+let hasSideEffe
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/14] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
@@ -71,6 +71,18 @@ enum Fixups {
// Used to generate an R_RISCV_ALIGN relocation, which indicates the linker
// should fixup the alignment after linker relaxation.
fixup_riscv_align,
+ // 20-bit fixup corresponding to %tlsdesc_hi(foo) for instructions like
+ // auipc
+
@@ -597,7 +613,10 @@ struct RISCVOperand final : public MCParsedAsmOperand {
if (!isImm())
return false;
bool IsConstantImm = evaluateConstantImm(getImm(), Imm, VK);
-if (VK == RISCVMCExpr::VK_RISCV_LO || VK == RISCVMCExpr::VK_RISCV_PCREL_LO)
+if (VK == RI
@@ -188,3 +188,8 @@ addi a2, ft0, 24 # CHECK: :[[@LINE]]:10: error: invalid
operand for instruction
# fence.tso accepts no operands
fence.tso rw, rw # CHECK: :[[@LINE]]:11: error: invalid operand for instruction
+
+.Ltlsdesc_hi0:
+jalr x5, 0(a1), %tlsdesc_hi(.Ltlsdesc_hi0)
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/15] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66916
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/17] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66915
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/15] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/66916
>From ce9772dd519a62025cf545ded306bf40c75f2924 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 19 Sep 2023 20:53:54 +
Subject: [PATCH 01/17] [RISCV] Support Global Dynamic TLSDESC in the RISC-V
backend
@@ -151,9 +155,10 @@ Usage
To enable ShadowCallStack, just pass the ``-fsanitize=shadow-call-stack`` flag
to both compile and link command lines. On aarch64, you also need to pass
-``-ffixed-x18`` unless your target already reserves ``x18``. On RISC-V, ``x3``
-(``gp``) is alwa
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/68075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi commented:
Should the driver issue an error when using `-mforced-sw-shadow-stack` w/o
`Zicfiss`? As mentioned in-line, I'm not sure we can do that check, but it
feels like it should be incompatible.
https://github.com/llvm/llvm-project/pull/68075
@@ -57,11 +57,14 @@ compiled application or the operating system. Integrating
the runtime into
the operating system should be preferred since otherwise all thread creation
and destruction would need to be intercepted by the application.
-The instrumentation makes use of the p
ilovepi wrote:
The title should probably be changed to something like:
`[RISCV] Add Zicfiss support to the shadow call stack implementation`
The current title doesn't make much sense to me, but maybe I've misunderstood
the intent?
https://github.com/llvm/llvm-project/pull/68075
__
@@ -3,8 +3,8 @@
# Out of range immediates
## simm12
-flh ft1, -2049(a0) # CHECK: :[[@LINE]]:10: error: operand must be a symbol
with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
-fsh ft2, 2048(a1) # CHECK: :[[@LINE]]:10: error: operand must be a s
@@ -0,0 +1,44 @@
+# RUN: llvm-mc -filetype=obj -triple riscv32 < %s --defsym RV32=1 |
llvm-objdump -d -M no-aliases - | FileCheck %s --check-prefixes=INST,RV32
+# RUN: llvm-mc -filetype=obj -triple riscv64 < %s | llvm-objdump -d -M
no-aliases - | FileCheck %s --check-prefixes=I
@@ -71,6 +71,18 @@ enum Fixups {
// Used to generate an R_RISCV_ALIGN relocation, which indicates the linker
// should fixup the alignment after linker relaxation.
fixup_riscv_align,
+ // 20-bit fixup corresponding to %tlsdesc_hi(foo) for instructions like
+ // auipc
+
ilovepi wrote:
> The base branch can be edited if you click "Edit" near the title, which will
> help reveal the lld side changes...
hmm, I was hoping that would work, but the base branch is in my fork. I think
to make it work correctly I'd have to be using the "user" branches in the main
repo
ilovepi wrote:
@MaskRay , do you think this is worth abandoning in favor of
https://github.com/llvm/llvm-project/pull/77516? If so, I guess I'd also need
to abandon https://github.com/llvm/llvm-project/pull/66915, which is
unfortunate.
https://github.com/llvm/llvm-project/pull/66916
_
ilovepi wrote:
@topperc @MaskRay , do either of you have strong feelings about abandoning this
in favor of https://github.com/llvm/llvm-project/pull/77515? That PR was made
w/ `spr` and should be a bit easier to understand/review (since it won't have
merge or fixup commits) and will make the L
ilovepi wrote:
sounds good. I'll go ahead and close this in favor of
https://github.com/llvm/llvm-project/pull/77516 then, and leave the LLVM PR
alone.
https://github.com/llvm/llvm-project/pull/66916
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/66916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
As @MaskRay pointed out in #66916, there's a bit too much context in this
review, so please just ignore my earlier question about moving to a stacked PR.
https://github.com/llvm/llvm-project/pull/66915
___
cfe-commits mailing list
cfe-
Author: Paul Kirth
Date: 2022-03-29T00:14:07Z
New Revision: a427e18896dee3cd00d5f565cfb9d7d2f26ebcec
URL:
https://github.com/llvm/llvm-project/commit/a427e18896dee3cd00d5f565cfb9d7d2f26ebcec
DIFF:
https://github.com/llvm/llvm-project/commit/a427e18896dee3cd00d5f565cfb9d7d2f26ebcec.diff
LOG: [d
Author: Paul Kirth
Date: 2022-03-29T06:19:53Z
New Revision: 6c77972bac7ce125110ed2baea9919fb6866db39
URL:
https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39
DIFF:
https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39.diff
LOG: Re
Author: Paul Kirth
Date: 2022-04-20T18:29:40Z
New Revision: 61e36e87df1a4ad11f752d66c90e124101fe4023
URL:
https://github.com/llvm/llvm-project/commit/61e36e87df1a4ad11f752d66c90e124101fe4023
DIFF:
https://github.com/llvm/llvm-project/commit/61e36e87df1a4ad11f752d66c90e124101fe4023.diff
LOG: [s
Author: Paul Kirth
Date: 2022-04-21T21:58:24Z
New Revision: 414f84ba29d96c8cbbe198cfc022146e4582cbef
URL:
https://github.com/llvm/llvm-project/commit/414f84ba29d96c8cbbe198cfc022146e4582cbef
DIFF:
https://github.com/llvm/llvm-project/commit/414f84ba29d96c8cbbe198cfc022146e4582cbef.diff
LOG: [c
Author: Paul Kirth
Date: 2022-04-21T22:47:56Z
New Revision: b8786413d8007f6864f0dc55d95a09c232e3
URL:
https://github.com/llvm/llvm-project/commit/b8786413d8007f6864f0dc55d95a09c232e3
DIFF:
https://github.com/llvm/llvm-project/commit/b8786413d8007f6864f0dc55d95a09c232e3.diff
LOG: Re
Author: Paul Kirth
Date: 2022-07-22T17:36:30Z
New Revision: 30360d88d42214e75215145c4e73a74aaf93ddfd
URL:
https://github.com/llvm/llvm-project/commit/30360d88d42214e75215145c4e73a74aaf93ddfd
DIFF:
https://github.com/llvm/llvm-project/commit/30360d88d42214e75215145c4e73a74aaf93ddfd.diff
LOG: [c
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/80480
>From 043e8a33f10905d456e42b71801f0ab1b24a8b36 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 22 Aug 2023 15:24:03 +
Subject: [PATCH 1/6] [CMAKE] Enable FatLTO as a build option for LLVM
---
clang/cma
ilovepi wrote:
Not sure what I've managed to do here w/ basic rebase ... Will remove
unrelated folks and triage the commits
https://github.com/llvm/llvm-project/pull/80480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/80480
>From c0f09d9efd3836a83e72c329d17b32f7a87764b7 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 22 Aug 2023 15:24:03 +
Subject: [PATCH 1/4] [CMAKE] Enable FatLTO as a build option for LLVM
---
clang/cma
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/80480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/85677
We're seeing an issue on Macs, which shouldn't be using this config, so
we will temporarily disable this while we investigate.
>From 56e6059431398d126420b3595d58c3c19e20613b Mon Sep 17 00:00:00 2001
From: Paul K
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/85677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM. Thanks for the quick fix. I’ll try this out later today and let you know
if this completely solves the issue or if there is something else that may
still warrant investigating.
https://github.com/llvm/llvm-project/pull/86596
___
ilovepi wrote:
Well, its down to about 15 minutes from 1hr 40 min, which is a pretty great
improvement. 15 minutes does still seem to be too long for a file that's only
2KLOC. I know its more complex w/ headers and macros, but it does only take
about 1-2 minutes to compile normally, so I feel
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/86821
The existing JSON output from `--enable-profile` uses the check names as
keys in the object. This limits the machine readability of the output,
as each key is unique, forcing consumers to split and parse the
subst
https://github.com/ilovepi approved this pull request.
LGTM. Seems like all of my comments have been addressed. Thanks for the hard
work!
https://github.com/llvm/llvm-project/pull/68075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/81198
>From 3221a5e60c58e64dabdf23c52d33ba7ed5bdf81e Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 8 Feb 2024 14:21:49 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8?
ilovepi wrote:
Sounds good. I’ll update this when I have a chance tomorrow.
https://github.com/llvm/llvm-project/pull/81198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/81198
>From 3221a5e60c58e64dabdf23c52d33ba7ed5bdf81e Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 8 Feb 2024 14:21:49 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8?
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/81198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3,6 +3,11 @@
// RUN: %clang -### --target=riscv64-linux %s 2>&1 | FileCheck
--check-prefix=NODESC %s
// RUN: %clang -### --target=x86_64-linux -mtls-dialect=gnu %s 2>&1 |
FileCheck --check-prefix=NODESC %s
+/// Android supports TLSDESC by default after Android version 29
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/81198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/80480
>From 1946ea0be5b87da44e05a5e668e383c3c463cdd7 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 22 Aug 2023 15:24:03 +
Subject: [PATCH 1/3] [CMAKE] Enable FatLTO as a build option for LLVM
---
clang/cma
@@ -1251,6 +1253,10 @@ elseif(LLVM_ENABLE_LTO)
endif()
endif()
+if(LLVM_ENABLE_FATLTO AND (FUCHSIA OR UNIX))
+append("-ffat-lto-objects" CMAKE_EXE_LINKER_FLAGS
CMAKE_SHARED_LINKER_FLAGS)
ilovepi wrote:
done. Thanks for the suggestion.
https://github.c
@@ -740,7 +740,8 @@ bool tools::isTLSDESCEnabled(const ToolChain &TC,
SupportedArgument = V == "desc" || V == "trad";
EnableTLSDESC = V == "desc";
} else if (Triple.isX86()) {
-SupportedArgument = V == "gnu";
+SupportedArgument = V == "gnu" || V == "gnu2";
+
https://github.com/ilovepi commented:
I assume that's what you're doing in the place I asked for a comment is trying
to avoid redundantly generating TLSDESC accesses for _TLS_MODULE_BASE_. I see
that we don't generate multiple accesses for _TLS_MODULE_BASE_ in the test
cases, but I thought t
1 - 100 of 1108 matches
Mail list logo
