[clang] b4ad387 - [clang-format][doc] Fix C++ code blocks for IntegerLiteralSeparator

2023-01-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-11T13:24:39-08:00 New Revision: b4ad387ec558dc886c2ab85e4aea10c111cc83c0 URL: https://github.com/llvm/llvm-project/commit/b4ad387ec558dc886c2ab85e4aea10c111cc83c0 DIFF: https://github.com/llvm/llvm-project/commit/b4ad387ec558dc886c2ab85e4aea10c111cc83c0.diff LOG:

[clang] 2e2aa8b - [clang-format] Fix a bug in DerivePointerAlignment fallback

2023-01-13 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-13T12:58:33-08:00 New Revision: 2e2aa8bb6dea365e972528ad330f575b6b6e254b URL: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b DIFF: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b.diff LOG:

[clang] e3eca33 - [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

2023-01-13 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-13T15:46:34-08:00 New Revision: e3eca335940251308c8990c8880341002e74b9c1 URL: https://github.com/llvm/llvm-project/commit/e3eca335940251308c8990c8880341002e74b9c1 DIFF: https://github.com/llvm/llvm-project/commit/e3eca335940251308c8990c8880341002e74b9c1.diff LOG:

[clang] dadfc6b - [clang-format][NFC] Set LineEnding to LF in config files

2023-01-22 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-22T02:53:06-08:00 New Revision: dadfc6b38b00ff6e7c243ccc834f06d794a32b59 URL: https://github.com/llvm/llvm-project/commit/dadfc6b38b00ff6e7c243ccc834f06d794a32b59 DIFF: https://github.com/llvm/llvm-project/commit/dadfc6b38b00ff6e7c243ccc834f06d794a32b59.diff LOG:

[clang] a0dab49 - [clang-format][NFC] Add .clang-format to clang/tools/clang-format/

2023-01-22 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-22T02:59:23-08:00 New Revision: a0dab49508e377bdf1ad7af314e16a8a037bc589 URL: https://github.com/llvm/llvm-project/commit/a0dab49508e377bdf1ad7af314e16a8a037bc589 DIFF: https://github.com/llvm/llvm-project/commit/a0dab49508e377bdf1ad7af314e16a8a037bc589.diff LOG:

[clang] 02fd002 - [clang-format] Fix bugs in parsing C++20 module import statements

2023-01-23 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-23T14:35:15-08:00 New Revision: 02fd0020e5771b2850f892712b8fa51d3b98e270 URL: https://github.com/llvm/llvm-project/commit/02fd0020e5771b2850f892712b8fa51d3b98e270 DIFF: https://github.com/llvm/llvm-project/commit/02fd0020e5771b2850f892712b8fa51d3b98e270.diff LOG:

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto &foo, const auto &bar) {\n" - " return foo.

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Can you add test cases with `BreakConstructorInitializer` set to `AfterColon`? https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -1955,7 +1955,8 @@ void ContinuationIndenter::moveStatePastScopeCloser(LineState &State) { void ContinuationIndenter::moveStateToNewBlock(LineState &State) { if (Style.LambdaBodyIndentation == FormatStyle::LBI_OuterScope && - State.NextToken->is(TT_LambdaLBrace)) {

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22589,9 +22591,23 @@ TEST_F(FormatTest, FormatsLambdas) { verifyFormat("Namespace::Foo::Foo(LongClassName bar,\n" "AnotherLongClassName baz)\n" ": baz{baz}, func{[&] {\n" - " auto qux = bar;\n" -

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66893 Fixes #66857. >From a03878c28110c26c6119f3c5038640b01df3cfe0 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 03:54:09 -0700 Subject: [PATCH] [clang-format] Correctly annotate return type of functio

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66904 Fixes #66890. >From 95780df0571c27453b77e893e5020d9b451b0e6d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 05:56:27 -0700 Subject: [PATCH] [clang-format] Correctly annotate keyword operator funct

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto &foo, const auto &bar) {\n" - " return foo.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread Owen Pan via cfe-commits
owenca wrote: Please wait for @sstwcw. IMO it would be better to disable splitting string literals after `import`. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-22 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67218 None >From b00e6394bb1fe30be40e040b9201c4f3f1b28cd3 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 21:33:02 -0700 Subject: [PATCH] [clang-format][NFC] Clean up alignTrailingComments() --- clang/

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-22 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67221 Fixes #67116. >From 9fa6ed9430896ee9164260227f0791986c750f0f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 23:47:23 -0700 Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. LGTM, but please wait for @mydeveloperday. https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-24 Thread Owen Pan via cfe-commits
owenca wrote: Fixed in ff7e85402280. https://github.com/llvm/llvm-project/pull/67218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7db211b - [clang-format][NFC] Remove the unused separateDefinitionBlocks()

2023-09-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-24T19:25:23-07:00 New Revision: 7db211bda791e4326e380a57a882af20a273 URL: https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273 DIFF: https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273.diff LOG:

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca reopened https://github.com/llvm/llvm-project/pull/67221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67221 >From 8f9df29e1fdfdf49d4a420cc7ec7a28d6bba807f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 23:47:23 -0700 Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments Fixes #67116. -

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 38dd67c - [clang-format][NFC] Minor cleanup of the parser and annotator

2023-09-25 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-25T22:20:02-07:00 New Revision: 38dd67c8b3dbce4311e32a68d1100bd9f850c43e URL: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e DIFF: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e.diff LOG:

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-25 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67396 Replaced TT_AttributeParen with TT_AttributeLParen and TT_AttributeRParen. >From 32c071771910693e1ba739db32c0de212352e9d8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject: [PA

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-25 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67396 >From 3ae647542b80edb47bb2e47e87118be6a1bdbdec Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject: [PATCH] [clang-format] Split TT_AttributeParen Replaced TT_AttributeParen with

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Owen Pan via cfe-commits
owenca wrote: > Pinging @owenca. Waiting for one of @mydeveloperday @HazardyKnusperkeks @rymiel https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67422 Fixed #67407. >From 1c74983f9d2a16ab26d64624448df89e5fff87c4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 26 Sep 2023 05:17:25 -0700 Subject: [PATCH] [clang-format] Fix a bug in NamespaceEndCommentsFixer F

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67518 None >From 44165f4df433a668e4f4c2db730a66ce2acbc64b Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 26 Sep 2023 20:43:55 -0700 Subject: [PATCH] [clang-format] Handle __attribute/__declspec/AttributeMacro cons

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
owenca wrote: Ping @mydeveloperday @HazardyKnusperkeks @rymiel https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
owenca wrote: @HazardyKnusperkeks Np! Really appreciate your prompt reviews of so many clang-format patches! https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

2023-09-27 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67618 Fixed #67604. >From dfa92b41b74e554157467ea51f5db9dfcec4fcce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 27 Sep 2023 16:06:48 -0700 Subject: [PATCH] [clang-format] Don't align ctors and dtors with other f

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-28 Thread Owen Pan via cfe-commits
@@ -633,9 +637,10 @@ struct FormatToken { bool canBePointerOrReferenceQualifier() const { return isOneOf(tok::kw_const, tok::kw_restrict, tok::kw_volatile, - tok::kw___attribute, tok::kw__Nonnull, tok::kw__Nullable, + tok::kw__Nonnull,

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-28 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/67518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

2023-09-29 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-09-29 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67780 Fixed #66923. >From 4d65ac64140d39edb70ba64d88971819c2602ea7 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 29 Sep 2023 02:30:47 -0700 Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows Fixed

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-09-29 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67780 >From 40d12f082ac712ea4b967db5a981a9fd08ef7c54 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 29 Sep 2023 02:30:47 -0700 Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows Fixed #66923. --- c

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-29 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 36c1e56 - [clang-format][NFC] Simplify the UnwrappedLine constructor

2023-09-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-30T02:03:14-07:00 New Revision: 36c1e568bb4f8e482e3f713c8cb9460c5cf19863 URL: https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863 DIFF: https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863.diff LOG:

[clang] 511662b - [clang-format][NFC] Don't call startsSequence() in the parser

2023-09-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-30T02:09:52-07:00 New Revision: 511662b88c36f8d5d02f0b758b15c1b84d4ee6c1 URL: https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1 DIFF: https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1.diff LOG:

[clang] [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (PR #67911)

2023-10-01 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67911 Don't remove the outermost parentheses surrounding a return statement expression when inside a function/lambda that has the decltype(auto) return type. Fixed #67892. >From 561af2122a9155b44e340d89549b13b0ea9b2c

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-01 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67955 After annotating constructors/destructors as FunctionDeclarationName in commit 08630512088, we have seen several issues because ctors/dtors had been treated differently than functions in aligning, wrapping, and i

[clang] [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (PR #67911)

2023-10-02 Thread Owen Pan via cfe-commits
owenca wrote: @tru np! That was my intention anyways. https://github.com/llvm/llvm-project/pull/67911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67955 >From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 1 Oct 2023 23:01:30 -0700 Subject: [PATCH] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead After

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
owenca wrote: Can you add an issue to show the incorrect format before this patch? https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) { " a_longer_name_for_wrap}};", Alignment); - Alignment.ColumnLimit = 60; + Alignment = getLLVMStyleWithColumns(60); + Alignment.AlignConsecutiveAssig

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) { " a_longer_name_for_wrap}};", Alignment); - Alignment.ColumnLimit = 60; + Alignment = getLLVMStyleWithColumns(60); + Alignment.AlignConsecutiveAssig

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

2023-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
@@ -3447,9 +3447,13 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok = Tok->Next) { if (Tok->Previous->EndsCppAttributeGroup) AfterLastAttribute = Tok; -if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
@@ -16339,7 +16345,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { verifyFormat("int f();", SpaceFuncDef); verifyFormat("void f (int a, T b) {}", SpaceFuncDef); - verifyFormat("A::A () : a(1) {}", SpaceFuncDef); + verifyFormat("A::A() : a(1) {}", SpaceFuncDef);

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
@@ -3447,9 +3447,13 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok = Tok->Next) { if (Tok->Previous->EndsCppAttributeGroup) AfterLastAttribute = Tok; -if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/67955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
owenca wrote: > https://buildkite.com/llvm-project/clang-ci/builds/4275#018af20e-3d3c-4344-b92d-88ac8b09b484 > Tests do not pass? I saw that but don't know why. Did you have the same failures? I'll push another commit shortly to trigger buildkite again. https://github.com/llvm/llvm-project/pu

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67955 >From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 1 Oct 2023 23:01:30 -0700 Subject: [PATCH 1/2] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead Af

[clang] [clang-format][NFC] AlignTokens: Rename Changes[i] to CurrentChange (PR #68152)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] AlignTokenSequence: Rename Changes[i] to CurrentC… (PR #68153)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] AlignTokenSequence: Skip loop iteration (PR #68154)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. We should also update [this line](https://github.com/llvm/llvm-project/pull/68154/files#diff-13a957866eda585a177e1d10139b157956e9d82c40d2275b500c2b1bcb2ad8c0R452) to: ``` assert(Shift > 0 || Changes[i].NewlinesBefore > 0 || ``` https://

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d08fcc8 - Revert "[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)"

2023-10-03 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-03T18:19:23-07:00 New Revision: d08fcc817eba7f0186620688eee73f6d25fa90e8 URL: https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8 DIFF: https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8.diff LOG:

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

2023-10-03 Thread Owen Pan via cfe-commits
owenca wrote: Reverted in d08fcc817eba. https://github.com/llvm/llvm-project/pull/67955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8902f12 - [clang-format][doc] Update the Linux kernel coding style URL

2023-10-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-05T01:18:49-07:00 New Revision: 8902f12e61aa2d3053ad4d536e36569fc8bc9512 URL: https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512 DIFF: https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512.diff LOG:

[clang] 84cbd9f - [clang-format] Fix an error message

2023-10-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-05T19:24:08-07:00 New Revision: 84cbd9f4ffba17a74516d1afa442568dc54eabb1 URL: https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1 DIFF: https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1.diff LOG:

[clang] e4aa142 - [clang-format] Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-18 Thread Owen Pan via cfe-commits
Author: Sedenion Date: 2023-07-18T13:32:07-07:00 New Revision: e4aa1428a28dce38cd4712b5720baa333cbdd25b URL: https://github.com/llvm/llvm-project/commit/e4aa1428a28dce38cd4712b5720baa333cbdd25b DIFF: https://github.com/llvm/llvm-project/commit/e4aa1428a28dce38cd4712b5720baa333cbdd25b.diff LOG:

[clang] 0570cc5 - [clang-format] Fix indent for selective formatting

2023-07-18 Thread Owen Pan via cfe-commits
Author: Sedenion Date: 2023-07-18T14:10:53-07:00 New Revision: 0570cc568f5c8047267be7ab5056f8c4f45349b5 URL: https://github.com/llvm/llvm-project/commit/0570cc568f5c8047267be7ab5056f8c4f45349b5 DIFF: https://github.com/llvm/llvm-project/commit/0570cc568f5c8047267be7ab5056f8c4f45349b5.diff LOG:

[clang] 5c106f7 - [clang-format] Add TypeNames option to disambiguate types/objects

2023-07-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-18T14:18:40-07:00 New Revision: 5c106f7b947e514852402ad5678c0ebf70ce91b1 URL: https://github.com/llvm/llvm-project/commit/5c106f7b947e514852402ad5678c0ebf70ce91b1 DIFF: https://github.com/llvm/llvm-project/commit/5c106f7b947e514852402ad5678c0ebf70ce91b1.diff LOG:

[clang] 8f54b83 - [clang-format][doc] Replace single back quotes with double ones

2023-07-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-18T18:27:15-07:00 New Revision: 8f54b8331f9f083220eab06fe903b47115441dbe URL: https://github.com/llvm/llvm-project/commit/8f54b8331f9f083220eab06fe903b47115441dbe DIFF: https://github.com/llvm/llvm-project/commit/8f54b8331f9f083220eab06fe903b47115441dbe.diff LOG:

[clang] 2f6b2da - [clang-format] Insert namespace comments with leading spaces

2023-07-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-24T09:22:51-07:00 New Revision: 2f6b2dafb78345b3013797096e8e71677710ce48 URL: https://github.com/llvm/llvm-project/commit/2f6b2dafb78345b3013797096e8e71677710ce48 DIFF: https://github.com/llvm/llvm-project/commit/2f6b2dafb78345b3013797096e8e71677710ce48.diff LOG:

[clang] 4ba0084 - [clang-format] Add AlignConsecutiveShortCaseStatements

2023-07-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-24T18:16:21-07:00 New Revision: 4ba00844174db562d2bd8b15dab6aac605eddf57 URL: https://github.com/llvm/llvm-project/commit/4ba00844174db562d2bd8b15dab6aac605eddf57 DIFF: https://github.com/llvm/llvm-project/commit/4ba00844174db562d2bd8b15dab6aac605eddf57.diff LOG:

[clang] 4f093b3 - Revert "[clang-format] Add AlignConsecutiveShortCaseStatements"

2023-07-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-24T18:19:38-07:00 New Revision: 4f093b31669a4f8e417259583141159586a05b28 URL: https://github.com/llvm/llvm-project/commit/4f093b31669a4f8e417259583141159586a05b28 DIFF: https://github.com/llvm/llvm-project/commit/4f093b31669a4f8e417259583141159586a05b28.diff LOG:

[clang] ac6e551 - Revert "Revert "[clang-format] Add AlignConsecutiveShortCaseStatements""

2023-07-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-24T18:24:30-07:00 New Revision: ac6e55146f8c48f8ced95dfe54004142c0b36756 URL: https://github.com/llvm/llvm-project/commit/ac6e55146f8c48f8ced95dfe54004142c0b36756 DIFF: https://github.com/llvm/llvm-project/commit/ac6e55146f8c48f8ced95dfe54004142c0b36756.diff LOG:

[clang] 87ad34f - Revert "[clang-format] Add AlignConsecutiveShortCaseStatements"

2023-07-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-24T18:37:42-07:00 New Revision: 87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc URL: https://github.com/llvm/llvm-project/commit/87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc DIFF: https://github.com/llvm/llvm-project/commit/87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc.diff LOG:

[clang] 74720d1 - [clang-format] Add AlignConsecutiveShortCaseStatements

2023-07-24 Thread Owen Pan via cfe-commits
Author: Galen Elias Date: 2023-07-24T18:39:25-07:00 New Revision: 74720d1b338efb0725dd80bf3e59069700f6e2f0 URL: https://github.com/llvm/llvm-project/commit/74720d1b338efb0725dd80bf3e59069700f6e2f0 DIFF: https://github.com/llvm/llvm-project/commit/74720d1b338efb0725dd80bf3e59069700f6e2f0.diff L

[clang] c669541 - [clang-format] Add SpacesInParens with SpacesInParensOptions

2023-07-24 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-07-24T19:27:23-07:00 New Revision: c669541c969c70190933b4a16384c60de80242c0 URL: https://github.com/llvm/llvm-project/commit/c669541c969c70190933b4a16384c60de80242c0 DIFF: https://github.com/llvm/llvm-project/commit/c669541c969c70190933b4a16384c60de80242c0.diff

[clang] 2b8542c - [clang-format] Correctly count annoated lines of a namespace body

2023-08-10 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-10T15:55:01-07:00 New Revision: 2b8542ce8e8c24dfcdd0433542cf733556b8 URL: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8 DIFF: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8.diff LOG:

[clang] 063c42e - [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

2023-08-16 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-16T10:45:54-07:00 New Revision: 063c42e919c01d7e64c1af5a10898fc84b06dfe8 URL: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8 DIFF: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8.diff LOG:

[clang] e3a7950 - [clang-format] Exclude kw_decltype in RemoveParentheses

2023-08-17 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-17T16:04:44-07:00 New Revision: e3a79503a30f8c9d8fba79f3e5427bb895f320cf URL: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf DIFF: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf.diff LOG:

[clang] 07181e2 - [clang-format][NFC] Simplify getFirstNonComment() in the annotator

2023-08-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-18T13:23:47-07:00 New Revision: 07181e289e3c6296ed5e982dca0764b91acbb8e6 URL: https://github.com/llvm/llvm-project/commit/07181e289e3c6296ed5e982dca0764b91acbb8e6 DIFF: https://github.com/llvm/llvm-project/commit/07181e289e3c6296ed5e982dca0764b91acbb8e6.diff LOG:

[clang] 3364d76 - [clang-format][doc] Don't use the ".0" suffix on version numbers

2023-08-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-18T14:57:43-07:00 New Revision: 3364d7620ef78c6e9f04c63e62ac6b0801090ea5 URL: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5 DIFF: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5.diff LOG:

[clang] Annotate enum r brace (PR #68535)

2023-10-08 Thread Owen Pan via cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?= Message-ID: In-Reply-To: https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] Annotate enum r brace (PR #68535)

2023-10-08 Thread Owen Pan via cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?= Message-ID: In-Reply-To: owenca wrote: See https://github.com/llvm/llvm-project/issues/56636. https://github.com/llvm/llvm-project/pull/68535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang-format][NFC] Annotate more r_braces (PR #68534)

2023-10-08 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 42c564d - [clang-format][NFC] Make InsertNewlineAtEOF a little more efficient

2023-10-09 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-09T01:09:45-07:00 New Revision: 42c564df2f479efb38e6f02340e370815b439eb1 URL: https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1 DIFF: https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1.diff LOG:

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-10 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-10 Thread Owen Pan via cfe-commits
@@ -2756,6 +2756,10 @@ FormatToken *UnwrappedLineParser::parseIfThenElse(IfStmtKind *IfKind, CompoundStatementIndenter Indenter(this, Style, Line->Level); parseBlock(/*MustBeDeclaration=*/false, /*AddLevels=*/1u, /*MunchSemi=*/true, KeepIfBraces, &IfBloc

<    3   4   5   6   7   8   9   10   11   12   >