[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From 19e6556e0fb0add28c502bb82543bcdf820c1877 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH] [Clang] prevent recovery call expression from proceeding with

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From 19e6556e0fb0add28c502bb82543bcdf820c1877 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH] [Clang] prevent recovery call expression from proceeding with

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] prevented assertion failure by handling integral to boolean conversions for boolean vectors (PR #108657)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/108657 >From 70d1be2a2a0f2f44cdd70bfb4397e7a36f1c9f30 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 14 Sep 2024 01:46:28 +0300 Subject: [PATCH 1/3] [Clang] prevented assertion failure by handling integral t

[clang] [Clang] prevented assertion failure by handling integral to boolean conversions for boolean vectors (PR #108657)

@@ -51,6 +53,9 @@ static void test(void) { ivec4 -= ivec4; ivec4 |= ivec4; ivec4 += ptr; // expected-error {{cannot convert between vector and non-scalar values ('int4' (vector of 4 'int' values) and 'int *')}} + +bvec4 != 0; // expected-warning {{inequality co

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

a-tarasyuk wrote: @erichkeane thanks for the feedback https://github.com/llvm/llvm-project/pull/107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevented assertion failure by handling integral to boolean conversions for boolean vectors (PR #108657)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/108657 >From 70d1be2a2a0f2f44cdd70bfb4397e7a36f1c9f30 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 14 Sep 2024 01:46:28 +0300 Subject: [PATCH 1/2] [Clang] prevented assertion failure by handling integral t

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From 8774b4b073b5ebb52bdf35a7c44c613c6fcf56fc Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 13 Sep 2024 17:55:15 +0300 Subject: [PATCH] [Clang] prevent recovery call expression from proceeding with

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH] [Clang] omit parentheses in fold expressions with a single expa

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/110761 Fixes #101863 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH] [Clang] omit parentheses in fold expressions with

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH] [Clang] omit parentheses in fold expressions with a single expa

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 1/3] [Clang] omit parentheses in fold expressions with a single

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/110761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

@@ -15598,6 +15598,9 @@ TreeTransform::TransformCXXFoldExpr(CXXFoldExpr *E) { return getDerived().RebuildEmptyCXXFoldExpr(E->getEllipsisLoc(), E->getOperator()); + if (*NumExpansions == 1) a-tarasyuk wrote:

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 1/2] [Clang] omit parentheses in fold expressions with a single

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 1/4] [Clang] omit parentheses in fold expressions with a single

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 1/4] [Clang] omit parentheses in fold expressions with a single

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 1/5] [Clang] omit parentheses in fold expressions with a single

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

@@ -122,35 +122,34 @@ void test() { #undef EQ } -void (*fn)(); - -void test2() { a-tarasyuk wrote: It looks like I accidentally removed them — I'm sorry for the confusion. I’ve pushed a revert. https://github.com/llvm/llvm-project/pull/110761 __

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/7] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/5] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

@@ -185,3 +185,27 @@ template struct S { friend void X::f(T::type); }; } + +namespace GH113324 { +template struct ct { + friend void f1(ct, int = 0); // expected-error {{friend declaration specifying a default argument must be a definition}} + friend void f2

[clang] [Clang] skip default argument instantiation for non-defining friend declarations without specialization info to meet [dcl.fct.default] p4 (PR #113777)

https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] skip default argument instantiation for non-defining friend declarations without specialization info to meet [dcl.fct.default] p4 (PR #113777)

a-tarasyuk wrote: @zyn0217 done https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] skip default argument instantiation for non-defining friend declarations without specialization info to meet [dcl.fct.default] p4 (PR #113777)

a-tarasyuk wrote: @mizvekov thanks https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] skip default argument instantiation for non-defining friend declarations without specialization info to meet [dcl.fct.default] p4 (PR #113777)

a-tarasyuk wrote: @alanzhao1 thanks for catching that. should I revert it? https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/4] [Clang] fix range calculation for conditionals with throw

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/4] [Clang] fix range calculation for conditionals with throw

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

@@ -9582,8 +9582,10 @@ static QualType GetExprType(const Expr *E) { ///particular, assume that arithmetic on narrower types doesn't leave ///those types. If \c false, return a range including all possible ///result values. a-tarasyuk wro

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/4] [Clang] fix range calculation for conditionals with throw

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/4] [Clang] fix range calculation for conditionals with throw

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

@@ -11536,6 +11536,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( LValue Subobject = This; Subobject.addArray(Info, ExprToVisit, CAT); auto Eval = [&](const Expr *Init, unsigned ArrayIndex) { +if (Init->isValueDependent()) a-tarasyuk

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

@@ -39,7 +39,8 @@ bool Sema::SetMemberAccessSpecifier(NamedDecl *MemberDecl, AccessSpecifier LexicalAS) { if (!PrevMemberDecl) { // Use the lexical access specifier. -MemberDecl->setAccess(LexicalAS); a-tarasyuk wro

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

@@ -9827,6 +9827,9 @@ static IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth, return IntRange(BitField->getBitWidthValue(C), BitField->getType()->isUnsignedIntegerOrEnumerationType()); a-tarasyuk wrote: @shafik G

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/112424 Fixes #112208 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH] [Clang] prevent setting default lexical access

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/4] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent assertion failure from an invalid template instantiation pattern when adding instantiated params to the scope in friend functions with defaulted params (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/3] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

@@ -8236,11 +8236,14 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, DeclContext *NewDC = D->getDeclContext(); if (FieldDecl *FD = dyn_cast(ShadowedDecl)) { -// Fields are not shadowed by variables in C++ static methods. -if (CXXMethodDecl *MD = d

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/3] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

@@ -3430,15 +3430,17 @@ bool Sema::SubstDefaultArgument( ContextRAII SavedContext(*this, FD); std::unique_ptr LIS; -if (ForCallExpr) { +FunctionDecl *PatternFD = +ForCallExpr +? FD->getTemplateInstantiationPattern(/*ForDefinition*/ false) +

[clang] [Clang] prevent assertion failure from an invalid template instantiation pattern when adding instantiated params to the scope in friend functions with defaulted params (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/4] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

@@ -185,3 +185,21 @@ template struct S { friend void X::f(T::type); }; } + +namespace GH113324 { +template struct ct { + friend void f1(ct, int = 0); // expected-error {{friend declaration specifying a default argument must be a definition}} + friend void f2

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 2ef4cc6c16d2217053f90fe4c3d2f251a52e0c60 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Thu, 7 Nov 2024 15:14:05 +0200 Subject: [PATCH] [Clang] skip default argument instantiation for non-defining fr

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

a-tarasyuk wrote: @zyn0217 should all the commits be squashed into one? https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

a-tarasyuk wrote: @mizvekov @zyn0217 if no additional reviews are needed, could someone please merge it? thanks https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/113777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/7] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/4] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/6] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] Ensure default arguments in friend declarations are only allowed in defining declarations to prevent multiple reachable declarations (PR #113777)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH 1/6] [Clang] prevent assertion failure from an invalid template

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/115558 >From f63263a1aa4873a63918649ea92352eb5cfe66eb Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 9 Nov 2024 00:41:13 +0200 Subject: [PATCH 1/3] [Clang] skip warnings for constructors marked with the [[no

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

@@ -555,6 +555,8 @@ Improvements to Clang's diagnostics getS(); // Now diagnoses "Reason 2", previously diagnoses "Reason 1" } +- Clang now omits warnings for constructors marked with the ``[[noreturn]]`` attribute (#GH63009). a-tarasyuk wrote: @Si

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

@@ -49,3 +49,15 @@ void check() { test_type(g); test_type(h); // expected-note {{instantiation}} } + +namespace GH63009 { +struct S { + [[noreturn]] S() { throw int {}; } +}; + +int test_no_return_constructor() { S(); } // ok a-tarasyuk wrote: @AaronBallm

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/5] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/6] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/6] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

@@ -32,6 +32,26 @@ void test_invalid_call(int s) { int var = some_func(undef1); } +int some_func2(int a, int b); +void test_invalid_call_2() { + // CHECK: `-RecoveryExpr {{.*}} 'int' contains-errors + // CHECK-NEXT: |-UnresolvedLookupExpr {{.*}} '' lvalue (ADL) = 'some_

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/118041 Fixes #113659 >From 59fa1de4e6638f1c8bba39e2e55c43cb3991fc3c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 29 Nov 2024 02:54:53 +0200 Subject: [PATCH] [Clang] fix crash due to incorrect argument pos

[clang] Reland [Clang] skip default argument instantiation for non-defining friend declarations to meet [dcl.fct.default] p4 (PR #115487)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/115487 >From 5e24d212f797b5fa1b6da1526c807046373d3c21 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 8 Nov 2024 16:13:17 +0200 Subject: [PATCH 1/6] [Clang] skip default argument instantiation for non-definin

[clang] [Clang] replace 'bitfield' with 'bit-field' for consistency (PR #117881)

https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/117881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] skip consumed analysis for consteval conditions in control-flow terminators (PR #117403)

https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/117403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/118041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/116513 >From 69689f6ba5ac1715cc1df6cf08b79bb4b8bbe107 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 17 Nov 2024 01:34:42 +0200 Subject: [PATCH] [Clang] avoid adding consteval condition as the last statement

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/115558 >From f63263a1aa4873a63918649ea92352eb5cfe66eb Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 9 Nov 2024 00:41:13 +0200 Subject: [PATCH] [Clang] skip warnings for constructors marked with the [[noretu

[clang] Reland [Clang] skip default argument instantiation for non-defining friend declarations to meet [dcl.fct.default] p4 (PR #115487)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/115487 >From 5e24d212f797b5fa1b6da1526c807046373d3c21 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 8 Nov 2024 16:13:17 +0200 Subject: [PATCH 1/2] [Clang] skip default argument instantiation for non-definin

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/3] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH] [Clang] enhance error recovery with RecoveryExpr for trailing c

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/115558 >From f63263a1aa4873a63918649ea92352eb5cfe66eb Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 9 Nov 2024 00:41:13 +0200 Subject: [PATCH] [Clang] skip warnings for constructors marked with the [[noretu

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/116513 >From 69689f6ba5ac1715cc1df6cf08b79bb4b8bbe107 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 17 Nov 2024 01:34:42 +0200 Subject: [PATCH 1/2] [Clang] avoid adding consteval condition as the last state

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/116513 >From 69689f6ba5ac1715cc1df6cf08b79bb4b8bbe107 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 17 Nov 2024 01:34:42 +0200 Subject: [PATCH 1/2] [Clang] avoid adding consteval condition as the last state

[clang] [Clang] avoid adding consteval condition as the last statement to preserve valid CFG (PR #116513)

@@ -5,3 +5,9 @@ static_assert(__is_same(decltype([] constexpr -> int { }( )), int)); // expected consteval int g() { } // expected-warning {{non-void function does not return a value}} static_assert(__is_same(decltype([] consteval -> int { }( )), int)); // expected-warning

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/4] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] skip warnings for constructors marked with the [[noreturn]] attribute (PR #115558)

@@ -49,3 +49,15 @@ void check() { test_type(g); test_type(h); // expected-note {{instantiation}} } + +namespace GH63009 { +struct S { + [[noreturn]] S() { throw int {}; } +}; + +int test_no_return_constructor() { S(); } // ok a-tarasyuk wrote: > Can you a

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

@@ -8236,11 +8236,14 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, DeclContext *NewDC = D->getDeclContext(); if (FieldDecl *FD = dyn_cast(ShadowedDecl)) { -// Fields are not shadowed by variables in C++ static methods. -if (CXXMethodDecl *MD = d

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/3] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/2] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/4] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/5] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114684 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH 1/2] [Clang] enhance error recovery with RecoveryExpr for traili

[clang] [Clang] update reasoned delete diagnostic kind to use Extension, making it pedantic only (PR #114713)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114713 >From c07fa270194eadde3ccecab368b2225702fc2e63 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 3 Nov 2024 19:22:56 +0200 Subject: [PATCH 1/2] [Clang] update reasoned delete diagnostic kind to use Exten

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/3] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/114813 >From 91ff2b4226110ea35c78f0f1b6ff89b4bec2c788 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 4 Nov 2024 17:38:46 +0200 Subject: [PATCH 1/5] [Clang] eliminate shadowing warnings for parameters using d

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

@@ -0,0 +1,13 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c++2b -Wshadow-all %s + +namespace GH95707 { +struct Foo { + int a; // expected-note {{previous declaration is here}} + + void f1(this auto &self, int a) { self.a = a; } + void f2(int a) { } // expected-warning {{d

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/114813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

@@ -2890,8 +2890,9 @@ Decl *Parser::ParseDeclarationAfterDeclaratorAndAttributes( // ProduceConstructorSignatureHelp only on VarDecls. ExpressionStarts = SetPreferredType; } - -bool SawError = ParseExpressionList(Exprs, ExpressionStarts); +bool HasTrail

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/114813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   8   9   10   >