[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Anyways, I rebased the old version of the patch locally so that I could generate an interdiff, which I'll attach for reference: ```diff diff --git a/clang-tools-extra/clangd/Config.h b/clang-tools-extra/clangd/Config.h index 12ed1420c93e..3559591fce00 100644 --- a/clang

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (In the future, it would greatly help me as a reviewer if rebases are pushed separately from updates to address review comments, so that the latter get their own Compare link.) https://github.com/llvm/llvm-project/pull/67749 ___

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > It's sad that there's not a single codepath that would handle all these, > > but maybe the perfect is the enemy of the good here. > > The code duplication was my reason for looking at the common path. If you're > fine with duplicating the code I will go ahead and do t

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > @HighCommander4 Thanks for the review. I've updated the comments, but don't > have merge access, could you merge this? Thanks Done https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] [clangd] Attempt to fix https://github.com/clangd/clangd/issues/1536 (PR #79448)

2024-01-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > However, this doesn't seem to change the behavior in vscode: I applied the patch locally, and it does have _an_ effect on the steps from #1536 (running `Auto fix` with code containing multiple diagnostics selected): * before, it would show a message saying no fixes are

[clang-tools-extra] [clangd] Attempt to fix https://github.com/clangd/clangd/issues/1536 (PR #79448)

2024-01-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: I read up on this a bit; https://github.com/Microsoft/vscode/issues/62110 seems particularly relevant. Based on [this comment](https://github.com/Microsoft/vscode/issues/62110#issuecomment-456240329): > [...] we have an `auto fix` action in the editor that fixes individu

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > (A drive-by comment: I stumbled on the commit message of this PR and found it > surprising that I'm the co-author of it! I'm not entirely clear on GitHub's > schemas, but IMO shouldn't the co-author be the one who clicks the "merge" > button?) The reason is that one of

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-29 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Linking to the issue this is seeking to address for reference: https://github.com/clangd/clangd/issues/1589 https://github.com/llvm/llvm-project/pull/78454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-29 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks, the approach in this patch looks pretty good to me. My only feedback is to encapsulate the "hard coding" into a function like: ``` Option TryConvertToRename(const Diag *D, const Fix *F) ``` because I can imagine in the future coming across o

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

2024-01-29 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: @sam-mccall review ping :) I would particularly appreciate feedback on whether I should plan to set aside some time to implement the "deep lookup optimization" (from [this comment](https://reviews.llvm.org/D93829#4258101)), or whether the 2.5% increase in index memory us

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2024-01-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2024-01-12 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > Thank you for the review. Since I don't have permission to commit the change, > could you merge this on my behalf? Sure, done. https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang-tools-extra] [clang] [clangd] Handle an expanded token range that ends in the `eof` token in TokenBuffer::spelledForExpanded() (PR #78092)

2024-01-14 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/78092 Such ranges can legitimately arise in the case of invalid code, such as a declaration missing an ending brace. >From 26a11f5fa7e79c85bac5cf92048194212b957b0a Mon Sep 17 00:00:00 2001 From: Nathan Ridge D

[clang-tools-extra] [clang] [clangd] Handle an expanded token range that ends in the `eof` token in TokenBuffer::spelledForExpanded() (PR #78092)

2024-01-14 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Based on previous discussion and analysis in https://github.com/llvm/llvm-project/pull/69849 https://github.com/llvm/llvm-project/pull/78092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

2024-01-14 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > What do you think about this as an alternative: if `spelledForExpanded` > receives as input an expanded token range `[firstExpanded, lastExpanded]` > where `lastExpanded` is the `eof` token, return the spelled tokens > corresponding to `[firstExpanded, lastExpanded - 1]

[clang-tools-extra] [clang] [clangd] Handle an expanded token range that ends in the `eof` token in TokenBuffer::spelledForExpanded() (PR #78092)

2024-01-14 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/78092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-17 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/78466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clangd] Handle an expanded token range that ends in the `eof` token in TokenBuffer::spelledForExpanded() (PR #78092)

2024-01-17 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/78092 >From 25449579788db640d5f636e82c429aa7d459bbbc Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 9 Jan 2024 18:56:10 -0500 Subject: [PATCH] [clangd] Handle an expanded token range that ends in the `e

[clang-tools-extra] [clang] [clangd] Handle an expanded token range that ends in the `eof` token in TokenBuffer::spelledForExpanded() (PR #78092)

2024-01-17 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/78092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

2024-01-17 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/69849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

2024-01-17 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Superseded by #78092. Thanks for putting together this patch, @robozati. While we didn't go with the fix approach taken in this patch, it did prod me to look at the issue in more detail :laughing: https://github.com/llvm/llvm-project/pull/69849 _

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-21 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/78925 guessLanguage() uses UnwrappedLineParser to process different preprocessor variants of a file. For large files with many preprocessor branches, the number of variants can be very large and the operation c

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-21 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: A few additional notes: * I chose the value `1 << 20` for `MaxLinesToProcess` empirically to get `guessLanguage()` to return in about 1 second on my (average-for-a-developer-machine) hardware. I don't feel strongly about the value and I'm happy to go with a different on

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-21 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > > What is the relationship between this patch, and clangd 17's ["missing > > > include" > > > warning](https://clangd.llvm.org/guides/include-cleaner#missing-include-warning)? > > > Does the quick-fix for the "missing include" warning also respect these > > > config

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-21 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > @HighCommander4 @sam-mccall do you have any capacity to review this change? I'm happy to try and help, but I haven't really been involved in the development of the include-cleaner component, and based on the findings in my previous comment, the patch would benefit from

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/78925 >From 47ebe97c199ade54a9538eaed02171d78e6a5a46 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sun, 21 Jan 2024 02:45:16 -0500 Subject: [PATCH] [clang-format] Limit how much work guessLanguage() can do

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-22 Thread Nathan Ridge via cfe-commits
@@ -243,6 +247,14 @@ void UnwrappedLineParser::parse() { Callback.consumeUnwrappedLine(Line); } Callback.finishRun(); +TotalLinesProcessed += Lines.size(); +if ((TotalLinesProcessed / 1) > LastReport) { HighCommander4 wrote: My bad, I

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-22 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > Can we write a unit test for this? I'm open to trying but there are a few open questions in my mind: * Is it fine if the failure mode of a testcase is triggering an OOM? * Triggering the problematic codepath requires a combination of a large file (thousands of lines)

[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

2024-01-22 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > couldn't we just use the .clang-format-ignore file to say... hey don't bother > with this file, we can't do it... I think that's a good solution for avoiding the OOM when actually trying to format the file, in combination with this patch for avoiding the OOM in `guessL

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: I took a pass through the implementation. Generally looks good. Would be nice to have a test that exercises the include insertion process in a more end-to-end way. I think something in `CodeCompleteTests.cpp` would work, using `WithContextValue` to

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
@@ -211,10 +214,12 @@ class IncludeInserter { // include path of non-verbatim header will not be shortened. IncludeInserter(StringRef FileName, StringRef Code, const format::FormatStyle &Style, StringRef BuildDir, - HeaderSearch *HeaderSea

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
@@ -9,6 +9,7 @@ #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_HEADERS_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_HEADERS_H +#include "Config.h" HighCommander4 wrote: Nothing in this header uses `Config.h` https://github.com/llvm/llvm-project/pull/67749

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
@@ -539,6 +539,42 @@ TEST_F(ConfigCompileTests, Style) { Frag.Style.FullyQualifiedNamespaces.push_back(std::string("bar")); EXPECT_TRUE(compileAndApply()); EXPECT_THAT(Conf.Style.FullyQualifiedNamespaces, ElementsAre("foo", "bar")); + + { +Frag = {}; +EXPECT_TRUE

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
@@ -123,6 +123,10 @@ struct Config { // declarations, always spell out the whole name (with or without leading // ::). All nested namespaces are affected as well. std::vector FullyQualifiedNamespaces; + +// List of regexes for inserting certain headers with <> o

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
@@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) { "-bugprone-use-after-move", // Alias for bugprone-use-after-move. "-hicpp-invalid-access-moved", + // Check uses dataflow analysis, which might hang/crash unexpectedl

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: This may be a good candidate for a 17.0.x backport. https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -76,7 +82,7 @@ bool RawStringLiteral::prepare(const Selection &Inputs) { if (!N) return false; Str = dyn_cast_or_null(N->ASTNode.get()); - return Str && + return Str && isFeatureAvailable(Inputs) && HighCommander4 wrote: I would move this language

[clang] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks for the patch! https://github.com/llvm/llvm-project/pull/69011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/69011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -6133,7 +6133,17 @@ ProduceSignatureHelp(Sema &SemaRef, MutableArrayRef Candidates, // so that we can recover argument names from it. static FunctionProtoTypeLoc GetPrototypeLoc(Expr *Fn) { TypeLoc Target; - if (const auto *T = Fn->getType().getTypePtr()->getAs()) { + +

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -203,6 +214,7 @@ template <> struct DenseMapInfo { Val.Driver, Val.StandardIncludes, Val.StandardCXXIncludes, +Val.Stdlib, HighCommander4 wrote: nit: it looks like the previous patch which introduced `Target` forgot to add i

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! I have one suggestion for your consideration, otherwise this looks good to me. https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -859,7 +872,9 @@ class InlayHintVisitor : public RecursiveASTVisitor { else ForwardedParams = {Params.begin(), Params.end()}; -NameVec ParameterNames = chooseParameterNames(ForwardedParams); +auto ForwardedParamsRef = HighCommander4 wrote

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-24 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-24 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-24 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-24 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/69283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r370103 - [clangd] Add a distinct highlighting for local variables

2019-08-27 Thread Nathan Ridge via cfe-commits
Author: nridge Date: Tue Aug 27 12:39:11 2019 New Revision: 370103 URL: http://llvm.org/viewvc/llvm-project?rev=370103&view=rev Log: [clangd] Add a distinct highlighting for local variables Summary: It's useful to be able to distinguish local variables from namespace scope variables. Reviewers:

[clang-tools-extra] r370429 - [clangd] Add distinct highlightings for static fields and methods

2019-08-29 Thread Nathan Ridge via cfe-commits
Author: nridge Date: Thu Aug 29 20:37:24 2019 New Revision: 370429 URL: http://llvm.org/viewvc/llvm-project?rev=370429&view=rev Log: [clangd] Add distinct highlightings for static fields and methods Reviewers: hokein, ilya-biryukov, jvikstrom Reviewed By: hokein Subscribers: MaskRay, jkorous, a

[clang-tools-extra] 751d4da - [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

2020-01-07 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-01-07T12:13:32-05:00 New Revision: 751d4dae3284c466481ed20ec0b76e894527d2c6 URL: https://github.com/llvm/llvm-project/commit/751d4dae3284c466481ed20ec0b76e894527d2c6 DIFF: https://github.com/llvm/llvm-project/commit/751d4dae3284c466481ed20ec0b76e894527d2c6.diff

[clang-tools-extra] 16f47cf - [clangd] Heuristically resolve dependent call through smart pointer type

2020-01-07 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-01-07T12:52:03-05:00 New Revision: 16f47cf607c7193e888de4c1774c46367a5bedf4 URL: https://github.com/llvm/llvm-project/commit/16f47cf607c7193e888de4c1774c46367a5bedf4 DIFF: https://github.com/llvm/llvm-project/commit/16f47cf607c7193e888de4c1774c46367a5bedf4.diff

[clang-tools-extra] 6a69d3c - [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

2020-01-09 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-01-09T16:14:11-05:00 New Revision: 6a69d3c6b3da3d4e7709d11fd52b8e5540265280 URL: https://github.com/llvm/llvm-project/commit/6a69d3c6b3da3d4e7709d11fd52b8e5540265280 DIFF: https://github.com/llvm/llvm-project/commit/6a69d3c6b3da3d4e7709d11fd52b8e5540265280.diff

[clang-tools-extra] 1ad1308 - [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

2020-01-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-01-12T22:18:21-05:00 New Revision: 1ad1308b69b89cc87533c16957189a84e1dd9754 URL: https://github.com/llvm/llvm-project/commit/1ad1308b69b89cc87533c16957189a84e1dd9754 DIFF: https://github.com/llvm/llvm-project/commit/1ad1308b69b89cc87533c16957189a84e1dd9754.diff

[clang-tools-extra] 79a09d8 - [clangd] Show template arguments in type hierarchy when possible

2020-01-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-01-12T22:31:40-05:00 New Revision: 79a09d8bf4d508b0ae6a1e3c90907488092678c5 URL: https://github.com/llvm/llvm-project/commit/79a09d8bf4d508b0ae6a1e3c90907488092678c5 DIFF: https://github.com/llvm/llvm-project/commit/79a09d8bf4d508b0ae6a1e3c90907488092678c5.diff

[clang-tools-extra] 90a8c44 - [clangd] Fix typo in field name

2020-09-20 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-20T19:52:39-04:00 New Revision: 90a8c44d92b217eccba2467a11d0658675b5fe80 URL: https://github.com/llvm/llvm-project/commit/90a8c44d92b217eccba2467a11d0658675b5fe80 DIFF: https://github.com/llvm/llvm-project/commit/90a8c44d92b217eccba2467a11d0658675b5fe80.diff

[clang-tools-extra] f18f8f3 - [clangd] Link libclangdSupport into clangd-index-server

2020-09-21 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-22T02:28:48-04:00 New Revision: f18f8f34d3d82b0842daf184c71e8240620d925c URL: https://github.com/llvm/llvm-project/commit/f18f8f34d3d82b0842daf184c71e8240620d925c DIFF: https://github.com/llvm/llvm-project/commit/f18f8f34d3d82b0842daf184c71e8240620d925c.diff

[clang-tools-extra] aa3c763 - [clang] Traverse init-captures while indexing

2020-09-21 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-22T02:32:09-04:00 New Revision: aa3c7638ba1648e020cf65a424389e093f2b3a1a URL: https://github.com/llvm/llvm-project/commit/aa3c7638ba1648e020cf65a424389e093f2b3a1a DIFF: https://github.com/llvm/llvm-project/commit/aa3c7638ba1648e020cf65a424389e093f2b3a1a.diff

[clang] 7cd6b0c - [clang] Do not consider the template arguments of bases to be bases themselves

2020-09-01 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-01T19:18:03-04:00 New Revision: 7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f URL: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f DIFF: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f.diff

[clang-tools-extra] ca842c8 - [clangd] Handle templates more consistently in type hierarchy

2020-09-01 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-01T19:18:37-04:00 New Revision: ca842c825a1caf10aacb1dc63664d565b1f2f4eb URL: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb DIFF: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb.diff

[clang-tools-extra] fef242c - [clangd] Fix locateMacroAt() for macro definition outside preamble

2020-12-13 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-12-13T18:33:33-05:00 New Revision: fef242c32e833b84e8b46bd56a28c01c5f9aa65d URL: https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d DIFF: https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d.diff

[clang-tools-extra] 3bec07f - [clangd] Store the containing symbol for refs

2020-11-04 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-04T03:21:45-05:00 New Revision: 3bec07f91fb1aea7a53ebc760f0511be1b5409f4 URL: https://github.com/llvm/llvm-project/commit/3bec07f91fb1aea7a53ebc760f0511be1b5409f4 DIFF: https://github.com/llvm/llvm-project/commit/3bec07f91fb1aea7a53ebc760f0511be1b5409f4.diff

[clang-tools-extra] 9d77584 - [clangd] Call hierarchy (Protocol layer)

2020-11-18 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-18T03:41:31-05:00 New Revision: 9d77584fe04010a2aa536308d4032bf5677d7000 URL: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000 DIFF: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000.diff

[clang-tools-extra] cc6d1f8 - [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

2020-09-28 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-09-28T21:18:31-04:00 New Revision: cc6d1f8029b05cd747c46ad3244a1b31ae970c61 URL: https://github.com/llvm/llvm-project/commit/cc6d1f8029b05cd747c46ad3244a1b31ae970c61 DIFF: https://github.com/llvm/llvm-project/commit/cc6d1f8029b05cd747c46ad3244a1b31ae970c61.diff

[clang-tools-extra] f82346f - [clangd] Avoid relations being overwritten in a header shard

2020-10-11 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-11T15:32:54-04:00 New Revision: f82346fd7391fdd15b77355deb6f7c030a89dcb5 URL: https://github.com/llvm/llvm-project/commit/f82346fd7391fdd15b77355deb6f7c030a89dcb5 DIFF: https://github.com/llvm/llvm-project/commit/f82346fd7391fdd15b77355deb6f7c030a89dcb5.diff

[clang-tools-extra] 1b962fd - [clangd] Heuristic resolution for dependent type and template names

2020-10-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-12T13:37:22-04:00 New Revision: 1b962fdd5f365a10684d9f70d703ae101c20d37a URL: https://github.com/llvm/llvm-project/commit/1b962fdd5f365a10684d9f70d703ae101c20d37a DIFF: https://github.com/llvm/llvm-project/commit/1b962fdd5f365a10684d9f70d703ae101c20d37a.diff

[clang-tools-extra] b764edc - [clangd] Try harder to get accurate ranges for documentSymbols in macros

2020-10-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-12T19:26:36-04:00 New Revision: b764edc59ff7768e052bc2b9e76e3bb69dd5147b URL: https://github.com/llvm/llvm-project/commit/b764edc59ff7768e052bc2b9e76e3bb69dd5147b DIFF: https://github.com/llvm/llvm-project/commit/b764edc59ff7768e052bc2b9e76e3bb69dd5147b.diff

[clang-tools-extra] cb3c13f - [clangd] Propagate CollectMainFileRefs to BackgroundIndex

2020-10-13 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-13T09:20:18-04:00 New Revision: cb3c13fab6beac4666865b68bea59aae593aaf83 URL: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83 DIFF: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83.diff

[clang-tools-extra] 3e6e6a2 - [clangd] Call hierarchy (XRefs layer, incoming calls)

2020-11-23 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-23T20:43:38-05:00 New Revision: 3e6e6a2db674cd85b33c06b75685c6bce5acb154 URL: https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154 DIFF: https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154.diff

[clang-tools-extra] 4cb976e - [clangd] Call hierarchy (ClangdServer layer)

2020-11-23 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-23T20:43:41-05:00 New Revision: 4cb976e014db80efd20dfca45ba218c3a69aac42 URL: https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42 DIFF: https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42.diff

[clang-tools-extra] 0a4f99c - [clangd] Call hierarchy (ClangdLSPServer layer)

2020-11-23 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-23T20:44:07-05:00 New Revision: 0a4f99c494d007a21652b1b3939bde4753042c33 URL: https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33 DIFF: https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33.diff

[clang-tools-extra] dced150 - [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

2020-11-23 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-23T20:44:14-05:00 New Revision: dced150375d09df6266448342fbb066d638b59ef URL: https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef DIFF: https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef.diff

[clang-tools-extra] 5b6f475 - [clangd] Sort results of incomingCalls request by container name

2020-11-24 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-24T03:29:02-05:00 New Revision: 5b6f47595bab686c6c3351fc1bd1f564add80dbf URL: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf DIFF: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf.diff

[clang-tools-extra] 3d2c681 - [clangd] Avoid type hierarchy crash on incomplete type

2020-11-25 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-25T03:45:00-05:00 New Revision: 3d2c681f2835261599654c1b82dacdae05c9b4c4 URL: https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4 DIFF: https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4.diff

[clang-tools-extra] c6cb47b - [clangd] Collect main file refs by default

2020-11-25 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-25T20:33:57-05:00 New Revision: c6cb47b640ffafda113581c488a73fb62b6ea38a URL: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a DIFF: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a.diff

[clang-tools-extra] d1fd91d - [clangd] Do not treat line as inactive if skipped range ends at character position 0

2020-11-26 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-26T03:42:42-05:00 New Revision: d1fd91ddaf9de95428a25d001606c23703e14b31 URL: https://github.com/llvm/llvm-project/commit/d1fd91ddaf9de95428a25d001606c23703e14b31 DIFF: https://github.com/llvm/llvm-project/commit/d1fd91ddaf9de95428a25d001606c23703e14b31.diff

[clang-tools-extra] f15b786 - [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

2020-11-29 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-11-29T18:32:23-05:00 New Revision: f15b7869e5afbd6c24ef440b0b62593e80fbd24f URL: https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f DIFF: https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f.diff

[clang-tools-extra] aaa8b44 - [clangd] Add a TestWorkspace utility

2020-10-24 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-24T20:15:17-04:00 New Revision: aaa8b44d19918ea1764339224cec68c27445aa8e URL: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e DIFF: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e.diff

[clang] 2756e2e - [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

2020-10-26 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-27T01:46:32-04:00 New Revision: 2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84 URL: https://github.com/llvm/llvm-project/commit/2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84 DIFF: https://github.com/llvm/llvm-project/commit/2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84.diff

[clang-tools-extra] 245b61a - [clangd] Increase the TooMany limit for index-based textual navigation to 5

2020-10-26 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-27T01:49:09-04:00 New Revision: 245b61a330abee06b81ac7d93da4582db51b1de7 URL: https://github.com/llvm/llvm-project/commit/245b61a330abee06b81ac7d93da4582db51b1de7 DIFF: https://github.com/llvm/llvm-project/commit/245b61a330abee06b81ac7d93da4582db51b1de7.diff

[clang-tools-extra] 0be2657 - [clangd] Type hints for variables with 'auto' type

2021-05-31 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-06-01T02:21:02-04:00 New Revision: 0be2657c2f486ffc006a037684cb658f4bf6cf11 URL: https://github.com/llvm/llvm-project/commit/0be2657c2f486ffc006a037684cb658f4bf6cf11 DIFF: https://github.com/llvm/llvm-project/commit/0be2657c2f486ffc006a037684cb658f4bf6cf11.diff

[clang-tools-extra] f976b99 - [clangd] Improve resolution of static method calls in HeuristicResolver

2021-06-02 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-06-02T20:30:19-04:00 New Revision: f976b9997ee55a130b139efe7b6e6f3b0384016b URL: https://github.com/llvm/llvm-project/commit/f976b9997ee55a130b139efe7b6e6f3b0384016b DIFF: https://github.com/llvm/llvm-project/commit/f976b9997ee55a130b139efe7b6e6f3b0384016b.diff

[clang-tools-extra] d87d1aa - [clangd] Deduplicate inlay hints

2021-09-21 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-09-21T03:23:04-04:00 New Revision: d87d1aa07612116a5c2a660f678856d3bda94f46 URL: https://github.com/llvm/llvm-project/commit/d87d1aa07612116a5c2a660f678856d3bda94f46 DIFF: https://github.com/llvm/llvm-project/commit/d87d1aa07612116a5c2a660f678856d3bda94f46.diff

[clang-tools-extra] 4223195 - [clangd] Ensure lambda init-capture gets semantic token

2021-09-23 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-09-23T03:52:57-04:00 New Revision: 4223195de3eaaa9c221d1f178899f221be6264c5 URL: https://github.com/llvm/llvm-project/commit/4223195de3eaaa9c221d1f178899f221be6264c5 DIFF: https://github.com/llvm/llvm-project/commit/4223195de3eaaa9c221d1f178899f221be6264c5.diff

[clang-tools-extra] 9510b09 - [clangd] Factor out the heuristic resolver code into its own class

2021-02-16 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-02-16T04:10:52-05:00 New Revision: 9510b09402659e6ba6e29b9caf0504c89bc72871 URL: https://github.com/llvm/llvm-project/commit/9510b09402659e6ba6e29b9caf0504c89bc72871 DIFF: https://github.com/llvm/llvm-project/commit/9510b09402659e6ba6e29b9caf0504c89bc72871.diff

[clang-tools-extra] e37653d - [clangd] Type hints for C++14 return type deduction

2021-06-20 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-06-21T01:13:00-04:00 New Revision: e37653da1399d846e02897680412139fdcde93ab URL: https://github.com/llvm/llvm-project/commit/e37653da1399d846e02897680412139fdcde93ab DIFF: https://github.com/llvm/llvm-project/commit/e37653da1399d846e02897680412139fdcde93ab.diff

[clang-tools-extra] 47d9d55 - [clangd] Do not show inlay hints pertaining to code in other files

2021-08-15 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-08-16T01:58:23-04:00 New Revision: 47d9d55c66601ffb5939ce07a7eb3c96122c48d6 URL: https://github.com/llvm/llvm-project/commit/47d9d55c66601ffb5939ce07a7eb3c96122c48d6 DIFF: https://github.com/llvm/llvm-project/commit/47d9d55c66601ffb5939ce07a7eb3c96122c48d6.diff

[clang-tools-extra] a15adbc - [clangd] Type hints for structured bindings

2021-07-04 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-07-04T21:53:36-04:00 New Revision: a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f URL: https://github.com/llvm/llvm-project/commit/a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f DIFF: https://github.com/llvm/llvm-project/commit/a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f.diff

[clang] 20176bc - [clang] Refactor AST printing tests to share more infrastructure

2021-07-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-07-13T01:48:30-04:00 New Revision: 20176bc7dd3f431db4c3d59b51a9f53d52190c82 URL: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82 DIFF: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82.diff

[clang] 9cfec72 - [clang] Refactor AST printing tests to share more infrastructure

2021-07-14 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-07-14T19:44:18-04:00 New Revision: 9cfec72ffeec242783b70e792c50bd163dcf9dbb URL: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb DIFF: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb.diff

[clang] 7a8c794 - [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

2021-11-17 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-11-17T16:56:46-05:00 New Revision: 7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411 URL: https://github.com/llvm/llvm-project/commit/7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411 DIFF: https://github.com/llvm/llvm-project/commit/7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411.diff

[clang] 5233ad1 - Compilation Database: Point Bazel users to a solution

2021-11-28 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-11-28T19:30:06-05:00 New Revision: 5233ad17e77eb7b7697f2664dc5a588a30fe5eaf URL: https://github.com/llvm/llvm-project/commit/5233ad17e77eb7b7697f2664dc5a588a30fe5eaf DIFF: https://github.com/llvm/llvm-project/commit/5233ad17e77eb7b7697f2664dc5a588a30fe5eaf.diff

[clang-tools-extra] 4abc910 - [clangd] Implement semantic token modifier "definition"

2022-10-17 Thread Nathan Ridge via cfe-commits
Author: Christian Kandeler Date: 2022-10-17T17:12:41-04:00 New Revision: 4abc910a42e50d278f64558acc20b346bf3013f4 URL: https://github.com/llvm/llvm-project/commit/4abc910a42e50d278f64558acc20b346bf3013f4 DIFF: https://github.com/llvm/llvm-project/commit/4abc910a42e50d278f64558acc20b346bf3013f4.

[clang-tools-extra] c93430b - [clangd] Update testcase for issue 1222 to use the 'definition' modifier

2022-10-17 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2022-10-17T19:56:19-04:00 New Revision: c93430bae4fc95b58185900aa5f0ccbc037de031 URL: https://github.com/llvm/llvm-project/commit/c93430bae4fc95b58185900aa5f0ccbc037de031 DIFF: https://github.com/llvm/llvm-project/commit/c93430bae4fc95b58185900aa5f0ccbc037de031.diff

<    1   2   3   4   5   6   7   8   9   10   >