Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

2016-06-13 Thread Michael Spertus via cfe-commits
Hi David, While I understand the initial reasoning. I have found that this is like a hundred times better for working on Clang in practice and can't imagine working without it. The point is that many Clang data structures contain SmallVectors and having to do zero expansion clicks instead of multip

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

2016-06-13 Thread Michael Spertus via cfe-commits
Gotcha. Going forward, if I feel anything requires a heads up, I'll do the full pre-commit review. Thanks for the feedback, Mike On Mon, Jun 13, 2016 at 11:30 AM, Aaron Ballman wrote: > On Mon, Jun 13, 2016 at 12:27 PM, Zachary Turner > wrote: > > I agree that it can be annoying to say "hey gu

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

2016-06-13 Thread Michael Spertus via cfe-commits
Hi David, IIUC Eric Feiveson drives Visual Studio visualizers. I'll email him (and will also demo to STL in Oulu). Best, Mike On Monday, June 13, 2016, David Blaikie wrote: > > > On Mon, Jun 13, 2016 at 8:55 AM, Michael Spertus > wrote: > >> Hi David, >> While I understand the initial reasonin

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

2016-06-14 Thread Michael Spertus via cfe-commits
On Mon, Jun 13, 2016 at 11:27 AM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", > and then potentially waiting an indeterminate amount of time. > > I think that actually