Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

2019-03-26 Thread Michael Spencer via cfe-commits
On Wed, Mar 20, 2019 at 12:21 PM Rafael Auler via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafauler > Date: Wed Mar 20 12:22:24 2019 > New Revision: 356598 > > URL: http://llvm.org/viewvc/llvm-project?rev=356598&view=rev > Log: > Recommit "Support attribute used in member funcs o

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

2019-03-28 Thread Michael Spencer via cfe-commits
On Tue, Mar 26, 2019 at 7:40 PM Rafael Auler wrote: > I’m familiar with this issue as I had to fix a memory bug in LLVM IRLinker > that was exposed by this commit. That’s why I initially reverted it. > However, after fixing it, I was able to do the full clang LTO self-hosting > with lld on Linux.

Re: r359367 - Reinstate r359059, reverted in r359361, with a fix to properly prevent

2019-09-09 Thread Michael Spencer via cfe-commits
On Fri, Apr 26, 2019 at 7:56 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Apr 26 19:58:17 2019 > New Revision: 359367 > > URL: http://llvm.org/viewvc/llvm-project?rev=359367&view=rev > Log: > Reinstate r359059, reverted in r359361, with a fix t

Re: [PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

2019-10-19 Thread Michael Spencer via cfe-commits
On Fri, Oct 18, 2019 at 7:38 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Looks like this fails on win: http://45.33.8.238/win/841/step_6.txt > > Ptal! > > Maybe just cat'ing all files instead of echoing the first and piping into > cat works? > > R

[clang] 9ab6d82 - [clang-scan-deps] Add basic support for modules.

2019-10-24 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2019-10-24T16:19:11-07:00 New Revision: 9ab6d8236b176bf9dd43741f4d874a8afebed99c URL: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c DIFF: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c.dif

[clang] 7af309a - [clang][DependencyScanning] clang-format.

2019-10-24 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2019-10-24T18:28:01-07:00 New Revision: 7af309a4ed1a105315a39af3c77da3a8912b8685 URL: https://github.com/llvm/llvm-project/commit/7af309a4ed1a105315a39af3c77da3a8912b8685 DIFF: https://github.com/llvm/llvm-project/commit/7af309a4ed1a105315a39af3c77da3a8912b8685.dif

[clang] 8da2056 - [clang][DependencyScanning] 80-col.

2019-10-25 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2019-10-25T15:43:57-07:00 New Revision: 8da20560ab0da11c47d4718712c9c455e71c2b51 URL: https://github.com/llvm/llvm-project/commit/8da20560ab0da11c47d4718712c9c455e71c2b51 DIFF: https://github.com/llvm/llvm-project/commit/8da20560ab0da11c47d4718712c9c455e71c2b51.dif

[clang] dddec1f - [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.

2019-10-28 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2019-10-28T17:37:25-07:00 New Revision: dddec1f1840b8a019c8c89dd1e7961cf39d845d3 URL: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3 DIFF: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3.dif

[clang-tools-extra] 7fcc1bb - [clangd] Fix the build with clang <3.9.

2020-07-17 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-07-17T16:12:31-06:00 New Revision: 7fcc1bb4b654461c3109b01e1fe7eae191a86f7f URL: https://github.com/llvm/llvm-project/commit/7fcc1bb4b654461c3109b01e1fe7eae191a86f7f DIFF: https://github.com/llvm/llvm-project/commit/7fcc1bb4b654461c3109b01e1fe7eae191a86f7f.dif

[clang] 92e8af0 - [Clang] Expose RequiresNullTerminator in FileManager.

2020-04-15 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-04-15T14:17:51-07:00 New Revision: 92e8af0ecbe7eb36bc03a211afa9151c81b7b531 URL: https://github.com/llvm/llvm-project/commit/92e8af0ecbe7eb36bc03a211afa9151c81b7b531 DIFF: https://github.com/llvm/llvm-project/commit/92e8af0ecbe7eb36bc03a211afa9151c81b7b531.dif

[clang] 1727c6a - [clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs

2020-06-10 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-06-10T14:37:30-06:00 New Revision: 1727c6aab34012f0cefc8a3f29ede5f1f718c832 URL: https://github.com/llvm/llvm-project/commit/1727c6aab34012f0cefc8a3f29ede5f1f718c832 DIFF: https://github.com/llvm/llvm-project/commit/1727c6aab34012f0cefc8a3f29ede5f1f718c832.dif

[clang] 64788d7 - [clang] Include missing LangOpts in `getModuleHash`.

2020-07-07 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-07-07T17:13:23-06:00 New Revision: 64788d7d5377345af5e3080d26cb6a76c324ab5b URL: https://github.com/llvm/llvm-project/commit/64788d7d5377345af5e3080d26cb6a76c324ab5b DIFF: https://github.com/llvm/llvm-project/commit/64788d7d5377345af5e3080d26cb6a76c324ab5b.dif

[llvm] [clang] [clang][DepScan] Make OptimizeArgs a bit mask enum and enable by default (PR #71588)

2023-11-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/71588 Make it easier to control which optimizations are enabled by making OptimizeArgs a bit masked enum. There's currently only one such optimization, but more will be added in followup commits. >From 7d8281c6a48800

[clang] [llvm] [clang][DepScan] Make OptimizeArgs a bit mask enum and enable by default (PR #71588)

2023-11-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/71588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/71612 Since system modules don't emit most warnings, remove the warning flags to increase module reuse. >From 6c8c4cde5698a1693ad64a14a156030f249032a6 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Tue, 7 Nov

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
@@ -52,6 +52,28 @@ static void optimizeHeaderSearchOpts(HeaderSearchOptions &Opts, Opts.UserEntries.push_back(Entries[Idx]); } +static void optimizeDiagnosticOpts(DiagnosticOptions &Opts, + bool IsSystemModule) { + // If this is not a sy

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/build/compile-commands.json.in > %t/build/compile-commands.json +// RUN: clang-scan-deps -compilation-database %t/build/compile-commands.json \ +// RUN: -j 1 -format experimental-full

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/build/compile-commands.json.in > %t/build/compile-commands.json +// RUN: clang-scan-deps -compilation-database %t/build/compile-commands.json \ +// RUN: -j 1 -format experimental-full

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/build/compile-commands.json.in > %t/build/compile-commands.json +// RUN: clang-scan-deps -compilation-database %t/build/compile-commands.json \ +// RUN: -j 1 -format experimental-full

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/71612 >From 6c8c4cde5698a1693ad64a14a156030f249032a6 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Tue, 7 Nov 2023 14:02:38 -1000 Subject: [PATCH 1/2] [clang][DependencyScanner] Remove all warning flags when

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-08 Thread Michael Spencer via cfe-commits
Bigcheese wrote: Added test comments and added a test for `-Wsystem-headers` being present. https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-13 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-11-02 Thread Michael Spencer via cfe-commits
Bigcheese wrote: This is fine, it's definitely wrong to include framework headers like this too. https://github.com/llvm/llvm-project/pull/69555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang][modules] Strip LLVM options (PR #75405)

2023-12-13 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. https://github.com/llvm/llvm-project/pull/75405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][modules] Deprecate module.map in favor of module.modulemap (PR #75142)

2023-12-14 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/75142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DependencyScanner] Include the working directory in the context hash (PR #73719)

2023-11-28 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/73719 The working directory is included in the PCM, but is not currently part of the context hash. This causes problems because different builds of a PCM with exactly the same command line can end up with different

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-28 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/73734 `-ivfsoverlay` files are unused when building most modules. Enable removing them by, * adding a way to visit the filesystem tree with extensible RTTI to access each `RedirectingFileSystem`. * Adding tracking t

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-29 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > It's odd to me that tracking is enabled by default. I would have expected > tracking be off by default and enabled explicitly for scanning. Similarly, in > the modulemap case it could save-and-restore rather than enable the tracking > if it was previously off. It has to be

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-29 Thread Michael Spencer via cfe-commits
@@ -498,11 +518,18 @@ class NamedNodeOrError { } // namespace detail /// An in-memory file system. -class InMemoryFileSystem : public FileSystem { +class InMemoryFileSystem : public RTTIExtends { std::unique_ptr Root; std::string WorkingDirectory; bool UseNormalizedPa

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-29 Thread Michael Spencer via cfe-commits
@@ -142,6 +142,21 @@ std::vector HeaderSearch::computeUserEntryUsage() const { return UserEntryUsage; } +std::vector HeaderSearch::computeVFSUsage() const { + std::vector VFSUsage; + llvm::vfs::FileSystem &RootFS = FileMgr.getVirtualFileSystem(); + // TODO: This only wor

[clang] [clang][DependencyScanner] Include the working directory in the context hash (PR #73719)

2023-11-30 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/73719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-01-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,60 @@ +//=== SocketMsgSupport.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Driver] Ignore non-clang pch files when -include a.h probes a.h.gch (PR #69204)

2024-01-10 Thread Michael Spencer via cfe-commits
Bigcheese wrote: This incorrectly handles `-gmodules` which produces an object file that contains a clang PCH. Detecting that is a bit harder, is it fine if it just accepts all object files as returned by `llvm::identify_magic`? https://github.com/llvm/llvm-project/pull/69204 _

[clang] [llvm] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-10 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/77711 A previous commit (82f75ed) made clang ignore .gch files that were not Clang AST files. This broke `-gmodules`, which embeds the Clang AST into an object file containing debug info. This changes the probing t

[clang] [llvm] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-11 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > What does the code that reads these files look like, could we leverage that > somehow? You can call `clang::ObjectFilePCHContainerReader::ExtractPCH()` and then check the magic. This lives in the CodeGen library which I don't think the driver currently (or should) links aga

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-26 Thread Michael Spencer via cfe-commits
Bigcheese wrote: I'm checking with the C and C++ Compatibility study group (SG22) for what's expected here. https://github.com/llvm/llvm-project/pull/86748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-05 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/83641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [llvm][Support] Add and use errnoAsErrorCode (PR #84423)

2024-03-07 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/84423 LLVM is inconsistent about how it converts `errno` to `std::error_code`. This can cause problems because values outside of `std::errc` compare differently if one is system and one is generic on POSIX systems.

[clang] [clang-tools-extra] [llvm] [llvm][Support] Add and use errnoAsErrorCode (PR #84423)

2024-03-08 Thread Michael Spencer via cfe-commits
Bigcheese wrote: The other cases of `std::system_category` were in `LLVM_ON_UNIX` (or similar) blocks that would only be used on systems where it's mostly fine to use either one, as most of the time you'll get an error that's in `std::errc`, and then there's no difference (or they just are nev

[clang] [clang-tools-extra] [llvm] [llvm][Support] Add and use errnoAsErrorCode (PR #84423)

2024-03-08 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/84423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] reland: [clang][ScanDeps] Canonicalize -D and -U flags (PR #82568)

2024-02-23 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/82568 >From eb622c20b8d84afabdbb82543c1f9e4889639735 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 16 Feb 2024 22:05:25 -0800 Subject: [PATCH] [clang][ScanDeps] Canonicalize -D and -U flags Canonicalize

[clang] reland: [clang][ScanDeps] Canonicalize -D and -U flags (PR #82568)

2024-02-23 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/82568 >From a690c96562dea29a760390644d78a01a263993ca Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 16 Feb 2024 22:05:25 -0800 Subject: [PATCH] [clang][ScanDeps] Canonicalize -D and -U flags Canonicalize

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-23 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/82294 >From 45852f569575d0735c686376ad30753fe791db26 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Thu, 15 Feb 2024 16:44:45 -0800 Subject: [PATCH] [clang][ScanDeps] Allow PCHs to have different VFS overlays

[clang] reland: [clang][ScanDeps] Canonicalize -D and -U flags (PR #82568)

2024-02-23 Thread Michael Spencer via cfe-commits
Bigcheese wrote: CI failure was a preexisting trailing whitespace issue. https://github.com/llvm/llvm-project/pull/82568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] reland: [clang][ScanDeps] Canonicalize -D and -U flags (PR #82568)

2024-02-23 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/82568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-23 Thread Michael Spencer via cfe-commits
Bigcheese wrote: CI failure is a preexisting Flang test failure and a preexisting trailing whitespace issue. https://github.com/llvm/llvm-project/pull/82294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-23 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/82294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-28 Thread Michael Spencer via cfe-commits
@@ -175,8 +192,19 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.ShowCarets = false; // Don't write out diagnostic file. DiagOpts.DiagnosticSerializationFile.clear(); - // Don't emit warnings as errors (and all other warnings too). - DiagOpts.Ig

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/83641 Before this patch, if a module fails to build because of a missing config_macro, the user will never see the config macro warning. This patch diagnoses this before building, and each subsequent time a module i

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/83641 >From c2445d426e374592522ac392254c9909ab52fc40 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 1 Mar 2024 17:18:20 -0800 Subject: [PATCH] [clang] Diagnose config_macros before building modules Before

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
@@ -2006,6 +2021,11 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, if (auto MaybeModule = MM.getCachedModuleLoad(*Path[0].first)) { // Use the cached result, which may be nullptr. Module = *MaybeModule; +// Config macros are already checked before build

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
@@ -22,7 +58,10 @@ #define WANT_BAR 1 // expected-note{{macro was defined here}} @import config; // expected-warning{{definition of configuration macro 'WANT_BAR' has no effect on the import of 'config'; pass '-DWANT_BAR=...' on the command line to configure the module}} -//

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
@@ -2006,6 +2021,11 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, if (auto MaybeModule = MM.getCachedModuleLoad(*Path[0].first)) { // Use the cached result, which may be nullptr. Module = *MaybeModule; +// Config macros are already checked before build

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-04 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/83641 >From e8993b51f0dcdecd2fcb72f91d7e4631e95c2c09 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 1 Mar 2024 17:18:20 -0800 Subject: [PATCH] [clang] Diagnose config_macros before building modules Before

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-30 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/73734 >From 42666e6c0b46a83f0b4fbc7d7945825c56e6ac5a Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 24 Feb 2023 17:18:51 -0800 Subject: [PATCH] [clang][DepScan] Remove unused -ivfsoverlay files `-ivfsover

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-30 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/73734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b21a2f9 - [clang][scan-deps] Stop scanning if any scanning setup emits an error.

2024-01-30 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2024-01-30T17:03:13-08:00 New Revision: b21a2f9365b6c5fd464a97be5dfe7085742870ef URL: https://github.com/llvm/llvm-project/commit/b21a2f9365b6c5fd464a97be5dfe7085742870ef DIFF: https://github.com/llvm/llvm-project/commit/b21a2f9365b6c5fd464a97be5dfe7085742870ef.dif

[clang] [clang][DependencyScanner] Remove unused -fmodule-map-file arguments (PR #80090)

2024-01-30 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/80090 Since we already add a `-fmodule-map-file=` argument for every used modulemap, we can remove all `ModuleMapFiles` entries before adding them. This reduces the number of module variants when `-fmodule-map-file=

[clang] [clang][DependencyScanner] Remove unused -fmodule-map-file arguments (PR #80090)

2024-01-31 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/80090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-25 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/73734 >From 3c7f36b087e09e1b7ab3231e8267bcdd8400fac4 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 24 Feb 2023 17:18:51 -0800 Subject: [PATCH] [clang][DepScan] Remove unused -ivfsoverlay files `-ivfsover

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-25 Thread Michael Spencer via cfe-commits
Bigcheese wrote: I've updated the patch to use the alternative implementation Jan suggested. https://github.com/llvm/llvm-project/pull/73734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-25 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/73734 >From 0559ec44d2d3c39292bae6d6431dde9626ac755e Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 24 Feb 2023 17:18:51 -0800 Subject: [PATCH] [clang][DepScan] Remove unused -ivfsoverlay files `-ivfsover

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-29 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/73734 >From 0559ec44d2d3c39292bae6d6431dde9626ac755e Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 24 Feb 2023 17:18:51 -0800 Subject: [PATCH 1/2] [clang][DepScan] Remove unused -ivfsoverlay files `-ivfs

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-11 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/77711 >From ef781002ef63817afa4df4834742ec3c2f22 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Wed, 10 Jan 2024 16:58:59 -0800 Subject: [PATCH] [clang][Driver] Don't ignore -gmodules .gch files A previous

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-11 Thread Michael Spencer via cfe-commits
Bigcheese wrote: I updated the patch to try to actually open the object file. https://github.com/llvm/llvm-project/pull/77711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-15 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/77711 >From d3e928fc5b725cb3e484a8cfd50fa23c26f7eb22 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Wed, 10 Jan 2024 16:58:59 -0800 Subject: [PATCH] [clang][Driver] Don't ignore -gmodules .gch files A previous

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-16 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/77711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-17 Thread Michael Spencer via cfe-commits
Bigcheese wrote: Yep, I'll take a look. https://github.com/llvm/llvm-project/pull/77711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-17 Thread Michael Spencer via cfe-commits
Bigcheese wrote: Ah, looks like all the other gmodules tests have: ``` // Unsupported on AIX because we don't support the requisite "__clangast" // section in XCOFF yet. // UNSUPPORTED: target={{.*}}-aix{{.*}} ``` I'll just add that. https://github.com/llvm/llvm-project/pull/77711 _

[clang] [clang] Disable gch-probe.c on AIX as `-gmodules` is not supported there yet. (PR #78513)

2024-01-17 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/78513 Followup fix for https://github.com/llvm/llvm-project/pull/77711 >From a12b3ab8663c591f66848a7e46620a79583f5045 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Wed, 17 Jan 2024 14:27:03 -0800 Subject: [PA

[clang] [clang] Disable gch-probe.c on AIX as `-gmodules` is not supported there yet. (PR #78513)

2024-01-17 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/78513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Fix CodeGen options that can affect the AST. (PR #78816)

2024-01-19 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. LGTM, although are we sure none of the other options should be affecting? I just did a quick search and it seems like this is it. I don't think it matters here, but the actual option that controls the macro is on `LangOptions` and where

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. LGTM. The rest of clang reasons about this at the top level module, so so should this. https://github.com/llvm/llvm-project/pull/69651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > > Implementing a timeout as part of this patch as a safety measure seems > > worth while too but I'm not sure I understand your final solution. You all > > spawned a clang job that had to communicate with the daemon to make sure > > one did not exist? > > It is something li

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > I had a couple of questions. I guess my main concern here is that the TODO > for portability might turn out to be quite heavy lifting. Perhaps we should > be looking to abstract the socket-like interface at a lower level. We have someone working on a simple socket library fo

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
@@ -15,21 +12,12 @@ int main() {return 0;} // RUN: %clang -fmodule-build-daemon=mbd-handshake -Rmodule-build-daemon %t/main.c &> %t/output-existing // RUN: cat %t/output-existing | FileCheck %s --check-prefix=CHECK-EXIST -// CHECK: remark: Trying to spawn module build daemon

[clang] 22b65a3 - [NFC][Clang][ASTTests] Use ASSERT instead of EXPECT for nullptr checks

2023-01-04 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2023-01-04T17:33:12-08:00 New Revision: 22b65a329ac2621279ae211dd6a868198e68d149 URL: https://github.com/llvm/llvm-project/commit/22b65a329ac2621279ae211dd6a868198e68d149 DIFF: https://github.com/llvm/llvm-project/commit/22b65a329ac2621279ae211dd6a868198e68d149.dif

[clang] ffa2a64 - [Clang][DependencyScanner] Remove secondary actions from -cc1

2023-02-01 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2023-02-01T15:17:32-08:00 New Revision: ffa2a647c6a9dd2fab13a5e1bd4832b5b200d908 URL: https://github.com/llvm/llvm-project/commit/ffa2a647c6a9dd2fab13a5e1bd4832b5b200d908 DIFF: https://github.com/llvm/llvm-project/commit/ffa2a647c6a9dd2fab13a5e1bd4832b5b200d908.dif

[clang] 1694175 - [Clang][Modules] Merge availability attributes on imported decls

2022-06-15 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2022-06-15T17:46:16-07:00 New Revision: 169417531578501e955f12c79ecb8ff05333ae15 URL: https://github.com/llvm/llvm-project/commit/169417531578501e955f12c79ecb8ff05333ae15 DIFF: https://github.com/llvm/llvm-project/commit/169417531578501e955f12c79ecb8ff05333ae15.dif

Re: [clang] f06abbb - LLVM Driver Multicall tool

2022-06-06 Thread Michael Spencer via cfe-commits
I believe this broke the shared library build. CMake complains with a cycle: CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): I'm verifying that this occurs with a clean upstream build. - Michael Spencer On Sun, Jun 5, 2022 at 9:28 PM

Re: [clang] f06abbb - LLVM Driver Multicall tool

2022-06-06 Thread Michael Spencer via cfe-commits
Hmm, I'm not able to reproduce this with upstream. Sorry for the noise. - Michael Spencer On Mon, Jun 6, 2022 at 2:44 PM Michael Spencer wrote: > I believe this broke the shared library build. CMake complains with a > cycle: > > CMake Error: The inter-target dependency graph contains the follo

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,44 @@ +//===- Protocol.h -===// Bigcheese wrote: Client.h https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lis

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -2836,6 +2836,18 @@ defm declspec : BoolOption<"f", "declspec", NegFlag, BothFlags<[], [ClangOption, CC1Option], " __declspec as a keyword">>, Group; + +def fmodule_build_daemon : Flag<["-"], "fmodule-build-daemon">, Group, + Flags<[NoXarchOption]>, + Visibil

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,18 @@ +// Check that clang invocation can spawn and handshake with module build daemon + +// REQUIRES: !system-windows + +// RUN: if pgrep -f "cc1modbuildd mbd-handshake"; then pkill -f "cc1modbuildd mbd-handshake"; fi +// RUN: rm -rf mbd-handshake %t ---

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,167 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,31 @@ +//===-- SocketSupport.h ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,128 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,128 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,18 @@ +// Check that clang invocation can spawn and handshake with module build daemon Bigcheese wrote: This test should also check that clang can connect to an existing MBD without spawning a new one. https://github.com/llvm/llvm-project/pull/67562

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,167 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,18 @@ +// Check that clang invocation can spawn and handshake with module build daemon + +// REQUIRES: !system-windows + +// RUN: if pgrep -f "cc1modbuildd mbd-handshake"; then pkill -f "cc1modbuildd mbd-handshake"; fi +// RUN: rm -rf mbd-handshake %t +// RUN: split

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

  1   2   3   4   >